dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Windows crash log: Don't bother writing raw stack if it can be decoded

Browse Source 
The raw values are almost always useless
This commit is contained in:
Jonathan G Rennison
2023-06-18 15:46:13 +01:00
parent bcab44dc98
commit a7a8f4c695
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/os/windows/crashlog_win.cpp
View File

@@ -85,7 +85,6 @@ public:
#endif /* _MSC_VER */ #endif /* _MSC_VER */
#if defined(_MSC_VER) || defined(WITH_DBGHELP) #if defined(_MSC_VER) || defined(WITH_DBGHELP)
char *AppendDecodedStacktrace(char *buffer, const char *last) const; char *AppendDecodedStacktrace(char *buffer, const char *last) const;
char *LogDebugExtra(char *buffer, const char *last) const override;
#endif /* _MSC_VER || WITH_DBGHELP */ #endif /* _MSC_VER || WITH_DBGHELP */
@@ -441,6 +440,16 @@ static char *PrintModuleInfo(char *output, const char *last, HMODULE mod)
/* virtual */ char *CrashLogWindows::LogStacktrace(char *buffer, const char *last) const /* virtual */ char *CrashLogWindows::LogStacktrace(char *buffer, const char *last) const
{ {
#if defined(_MSC_VER) || defined(WITH_DBGHELP)
char *stacktrace_end = this->AppendDecodedStacktrace(buffer, last);
if (stacktrace_end - buffer >= 32) {
/* If AppendDecodedStacktrace managed to write out anything more than just the section title,
* consider that a success and don't bother writing out the raw stack trace values as well.
* The raw values are useless in almost all cases. */
return stacktrace_end;
}
#endif
buffer += seprintf(buffer, last, "Stack trace:\n"); buffer += seprintf(buffer, last, "Stack trace:\n");
#ifdef _M_AMD64 #ifdef _M_AMD64
uint32 *b = (uint32*)ep->ContextRecord->Rsp; uint32 *b = (uint32*)ep->ContextRecord->Rsp;
@@ -650,14 +659,6 @@ char *CrashLogWindows::AppendDecodedStacktrace(char *buffer, const char *last) c
return buffer + seprintf(buffer, last, "\n");; return buffer + seprintf(buffer, last, "\n");;
} }
/**
* Log decoded stack trace
*/
char *CrashLogWindows::LogDebugExtra(char *buffer, const char *last) const
{
return this->AppendDecodedStacktrace(buffer, last);
}
#endif /* _MSC_VER || WITH_DBGHELP */ #endif /* _MSC_VER || WITH_DBGHELP */
#if defined(_MSC_VER) #if defined(_MSC_VER)