From a8d5e5669653c394ec78ff35525f5aea29476253 Mon Sep 17 00:00:00 2001 From: Jonathan G Rennison Date: Sun, 11 Sep 2022 10:28:57 +0100 Subject: [PATCH] Crashlog: Only output dump files for MSVC builds --- src/os/windows/crashlog_win.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/os/windows/crashlog_win.cpp b/src/os/windows/crashlog_win.cpp index dd2e2ef16d..cda74d7aa5 100644 --- a/src/os/windows/crashlog_win.cpp +++ b/src/os/windows/crashlog_win.cpp @@ -56,8 +56,10 @@ class CrashLogWindows : public CrashLog { char *LogRegisters(char *buffer, const char *last) const override; char *LogModules(char *buffer, const char *last) const override; public: -#if defined(_MSC_VER) || defined(WITH_DBGHELP) +#if defined(_MSC_VER) int WriteCrashDump(char *filename, const char *filename_last) const override; +#endif /* _MSC_VER */ +#if defined(_MSC_VER) || defined(WITH_DBGHELP) char *AppendDecodedStacktrace(char *buffer, const char *last) const; #else char *AppendDecodedStacktrace(char *buffer, const char *last) const { return buffer; } @@ -579,7 +581,9 @@ char *CrashLogWindows::AppendDecodedStacktrace(char *buffer, const char *last) c return buffer + seprintf(buffer, last, "\n*** End of additional info ***\n"); } +#endif /* _MSC_VER || WITH_DBGHELP */ +#if defined(_MSC_VER) /* virtual */ int CrashLogWindows::WriteCrashDump(char *filename, const char *filename_last) const { if (_settings_client.gui.developer == 0) return 0;