dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

YAPF: Prevent user for configuring signal penalties to negative values

Browse Source 
Warn if signal penalty polynomial goes negative, and clamp to non-negative
This commit is contained in:
Jonathan G Rennison
2020-01-17 19:23:03 +00:00
parent 07f5b86dfc
commit bb363695fc
5 changed files with 34 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/pathfinder/yapf/yapf_rail.cpp
View File

@@ -17,6 +17,7 @@
#include "../../viewport_func.h"
#include "../../newgrf_station.h"
#include "../../tracerestrict.h"
#include "../../debug.h"
#include "../../safeguards.h"
@@ -762,3 +763,18 @@ void YapfNotifyTrackLayoutChange(TileIndex tile, Track track)
{
CSegmentCostCacheBase::NotifyTrackLayoutChange(tile, track);
}
void YapfCheckRailSignalPenalties()
{
bool negative = false;
int p0 = _settings_game.pf.yapf.rail_look_ahead_signal_p0;
int p1 = _settings_game.pf.yapf.rail_look_ahead_signal_p1;
int p2 = _settings_game.pf.yapf.rail_look_ahead_signal_p2;
for (int i = 0; i < (int) _settings_game.pf.yapf.rail_look_ahead_max_signals; i++) {
if (p0 + i * (p1 + i * p2) < 0) negative = true;
}
if (negative) {
DEBUG(misc, 0, "Settings: pf.yapf.rail_look_ahead_signal_p0, pf.yapf.rail_look_ahead_signal_p1, pf.yapf.rail_look_ahead_signal_p2 and pf.yapf.rail_look_ahead_max_signal "
"are set to incorrect values (i.e. resulting in hegative penalties), negative penalties will be truncated");
}
}