From c5e30b8f0481c968b7cd5340834f9f8b47c4d249 Mon Sep 17 00:00:00 2001 From: cirdan Date: Wed, 13 Feb 2013 23:27:46 +0100 Subject: [PATCH] Fix file descriptor leak in LoadOldSaveGame LoadOldSaveGame was leaking a file descriptor when it successfully loaded a savegame. (cherry picked from commit f47cfbbba0b182f116109e02445bb419fab1a157) --- src/saveload/oldloader.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/saveload/oldloader.cpp b/src/saveload/oldloader.cpp index 13ee0e5b06..15e62b8412 100644 --- a/src/saveload/oldloader.cpp +++ b/src/saveload/oldloader.cpp @@ -308,9 +308,10 @@ bool LoadOldSaveGame(const char *file) game_loaded = false; } + fclose(ls.file); + if (!game_loaded) { SetSaveLoadError(STR_GAME_SAVELOAD_ERROR_DATA_INTEGRITY_CHECK_FAILED); - fclose(ls.file); return false; }