dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Saveload: Improve performance of script data save/load

Browse Source 
Avoid unnecessarily using SlObject wrappers
This commit is contained in:
Jonathan G Rennison
2023-08-14 17:28:49 +01:00
parent 2b8171093a
commit d0c6b7136d
1 changed files with 29 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

79
src/script/script_instance.cpp
View File

@@ -378,13 +378,6 @@ ScriptLogTypes::LogData &ScriptInstance::GetLogData()
* - null: No data.
*/
static byte _script_sl_byte; ///< Used as source/target by the script saveload code to store/load a single byte.
/** SaveLoad array that saves/loads exactly one byte. */
static const SaveLoad _script_byte[] = {
SLEG_VAR(_script_sl_byte, SLE_UINT8),
};
/* static */ bool ScriptInstance::SaveObject(HSQUIRRELVM vm, SQInteger index, int max_depth, bool test)
{
if (max_depth == 0) {
@@ -395,8 +388,7 @@ static const SaveLoad _script_byte[] = {
switch (sq_gettype(vm, index)) {
case OT_INTEGER: {
if (!test) {
_script_sl_byte = SQSL_INT;
SlObject(nullptr, _script_byte);
SlWriteByte(SQSL_INT);
}
SQInteger res;
sq_getinteger(vm, index, &res);
@@ -409,8 +401,7 @@ static const SaveLoad _script_byte[] = {
case OT_STRING: {
if (!test) {
_script_sl_byte = SQSL_STRING;
SlObject(nullptr, _script_byte);
SlWriteByte(SQSL_STRING);
}
const SQChar *buf;
sq_getstring(vm, index, &buf);
@@ -420,8 +411,7 @@ static const SaveLoad _script_byte[] = {
return false;
}
if (!test) {
_script_sl_byte = (byte)len;
SlObject(nullptr, _script_byte);
SlWriteByte((byte)len);
SlArray(const_cast<char *>(buf), len, SLE_CHAR);
}
return true;
@@ -429,8 +419,7 @@ static const SaveLoad _script_byte[] = {
case OT_ARRAY: {
if (!test) {
_script_sl_byte = SQSL_ARRAY;
SlObject(nullptr, _script_byte);
SlWriteByte(SQSL_ARRAY);
}
sq_pushnull(vm);
while (SQ_SUCCEEDED(sq_next(vm, index - 1))) {
@@ -444,16 +433,14 @@ static const SaveLoad _script_byte[] = {
}
sq_pop(vm, 1);
if (!test) {
_script_sl_byte = SQSL_ARRAY_TABLE_END;
SlObject(nullptr, _script_byte);
SlWriteByte(SQSL_ARRAY_TABLE_END);
}
return true;
}
case OT_TABLE: {
if (!test) {
_script_sl_byte = SQSL_TABLE;
SlObject(nullptr, _script_byte);
SlWriteByte(SQSL_TABLE);
}
sq_pushnull(vm);
while (SQ_SUCCEEDED(sq_next(vm, index - 1))) {
@@ -467,30 +454,26 @@ static const SaveLoad _script_byte[] = {
}
sq_pop(vm, 1);
if (!test) {
_script_sl_byte = SQSL_ARRAY_TABLE_END;
SlObject(nullptr, _script_byte);
SlWriteByte(SQSL_ARRAY_TABLE_END);
}
return true;
}
case OT_BOOL: {
if (!test) {
_script_sl_byte = SQSL_BOOL;
SlObject(nullptr, _script_byte);
SlWriteByte(SQSL_BOOL);
}
SQBool res;
sq_getbool(vm, index, &res);
if (!test) {
_script_sl_byte = res ? 1 : 0;
SlObject(nullptr, _script_byte);
SlWriteByte(res ? 1 : 0);
}
return true;
}
case OT_NULL: {
if (!test) {
_script_sl_byte = SQSL_NULL;
SlObject(nullptr, _script_byte);
SlWriteByte(SQSL_NULL);
}
return true;
}
@@ -503,8 +486,7 @@ static const SaveLoad _script_byte[] = {
/* static */ void ScriptInstance::SaveEmpty()
{
_script_sl_byte = 0;
SlObject(nullptr, _script_byte);
SlWriteByte(0);
}
void ScriptInstance::Save()
@@ -519,8 +501,7 @@ void ScriptInstance::Save()
HSQUIRRELVM vm = this->engine->GetVM();
if (this->is_save_data_on_stack) {
_script_sl_byte = 1;
SlObject(nullptr, _script_byte);
SlWriteByte(1);
/* Save the data that was just loaded. */
SaveObject(vm, -1, SQUIRREL_MAX_DEPTH, false);
} else if (!this->is_started) {
@@ -562,8 +543,7 @@ void ScriptInstance::Save()
}
sq_pushobject(vm, savedata);
if (SaveObject(vm, -1, SQUIRREL_MAX_DEPTH, true)) {
_script_sl_byte = 1;
SlObject(nullptr, _script_byte);
SlWriteByte(1);
SaveObject(vm, -1, SQUIRREL_MAX_DEPTH, false);
this->is_save_data_on_stack = true;
} else {
@@ -572,8 +552,7 @@ void ScriptInstance::Save()
}
} else {
ScriptLog::Warning("Save function is not implemented");
_script_sl_byte = 0;
SlObject(nullptr, _script_byte);
SlWriteByte(0);
}
}
@@ -598,8 +577,8 @@ bool ScriptInstance::IsPaused()
/* static */ bool ScriptInstance::LoadObjects(ScriptData *data)
{
SlObject(nullptr, _script_byte);
switch (_script_sl_byte) {
byte type = SlReadByte();
switch (type) {
case SQSL_INT: {
int64 value;
SlArray(&value, 1, (IsSavegameVersionBefore(SLV_SCRIPT_INT64) && SlXvIsFeatureMissing(XSLFI_SCRIPT_INT64)) ? SLE_FILE_I32 | SLE_VAR_I64 : SLE_INT64);
@@ -608,34 +587,34 @@ bool ScriptInstance::IsPaused()
}
case SQSL_STRING: {
SlObject(nullptr, _script_byte);
static char buf[std::numeric_limits<decltype(_script_sl_byte)>::max()];
SlArray(buf, _script_sl_byte, SLE_CHAR);
StrMakeValidInPlace(buf, buf + _script_sl_byte);
byte len = SlReadByte();
static char buf[std::numeric_limits<decltype(len)>::max()];
SlArray(buf, len, SLE_CHAR);
StrMakeValidInPlace(buf, buf + len);
if (data != nullptr) data->push_back(std::string(buf));
return true;
}
case SQSL_ARRAY:
case SQSL_TABLE: {
if (data != nullptr) data->push_back((SQSaveLoadType)_script_sl_byte);
if (data != nullptr) data->push_back((SQSaveLoadType)type);
while (LoadObjects(data));
return true;
}
case SQSL_BOOL: {
SlObject(nullptr, _script_byte);
if (data != nullptr) data->push_back((SQBool)(_script_sl_byte != 0));
byte sl_byte = SlReadByte();
if (data != nullptr) data->push_back((SQBool)(sl_byte != 0));
return true;
}
case SQSL_NULL: {
if (data != nullptr) data->push_back((SQSaveLoadType)_script_sl_byte);
if (data != nullptr) data->push_back((SQSaveLoadType)type);
return true;
}
case SQSL_ARRAY_TABLE_END: {
if (data != nullptr) data->push_back((SQSaveLoadType)_script_sl_byte);
if (data != nullptr) data->push_back((SQSaveLoadType)type);
return false;
}
@@ -698,9 +677,9 @@ bool ScriptInstance::IsPaused()
/* static */ void ScriptInstance::LoadEmpty()
{
SlObject(nullptr, _script_byte);
byte sl_byte = SlReadByte();
/* Check if there was anything saved at all. */
if (_script_sl_byte == 0) return;
if (sl_byte == 0) return;
LoadObjects(nullptr);
}
@@ -712,9 +691,9 @@ bool ScriptInstance::IsPaused()
return nullptr;
}
SlObject(nullptr, _script_byte);
byte sl_byte = SlReadByte();
/* Check if there was anything saved at all. */
if (_script_sl_byte == 0) return nullptr;
if (sl_byte == 0) return nullptr;
ScriptData *data = new ScriptData();
data->push_back((SQInteger)version);