From d452517c66bb502d312cde00a114e37425c91367 Mon Sep 17 00:00:00 2001 From: Jonathan G Rennison Date: Tue, 6 Apr 2021 03:53:01 +0100 Subject: [PATCH] Fix data race warning in NetworkGameListHandleDelayedInsert Avoid thread-sanitizer warning on ins_item->next --- src/network/network_gamelist.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/network_gamelist.cpp b/src/network/network_gamelist.cpp index dfe07bdbbb..7994b38400 100644 --- a/src/network/network_gamelist.cpp +++ b/src/network/network_gamelist.cpp @@ -40,7 +40,7 @@ void NetworkGameListAddItemDelayed(NetworkGameList *item) static void NetworkGameListHandleDelayedInsert() { while (true) { - NetworkGameList *ins_item = _network_game_delayed_insertion_list.load(std::memory_order_relaxed); + NetworkGameList *ins_item = _network_game_delayed_insertion_list.load(std::memory_order_acquire); while (ins_item != nullptr && !_network_game_delayed_insertion_list.compare_exchange_weak(ins_item, ins_item->next, std::memory_order_acq_rel)) {} if (ins_item == nullptr) break; // No item left.