(svn r3747) Change HASBIT() to return 0/1 instead of 0/value of tested bit, because the name suggests it does the former and current behavior broke in some places in very subtle ways (for example HASBIT(x, 0) != HASBIT(y, 1) doesn't work, returning a bool after HASBIT(x, 9) neither)
This commit is contained in:
@@ -291,8 +291,8 @@ static void BuildRailClick_Remove(Window *w)
|
||||
SndPlayFx(SND_15_BEEP);
|
||||
|
||||
TOGGLEBIT(w->click_state, 16);
|
||||
_remove_button_clicked = HASBIT(w->click_state, 16) != 0;
|
||||
SetSelectionRed(HASBIT(w->click_state, 16) != 0);
|
||||
_remove_button_clicked = HASBIT(w->click_state, 16);
|
||||
SetSelectionRed(HASBIT(w->click_state, 16));
|
||||
|
||||
// handle station builder
|
||||
if (HASBIT(w->click_state, 16)) {
|
||||
|
||||
Reference in New Issue
Block a user