dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

(svn r14759) -Fix (r14730): tab completion causing out-of-bounds read.

Browse Source
This commit is contained in:
rubidium
2008-12-28 21:07:45 +00:00
parent ee952b10d9
commit e626e07bd3
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/network/network_chat_gui.cpp
View File

@@ -300,12 +300,14 @@ struct NetworkChatWindow : public QueryStringBaseWindow {
/* First, try clients */
if (*item < MAX_CLIENT_SLOTS) {
/* Skip inactive clients */
NetworkClientInfo *ci;
FOR_ALL_CLIENT_INFOS_FROM(ci, *item + 1) break;
if (ci != NULL) {
*item = ci->index;
return ci->client_name;
if (*item + 1 < GetNetworkClientInfoPoolSize()) {
/* Skip inactive clients */
NetworkClientInfo *ci;
FOR_ALL_CLIENT_INFOS_FROM(ci, *item + 1) break;
if (ci != NULL) {
*item = ci->index;
return ci->client_name;
}
}
*item = MAX_CLIENT_SLOTS;
}