(svn r14414) -Fix: replace instances of strncpy with strecpy as strncpy doesn't guarantee the resulting string is '\0'-terminated.

2008-09-29 16:27:02 +00:00
parent a25d9bcc8b
commit e7829c1a57
10 changed files with 14 additions and 11 deletions
--- a/src/namegen.cpp
+++ b/src/namegen.cpp
@@ -36,7 +36,7 @@ static inline int32 SeedChanceBias(int shift_by, int max, uint32 seed, int bias)

 static void ReplaceWords(const char *org, const char *rep, char *buf)
 {
-	if (strncmp(buf, org, 4) == 0) strncpy(buf, rep, 4);
+	if (strncmp(buf, org, 4) == 0) strncpy(buf, rep, 4); // Safe as the string in buf is always more than 4 characters long.
 }

 static byte MakeEnglishOriginalTownName(char *buf, uint32 seed, const char *last)