Merge branch 'master' into jgrpp
# Conflicts: # projects/openttd_vs140.vcxproj.filters # projects/openttd_vs141.vcxproj.filters # projects/openttd_vs142.vcxproj.filters # src/base_consist.h # src/company_base.h # src/newgrf_config.cpp # src/newgrf_config.h # src/openttd.cpp # src/saveload/saveload.cpp # src/saveload/saveload.h # src/saveload/station_sl.cpp # src/settings.cpp # src/signs_base.h # src/string.cpp # src/string_func.h # src/table/misc_settings.ini # src/table/settings.h.preamble # src/town_cmd.cpp # src/vehicle.cpp # src/vehicle_cmd.cpp # src/video/cocoa/cocoa_v.mm # src/video/null_v.cpp
This commit is contained in:
@@ -68,7 +68,6 @@ assert_compile(lengthof(_orig_rail_vehicle_info) + lengthof(_orig_road_vehicle_i
|
||||
const uint EngineOverrideManager::NUM_DEFAULT_ENGINES = _engine_counts[VEH_TRAIN] + _engine_counts[VEH_ROAD] + _engine_counts[VEH_SHIP] + _engine_counts[VEH_AIRCRAFT];
|
||||
|
||||
Engine::Engine() :
|
||||
name(nullptr),
|
||||
overrides_count(0),
|
||||
overrides(nullptr)
|
||||
{
|
||||
@@ -141,7 +140,6 @@ Engine::Engine(VehicleType type, EngineID base)
|
||||
Engine::~Engine()
|
||||
{
|
||||
UnloadWagonOverrides(this);
|
||||
free(this->name);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -1079,7 +1077,7 @@ void EnginesMonthlyLoop()
|
||||
static bool IsUniqueEngineName(const char *name)
|
||||
{
|
||||
for (const Engine *e : Engine::Iterate()) {
|
||||
if (e->name != nullptr && strcmp(e->name, name) == 0) return false;
|
||||
if (!e->name.empty() && e->name == name) return false;
|
||||
}
|
||||
|
||||
return true;
|
||||
@@ -1107,12 +1105,10 @@ CommandCost CmdRenameEngine(TileIndex tile, DoCommandFlag flags, uint32 p1, uint
|
||||
}
|
||||
|
||||
if (flags & DC_EXEC) {
|
||||
free(e->name);
|
||||
|
||||
if (reset) {
|
||||
e->name = nullptr;
|
||||
e->name.clear();
|
||||
} else {
|
||||
e->name = stredup(text);
|
||||
e->name = text;
|
||||
}
|
||||
|
||||
MarkWholeScreenDirty();
|
||||
|
Reference in New Issue
Block a user