(svn r2324) Introduce _cmd_text for passing strings with a command instead of abusing _decode_parameters as text buffer. This should prevent several possible buffer overruns and is a bit cleaner to use. As bonus it reduces the size of most command packets by 79 bytes.
This commit is contained in:
@@ -2658,7 +2658,7 @@ int32 CmdRenameStation(int x, int y, uint32 flags, uint32 p1, uint32 p2)
|
||||
|
||||
if (!IsValidStation(st) || !CheckOwnership(st->owner)) return CMD_ERROR;
|
||||
|
||||
str = AllocateNameUnique((const char*)_decode_parameters, 6);
|
||||
str = AllocateNameUnique(_cmd_text, 6);
|
||||
if (str == 0) return CMD_ERROR;
|
||||
|
||||
if (flags & DC_EXEC) {
|
||||
|
Reference in New Issue
Block a user