tron
270e366772
(svn r8896) -Fix
...
Most (i.e. 13 of 15) callers of GetNewVehiclePos() do not care for the return and the others can figure it out by inspecting the information returned in struct GetNewVehiclePosResult.
Therefore remove the return value.
2007-02-25 10:25:25 +00:00
tron
696b895b77
(svn r8896) -Fix
...
Most (i.e. 13 of 15) callers of GetNewVehiclePos() do not care for the return and the others can figure it out by inspecting the information returned in struct GetNewVehiclePosResult.
Therefore remove the return value.
2007-02-25 10:25:25 +00:00
peter1138
6b7a4ba448
(svn r8891) -Codechange: Remove remains of global cargo scheme. All cargo mapping is now dealt with only in NewGRF code, on load where possible.
2007-02-24 23:36:40 +00:00
peter1138
4c4b035175
(svn r8891) -Codechange: Remove remains of global cargo scheme. All cargo mapping is now dealt with only in NewGRF code, on load where possible.
2007-02-24 23:36:40 +00:00
peter1138
2306a02f75
(svn r8849) -Codechange: Replace hardcoded global/climate cargo mapping tables with dynamically generated data. Change associated code to use new functions.
2007-02-22 22:09:51 +00:00
peter1138
6062004960
(svn r8849) -Codechange: Replace hardcoded global/climate cargo mapping tables with dynamically generated data. Change associated code to use new functions.
2007-02-22 22:09:51 +00:00
tron
053e2ddda5
(svn r8841) -Fix
...
Remove {,u}intswap() and replace them by Swap()
2007-02-22 08:43:02 +00:00
tron
103d119c51
(svn r8841) -Fix
...
Remove {,u}intswap() and replace them by Swap()
2007-02-22 08:43:02 +00:00
bjarni
2841e946af
(svn r8777) -Fix: FS#596 Cloning Maglev in UKRS forgets Mail refit
...
Cloning were unaware that articulated locomotives could refit without refitting the front unit
2007-02-17 13:50:22 +00:00
bjarni
790a3f5d5e
(svn r8777) -Fix: FS#596 Cloning Maglev in UKRS forgets Mail refit
...
Cloning were unaware that articulated locomotives could refit without refitting the front unit
2007-02-17 13:50:22 +00:00
celestar
d9f034bd87
(svn r8744) -Fix(r654/2105): Call GetFirstVehicleInChain only for trains, and assert the vehicle type in that function. Not a critical error, but it does increase game performance by up to 10% when playing a large game (many vehicles) with aircraft/road vehicle newgrfs loaded.
2007-02-15 10:21:00 +00:00
celestar
6abbf15a8e
(svn r8744) -Fix(r654/2105): Call GetFirstVehicleInChain only for trains, and assert the vehicle type in that function. Not a critical error, but it does increase game performance by up to 10% when playing a large game (many vehicles) with aircraft/road vehicle newgrfs loaded.
2007-02-15 10:21:00 +00:00
rubidium
a2999dadc9
(svn r8735) -Feature: drive-through road stops made possible by the hard work of mart3p.
2007-02-14 16:37:16 +00:00
rubidium
0e8f006dc1
(svn r8735) -Feature: drive-through road stops made possible by the hard work of mart3p.
2007-02-14 16:37:16 +00:00
rubidium
a374caf51d
(svn r8730) -Codechange: more replacements of magic numbers by enums and removal of some (by now) redundant comments.
2007-02-14 10:33:36 +00:00
rubidium
447b16930e
(svn r8730) -Codechange: more replacements of magic numbers by enums and removal of some (by now) redundant comments.
2007-02-14 10:33:36 +00:00
rubidium
b5dade8098
(svn r8715) -Codechange/cleanup: replace magic numbers related to state of road vehicles with enums. Original patch by mart3p.
2007-02-13 22:27:27 +00:00
rubidium
154dff9873
(svn r8715) -Codechange/cleanup: replace magic numbers related to state of road vehicles with enums. Original patch by mart3p.
2007-02-13 22:27:27 +00:00
rubidium
0ba18a677c
(svn r8701) -Codechange: replace magic numbers with enums for u.rail.track.
2007-02-13 10:46:45 +00:00
rubidium
4ec7eb2201
(svn r8701) -Codechange: replace magic numbers with enums for u.rail.track.
2007-02-13 10:46:45 +00:00
rubidium
eb5648f382
(svn r8698) -Codechange: enumify the returns of VehicleEnterTile
2007-02-13 10:26:53 +00:00
rubidium
a419f4aeda
(svn r8698) -Codechange: enumify the returns of VehicleEnterTile
2007-02-13 10:26:53 +00:00
bjarni
d40886903d
(svn r8621) -Codechange: assigned new numbers to the VEH_(type) enum so that VEH_Train is 0, VEH_Road is 1 and so on
...
This means that "v->type" can be used as array indexes instead of VehTypeToIndex() (or "v->type - VEH_Train/0x10 as the code still used in some places)
Surprisingly this can be done without changing the savegame format
2007-02-07 19:10:19 +00:00
bjarni
037d636734
(svn r8621) -Codechange: assigned new numbers to the VEH_(type) enum so that VEH_Train is 0, VEH_Road is 1 and so on
...
This means that "v->type" can be used as array indexes instead of VehTypeToIndex() (or "v->type - VEH_Train/0x10 as the code still used in some places)
Surprisingly this can be done without changing the savegame format
2007-02-07 19:10:19 +00:00
bjarni
f626458af7
(svn r8610) -Codechange/Feature: rewrote the list handling in the autoreplace window
...
-The user will notice the following changes:
All vehicle types behaves in the same way
Adding/removing an engine (new design and so on) can no longer result in the window selecting a new engine
All valid replacements will be displayed since it looks at refitting options as well (this solves the missing ships with the newships GRF)
Since you can't replace an engine into itself, the engine selected in the left list will no longer appear in the right list
-The code changes:
Instead of looping all engines all the time, each list generates a list like the build windows
This ensures consistent list generation since only one function can loop all engines
Unified code for all vehicle types
It now use the lists to call the drawing code in the build vehicle window
Works on selected EngineIDs instead of selected index in the list
2007-02-06 11:11:12 +00:00
bjarni
80125fd934
(svn r8610) -Codechange/Feature: rewrote the list handling in the autoreplace window
...
-The user will notice the following changes:
All vehicle types behaves in the same way
Adding/removing an engine (new design and so on) can no longer result in the window selecting a new engine
All valid replacements will be displayed since it looks at refitting options as well (this solves the missing ships with the newships GRF)
Since you can't replace an engine into itself, the engine selected in the left list will no longer appear in the right list
-The code changes:
Instead of looping all engines all the time, each list generates a list like the build windows
This ensures consistent list generation since only one function can loop all engines
Unified code for all vehicle types
It now use the lists to call the drawing code in the build vehicle window
Works on selected EngineIDs instead of selected index in the list
2007-02-06 11:11:12 +00:00
rubidium
bec2c60245
(svn r8593) -Fix (FS#564): bridges do not get destroyed when the bridge head gets flooded and there is a vehicle on the bridge. Original patch by KeeperofTheSoul.
2007-02-05 14:00:32 +00:00
rubidium
1bf688e5b5
(svn r8593) -Fix (FS#564): bridges do not get destroyed when the bridge head gets flooded and there is a vehicle on the bridge. Original patch by KeeperofTheSoul.
2007-02-05 14:00:32 +00:00
maedhros
913558797b
(svn r8501) -Fix (r7377) [FS#539]: Keep track of how much cargo has been paid for, so that cargo cannot be paid for more than once.
2007-01-31 22:33:24 +00:00
maedhros
d8edc2bb98
(svn r8501) -Fix (r7377) [FS#539]: Keep track of how much cargo has been paid for, so that cargo cannot be paid for more than once.
2007-01-31 22:33:24 +00:00
belugas
e8af755d7f
(svn r8455) -Codechange: Give a more meaningful name (railveh_type)to member flags of RailVehInfo, as well as changing the code to reflect the fact that it was not a flag but rather a one value only variable. Doing so, some evaluations have been simplified.
...
-Codechange: Add and use RAILVEH_SINGLEHEAD when railveh_type is set to 0, which was implicit before.
-Cleanup: Remove some extraneous parenthesis.
2007-01-30 11:53:35 +00:00
belugas
0c45071bb0
(svn r8455) -Codechange: Give a more meaningful name (railveh_type)to member flags of RailVehInfo, as well as changing the code to reflect the fact that it was not a flag but rather a one value only variable. Doing so, some evaluations have been simplified.
...
-Codechange: Add and use RAILVEH_SINGLEHEAD when railveh_type is set to 0, which was implicit before.
-Cleanup: Remove some extraneous parenthesis.
2007-01-30 11:53:35 +00:00
Darkvater
83ba97c755
(svn r8448) -Codechange/Fix (r2993): Also update the helicopter's rotor when loading the game. This can solve crashes when a game is loaded with missing GRF's
2007-01-28 21:53:13 +00:00
Darkvater
39a50e3723
(svn r8448) -Codechange/Fix (r2993): Also update the helicopter's rotor when loading the game. This can solve crashes when a game is loaded with missing GRF's
2007-01-28 21:53:13 +00:00
Darkvater
fa0b625552
(svn r8429) -Codechange: Add a name for AircraftVehicleInfo subtype helicopter and remove some magic numbers related to the subtype.
2007-01-27 12:45:55 +00:00
Darkvater
08c21c0c61
(svn r8429) -Codechange: Add a name for AircraftVehicleInfo subtype helicopter and remove some magic numbers related to the subtype.
2007-01-27 12:45:55 +00:00
Darkvater
2ff4492abc
(svn r8428) -Codechange: Add proper names to aircraft subtypes instead of magic numbers and add a function IsNormalAircraft() which tells us whether the aircraft is in fact some flying device or a rotor/shadow.
2007-01-27 12:29:55 +00:00
Darkvater
50ca901b40
(svn r8428) -Codechange: Add proper names to aircraft subtypes instead of magic numbers and add a function IsNormalAircraft() which tells us whether the aircraft is in fact some flying device or a rotor/shadow.
2007-01-27 12:29:55 +00:00
tron
7fffe8b3d4
(svn r8385) -Fix
...
-Regression (r8314): I only did half the necessary changes to move railtype from Engine to RailVehicleInfo. Now do the rest.
2007-01-24 07:14:09 +00:00
tron
0996de79df
(svn r8385) -Fix
...
-Regression (r8314): I only did half the necessary changes to move railtype from Engine to RailVehicleInfo. Now do the rest.
2007-01-24 07:14:09 +00:00
bjarni
c4dd62914a
(svn r8353) -Cleanup: added IsPlayerBuildableVehicleType() to autoreplace code (duplicated code removal)
2007-01-22 16:48:36 +00:00
bjarni
edf2f70565
(svn r8353) -Cleanup: added IsPlayerBuildableVehicleType() to autoreplace code (duplicated code removal)
2007-01-22 16:48:36 +00:00
bjarni
89bf1d627b
(svn r8349) -Codechange: replaced CMD_REFIT_VEH() and similar defines with real static inline functions
2007-01-22 16:16:52 +00:00
bjarni
8de4196410
(svn r8349) -Codechange: replaced CMD_REFIT_VEH() and similar defines with real static inline functions
2007-01-22 16:16:52 +00:00
tron
3d5acc1450
(svn r8314) -Fix
...
-Codechange: Move the railtype from EngineInfo to RailVehicleInfo, because having a railtype for non-rail vehicles isn't that useful
2007-01-21 16:08:18 +00:00
tron
bc523186e0
(svn r8314) -Fix
...
-Codechange: Move the railtype from EngineInfo to RailVehicleInfo, because having a railtype for non-rail vehicles isn't that useful
2007-01-21 16:08:18 +00:00
bjarni
8ca4a7d8d9
(svn r8296) -Fix: GenerateVehicleSortList() tried to put a TileIndex into an uint16
...
-Fix: CmdMassStartStopVehicle() tried to put a TileIndex into an uint16
Those two bugs were unrelated to each other and unrelated to r8295, even though that commit touched the code in question
2007-01-21 01:25:59 +00:00
bjarni
59e6e762b8
(svn r8296) -Fix: GenerateVehicleSortList() tried to put a TileIndex into an uint16
...
-Fix: CmdMassStartStopVehicle() tried to put a TileIndex into an uint16
Those two bugs were unrelated to each other and unrelated to r8295, even though that commit touched the code in question
2007-01-21 01:25:59 +00:00
bjarni
1995cdf00b
(svn r8295) -Cleanup: merged arguments station, order and depot_airport_index for GenerateVehicleSortList() and BuildVehicleList() into one uint16 argument
...
It turned out that all 3 arguments were the same at all the places those functions are called, so there was no point in having more than one
2007-01-21 01:07:15 +00:00
bjarni
518c4cdfce
(svn r8295) -Cleanup: merged arguments station, order and depot_airport_index for GenerateVehicleSortList() and BuildVehicleList() into one uint16 argument
...
It turned out that all 3 arguments were the same at all the places those functions are called, so there was no point in having more than one
2007-01-21 01:07:15 +00:00