dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
57,988 Commits 1 Branch 0 Tags
3136f08b86116b7d6aa92f4a5f9d27a72fb471e2
Commit Graph

57988 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jonathan G Rennison
f8085683fb Change HTTPCallback::OnReceiveData to use UniqueBuffer 
See: https://github.com/OpenTTD/OpenTTD/issues/11636
 2023-12-30 20:43:36 +00:00
Jonathan G Rennison
f457f306ce Add std::unique_ptr<T[]> wrapper (UniqueBuffer) which also stores the size 2023-12-30 20:43:36 +00:00
Patric Stout
6e7c92e3af Fix: race-conditions in GUI updates when downloading HTTP files 
(cherry picked from commit 56c6df4702015fda7cc7a05b67bfe90b3ede1ad0)

See: https://github.com/OpenTTD/OpenTTD/issues/11636
See: https://github.com/OpenTTD/OpenTTD/pull/11639
 2023-12-30 19:00:21 +00:00
Peter Nelson
8ff0bef862 Codechange: Make widget index const to prevent changes. (#11658) 
This guards against future widget index manipulation.
 2023-12-30 18:55:16 +00:00
translators
fd782ada05 Update: Translations from eints 
russian: 11 changes by lexuslatvia
finnish: 12 changes by hpiirai
latvian: 217 changes by lexuslatvia
 2023-12-30 18:38:27 +00:00
Peter Nelson
6215e9bf77 Fix #11655: Crash due to NWidgetMatrix modifying widget->index. (#11657) 
NWidgetMatrix modifies its child widget's index to indicate which element
is to be drawn, which now causes issues with code that does not know about
stuffing extra data into the index.

Instead, let NWidgetMatrix store the currently processing element, and
retrieve this information from the matrix widget while child widgets are
being drawn.

This means only widgets that are children of NWidgetMatrix need to know
anything about their extra data.
 2023-12-30 18:24:26 +00:00
Charles Pigott
1e60734660 Fix: Compilation with DEBUG_DUMP_COMMANDS enabled (#11607) 2023-12-30 17:46:32 +00:00
Patric Stout
49db7bbe08 Change: add vcpkg.json to instruct vcpkg what dependencies we require 
This works on all OSes, making it far simpler for any developer
to jump in. Just install vcpkg, run "vcpkg install" in our root,
and you have all the dependencies.
 2023-12-30 18:40:04 +01:00
Patric Stout
0c064b5119 Change: [CI] use vcpkg built-in caching mechanism 2023-12-30 18:40:04 +01:00
Patric Stout
5d86588a45 Change: [CI] pkg-config is installed by default on latest runner 2023-12-30 18:40:04 +01:00
Patric Stout
086bd00f5d Fix: [CI] upgrade curl to a modern version to avoid patching other tools 2023-12-30 18:40:04 +01:00
Patric Stout
3fec8ece5a Change: [CI] always use "latest" image for our runners 2023-12-30 18:40:04 +01:00
Jonathan G Rennison
673a0dc5de Fix station blocked/pylon/wire bits with CBID_STATION_TILE_LAYOUT 2023-12-30 17:20:34 +00:00
Jonathan G Rennison
f3614c419d Fix savegames with incorrect signal always reserve through bits 
See: #620
 2023-12-30 15:16:25 +00:00
Jonathan G Rennison
8256bb8359 Tracerestrict: Fix share/unshare actions setting always reserve through bit incorrectly 
See: #620
 2023-12-30 14:53:17 +00:00
Jonathan G Rennison
00a0853550 Debug: Show if signal is always reserve through 2023-12-30 14:01:14 +00:00
Jonathan G Rennison
099a7bdd3a Debug: Add drop-down items to go between road/rail/signal features 2023-12-30 14:01:14 +00:00
Jonathan G Rennison
dac4d9a221 Debug: Allow debug feature helpers to provide drop down options 
In non sprite dump mode
 2023-12-30 14:01:14 +00:00
Patric Stout
d6e8e83052 Fix: [CI] patch in SHF_COMPRESSED symbol for our Linux Generic binaries (#11651) 2023-12-30 14:40:09 +01:00
Peter Nelson
f3b4d2a384 Fix #11649: Ignore disabling a widget that does not exist. (#11652) 
Orders window has different widget layouts depending on vehicle type
which don't all have the same widgets, and therefore it tries to disable
widgets that might not exist.

Restore the old behaviour of ignoring such requests, instead of crashing.
 2023-12-30 13:29:31 +00:00
Peter Nelson
268e512fb8 Codechange: Set storage type of widget enums to WidgetID. 2023-12-30 00:23:57 +00:00
Peter Nelson
a0dfb76e34 Codechange: Replace mishmash of types for widget index with WidgetID. 
Indices were stored as int, but often passed around as uint/uint8_t and casts.

Now they should all use WidgetID.
 2023-12-30 00:23:57 +00:00
Peter Nelson
fd84f73323 Fix #11643: Empty area at top of survey preview. (#11647) 
Empty area at the top of some textfile windows due to calling
SetDisplayedPlane() after calling FinishInitNested(), and/or changing
the displayed plane and not calling ReInit() after.

This was previously hidden by CheckForMissingGlyphs() reinitialising
all windows anyway.
 2023-12-30 00:19:27 +00:00
Jonathan G Rennison
e62c912c10 Fix off-by-one/buffer over-read error in StrMakeValid 
See: https://github.com/OpenTTD/OpenTTD/issues/11644
 2023-12-30 00:11:36 +00:00
Jonathan G Rennison
74a2cd5123 Fix thread safety issues in GetLogPrefix 2023-12-30 00:11:36 +00:00
Jonathan G Rennison
3683fdce6a Bump OpenTTD content version to 13.4 2023-12-29 20:33:57 +00:00
Jonathan G Rennison
383a21de9e CMake: Exclude SURVEY_KEY from version info 2023-12-29 19:55:16 +00:00
Jonathan G Rennison
f47a4e7cbd CMake: Fix binfiles not being included in build 2023-12-29 18:47:23 +00:00
Jonathan G Rennison
201ddf4c08 Merge branch 'master' into jgrpp 
# Conflicts:
#	src/widget.cpp
 2023-12-29 18:47:01 +00:00
Peter Nelson
b86182ab84 Codechange: Use std::map to provide indexed widget access. 
This removes the need to determine the biggest widget index and replaces C-style memory handling.
 2023-12-29 18:45:43 +00:00
Peter Nelson
a12f426d69 Codechange: Rename nested array to widget lookup. 
This changes from naming storage-type to naming functionality.

* `FillNestedArray` is renamed to `FillWidgetLookup`.
* `Window::nested_array` is renamed to `Window::widget_lookup`.
* `array` parameter renamed as well.
 2023-12-29 18:45:43 +00:00
translators
a8e587632a Update: Translations from eints 
danish: 3 changes by bscargo
dutch: 10 changes by Afoklala
 2023-12-29 18:38:59 +00:00
Jonathan G Rennison
b49f8c6bfc Avoid O(N^2) in group livery propagation 2023-12-29 15:34:34 +00:00
Jonathan G Rennison
ffff696b4e Merge branch 'master' into jgrpp 
# Conflicts:
#	src/build_vehicle_gui.cpp
#	src/cheat_gui.cpp
#	src/console_cmds.cpp
#	src/crashlog.cpp
#	src/date_gui.cpp
#	src/engine.cpp
#	src/group_cmd.cpp
#	src/landscape.cpp
#	src/network/network_gui.cpp
#	src/newgrf.cpp
#	src/saveload/afterload.cpp
#	src/script/api/script_date.cpp
#	src/sl/oldloader_sl.cpp
#	src/station_cmd.cpp
#	src/station_cmd.h
#	src/strings.cpp
#	src/subsidy_gui.cpp
#	src/survey.cpp
#	src/timer/timer_game_calendar.cpp
#	src/timer/timer_game_calendar.h
 2023-12-29 14:46:53 +00:00
Peter Nelson
feb94d233d Codechange: Remove deferred nested_array initialization path. (#11640) 
Having two ways (`FillNestedArray` and `SetupSmallestSize`) to initialize
`Window::nested_array` introduces confusion.

Instead, make `FillNestedArray` the canonical way, always call it, and remove
init_array from `SetupSmallestSize`.
 2023-12-29 14:27:04 +00:00
Patric Stout
11ba951250 Fix: race-condition when creating new HTTP requests from different threads (#11638) 2023-12-29 12:45:23 +01:00
Jonathan G Rennison
0776d7e992 Disallow converting far end of tunnel/bridge road/tram when owned by other 
When adding road across or converting road/tram type
 2023-12-29 01:31:17 +00:00
Jonathan G Rennison
decfab153a Settings: Fix duplication of PLYX save field table 2023-12-29 00:57:10 +00:00
Jonathan G Rennison
ec6d2b68de Fix infrastructure totals when connecting road/tram of different owners 
across dual road/tram bridge with custom bridge heads
 2023-12-29 00:42:29 +00:00
Jonathan G Rennison
2810c4fe65 Simplify infrastructure updates in tunnel/bridge road/tram conversion 2023-12-28 23:55:31 +00:00
Peter Nelson
5d2ed80c95 Fix: Changing group parent did not properly update partially-default liveries. 2023-12-28 23:16:19 +00:00
Peter Nelson
bfb4254226 Fix: Changing default livery did not propagate to group liveries. 
#11614 attempted to address this but did not handle 2CC properly, and changes to the default livery were not handled.
 2023-12-28 23:16:19 +00:00
Jonathan G Rennison
3b18877b87 Fix #11629: AirportGetNearestTown for rotated airports (#11631) 
Add rotation parameter to AirportGetNearestTown
Add wrapper for existing stations
Remove unnecessary iterator cloning
 2023-12-28 21:43:05 +00:00
Peter Nelson
33ff64ef74 Codechange: Simplify ConvertDateToYMD by returning YearMonthDay instead of outputting to a pointer. (#11637) 2023-12-28 21:34:08 +00:00
Peter Nelson
bd3b28551e Codechange: Replace reliability magic numbers with constants. 
These are derived as a percentage of UINT16_MAX.
 2023-12-28 21:26:24 +00:00
Peter Nelson
7b2c143df0 Fix: Prevent underflow if engine base life is less than 8 years. 2023-12-28 21:26:24 +00:00
translators
ead5ad119c Update: Translations from eints 
english (au): 11 changes by krysclarke
danish: 9 changes by bscargo
portuguese (brazilian): 10 changes by pasantoro
 2023-12-28 18:38:31 +00:00
Jonathan G Rennison
6a94f2f3e7 Fix 35d2842d: Fix script handling of airport rotations 
Adjust types/signature
 2023-12-28 17:03:08 +00:00
Jonathan G Rennison
b72366419b Merge branch 'master' into jgrpp 
# Conflicts:
#	src/blitter/32bpp_anim.cpp
#	src/blitter/8bpp_optimized.cpp
#	src/gfx.cpp
#	src/gfx_func.h
#	src/gfxinit.cpp
#	src/network/core/os_abstraction.cpp
#	src/spritecache.cpp
 2023-12-28 16:56:54 +00:00
Jonathan G Rennison
507fd1839c Change minimum value for auto_timetable_separation_rate setting 2023-12-28 13:38:29 +00:00