dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
52,371 Commits 1 Branch 0 Tags
4db14ccd1817da3ff9de683feab9ca2fb2ea950d
Commit Graph

52371 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Patric Stout
921ab68a48 Codechange: use AsIntSetting()->Read() wrapper if possible (#9324) 2021-05-31 10:56:06 +02:00
Rubidium
68217b4568 Cleanup: [Fluidsynth] Remove fluid_player_join 
The function fluid_player_join in the library is broken beyond compare for the
usecases it was used for (see their #872). It does not wait until it is safe
to delete the player, so it is up to the end user to ensure that.

For OpenTTD we acquire a lock before fluid_synth_write_s16 and we acquire the
same lock in the stop function. So, only one of the functions can be doing its
thing, meaning we do not need to wait for the player to be stopped as it
cannot be doing anything as we prevent that by the lock.

(cherry picked from commit 79fc094c54)
 2021-05-30 22:09:54 +01:00
PeterN
d274a81d3f Fix: Apply unscaled padding to Viewport inside WWT_INSET. (#9219) 
Since pixel dimensions in SetPadding() are scaled by GUI size, padding for inset viewports was excessive.

Instead, automatically apply padding for WWT_INSET at widget level. This applies to all widgets inside a WWT_INSET, which in all instances is a NWID_VIEWPORT.

(cherry picked from commit 330a305c99)
 2021-05-30 22:06:56 +01:00
Jonathan G Rennison
fe64093cc0 Avoid reading non-32bpp sprites twice where possible 
Try to avoid unnecessary over-reading
 2021-05-30 22:02:14 +01:00
Jonathan G Rennison
f212332359 Inline fast case for random access file byte/word/dword read 2021-05-30 22:02:14 +01:00
Jonathan G Rennison
054c820521 Implement custom sprite detection with new sprite mechanism 2021-05-30 22:02:14 +01:00
rubidium42
2b014ba1d9 Fix fdc11a9: Missing sprite count determined on the wrong file 
(cherry picked from commit de940b1dbc)
 2021-05-30 22:02:14 +01:00
Rubidium
e227bbaff0 Cleanup: remove the old FIO slot functions 
(cherry picked from commit fa6abe1646)
 2021-05-30 22:02:14 +01:00
Rubidium
eecf7c8525 Codechange: let NewGRF make use of SpriteFile instead of most of the FIO slot functions 
(cherry picked from commit 10e35ca8e4)
 2021-05-30 22:02:14 +01:00
Rubidium
6bd12e24d7 Codechange: introduce SpriteFile to be used by the sprite loader instead of the global FIO slot functionality 
(cherry picked from commit fdc11a9f94)
 2021-05-30 22:02:14 +01:00
translators
043a544248 Update: Translations from eints 
korean: 2 changes by telk5093
russian: 1 change by Ln-Wolf
finnish: 1 change by hpiirai
portuguese: 1 change by azulcosta
portuguese (brazilian): 1 change by Vimerum
 2021-05-30 19:56:14 +00:00
Rubidium
5ded596c80 Fix #9320, 2e136285: nullptr could not be converted to string 2021-05-30 19:59:49 +02:00
rubidium42
4613ababd3 Fix #9316, 64eddaeb: at about 250.000 inhabitants the bridge length limit check overflows 2021-05-30 15:09:18 +02:00
Patric Stout
0c96884700 Codechange: add a wrapper function to find all settings based on prefix (#9312) 2021-05-30 10:55:52 +02:00
Patric Stout
e9e4588db1 Codechange: use setting name instead of index for HandleOldDiffCustom() (#9311) 2021-05-30 10:40:59 +02:00
Patric Stout
bcd7a7aafe Codechange: rename _SQ64 into POINTER_IS_64BIT (#9313) 2021-05-30 10:40:03 +02:00
rubidium42
8c273ed598 Codechange: [Network] Let admin-console use std::string(_view) 2021-05-30 10:15:22 +02:00
rubidium42
e58581f1f8 Codechange: [Network] Let admin-game script use std::string 2021-05-30 10:15:22 +02:00
rubidium42
29f2bd27c4 Codechange: [Game] Pass the length instead of '\0' terminating (and undoing that) in the middle of a C-string 2021-05-30 10:15:22 +02:00
rubidium42
8a918ce170 Codechange: [Network] Make admin name and version std::string 2021-05-30 10:15:22 +02:00
rubidium42
97c461d1e7 Fix: limit heightmap sizes to something reasonable to prevent crafted heightmaps to OOM-crash the game 2021-05-30 09:50:38 +02:00
Rubidium
04b38dbfca Codechange: lets music make use of RandomAccessFile instead of the FIO slot functions 
(cherry picked from commit 0dd339ecd8)
 2021-05-30 08:23:50 +01:00
Rubidium
525f6adcd0 Codechange: let NewGRF sounds make use of RandomAccessFile instead of the FIO slot functions 
(cherry picked from commit c097bc9d7d)
 2021-05-30 08:23:39 +01:00
Rubidium
4b37044ef1 Codechange: use the new RandomAccessFile as backend for the FIO slot functions 
(cherry picked from commit b144e56b2c)
 2021-05-30 08:21:09 +01:00
Jonathan G Rennison
98e9a3991b Increase RandomAccessFile::BUFFER_SIZE to 4096 2021-05-30 08:14:15 +01:00
Rubidium
e856ca7b69 Add: concept of a RandomAccessFile to replace the FIO slot functions 
(cherry picked from commit 8e0b1b5d1a)
 2021-05-30 08:11:09 +01:00
Rubidium
2606f5409a Fix: leaking file descriptors 
(cherry picked from commit 495d73a67f)
 2021-05-30 07:52:55 +01:00
Rubidium
7c4d803265 Fix: memory leak due to assigning result of strdup to a std::string 
(cherry picked from commit 296194ad36)
 2021-05-30 07:52:46 +01:00
Jonathan G Rennison
bf87578173 Fix #264: Crash before calling SDL_SetTextInputRect with no window focused 2021-05-30 07:38:37 +01:00
rubidium42
62e3bfd684 Fix #9243: [Network] For a dedicated server use a fallback client and server name 
Also warn when the client or server name has not been set and provide pointers on how to set them

(cherry picked from commit 0968d009c8)
 2021-05-30 06:45:44 +01:00
rubidium42
e3c9ed4d15 Codechange: [Network] Use std::string to determine an unique name for clients 2021-05-30 00:01:49 +02:00
rubidium42
806f78aa04 Codechange: [Network] Use std::string to send the client name and rcon commands 2021-05-30 00:01:49 +02:00
rubidium42
fd95736bac Codechange: [Network] Use std::string for server side logic of kicking and banning clients 2021-05-30 00:01:49 +02:00
rubidium42
f0e1cd0129 Codechange: [Network] Let server rcon result use std::string 2021-05-30 00:01:49 +02:00
rubidium42
8b9f1147df Codechange: [Network] Let server changing a client name use std::string 2021-05-30 00:01:49 +02:00
Patric Stout
d70fb74ac6 Codechange: use setting name instead of index for CmdChange(Company)Setting (#9306) 
This is mostly done as there are now constraints on settings.ini you might not
expected. For example, conditional settings always have to come last, as otherwise
they would influence the index.
 2021-05-29 23:27:01 +02:00
glx22
5799402f7a Codechange: Rename window related DeleteXXX to match new behaviour 2021-05-29 21:08:25 +02:00
glx22
994bf19aef Fix f6d5c01: Delay deletion when closing windows 2021-05-29 21:08:25 +02:00
rubidium42
ef991b1772 Codechange: [Network] Use std::string in CommandPacket 2021-05-29 19:02:18 +02:00
rubidium42
2e136285e1 Codechange: move from C-string to std::string for DoCommand 2021-05-29 19:02:18 +02:00
rubidium42
661728558e Codechange: let IsUnique.* functions accept std::string 2021-05-29 19:02:18 +02:00
rubidium42
b4aedef848 Codechange: add std::string variant of Utf8StringLength 2021-05-29 19:02:18 +02:00
Vít Šefl
0125ba82e8 Fix: Do not send vehicles towards incomplete PF nodes 
YAPF could end up in a situation where it sets the best intermediate node
to a node whose construction is never finalized (i.e. it is never added to
the open list). The content of the node would be overwritten in the next
round, potentially sending the vehicle to an unwanted location.
 2021-05-29 19:00:47 +02:00
Patric Stout
7713c3e3cc Codechange: move casting a "const char *" to "char *" to the caller 
It is not nice to have your definition say you won't change a value
while in fact the whole reason for your existance is to change it.
 2021-05-29 16:23:59 +02:00
Patric Stout
665e3c1f45 Fix: ScriptObject::DoCommand could modify "text" while defined "const" 
This could have unwanted side-effects, as it could change the
source for ever and ever.
 2021-05-29 16:23:59 +02:00
Patric Stout
b0f44d7eb1 Doc: describe what each settings-file is about 2021-05-29 11:27:00 +02:00
Patric Stout
e58046c947 Codechange: move all settings.ini files to table/settings 2021-05-29 11:27:00 +02:00
Patric Stout
ca9a7df752 Codechange: rename str_validate to StrMakeValid(InPlace) (#9304) 
This to be more explicit the function changes the value, and not
returns yes/no.
 2021-05-29 11:21:38 +02:00
Patric Stout
4d74e51907 Fix #9281: acquire a company uses special bookkeeping to make you rich (#9300) 
When you buy-out a company, you got your shares back. This is
based on company-value, which includes values for the vehicles etc.
In other words, you not only got the vehicles, but you also got
paid to get them back.

Additionally, you also got the loan of the company, but not the
money for the loan (as that is subtracted from the company-value).

Solve this by changing the rules of a buy-out: don't sell your
shares, get the loan AND the balance and get the infrastructure.
 2021-05-29 11:21:30 +02:00
rubidium42
4c0e083128 Cleanup: set the base in the setting templates, instead of defining the base for every setting 
This has the added benefit of not getting mistaken that multiple bases can be used for the same SettingTable
 2021-05-29 10:32:32 +02:00