PeterN
2d3250923c
Fix #10554 : Let Scrollbar::SetPosition clamp instead of assert. ( #10555 )
2023-03-09 10:19:58 -05:00
Rubidium
1e4a89177e
Fix: crashes to desktop from game scripts when companies disappear
...
When a game script is in company mode, it pretends to be another company. When
that company disappear (bankruptcy/merger), the game script still uses that
company and it keeps calling functions as if it is that company.
For example, ScriptEngine::IsBuildable internally dereferences Company without
checks, causing a null dereference for any ScriptEngine function when called
from a company scope of a company that has disappeared.
Guard against this by extending the ScriptCompanyScope::IsValid check to also
check for the company still being active.
2023-03-08 22:33:47 +01:00
Rubidium
717f79ff22
Add: deity mode enforcement checks to functions with command or company access
...
Command functions are those that call ScriptObject::Command, and functions
with company access are any that call ScriptObject::GetCompany. This is a bit
over-protective, but having the check everywhere makes it easier to validate
that no check is missing automatically instead of by review.
2023-03-08 22:33:47 +01:00
Rubidium
8d443d1379
Add: company mode enforcement checks to functions with command or company access
...
Command functions are those that call ScriptObject::Command, and functions
with company access are any that call ScriptObject::GetCompany. This is a bit
over-protective, but having the check everywhere makes it easier to validate
that no check is missing automatically instead of by review.
2023-03-08 22:33:47 +01:00
Rubidium
534f2419ad
Add: precondition checks to functions that work with both valid company and deity
...
These are functions that either use ScriptObject::Command or ScriptObject::GetCompany.
This is a bit over-protective, but having the check everywhere makes it easier to
validate that no check is missing automatically instead of by review.
At this moment these checks will not do anything useful, as either IsValid or
IsDeity from ScriptCompanyMode returns true, but that will change later.
2023-03-08 22:33:47 +01:00
Rubidium
a79f97c022
Change: upon an invalid company mode, set ERR_PRECONDITION_INVALID_COMPANY instead of ERR_PRECONDITION_INVALID
2023-03-08 22:33:47 +01:00
Rubidium
3287acd114
Fix 13528bfcd0: bank balance command allows int64, GS was limited to int32
2023-03-07 23:20:04 +01:00
Rubidium
83946ca31d
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
...
Direct 1:1 replacements in the code, and comments now refer to either
GSCompanyMode::IsValid or GSCompanyMode::IsDeity instead of several variations
on "company mode active" or "no company mode active".
2023-03-06 22:34:09 +01:00
Rubidium
cada2ca310
Add: GSCompanyMode::IsValid and IsDeity, and precondition enforcement helpers
2023-03-06 22:34:09 +01:00
glx22
ca149447d7
Codechange: Use SQInteger for generic numbers in script_window
2023-03-06 00:32:12 +01:00
glx22
f752d96125
Codechange: Use SQInteger for generic numbers in script_vehicle
2023-03-06 00:32:12 +01:00
glx22
4e48bf2e16
Codechange: Use SQInteger for generic numbers in script_town
2023-03-06 00:32:12 +01:00
glx22
18fe0a4046
Codechange: Use SQInteger for generic numbers in script_tilelist
2023-03-06 00:32:12 +01:00
glx22
cada18a6f8
Codechange: Use SQInteger for generic numbers in script_tile
2023-03-06 00:32:12 +01:00
glx22
07b73a8c02
Codechange: Use SQInteger for generic numbers in script_subsidy
2023-03-06 00:32:12 +01:00
glx22
cd80b31d19
Codechange: Use SQInteger for generic numbers in script_storypage
2023-03-06 00:32:12 +01:00
glx22
a9a55f2153
Codechange: Use SQInteger for generic numbers in script_station
2023-03-06 00:32:12 +01:00
glx22
446ebaa6b9
Codechange: Use SQInteger for generic numbers in script_road
2023-03-06 00:32:12 +01:00
glx22
4f6a2f31b5
Codechange: Use SQInteger for generic numbers in script_rail
2023-03-06 00:32:12 +01:00
glx22
cb2e76aae3
Codechange: Use SQInteger for generic numbers in script_priorityqueue
2023-03-06 00:32:12 +01:00
glx22
777b4d0987
Codechange: Use SQInteger for generic numbers in script_order
2023-03-06 00:32:12 +01:00
glx22
49ea69fdef
Codechange: Use SQInteger for generic numbers in script_objecttype
2023-03-06 00:32:12 +01:00
glx22
0293fd41e5
Codechange: Use SQInteger for generic numbers in script_news
2023-03-06 00:32:12 +01:00
glx22
f22903ab14
Codechange: Use SQInteger for generic numbers in script_newgrf
2023-03-06 00:32:12 +01:00
glx22
ca67075397
Codechange: Use SQInteger for generic numbers in script_map
2023-03-06 00:32:12 +01:00
glx22
a225fda9fe
Codechange: Use SQInteger for generic numbers in script_list
2023-03-06 00:32:12 +01:00
glx22
74ab9ee9dd
Codechange: Use SQInteger for generic numbers in script_league
2023-03-06 00:32:12 +01:00
glx22
367b2ba6d1
Codechange: Use SQInteger for generic numbers in script_infrastructure
2023-03-06 00:32:12 +01:00
glx22
5eaf9d39bf
Codechange: Use SQInteger for generic numbers in script_industrytype
2023-03-06 00:32:12 +01:00
glx22
6671994655
Codechange: Use SQInteger for generic numbers in script_industry
2023-03-06 00:32:12 +01:00
glx22
8eb35633ec
Codechange: Use SQInteger for generic numbers in script_group
2023-03-06 00:32:12 +01:00
glx22
6ca8499e6a
Codechange: Use SQInteger for generic numbers in script_goal
2023-03-06 00:32:12 +01:00
glx22
e784915b27
Codechange: Use SQInteger for generic numbers in script_gamesettings
2023-03-06 00:32:12 +01:00
glx22
6b8b4c392f
Codechange: Use SQInteger for generic numbers in script_engine
2023-03-06 00:32:12 +01:00
glx22
2f40bf8097
Codechange: Use SQInteger for generic numbers in script_date
2023-03-06 00:32:12 +01:00
glx22
424ae74504
Codechange: Use SQInteger for generic numbers in script_companymode
2023-03-06 00:32:12 +01:00
glx22
89c0841d0a
Codechange: Use SQInteger for generic numbers in script_company
2023-03-06 00:32:12 +01:00
glx22
7727323dbe
Codechange: Use SQInteger for generic numbers in script_cargomonitor
2023-03-06 00:32:12 +01:00
glx22
40424601c6
Codechange: Use SQInteger for generic numbers in script_cargo
2023-03-06 00:32:12 +01:00
glx22
83826b1793
Codechange: Use SQInteger for generic numbers in script_bridgelist
2023-03-06 00:32:12 +01:00
glx22
58bf2f7176
Codechange: Use SQInteger for generic numbers in script_bridge
2023-03-06 00:32:12 +01:00
glx22
73561802cb
Codechange: Use SQInteger for generic numbers in script_airport
2023-03-06 00:32:12 +01:00
glx22
b6f3552e4b
Fix: [Script] Inconsistent precondition failure return values
2023-03-06 00:32:12 +01:00
glx22
e06a666fa2
Fix: remove ScriptController constructor from API documentation
2023-03-06 00:32:12 +01:00
glx22
67a4c5e0db
Codechange: Use {fmt} for script_admin JSON generation
2023-03-06 00:32:12 +01:00
glx22
ce8cde3b8d
Fix: [Script] Detect circular references in ScriptText
2023-03-05 22:24:08 +01:00
glx22
9a957f1d4b
Change: [Script] Improve ScriptText validation error messages
2023-03-05 22:24:08 +01:00
glx22
991a797e09
Change: [Script] Validate ScriptText parameters type and amount
2023-02-28 18:53:17 +01:00
Rubidium
728973859d
Change: [Script] Automate the ScriptObject reference counting
2023-02-28 18:53:17 +01:00
glx22
a1fc4d5c0e
Codechange: [Script] Merge the 3 ScriptText param arrays
2023-02-28 18:53:17 +01:00
