Rubidium
a2051bad50
Codechange: move logic whether there is enough space in a packet to write data into the Packet
2021-04-24 20:42:01 +02:00
Rubidium
c545cc9d70
Codechange: move more logic about packet size validity and reading into Packet
2021-04-24 20:42:01 +02:00
S. D. Cloudt
13cc8a0cee
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
Henry Wilson
7c8e7c6b6e
Codechange: Use null pointer literal instead of the NULL macro
2019-04-10 23:22:20 +02:00
Patric Stout
e3c639a09f
Remove: ENABLE_NETWORK switch
...
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.
With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
2019-03-20 19:24:55 +01:00
rubidium
0463dbdc9e
(svn r26482) -Codechange: add an include that allows us to undefine/redefine "unsafe" functions to prevent them from being used, and thus having to care about certain aspects of their return values
2014-04-23 20:13:33 +00:00
rubidium
fefe22b4aa
(svn r23590) -Codechange: make the string validation settings better expandable
2011-12-18 18:37:54 +00:00
rubidium
99ec3a044a
(svn r22403) -Document: some more network/core code
2011-05-01 13:29:40 +00:00
rubidium
9c83a8975f
(svn r21357) -Codechange: make it possible to resize the packet's buffer
2010-11-30 13:22:29 +00:00
rubidium
83c8c562bb
(svn r18800) -Fix: in some cases with invalid packets one can crash recent trunk and 1.0.0 betas; 0.7.5 and before can't be crashed though.
2010-01-14 21:47:31 +00:00
smatz
eb72a0095f
(svn r17746) -Codechange: 'operator new' doesn't return NULL, NetworkSend_Init() is useless
2009-10-09 11:03:00 +00:00
rubidium
7fbc33dae1
(svn r17248) -Fix: add GPL license notice where appropriate
2009-08-21 20:21:05 +00:00
rubidium
86ca408d46
(svn r15626) -Fix [FS#2698]: UTF8 string handling could cause buffer overruns.
2009-03-06 01:23:25 +00:00
rubidium
07e135547e
(svn r15135) -Fix/Change: allow str_validate (part of receiving strings from the network) to pass newlines instead of replacing them with question marks, but only when asked to do so.
2009-01-18 13:12:57 +00:00
rubidium
11da45ee55
(svn r14949) -Cleanup: pointer coding style
2009-01-10 00:31:47 +00:00
smatz
f32ecbcadb
(svn r12777) -Codechange: rename fatal() and error() in strgen, so it can always have the NORETURN attribute
2008-04-18 21:33:21 +00:00
rubidium
a3ccdcea36
(svn r11777) -Codechange: split the string header and make do not include it when it's not necessary.
2008-01-07 14:23:25 +00:00
rubidium
bf98e25e43
(svn r11691) -Codechange: move+rename helpers.hpp and only include it when it is really needed.
2007-12-25 09:48:53 +00:00
rubidium
01e20c9140
(svn r11674) -Codechange: refactor some functions out of macros.h into more logical locations.
2007-12-21 19:21:21 +00:00
rubidium
8795050ff7
(svn r11290) -Fix: obiwan in the assertion that checked for overflows when writing a packet, causing still correctly sized packets to cause assertions.
2007-10-18 17:44:59 +00:00
rubidium
36bb92ae24
(svn r9050) -Codechange: Foo(void) -> Foo()
2007-03-07 11:47:46 +00:00
celestar
0ed4b64e64
(svn r8857) -Documentation: Added some doxygen @file tags, repaired others (the @file tag MUST be found before any line of code, that includes preprocessor directives).
2007-02-23 08:37:33 +00:00
rubidium
500f9a971a
(svn r8546) -Codechange: add a seperate (wrapper) functions to send/receive booleans.
2007-02-02 23:16:58 +00:00
rubidium
16ce6def09
(svn r8523) -Codechange: move all the Network(Recv|Send)_(uintXX|string) functions to Packet.
2007-02-01 23:26:44 +00:00
rubidium
99f860e686
(svn r8521) -Codechange: initial step in converting Packet to a class; make and use constructors and functions related to the reading/saving the packet size.
2007-02-01 22:30:35 +00:00
rubidium
f72dde5236
(svn r8445) -Cleanup: remove some @params from comments as the parameters did not exist anymore and add comments to several variables/functions.
2007-01-28 20:47:25 +00:00
rubidium
f66b373b52
(svn r8083) -Codechange: make a NetworkSocketHandler as base for all sockets and move a little of NetworkClientState functionality to the NetworkSocketHandler. Move the rest of the NetworkClientState to the new NetworkTCPSocketHandler class/struct, which is not yet implemented in an object oriented manner. The UDP socket handler now extends the NetworkSocketHandler instead of having a reference to a NetworkClientState.
2007-01-12 20:19:49 +00:00
KUDr
33be1ecfb1
(svn r8066) - Codechange: MallocT(), CallocT(), ReallocT() now return the pointer to allocated memory instead of modifying the pointer given as parameter
2007-01-11 17:29:39 +00:00
rubidium
f35ed4bbc2
(svn r8038) -Merge: the cpp branch. Effort of KUDr, Celestar, glx, Smoovius, stillunknown and pv2b.
2007-01-10 18:56:51 +00:00
KUDr
e373ea7096
(svn r8033) [cpp] - Prepare for merge from branches/cpp (all .c files renamed to .cpp)
2007-01-10 18:12:09 +00:00
