Patric Stout
e3c639a09f
Remove: ENABLE_NETWORK switch
...
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.
With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
2019-03-20 19:24:55 +01:00
rubidium
0463dbdc9e
(svn r26482) -Codechange: add an include that allows us to undefine/redefine "unsafe" functions to prevent them from being used, and thus having to care about certain aspects of their return values
2014-04-23 20:13:33 +00:00
rubidium
5eac3a77d2
(svn r25597) -Fix [FS#5635]: [Content] When the server closed the connection, the client would for eternity try to read a packet and never timeout making it impossible to reconnect
2013-07-13 09:26:11 +00:00
rubidium
e6ae8cf420
(svn r25593) -Cleanup: remove a few stale #defines
2013-07-13 06:18:16 +00:00
rubidium
51f0d11ee3
(svn r25573) -Change: make content list appear faster by allowing some window redraws in between
2013-07-07 10:37:16 +00:00
frosch
a443375d44
(svn r24674) -Fix (r24466, r23234) [FS#5358]: Downloaded heightmaps could not be used anymore. (sbr)
2012-11-08 21:41:00 +00:00
rubidium
9db98f3b14
(svn r24638) -Codechange: add some #ifndefs so MSU code doesn't need to compile it, and doesn't need all the required dependencies
2012-10-28 19:16:58 +00:00
frosch
e84cf93c98
(svn r24508) -Fix [FS#5281] (24488): Content GUI crashed after downloading a NewGRF while it is selected.
2012-09-02 10:04:28 +00:00
rubidium
4563c50c91
(svn r24491) -Fix: compilation error with networking disabled
2012-08-21 19:03:21 +00:00
yexo
053770d4a6
(svn r24488) -Feature [FS#5236]: add buttons to view textfiles from the online content window (LordAro)
2012-08-20 21:03:50 +00:00
yexo
483d878d5f
(svn r24466) -Codechange [FS#5236]: add general function for ContentType -> Subdirectory conversion (LordAro)
2012-08-13 18:49:38 +00:00
michi_cc
3536f4086a
(svn r22431) -Fix (r22399): NETWORK_RECV_STATUS_MALFORMED_PACKET != false.
2011-05-06 22:17:34 +00:00
rubidium
d4737e0724
(svn r22399) -Codechange: replace some defines in the tcp/content code so doxygen can create better documentation
2011-05-01 11:13:11 +00:00
rubidium
eb299736c1
(svn r21886) -Codechange: move documentation towards the code to make it more likely to be updated [n].
2011-01-22 09:53:15 +00:00
rubidium
b6c2216749
(svn r21358) -Codechange: make some network function names conform to coding style
2010-11-30 13:38:46 +00:00
rubidium
0ca7e4e82e
(svn r20924) -Codechange: make the game connection packet handling look more like UDP/content packet handling
2010-10-15 13:47:37 +00:00
frosch
4ce5c6d93d
(svn r20089) -Fix [FS#3932]: Access of already freed memory, esp. due to hidden destructor call from Swap().
2010-07-08 18:38:38 +00:00
smatz
837913aa5a
(svn r19508) -Codechange: remove semicolon after DEFINE_UNAVAILABLE_CONTENT_RECEIVE_COMMAND and DEFINE_UNAVAILABLE_UDP_RECEIVE_COMMAND
2010-03-23 22:36:02 +00:00
rubidium
df75db67eb
(svn r17742) -Codechange: remove unused variable from Recv_Packet
2009-10-07 20:58:14 +00:00
rubidium
d6cded5380
(svn r17693) -Cleanup: remove some unneeded includes
2009-10-04 17:16:41 +00:00
smatz
32cbe57178
(svn r17692) -Codechange: minor coding style fixes
2009-10-04 17:10:57 +00:00
rubidium
7fbc33dae1
(svn r17248) -Fix: add GPL license notice where appropriate
2009-08-21 20:21:05 +00:00
rubidium
ae71df349e
(svn r17015) -Fix [FS#3075]: infinite recursion in content dependency checking
2009-07-31 23:54:43 +00:00
rubidium
804370d964
(svn r15914) -Codechange: let the content handling make use of NetworkAddress.
2009-04-02 18:35:59 +00:00
rubidium
4f5a8b15ed
(svn r15206) -Fix [FS#2567]: memory corruption due to not properly cleanup up the mess when cancelling a download
2009-01-22 10:09:56 +00:00
rubidium
3a13b75e37
(svn r15126) -Feature: downloading content from a central server (content.openttd.org) where authors can upload they NewGRFS/AI etc. This should make joining servers that use only NewGRFs that are distributed via this system easier as the players can download the NewGRFs from in the game. It should also make it easier to see whether there are updates for NewGRFs and make the necessary updates.
2009-01-17 16:53:32 +00:00
