dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
26,609 Commits 1 Branch 0 Tags
eaf1e33bd7fde28bab48c3a243aa13bb6df4e1a7
Commit Graph

26609 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jonathan G Rennison
67331fe946 Fix #9951: Scenario editor random industries button and persistent storage (#9952) 
BasePersistentStorageArray::SwitchMode was not called
 2022-07-21 16:21:38 +01:00
translators
8f772352ce Update: Translations from eints 
italian: 1 change by Rivarossi
 2022-07-20 18:57:16 +00:00
translators
b199779ad4 Update: Translations from eints 
chinese (simplified): 26 changes by ZZY2357
korean: 1 change by telk5093
 2022-07-19 18:55:56 +00:00
Patric Stout
77a85e9b4c Fix: CmdSetAutoReplace didn't validate group type and engine type match (#9950) 
Basically, you could setup an auto-replace in a group for trains
to replace a ship with another ship.

Most of the code is surprisingly okay with this, it is only the
group statistics that doesn't like this.
 2022-07-09 20:06:22 +02:00
Patric Stout
979704271b Fix: reverse train direction command did not validate the given vehicle properly (#9947) 
You could give a wagon in the chain to reverse (which makes no
functional sense ofc). In result, only parts of the vehicle were
reversing, leading to weird crashes.
 2022-07-09 12:28:20 +02:00
Patric Stout
055121df80 Fix: depot-related commands did not validate depot tiles properly (#9948) 
The bug comes in two slices:

1) the functions never actually checked if "tile" was a depot tile.
   This allowed executing the function on tile 0, where are the
   things like shadows of aircrafts are.
2) BuildDepotVehicleList() first checked if a vehicle is in a depot
   before checking if it was a primary vehicle. This is invalid
   for aircraft.

Fixing the first hides the second, and fixing the second makes the
first non-exploitable. But, fixing both felt like the best thing
to do.
 2022-07-09 12:28:09 +02:00
Patric Stout
100aca1848 Fix: CmdRemoveRoadStop didn't validate the height property properly (#9945) 
Height was a unsigned 32bit integer, where TileAddWrap uses a
signed 32bit integer for the height. In result, there was an
implicit cast from unsigned to signed, messing things up.

But looking at it from a functional perspective, allowing such
large values is not sensible. In fact, width is restricted to
just a 8bit integer. By changing height to a 8bit integer too,
the implicit cast will never make a positive value negative anymore.
 2022-07-09 12:27:58 +02:00
Patric Stout
9957675a66 Fix: autoreplace command did not validate the vehicle argument properly (#9946) 
It first checked if the vehicle was in the depot, which for some types
is only a valid action for the primary vehicle. Afterwards, it checked
if the vehicle was a primary vehicle.
 2022-07-09 11:25:17 +02:00
Patric Stout
4651ad94fe Fix: commands with a RoadType in their arguments were not validated properly (#9944) 
Although it was checked that RoadType was not 63 (INVALID_ROADTYPE),
and all values lower than 63 are fine, it also allowed values higher
than 63. As the RoadType is a "byte", it could contain values up
to 255.
 2022-07-09 10:03:57 +02:00
Patric Stout
6810d09c1b Fix: commands with Axis in their arguments were not validated properly (#9943) 
When you don't type an Enum, it is a signed value. To validate
if an Axis is valid, it is checked to be lower than AXIS_END. Which
is the case for any value below 0.
 2022-07-09 10:03:41 +02:00
Michael Lutz
dd93244853 Fix: The first tile in commands received from a client wasn't validated properly. 2022-07-08 22:37:41 +02:00
Jonathan G Rennison
19af139631 Fix #9937: Station industries_near incorrect after removing part moved sign 
RecomputeCatchment was being called before moving the sign tile
instead of afterwards
 2022-06-29 12:49:55 +02:00
translators
f72b9fa767 Update: Translations from eints 
italian: 22 changes by Rivarossi
 2022-06-28 18:54:28 +00:00
translators
ffd3c11ba7 Update: Translations from eints 
italian: 8 changes by Rivarossi
spanish: 19 changes by MontyMontana
 2022-06-24 18:48:39 +00:00
translators
68257e0d7d Update: Translations from eints 
turkish: 1 change by jnmbk
spanish: 12 changes by MontyMontana
 2022-06-23 18:50:06 +00:00
translators
f64cf8679d Update: Translations from eints 
chinese (traditional): 6 changes by wpi3
italian: 2 changes by Rivarossi
turkish: 1 change by jnmbk
 2022-06-21 18:47:23 +00:00
translators
278c1d06cf Update: Translations from eints 
italian: 6 changes by Rivarossi
turkish: 37 changes by jnmbk
 2022-06-20 18:48:32 +00:00
translators
79af42e992 Update: Translations from eints 
czech: 9 changes by LubosKolouch
 2022-06-19 18:45:14 +00:00
Jonathan G Rennison
4acccc232a Fix #9925: Industry tile layout validation for layouts of only one tile 2022-06-18 22:02:08 +02:00
translators
814c61a321 Update: Translations from eints 
tamil: 20 changes by Aswn
 2022-06-11 18:44:50 +00:00
Niels Martin Hansen
470c902bdc Fix #9918: Reset industy last production year on scenario start 2022-06-09 23:03:25 +02:00
Niels Martin Hansen
2cdb0cb084 Codechange: Factor out OnStartScenario function 2022-06-09 23:03:25 +02:00
translators
0d3756818f Update: Translations from eints 
korean: 1 change by telk5093
 2022-06-07 18:48:01 +00:00
translators
8cdf303e72 Update: Translations from eints 
indonesian: 30 changes by indrabagus
 2022-06-06 18:49:24 +00:00
translators
0a3d5f5ff8 Update: Translations from eints 
italian: 1 change by Rivarossi
 2022-06-02 18:51:19 +00:00
glx22
aeeee9f18e Fix #9909, 13528bf: Left-over unused parameter breaks overload resolution 2022-06-01 19:24:48 +02:00
glx22
675cf7a8ee Fix 6fe445e: [Script] Respect joining adjacent when building an airport 2022-05-31 23:14:47 +02:00
translators
9fca8af586 Update: Translations from eints 
spanish (mexican): 7 changes by absay
 2022-05-31 18:49:21 +00:00
translators
a59c19c6c2 Update: Translations from eints 
chinese (traditional): 24 changes by Tetrapod1206
italian: 6 changes by Rivarossi
 2022-05-30 18:48:34 +00:00
Niels Martin Hansen
5587e439a9 Fix: Industry layouts with zero regular tiles should be invalid 2022-05-29 16:34:30 +02:00
translators
578bb6638f Update: Translations from eints 
chinese (traditional): 120 changes by wpi3
vietnamese: 2 changes by KhoiCanDev
 2022-05-28 18:47:05 +00:00
translators
e3a4524133 Update: Translations from eints 
chinese (traditional): 130 changes by Tetrapod1206, 10 changes by wpi3
italian: 6 changes by Rivarossi
 2022-05-27 18:52:21 +00:00
glx22
906613e83a Change: [CMake] Disable newgrf scan for regression check 2022-05-27 19:57:50 +02:00
glx22
ed1457dca3 Fix 55170ae: [Script] Building two-way signals could end up one-way 2022-05-27 19:57:50 +02:00
translators
992c72c0cb Update: Translations from eints 
chinese (traditional): 365 changes by wpi3
 2022-05-26 18:50:37 +00:00
translators
57230c559b Update: Translations from eints 
swedish: 18 changes by joeax910
vietnamese: 26 changes by KhoiCanDev
 2022-05-25 18:51:33 +00:00
translators
d89e7484c8 Update: Translations from eints 
swedish: 15 changes by joeax910
 2022-05-24 18:51:54 +00:00
translators
59f16b1a38 Update: Translations from eints 
korean: 5 changes by telk5093
russian: 12 changes by Ln-Wolf
 2022-05-23 18:50:50 +00:00
translators
8d8f45f0dd Update: Translations from eints 
russian: 25 changes by Ln-Wolf
 2022-05-22 18:48:51 +00:00
translators
3a2c0531b6 Update: Translations from eints 
italian: 1 change by Rivarossi
polish: 2 changes by pAter-exe
 2022-05-21 18:48:45 +00:00
translators
b1e24a0ae3 Update: Translations from eints 
italian: 22 changes by Rivarossi
 2022-05-20 18:50:57 +00:00
translators
9d979a6d23 Update: Translations from eints 
spanish (mexican): 1 change by absay
german: 25 changes by SecretIdetity
 2022-05-18 18:48:29 +00:00
translators
9842e8b762 Update: Translations from eints 
spanish (mexican): 8 changes by absay
czech: 18 changes by adamek0202
russian: 1 change by Ln-Wolf
catalan: 5 changes by J0anJosep
 2022-05-17 18:46:43 +00:00
translators
f8c6034b93 Update: Translations from eints 
spanish (mexican): 21 changes by absay
italian: 1 change by Rivarossi
russian: 12 changes by Ln-Wolf
 2022-05-16 18:50:05 +00:00
translators
fd1aa154f4 Update: Translations from eints 
italian: 1 change by Rivarossi
russian: 16 changes by Ln-Wolf
 2022-05-15 18:47:13 +00:00
translators
adc76cca54 Update: Translations from eints 
catalan: 2 changes by J0anJosep
 2022-05-14 18:48:27 +00:00
Frazer Smith
9bdc1e8f04 Update: bump peter-evans/repository-dispatch from 1 to 2 2022-05-14 16:58:10 +02:00
Frazer Smith
19b838dd60 Update: bump actions/download-artifact from 2 to 3 2022-05-14 16:58:10 +02:00
Frazer Smith
9162ac9d37 Update: bump actions/checkout from 2 to 3 2022-05-14 16:58:10 +02:00
Frazer Smith
2a2f80bb71 Update: bump actions/cache from 2 to 3 2022-05-14 16:58:10 +02:00