dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
1e4a89177e88d44a4ac82acd7197a6ee79d46e66
openttd/src/script/api
History
Rubidium 1e4a89177e Fix: crashes to desktop from game scripts when companies disappear 
When a game script is in company mode, it pretends to be another company. When
that company disappear (bankruptcy/merger), the game script still uses that
company and it keeps calling functions as if it is that company.

For example, ScriptEngine::IsBuildable internally dereferences Company without
checks, causing a null dereference for any ScriptEngine function when called
from a company scope of a company that has disappeared.

Guard against this by extending the ScriptCompanyScope::IsValid check to also
check for the company still being active.
2023-03-08 22:33:47 +01:00
..
ai
Change: rewrote squirrel_export in CMake
2020-07-16 00:53:26 +02:00
game
Change: rewrote squirrel_export in CMake
2020-07-16 00:53:26 +02:00
ai_changelog.hpp
Fix: Some Script::IsValidVehicle checks need to be complemented with IsPrimaryVehicle
2023-02-18 09:58:02 +01:00
CMakeLists.txt
Feature: [GS] Scriptable league tables (#10001)
2022-11-26 18:03:03 +01:00
Doxyfile_AI.in
Fix: warnings about obsolete settings/setting values in Doxygen configurations
2023-01-26 16:07:14 +01:00
Doxyfile_GS.in
Fix: warnings about obsolete settings/setting values in Doxygen configurations
2023-01-26 16:07:14 +01:00
doxygen_filter.awk
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
doxygen_filter.sh
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
game_changelog.hpp
Add: GSCompanyMode::IsValid and IsDeity, and precondition enforcement helpers
2023-03-06 22:34:09 +01:00
script_accounting.cpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_accounting.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_admin.cpp
Codechange: Use {fmt} for script_admin JSON generation
2023-03-06 00:32:12 +01:00
script_admin.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_airport.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_airport.hpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_base.cpp
Fix: [Script] ScriptBase::Rand() return value was between -MIN(int32) and MAX(int32) (#10443)
2023-02-10 19:55:59 +01:00
script_base.hpp
Fix: [Script] ScriptBase::Rand() return value was between -MIN(int32) and MAX(int32) (#10443)
2023-02-10 19:55:59 +01:00
script_basestation.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_basestation.hpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_bridge.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_bridge.hpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_bridgelist.cpp
Codechange: Use SQInteger for generic numbers in script_bridgelist
2023-03-06 00:32:12 +01:00
script_bridgelist.hpp
Codechange: Use SQInteger for generic numbers in script_bridgelist
2023-03-06 00:32:12 +01:00
script_cargo.cpp
Codechange: Use SQInteger for generic numbers in script_cargo
2023-03-06 00:32:12 +01:00
script_cargo.hpp
Codechange: Use SQInteger for generic numbers in script_cargo
2023-03-06 00:32:12 +01:00
script_cargolist.cpp
Codechange: Replace FOR_ALL_CARGOSPECS with range-based for loops
2021-04-29 21:08:24 +02:00
script_cargolist.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_cargomonitor.cpp
Codechange: Use SQInteger for generic numbers in script_cargomonitor
2023-03-06 00:32:12 +01:00
script_cargomonitor.hpp
Codechange: Use SQInteger for generic numbers in script_cargomonitor
2023-03-06 00:32:12 +01:00
script_client.cpp
Codechange: [Network] Let NetworkClientInfo use std::string
2021-05-16 10:07:51 +02:00
script_client.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_clientlist.cpp
Codechange: Replace network related FOR_ALL with range-based for loops
2019-12-21 20:13:03 +01:00
script_clientlist.hpp
Fix: missing/duplicate documentation tags for scripts
2023-01-26 16:07:14 +01:00
script_company.cpp
Add: company mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_company.hpp
Add: company mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_companymode.cpp
Fix: crashes to desktop from game scripts when companies disappear
2023-03-08 22:33:47 +01:00
script_companymode.hpp
Fix: crashes to desktop from game scripts when companies disappear
2023-03-08 22:33:47 +01:00
script_controller.cpp
Codechange: move windows common to AI and GS out of ai_gui
2023-02-05 19:27:25 +01:00
script_controller.hpp
Fix: remove ScriptController constructor from API documentation
2023-03-06 00:32:12 +01:00
script_date.cpp
Codechange: Use SQInteger for generic numbers in script_date
2023-03-06 00:32:12 +01:00
script_date.hpp
Codechange: Use SQInteger for generic numbers in script_date
2023-03-06 00:32:12 +01:00
script_depotlist.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_depotlist.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_engine.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_engine.hpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_enginelist.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_enginelist.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_error.cpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_error.hpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_event_types.cpp
Add: company mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_event_types.hpp
Add: company mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_event.cpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_event.hpp
Fix: missing/duplicate documentation tags for scripts
2023-01-26 16:07:14 +01:00
script_execmode.cpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_execmode.hpp
Change: Use gender-neutral pronouns in console command messages (and comments) (#9203)
2021-05-08 11:02:30 +01:00
script_game.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_game.hpp
Fix: missing/duplicate documentation tags for scripts
2023-01-26 16:07:14 +01:00
script_gamesettings.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_gamesettings.hpp
Codechange: Use SQInteger for generic numbers in script_gamesettings
2023-03-06 00:32:12 +01:00
script_goal.cpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_goal.hpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_group.cpp
Add: company mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_group.hpp
Add: company mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_grouplist.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_grouplist.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_includes.hpp.in
Change: rewrote squirrel_export in CMake
2020-07-16 00:53:26 +02:00
script_industry.cpp
Add: deity mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_industry.hpp
Add: deity mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_industrylist.cpp
Codechange: Replace FOR_ALL_INDUSTRIES with range-based for loops
2019-12-21 20:13:03 +01:00
script_industrylist.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_industrytype.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_industrytype.hpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_industrytypelist.cpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_industrytypelist.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_info_docs.hpp
Add: [Script] Labels for negative values of a setting
2023-02-21 00:28:21 +01:00
script_infrastructure.cpp
Codechange: Use SQInteger for generic numbers in script_infrastructure
2023-03-06 00:32:12 +01:00
script_infrastructure.hpp
Codechange: Use SQInteger for generic numbers in script_infrastructure
2023-03-06 00:32:12 +01:00
script_league.cpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_league.hpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_list.cpp
Codechange: Use SQInteger for generic numbers in script_list
2023-03-06 00:32:12 +01:00
script_list.hpp
Codechange: Use SQInteger for generic numbers in script_list
2023-03-06 00:32:12 +01:00
script_log.cpp
Codechange: move windows common to AI and GS out of ai_gui
2023-02-05 19:27:25 +01:00
script_log.hpp
Codechange: convert printf DEBUG statements to fmt Debug statements
2021-06-13 12:45:45 +02:00
script_map.cpp
Codechange: Use SQInteger for generic numbers in script_map
2023-03-06 00:32:12 +01:00
script_map.hpp
Codechange: Use SQInteger for generic numbers in script_map
2023-03-06 00:32:12 +01:00
script_marine.cpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_marine.hpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_newgrf.cpp
Codechange: Use SQInteger for generic numbers in script_newgrf
2023-03-06 00:32:12 +01:00
script_newgrf.hpp
Codechange: Use SQInteger for generic numbers in script_newgrf
2023-03-06 00:32:12 +01:00
script_news.cpp
Add: deity mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_news.hpp
Add: deity mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_object.cpp
Fix: crashes to desktop from game scripts when companies disappear
2023-03-08 22:33:47 +01:00
script_object.hpp
Change: [Script] Automate the ScriptObject reference counting
2023-02-28 18:53:17 +01:00
script_objecttype.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_objecttype.hpp
Codechange: Use SQInteger for generic numbers in script_objecttype
2023-03-06 00:32:12 +01:00
script_objecttypelist.cpp
Add: allow gamescripts to build neutral objects (#9568)
2021-09-25 13:39:40 +02:00
script_objecttypelist.hpp
Add: allow gamescripts to build neutral objects (#9568)
2021-09-25 13:39:40 +02:00
script_order.cpp
Add: company mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_order.hpp
Add: company mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_priorityqueue.cpp
Codechange: Use SQInteger for generic numbers in script_priorityqueue
2023-03-06 00:32:12 +01:00
script_priorityqueue.hpp
Codechange: Use SQInteger for generic numbers in script_priorityqueue
2023-03-06 00:32:12 +01:00
script_rail.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_rail.hpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_railtypelist.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_railtypelist.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_road.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_road.hpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_roadtypelist.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_roadtypelist.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_sign.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_sign.hpp
Fix: scripts are not aware of nullptr, they only know null
2023-01-26 16:07:14 +01:00
script_signlist.cpp
Codechange: Replace FOR_ALL_SIGNS with range-based for loops
2019-12-21 20:13:03 +01:00
script_signlist.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_station.cpp
Add: company mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_station.hpp
Add: company mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_stationlist.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_stationlist.hpp
Change: Use gender-neutral pronouns in console command messages (and comments) (#9203)
2021-05-08 11:02:30 +01:00
script_story_page.cpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_story_page.hpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_storypageelementlist.cpp
Codechange: Replace story related FOR_ALL with range-based for loops
2019-12-21 20:13:03 +01:00
script_storypageelementlist.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_storypagelist.cpp
Codechange: Replace story related FOR_ALL with range-based for loops
2019-12-21 20:13:03 +01:00
script_storypagelist.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_subsidy.cpp
Add: deity mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_subsidy.hpp
Add: deity mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_subsidylist.cpp
Codechange: Replace FOR_ALL_SUBSIDIES with range-based for loops
2019-12-21 20:13:03 +01:00
script_subsidylist.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_testmode.cpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_testmode.hpp
Change: Use gender-neutral pronouns in console command messages (and comments) (#9203)
2021-05-08 11:02:30 +01:00
script_text.cpp
Fix: [Script] Detect circular references in ScriptText
2023-03-05 22:24:08 +01:00
script_text.hpp
Fix: [Script] Detect circular references in ScriptText
2023-03-05 22:24:08 +01:00
script_tile.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_tile.hpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_tilelist.cpp
Codechange: Use SQInteger for generic numbers in script_tilelist
2023-03-06 00:32:12 +01:00
script_tilelist.hpp
Codechange: Use SQInteger for generic numbers in script_tilelist
2023-03-06 00:32:12 +01:00
script_town.cpp
Add: deity mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_town.hpp
Add: deity mode enforcement checks to functions with command or company access
2023-03-08 22:33:47 +01:00
script_townlist.cpp
Codechange: Replace FOR_ALL_TOWNS with range-based for loops
2019-12-21 20:13:03 +01:00
script_townlist.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_tunnel.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_tunnel.hpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_types.hpp
Codechange: Make TileIndex a "strong" typedef to give it a distinct type.
2021-12-16 22:28:32 +01:00
script_vehicle.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_vehicle.hpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_vehiclelist.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_vehiclelist.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_viewport.cpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_viewport.hpp
Codechange: use GSCompanyMode::IsValid, IsDeity, and the precondition helpers
2023-03-06 22:34:09 +01:00
script_waypoint.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_waypoint.hpp
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
script_waypointlist.cpp
Add: precondition checks to functions that work with both valid company and deity
2023-03-08 22:33:47 +01:00
script_waypointlist.hpp
Change: Use gender-neutral pronouns
2021-05-15 10:16:48 +02:00
script_window.cpp
Codechange: Use SQInteger for generic numbers in script_window
2023-03-06 00:32:12 +01:00
script_window.hpp.in
Codechange: Use SQInteger for generic numbers in script_window
2023-03-06 00:32:12 +01:00
squirrel_export.hpp.sq.in
Change: rewrote squirrel_export in CMake
2020-07-16 00:53:26 +02:00