Improve handling for exceptions, output more information so we can find and fix problems.

eos/db/__init__.py

@@ -49,8 +49,9 @@ try:
     config.gamedata_version = gamedata_session.execute(
         "SELECT `field_value` FROM `metadata` WHERE `field_name` LIKE 'client_build'"
     ).fetchone()[0]
-except:
+except Exception as e:
     pyfalog.warning("Missing gamedata version.")
+    pyfalog.critical(e)
     config.gamedata_version = None
 
 saveddata_connectionstring = config.saveddata_connectionstring

eos/graph/fitDps.py

@@ -68,9 +68,9 @@ class FitDpsGraph(Graph):
                     bonus = values[i]
                     val *= 1 + (bonus - 1) * exp(- i ** 2 / 7.1289)
                 data[attr] = val
-            except:
-                pyfalog.warning("Caught exception in calcDPS.")
-                pass
+            except Exception as e:
+                pyfalog.critical("Caught exception in calcDPS.")
+                pyfalog.critical(e)
 
         for mod in fit.modules:
             dps, _ = mod.damageStats(fit.targetResists)

eos/saveddata/module.py

@@ -639,6 +639,7 @@ class Module(HandledItem, HandledCharge, ItemAttrShortcut, ChargeAttrShortcut):
                             effect.handler(fit, self, chargeContext, effect=effect)
                         except:
                             effect.handler(fit, self, chargeContext)
+                            pyfalog.debug("Applying effect handler for charge without effect.")
 
         if self.item:
             if self.state >= State.OVERHEATED:
@@ -662,6 +663,7 @@ class Module(HandledItem, HandledCharge, ItemAttrShortcut, ChargeAttrShortcut):
                         effect.handler(fit, self, context, effect=effect)
                     except:
                         effect.handler(fit, self, context)
+                        pyfalog.debug("Applying effect handler without effect")
 
     @property
     def cycleTime(self):

eos/saveddata/targetResists.py

@@ -18,6 +18,9 @@
 # ===============================================================================
 
 import re
+from logbook import Logger
+
+pyfalog = Logger(__name__)
 
 
 class TargetResists(object):
@@ -43,7 +46,7 @@ class TargetResists(object):
                 type, data = line.rsplit('=', 1)
                 type, data = type.strip(), data.split(',')
             except:
-                # Data isn't in correct format, continue to next line
+                pyfalog.warning("Data isn't in correct format, continue to next line.")
                 continue
 
             if type != "TargetResists":
@@ -59,6 +62,7 @@ class TargetResists(object):
                     assert 0 <= val <= 100
                     fields["%sAmount" % cls.DAMAGE_TYPES[index]] = val / 100
                 except:
+                    pyfalog.warning("Caught unhandled exception in import patterns.")
                     continue
 
             if len(fields) == 4:  # Avoid possible blank lines