Improve handling for exceptions, output more information so we can find and fix problems.

gui/builtinViews/fittingView.py

@@ -61,9 +61,9 @@ class FitSpawner(gui.multiSwitch.TabSpawner):
                     self.multiSwitch.SetSelection(index)
                     wx.PostEvent(self.mainFrame, GE.FitChanged(fitID=event.fitID))
                     break
-            except:
-                pyfalog.warning("Caught exception in fitSelected")
-                pass
+            except Exception as e:
+                pyfalog.critical("Caught exception in fitSelected")
+                pyfalog.critical(e)
         if count < 0:
             startup = getattr(event, "startup", False)  # see OpenFitsThread in gui.mainFrame
             sFit = Fit.getInstance()
@@ -638,15 +638,17 @@ class FittingView(d.Display):
         if 'wxMac' in wx.PlatformInfo:
             try:
                 self.MakeSnapshot()
-            except:
-                pyfalog.warning("Failed to make snapshot")
+            except Exception as e:
+                pyfalog.critical("Failed to make snapshot")
+                pyfalog.critical(e)
 
     def OnShow(self, event):
         if event.GetShow():
             try:
                 self.MakeSnapshot()
-            except:
-                pyfalog.warning("Failed to make snapshot")
+            except Exception as e:
+                pyfalog.critical("Failed to make snapshot")
+                pyfalog.critical(e)
         event.Skip()
 
     def Snapshot(self):
@@ -671,8 +673,9 @@ class FittingView(d.Display):
         sFit = Fit.getInstance()
         try:
             fit = sFit.getFit(self.activeFitID)
-        except:
-            pyfalog.warning("Failed to get fit")
+        except Exception as e:
+            pyfalog.critical("Failed to get fit")
+            pyfalog.critical(e)
 
         if fit is None:
             return

gui/characterSelection.py

@@ -114,10 +114,10 @@ class CharacterSelection(wx.Panel):
         if charName:
             try:
                 sChar.apiFetch(self.getActiveCharacter(), charName)
-            except:
+            except Exception as e:
                 # can we do a popup, notifying user of API error?
                 pyfalog.error("API fetch error")
-                pass
+                pyfalog.error(e)
         self.refreshCharacterList()
 
     def charChanged(self, event):

gui/chromeTabs.py

@@ -1095,9 +1095,9 @@ class PFTabsContainer(wx.Panel):
                             self.previewTab = tab
                             self.previewTimer.Start(500, True)
                             break
-                    except:
-                        pyfalog.warning("Exception caught in CheckTabPreview.")
-                        pass
+                    except Exception as e:
+                        pyfalog.critical("Exception caught in CheckTabPreview.")
+                        pyfalog.critical(e)
 
     def CheckAddHighlighted(self, x, y):
         """

gui/crestFittings.py

@@ -415,9 +415,9 @@ class FittingsTreeView(wx.Panel):
                 cargo = Cargo(getItem(item['type']['id']))
                 cargo.amount = item['quantity']
                 list.append(cargo)
-            except:
-                pyfalog.error("Exception caught in displayFit")
-                pass
+            except Exception as e:
+                pyfalog.critical("Exception caught in displayFit")
+                pyfalog.critical(e)
 
         self.parent.fitView.fitSelection = selection
         self.parent.fitView.update(list)

gui/graphFrame.py

@@ -244,6 +244,7 @@ class GraphFrame(wx.Frame):
                 self.subplot.plot(x, y)
                 legend.append(fit.name)
             except:
+                pyfalog.warning("Invalid values in '{0}'", fit.name)
                 self.SetStatusText("Invalid values in '%s'" % fit.name)
                 self.canvas.draw()
                 return

gui/marketBrowser.py

@@ -187,8 +187,9 @@ class MarketTree(wx.TreeCtrl):
                 iconId = self.addImage(sMkt.getIconByMarketGroup(childMktGrp))
                 try:
                     childId = self.AppendItem(root, childMktGrp.name, iconId, data=wx.TreeItemData(childMktGrp.ID))
-                except:
+                except Exception as e:
                     pyfalog.debug("Error appending item.")
+                    pyfalog.debug(e)
                     continue
                 if sMkt.marketGroupHasTypesCheck(childMktGrp) is False:
                     self.AppendItem(childId, "dummy")