Roll up all changes from #962 as the base has been massively changed by code cleanups. Rename our logging to a universal pyfalog to avoid shadowing either Logging or Logbook loggers

gui/characterEditor.py

@@ -33,6 +33,8 @@ from service.fit import Fit
 from service.character import Character
 from service.network import AuthenticationError, TimeoutError
 from service.market import Market
+from logbook import Logger
+pyfalog = Logger(__name__)
 
 
 class CharacterTextValidor(BaseValidator):
@@ -55,6 +57,7 @@ class CharacterTextValidor(BaseValidator):
 
             return True
         except ValueError, e:
+            pyfalog.error(e)
             wx.MessageBox(u"{}".format(e), "Error")
             textCtrl.SetFocus()
             return False
@@ -628,11 +631,16 @@ class APIView(wx.Panel):
         try:
             activeChar = self.charEditor.entityEditor.getActiveEntity()
             list = sChar.apiCharList(activeChar.ID, self.inputID.GetLineText(0), self.inputKey.GetLineText(0))
-        except AuthenticationError:
-            self.stStatus.SetLabel("Authentication failure. Please check keyID and vCode combination.")
-        except TimeoutError:
-            self.stStatus.SetLabel("Request timed out. Please check network connectivity and/or proxy settings.")
+        except AuthenticationError, e:
+            msg = "Authentication failure. Please check keyID and vCode combination."
+            pyfalog.info(msg)
+            self.stStatus.SetLabel(msg)
+        except TimeoutError, e:
+            msg = "Request timed out. Please check network connectivity and/or proxy settings."
+            pyfalog.info(msg)
+            self.stStatus.SetLabel(msg)
         except Exception, e:
+            pyfalog.error(e)
             self.stStatus.SetLabel("Error:\n%s" % e.message)
         else:
             self.charChoice.Clear()
@@ -655,6 +663,7 @@ class APIView(wx.Panel):
                 sChar.apiFetch(activeChar.ID, charName)
                 self.stStatus.SetLabel("Successfully fetched %s\'s skills from EVE API." % charName)
             except Exception, e:
+                pyfalog.error("Unable to retrieve {0}\'s skills. Error message:\n{1}", charName, e)
                 self.stStatus.SetLabel("Unable to retrieve %s\'s skills. Error message:\n%s" % (charName, e))