pyCharm inspection fixes. Mostly variable refernce issues

eos/db/__init__.py

@@ -62,6 +62,8 @@ if saveddata_connectionstring is not None:
     saveddata_meta = MetaData()
     saveddata_meta.bind = saveddata_engine
     saveddata_session = sessionmaker(bind=saveddata_engine, autoflush=False, expire_on_commit=False)()
+else:
+    saveddata_meta = None
 
 # Lock controlling any changes introduced to session
 sd_lock = threading.Lock()

eos/db/saveddata/queries.py

@@ -68,6 +68,7 @@ if configVal is True:
             def checkAndReturn(*args, **kwargs):
                 useCache = kwargs.pop("useCache", True)
                 cacheKey = []
+                items = None
                 cacheKey.extend(args)
                 for keyword in keywords:
                     cacheKey.append(kwargs.get(keyword))

eos/effectHandlerHelpers.py

@@ -17,12 +17,7 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-# from sqlalchemy.orm.attributes import flag_modified
 import logging
-# TODO: This can't point to es_Module, cyclical import loop
-# from eos.saveddata.module import Module as es_Module, State as es_State
-
-import eos.db
 
 logger = logging.getLogger(__name__)
 

eos/saveddata/fit.py

@@ -27,7 +27,6 @@ from sqlalchemy.orm import validates, reconstructor
 
 import eos.db
 from eos import capSim
-from eos.effectHandlerHelpers import *
 from eos.effectHandlerHelpers import HandledModuleList, HandledDroneCargoList, HandledImplantBoosterList, HandledProjectedDroneList, HandledProjectedModList
 from eos.enum import Enum
 from eos.saveddata.ship import Ship
@@ -39,15 +38,10 @@ import logging
 
 logger = logging.getLogger(__name__)
 
-try:
-    from collections import OrderedDict
-except ImportError:
-    from utils.compat import OrderedDict
-
 
 class ImplantLocation(Enum):
     def __init__(self):
-        pass
+        Enum.__init__(self)
 
     FIT = 0
     CHARACTER = 1
@@ -727,7 +721,7 @@ class Fit(object):
                         self.register(item)
                         item.calculateModifiedAttributes(self, runTime, False)
 
-                    if projected is True and item not in chain.from_iterable(r):
+                    if projected is True and projectionInfo and item not in chain.from_iterable(r):
                         # apply effects onto target fit
                         for _ in xrange(projectionInfo.amount):
                             targetFit.register(item, origin=self)