pyCharm inspection fixes. Mostly variable refernce issues

service/fit.py

@@ -421,9 +421,7 @@ class Fit(object):
             return False
 
         if m.item.category.name == "Subsystem":
-            slot = m.getModifiedItemAttr("subSystemSlot")
-            dummy_module = es_Module.buildEmpty(fit.modules[slot])
-            fit.modules.freeSlot(slot, dummy_module)
+            fit.modules.freeSlot(m.getModifiedItemAttr("subSystemSlot"), es_Module.buildEmpty(m.slot))
 
         if m.fits(fit):
             m.owner = fit
@@ -450,7 +448,7 @@ class Fit(object):
             return None
 
         numSlots = len(fit.modules)
-        dummy_module =  es_Module.buildEmpty(fit.modules[position].slot)
+        dummy_module = es_Module.buildEmpty(fit.modules[position].slot)
         fit.modules.toDummy(position, dummy_module)
         self.recalc(fit)
         self.checkStates(fit, None)

service/market.py

@@ -736,8 +736,6 @@ class Market():
         """Get ships for given group id"""
         grp = self.getGroup(grpid, eager=("items", "items.group", "items.marketGroup"))
         ships = self.getItemsByGroup(grp)
-        for ship in ships:
-            ship.race
         return ships
 
     def getShipListDelayed(self, id_, callback):

service/port.py

@@ -115,6 +115,8 @@ class Port(object):
             # codepage then fallback to utf-16, cp1252
 
             if isinstance(srcString, str):
+                savebom = None
+
                 encoding_map = (
                     ('\xef\xbb\xbf', 'utf-8'),
                     ('\xff\xfe\0\0', 'utf-32'),