From 967128cb6903265b76aa72586b7307e7ae1fee35 Mon Sep 17 00:00:00 2001 From: blitzmann Date: Wed, 22 Nov 2017 23:16:28 -0500 Subject: [PATCH 1/2] Added missing effect for shield booster penalty on crash --- .../boostershieldboostamountpenaltyshieldskills.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 eos/effects/boostershieldboostamountpenaltyshieldskills.py diff --git a/eos/effects/boostershieldboostamountpenaltyshieldskills.py b/eos/effects/boostershieldboostamountpenaltyshieldskills.py new file mode 100644 index 000000000..d3badaf46 --- /dev/null +++ b/eos/effects/boostershieldboostamountpenaltyshieldskills.py @@ -0,0 +1,14 @@ +type = "boosterSideEffect" + +# User-friendly name for the side effect +displayName = "Shield Boost" + +# Attribute that this effect targets +attr = "boosterShieldBoostAmountPenalty" + + +def handler(fit, src, context): + fit.modules.filteredItemBoost(lambda mod: mod.item.requiresSkill("Shield Operation"), "shieldBonus", + src.getModifiedItemAttr("boosterShieldBoostAmountPenalty")) + fit.modules.filteredItemBoost(lambda mod: mod.item.requiresSkill("Capital Shield Operation"), "shieldBonus", + src.getModifiedItemAttr("boosterShieldBoostAmountPenalty")) From bd181559ed18c655adc6b06616e97d7dfd9f1326 Mon Sep 17 00:00:00 2001 From: blitzmann Date: Wed, 22 Nov 2017 23:19:03 -0500 Subject: [PATCH 2/2] Don't show Side Effects menu if there are no side effects (eg: Synths) --- gui/builtinContextMenus/boosterSideEffects.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gui/builtinContextMenus/boosterSideEffects.py b/gui/builtinContextMenus/boosterSideEffects.py index 68cfed1b2..60f5e2ca5 100644 --- a/gui/builtinContextMenus/boosterSideEffects.py +++ b/gui/builtinContextMenus/boosterSideEffects.py @@ -20,7 +20,12 @@ class BoosterSideEffect(ContextMenu): return False self.booster = selection[0] - return True + + for effect in self.booster.sideEffects: + if effect.effect.isImplemented: + return True + + return False def getText(self, itmContext, selection): return "Side Effects"