Merge branch 'master' into test-3

Conflicts:
	eos/gamedata.py
	eos/saveddata/booster.py
	eos/saveddata/character.py
	gui/builtinAdditionPanes/commandView.py
	gui/builtinContextMenus/commandFits.py
	gui/builtinMarketBrowser/itemView.py
	gui/builtinMarketBrowser/marketTree.py
	gui/builtinPreferenceViews/pyfaGeneralPreferences.py
	gui/builtinShipBrowser/categoryItem.py
	gui/builtinShipBrowser/fitItem.py
	gui/builtinShipBrowser/navigationPanel.py
	gui/builtinShipBrowser/raceSelector.py
	gui/builtinShipBrowser/shipItem.py
	gui/builtinStatsViews/priceViewFull.py
	gui/builtinViews/fittingView.py
	gui/characterEditor.py
	gui/characterSelection.py
	gui/chromeTabs.py
	gui/crestFittings.py
	gui/itemStats.py
	gui/mainFrame.py
	scripts/itemDiff.py
	service/price.py

gui/builtinViewColumns/__init__.py

@@ -1,2 +1,2 @@
 __all__ = ["ammo", "ammoIcon", "attributeDisplay", "baseIcon", "baseName",
-           "capacitorUse", "maxRange", "price", "propertyDisplay", "state", "misc", "abilities"]
+           "capacitorUse", "maxRange", "price", "propertyDisplay", "state", "misc", "abilities", "sideEffects"]

gui/builtinViewColumns/misc.py

@@ -49,6 +49,7 @@ class Miscellanea(ViewColumn):
             self.columnText = "Misc data"
             self.mask |= wx.LIST_MASK_TEXT
         self.mainFrame = gui.mainFrame.MainFrame.getInstance()
+        self.fittingView = fittingView
 
     def getText(self, stuff):
         return self.__getData(stuff)[0]
@@ -487,7 +488,7 @@ class Miscellanea(ViewColumn):
             if not hp or not cycleTime or not cycles:
                 return "", None
 
-            fit = Fit.getInstance().getFit(self.mainFrame.getActiveFit())
+            fit = Fit.getInstance().getFit(self.fittingView.getActiveFit())
             ehpTotal = fit.ehp
             hpTotal = fit.hp
             useEhp = self.mainFrame.statsPane.nameViewMap["resistancesViewFull"].showEffective
@@ -543,25 +544,7 @@ class Miscellanea(ViewColumn):
             return text, tooltip
         elif stuff.charge is not None:
             chargeGroup = stuff.charge.group.name
-            if chargeGroup in (
-                    "Rocket",
-                    "Advanced Rocket",
-                    "Light Missile",
-                    "Advanced Light Missile",
-                    "FoF Light Missile",
-                    "Heavy Assault Missile",
-                    "Advanced Heavy Assault Missile",
-                    "Heavy Missile",
-                    "Advanced Heavy Missile",
-                    "FoF Heavy Missile",
-                    "Torpedo",
-                    "Advanced Torpedo",
-                    "Cruise Missile",
-                    "Advanced Cruise Missile",
-                    "FoF Cruise Missile",
-                    "XL Torpedo",
-                    "XL Cruise Missile"
-            ):
+            if chargeGroup.endswith("Rocket") or chargeGroup.endswith("Missile") or chargeGroup.endswith("Torpedo"):
                 cloudSize = stuff.getModifiedChargeAttr("aoeCloudSize")
                 aoeVelocity = stuff.getModifiedChargeAttr("aoeVelocity")
                 if not cloudSize or not aoeVelocity:

gui/builtinViewColumns/sideEffects.py

@@ -0,0 +1,46 @@
+# =============================================================================
+# Copyright (C) 2010 Diego Duclos
+#
+# This file is part of pyfa.
+#
+# pyfa is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# pyfa is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with pyfa.  If not, see <http://www.gnu.org/licenses/>.
+# =============================================================================
+
+
+# noinspection PyPackageRequirements
+import wx
+from eos.saveddata.booster import Booster
+from gui.viewColumn import ViewColumn
+import gui.mainFrame
+
+
+class SideEffects(ViewColumn):
+    name = "Side Effects"
+
+    def __init__(self, fittingView, params):
+        ViewColumn.__init__(self, fittingView)
+
+        self.mainFrame = gui.mainFrame.MainFrame.getInstance()
+        self.columnText = "Active Side Effects"
+        self.mask = wx.LIST_MASK_TEXT
+
+    def getText(self, stuff):
+        if isinstance(stuff, Booster):
+            active = [x.name for x in stuff.sideEffects if x.active]
+            if len(active) == 0:
+                return "None"
+            return ", ".join(active)
+
+
+SideEffects.register()