From 00139e87157e91fce2e3a0f357978aeef7764425 Mon Sep 17 00:00:00 2001
From: Raoul Van den Berge <raoulvdberge@gmail.com>
Date: Mon, 3 Jul 2017 22:44:32 +0200
Subject: [PATCH] Added external storage advancement, changed some parents of
 upgrade advancements

---
 .../advancements/better_range.json            |  2 +-
 .../advancements/crafting_on_demand.json      |  2 +-
 .../advancements/fortunate_destruction.json   |  2 +-
 .../advancements/interdimensional.json        |  2 +-
 .../refinedstorage/advancements/silky.json    |  2 +-
 .../advancements/storing_externally.json      | 26 +++++++++++++++++++
 .../assets/refinedstorage/lang/en_us.lang     |  2 ++
 7 files changed, 33 insertions(+), 5 deletions(-)
 create mode 100644 src/main/resources/assets/refinedstorage/advancements/storing_externally.json

diff --git a/src/main/resources/assets/refinedstorage/advancements/better_range.json b/src/main/resources/assets/refinedstorage/advancements/better_range.json
index d832619e9..e235c4749 100644
--- a/src/main/resources/assets/refinedstorage/advancements/better_range.json
+++ b/src/main/resources/assets/refinedstorage/advancements/better_range.json
@@ -11,7 +11,7 @@
       "translate": "advancements.refinedstorage:better_range.description"
     }
   },
-  "parent": "refinedstorage:upgrading",
+  "parent": "refinedstorage:wireless",
   "criteria": {
     "disk_drive_in_inventory": {
       "trigger": "minecraft:inventory_changed",
diff --git a/src/main/resources/assets/refinedstorage/advancements/crafting_on_demand.json b/src/main/resources/assets/refinedstorage/advancements/crafting_on_demand.json
index c6b61ec2e..0343a397b 100644
--- a/src/main/resources/assets/refinedstorage/advancements/crafting_on_demand.json
+++ b/src/main/resources/assets/refinedstorage/advancements/crafting_on_demand.json
@@ -11,7 +11,7 @@
       "translate": "advancements.refinedstorage:crafting_on_demand.description"
     }
   },
-  "parent": "refinedstorage:upgrading",
+  "parent": "refinedstorage:pattern_creation",
   "criteria": {
     "disk_drive_in_inventory": {
       "trigger": "minecraft:inventory_changed",
diff --git a/src/main/resources/assets/refinedstorage/advancements/fortunate_destruction.json b/src/main/resources/assets/refinedstorage/advancements/fortunate_destruction.json
index 2f288e155..2eef7e368 100644
--- a/src/main/resources/assets/refinedstorage/advancements/fortunate_destruction.json
+++ b/src/main/resources/assets/refinedstorage/advancements/fortunate_destruction.json
@@ -11,7 +11,7 @@
       "translate": "advancements.refinedstorage:fortunate_destruction.description"
     }
   },
-  "parent": "refinedstorage:upgrading",
+  "parent": "refinedstorage:destruction",
   "criteria": {
     "disk_drive_in_inventory": {
       "trigger": "minecraft:inventory_changed",
diff --git a/src/main/resources/assets/refinedstorage/advancements/interdimensional.json b/src/main/resources/assets/refinedstorage/advancements/interdimensional.json
index bbfd58aaa..2e1924a07 100644
--- a/src/main/resources/assets/refinedstorage/advancements/interdimensional.json
+++ b/src/main/resources/assets/refinedstorage/advancements/interdimensional.json
@@ -11,7 +11,7 @@
       "translate": "advancements.refinedstorage:interdimensional.description"
     }
   },
-  "parent": "refinedstorage:better_range",
+  "parent": "refinedstorage:no_cables_required",
   "criteria": {
     "disk_drive_in_inventory": {
       "trigger": "minecraft:inventory_changed",
diff --git a/src/main/resources/assets/refinedstorage/advancements/silky.json b/src/main/resources/assets/refinedstorage/advancements/silky.json
index a1160f28b..a14622ce2 100644
--- a/src/main/resources/assets/refinedstorage/advancements/silky.json
+++ b/src/main/resources/assets/refinedstorage/advancements/silky.json
@@ -11,7 +11,7 @@
       "translate": "advancements.refinedstorage:silky.description"
     }
   },
-  "parent": "refinedstorage:upgrading",
+  "parent": "refinedstorage:destruction",
   "criteria": {
     "disk_drive_in_inventory": {
       "trigger": "minecraft:inventory_changed",
diff --git a/src/main/resources/assets/refinedstorage/advancements/storing_externally.json b/src/main/resources/assets/refinedstorage/advancements/storing_externally.json
new file mode 100644
index 000000000..d531bc2f5
--- /dev/null
+++ b/src/main/resources/assets/refinedstorage/advancements/storing_externally.json
@@ -0,0 +1,26 @@
+{
+  "display": {
+    "icon": {
+      "item": "refinedstorage:external_storage"
+    },
+    "title": {
+      "translate": "advancements.refinedstorage:storing_externally"
+    },
+    "description": {
+      "translate": "advancements.refinedstorage:storing_externally.description"
+    }
+  },
+  "parent": "refinedstorage:soldering",
+  "criteria": {
+    "disk_drive_in_inventory": {
+      "trigger": "minecraft:inventory_changed",
+      "conditions": {
+        "items": [
+          {
+            "item": "refinedstorage:external_storage"
+          }
+        ]
+      }
+    }
+  }
+}
\ No newline at end of file
diff --git a/src/main/resources/assets/refinedstorage/lang/en_us.lang b/src/main/resources/assets/refinedstorage/lang/en_us.lang
index 8cae4eb93..ce3e45df5 100755
--- a/src/main/resources/assets/refinedstorage/lang/en_us.lang
+++ b/src/main/resources/assets/refinedstorage/lang/en_us.lang
@@ -355,3 +355,5 @@ advancements.refinedstorage:detecting=Detecting
 advancements.refinedstorage:detecting.description=Detect items or fluids in the network with the Detector
 advancements.refinedstorage:interface_to_the_world=Interface to the world
 advancements.refinedstorage:interface_to_the_world.description=Make your storage system available as a regular inventory to the world by using an Interface
+advancements.refinedstorage:storing_externally=Storing externally
+advancements.refinedstorage:storing_externally.description=Use an External Storage to provide the network with storage from an external block like a chest