1.5.27 - Fixed non-oredict patterns not consuming resources, fixes #1570

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Refined Storage Changelog
 
+### 1.5.27
+- Fixed non-oredict patterns not consuming resources (raoulvdberge)
+
 ### 1.5.26
 - Added Funky Locomotion integration (raoulvdberge)
 - Minor fixes to autocrafting (raoulvdberge)

build.gradle

@@ -20,7 +20,7 @@ apply plugin: 'maven'
 apply plugin: 'maven-publish'
 apply plugin: 'net.minecraftforge.gradle.forge'
 
-version = "1.5.26"
+version = "1.5.27"
 group = "refinedstorage"
 archivesBaseName = "refinedstorage"
 

src/main/java/com/raoulvdberge/refinedstorage/RS.java

@@ -23,7 +23,7 @@ public final class RS {
     }
 
     public static final String ID = "refinedstorage";
-    public static final String VERSION = "1.5.26";
+    public static final String VERSION = "1.5.27";
     public static final String DEPENDENCIES = "required-after:forge@[14.21.0.2363,);after:mcmultipart@[2.2.1,);after:storagedrawers@[1.12-5.2.2,);";
     public static final String GUI_FACTORY = "com.raoulvdberge.refinedstorage.gui.config.ModGuiFactory";
     public static final String UPDATE_JSON = "https://refinedstorage.raoulvdberge.com/update";

src/main/java/com/raoulvdberge/refinedstorage/apiimpl/autocrafting/CraftingPattern.java

@@ -96,33 +96,33 @@ public class CraftingPattern implements ICraftingPattern {
             }
         } else {
             outputs = ItemPattern.getOutputs(stack);
+        }
 
-            if (oreInputs.isEmpty()) {
+        if (oreInputs.isEmpty()) {
-                for (ItemStack input : inputs) {
+            for (ItemStack input : inputs) {
-                    if (input == null || input.isEmpty()) {
+                if (input == null || input.isEmpty()) {
-                        oreInputs.add(Collections.emptyList());
+                    oreInputs.add(Collections.emptyList());
+                } else {
+                    int[] ids = OreDictionary.getOreIDs(input);
+
+                    if (ids.length == 0) {
+                        oreInputs.add(Collections.singletonList(Comparer.stripTags(input)));
+                    } else if (isOredict()) {
+                        List<ItemStack> oredictInputs = Arrays.stream(ids)
+                            .mapToObj(OreDictionary::getOreName)
+                            .map(OreDictionary::getOres)
+                            .flatMap(List::stream)
+                            .map(ItemStack::copy)
+                            .map(Comparer::stripTags)
+                            .peek(s -> s.setCount(input.getCount()))
+                            .collect(Collectors.toList());
+
+                        // Add original stack as first, should prevent some issues
+                        oredictInputs.add(0, Comparer.stripTags(input.copy()));
+
+                        oreInputs.add(oredictInputs);
                     } else {
-                        int[] ids = OreDictionary.getOreIDs(input);
+                        oreInputs.add(Collections.singletonList(Comparer.stripTags(input)));
-
-                        if (ids.length == 0) {
-                            oreInputs.add(Collections.singletonList(Comparer.stripTags(input)));
-                        } else if (isOredict()) {
-                            List<ItemStack> oredictInputs = Arrays.stream(ids)
-                                .mapToObj(OreDictionary::getOreName)
-                                .map(OreDictionary::getOres)
-                                .flatMap(List::stream)
-                                .map(ItemStack::copy)
-                                .map(Comparer::stripTags)
-                                .peek(s -> s.setCount(input.getCount()))
-                                .collect(Collectors.toList());
-
-                            // Add original stack as first, should prevent some issues
-                            oredictInputs.add(0, Comparer.stripTags(input.copy()));
-
-                            oreInputs.add(oredictInputs);
-                        } else {
-                            oreInputs.add(Collections.singletonList(Comparer.stripTags(input)));
-                        }
                     }
                 }
             }

src/main/resources/mcmod.info

@@ -3,7 +3,7 @@
       "modid": "refinedstorage",
       "name": "Refined Storage",
       "description": "An elegant solution to your hoarding problem",
-      "version": "1.5.26",
+      "version": "1.5.27",
       "mcversion": "1.12.2",
       "url": "https://refinedstorage.raoulvdberge.com",
       "updateUrl": "",