From 036e6807951447bb3503ffaace4781abbf626197 Mon Sep 17 00:00:00 2001 From: raoulvdberge Date: Sun, 12 Feb 2023 10:16:36 +0100 Subject: [PATCH] Fixed Constructor being able to drop more than the maximum stack size for an item. Fixes #3455 --- CHANGELOG.md | 3 ++- .../apiimpl/network/node/ConstructorNetworkNode.java | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d85e0e8ee..b9ef0cc9f 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,8 +10,9 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ### Fixed - Fixed some craftable items not showing as craftable in JEI -- Fixed grid crashing on exit if JEI mod is not used +- Fixed Grid crashing on exit if JEI mod is not used - Fixed rare multithreading crash +- Fixed Constructor being able to drop more than the maximum stack size for an item ## [v1.11.4] - 2022-12-20 diff --git a/src/main/java/com/refinedmods/refinedstorage/apiimpl/network/node/ConstructorNetworkNode.java b/src/main/java/com/refinedmods/refinedstorage/apiimpl/network/node/ConstructorNetworkNode.java index da1a613a4..5a4e6c344 100644 --- a/src/main/java/com/refinedmods/refinedstorage/apiimpl/network/node/ConstructorNetworkNode.java +++ b/src/main/java/com/refinedmods/refinedstorage/apiimpl/network/node/ConstructorNetworkNode.java @@ -134,7 +134,8 @@ public class ConstructorNetworkNode extends NetworkNode implements IComparable, } private void extractAndDropItem(ItemStack stack) { - ItemStack took = network.extractItem(stack, upgrades.getStackInteractCount(), compare, Action.PERFORM); + int dropCount = Math.min(upgrades.getStackInteractCount(), stack.getMaxStackSize()); + ItemStack took = network.extractItem(stack, dropCount, compare, Action.PERFORM); if (!took.isEmpty()) { DefaultDispenseItemBehavior.spawnItem(level, took, 6, getDirection(), new PositionImpl(getDispensePositionX(), getDispensePositionY(), getDispensePositionZ()));