Fix issues pointed out by the static analyzer.

src/main/java/com/raoulvdberge/refinedstorage/apiimpl/autocrafting/CraftingManager.java

@@ -93,9 +93,9 @@ public class CraftingManager implements ICraftingManager {
             tasksToAdd.stream().filter(ICraftingTask::isValid).forEach(tasks::add);
             tasksToAdd.clear();
 
-            changed = tasks.removeIf(ICraftingTask::update);
+            boolean anyFinished = tasks.removeIf(ICraftingTask::update);
 
-            if (changed) {
+            if (changed || anyFinished) {
                 markCraftingMonitorForUpdate();
             }
         }

src/main/java/com/raoulvdberge/refinedstorage/capability/CapabilityNetworkNodeProxy.java

@@ -38,7 +38,7 @@ public class CapabilityNetworkNodeProxy {
 
     private static class Factory implements Callable<INetworkNodeProxy> {
         @Override
-        public INetworkNodeProxy call() throws Exception {
+        public INetworkNodeProxy call() {
             return new INetworkNodeProxy() {
                 @Nonnull
                 @Override

src/main/java/com/raoulvdberge/refinedstorage/integration/oc/EnvironmentNetwork.java

@@ -76,10 +76,12 @@ public class EnvironmentNetwork extends AbstractManagedEnvironment {
         if (node.getNetwork() == null) {
             return new Object[]{null, "not connected"};
         }
-        List<ItemStack> patterns = new LinkedList<ItemStack>();
+
+        List<ItemStack> patterns = new LinkedList<>();
         for (ICraftingPattern pattern : node.getNetwork().getCraftingManager().getPatterns()) {
             patterns.addAll(pattern.getOutputs());
         }
+
         return new Object[]{patterns};
     }
 

src/main/java/com/raoulvdberge/refinedstorage/network/MessageCraftingMonitorElements.java

@@ -67,9 +67,7 @@ public class MessageCraftingMonitorElements implements IMessage, IMessageHandler
 
     @Override
     public IMessage onMessage(MessageCraftingMonitorElements message, MessageContext ctx) {
-        GuiBase.executeLater(GuiCraftingMonitor.class, craftingMonitor -> {
+        GuiBase.executeLater(GuiCraftingMonitor.class, craftingMonitor -> craftingMonitor.setElements(message.elements));
-            craftingMonitor.setElements(message.elements);
-        });
 
         return null;
     }

src/main/java/com/raoulvdberge/refinedstorage/render/BakedModelDiskDrive.java

@@ -70,7 +70,7 @@ public class BakedModelDiskDrive implements IBakedModel {
 
     private LoadingCache<CacheKey, List<BakedQuad>> cache = CacheBuilder.newBuilder().build(new CacheLoader<CacheKey, List<BakedQuad>>() {
         @Override
-        public List<BakedQuad> load(CacheKey key) throws Exception {
+        public List<BakedQuad> load(CacheKey key) {
             EnumFacing facing = key.state.getValue(RSBlocks.DISK_DRIVE.getDirection().getProperty());
 
             List<BakedQuad> quads = models.get(facing).getQuads(key.state, key.side, 0);

src/main/java/com/raoulvdberge/refinedstorage/render/BakedModelDiskManipulator.java

@@ -71,7 +71,7 @@ public class BakedModelDiskManipulator implements IBakedModel {
 
     private LoadingCache<CacheKey, List<BakedQuad>> cache = CacheBuilder.newBuilder().build(new CacheLoader<CacheKey, List<BakedQuad>>() {
         @Override
-        public List<BakedQuad> load(CacheKey key) throws Exception {
+        public List<BakedQuad> load(CacheKey key) {
             EnumFacing facing = key.state.getValue(RSBlocks.DISK_MANIPULATOR.getDirection().getProperty());
 
             List<BakedQuad> quads = (key.state.getValue(BlockDiskManipulator.CONNECTED) ? modelsConnected : modelsDisconnected).get(facing).getQuads(key.state, key.side, 0);

src/main/java/com/raoulvdberge/refinedstorage/render/CustomModelLoaderDefault.java

@@ -22,7 +22,7 @@ public class CustomModelLoaderDefault implements ICustomModelLoader {
     }
 
     @Override
-    public IModel loadModel(ResourceLocation modelLocation) throws Exception {
+    public IModel loadModel(ResourceLocation modelLocation) {
         return model.get();
     }
 

src/main/java/com/raoulvdberge/refinedstorage/tile/grid/portable/PortableGrid.java

@@ -61,9 +61,7 @@ public class PortableGrid implements IGrid, IPortableGrid {
     private int tabPage;
     private int size;
 
-    private StorageTrackerItem storageTracker = new StorageTrackerItem(() -> {
+    private StorageTrackerItem storageTracker = new StorageTrackerItem(() -> stack.getTagCompound().setTag(NBT_STORAGE_TRACKER, getStorageTracker().serializeNBT()));
-        stack.getTagCompound().setTag(NBT_STORAGE_TRACKER, getStorageTracker().serializeNBT());
-    });
 
     private List<IFilter> filters = new ArrayList<>();
     private List<IGridTab> tabs = new ArrayList<>();