More sync fixes with regards to prev commit + Fixed the Fluid Grid not having a View type setting

This commit is contained in:
raoulvdberge
2019-11-01 22:55:27 +01:00
parent 3f8556e8b0
commit 3af161c649
4 changed files with 13 additions and 6 deletions

View File

@@ -4,6 +4,7 @@
- Port to Minecraft 1.14 (raoulvdberge) - Port to Minecraft 1.14 (raoulvdberge)
- Removed the Reader and Writer (raoulvdberge) - Removed the Reader and Writer (raoulvdberge)
- Removed covers (raoulvdberge) - Removed covers (raoulvdberge)
- Fixed the Fluid Grid not having a View type setting (raoulvdberge)
- Oredict mode for Patterns has been replaced with "Exact mode" (by default on). When exact mode is off, Refined Storage will use equivalent items or fluids from the Minecraft item/fluid tag system (raoulvdberge) - Oredict mode for Patterns has been replaced with "Exact mode" (by default on). When exact mode is off, Refined Storage will use equivalent items or fluids from the Minecraft item/fluid tag system (raoulvdberge)
- Grid filtering with "$" now does filtering based on item/fluid tag name instead of oredict name (raoulvdberge) - Grid filtering with "$" now does filtering based on item/fluid tag name instead of oredict name (raoulvdberge)
- When binding a network item to a network you can now bind to any network block, not only the Controller (raoulvdberge) - When binding a network item to a network you can now bind to any network block, not only the Controller (raoulvdberge)

View File

@@ -115,7 +115,7 @@ public class GridScreen extends BaseScreen<GridContainer> implements IScreenInfo
addButton(searchField); addButton(searchField);
if (grid.getGridType() != GridType.FLUID && grid.getViewType() != -1) { if (grid.getViewType() != -1) {
addSideButton(new GridViewTypeSideButton(this, grid)); addSideButton(new GridViewTypeSideButton(this, grid));
} }

View File

@@ -1,7 +1,6 @@
package com.raoulvdberge.refinedstorage.screen.grid.filtering; package com.raoulvdberge.refinedstorage.screen.grid.filtering;
import com.raoulvdberge.refinedstorage.screen.grid.stack.IGridStack; import com.raoulvdberge.refinedstorage.screen.grid.stack.IGridStack;
import com.raoulvdberge.refinedstorage.screen.grid.stack.ItemGridStack;
import java.util.function.Predicate; import java.util.function.Predicate;
@@ -14,7 +13,10 @@ public class CraftableGridFilter implements Predicate<IGridStack> {
@Override @Override
public boolean test(IGridStack stack) { public boolean test(IGridStack stack) {
// TODO Make working with fluids. if (craftable) {
return stack instanceof ItemGridStack && stack.isCraftable() == craftable; return stack.isCraftable();
} else {
return !stack.isCraftable() && stack.getOtherId() == null;
}
} }
} }

View File

@@ -58,8 +58,12 @@ public abstract class BaseGridView implements IGridView {
while (it.hasNext()) { while (it.hasNext()) {
IGridStack stack = it.next(); IGridStack stack = it.next();
// TODO Make working with grid sorting mode. // If this is a crafting stack,
if (stack.isCraftable() && // and there is a regular matching stack in the view too,
// and we aren't in "view only craftables" mode,
// we don't want the duplicate stacks and we will remove this stack.
if (screen.getGrid().getViewType() != IGrid.VIEW_TYPE_CRAFTABLES &&
stack.isCraftable() &&
stack.getOtherId() != null && stack.getOtherId() != null &&
map.containsKey(stack.getOtherId())) { map.containsKey(stack.getOtherId())) {
it.remove(); it.remove();