Revert "Fix craftable stack vanishing or duplicating when using craftable view (#2940)"

This reverts commit e10f2593

CHANGELOG.md

@@ -4,7 +4,6 @@
 
 - Removed experimental pipeline nagging message (raoulvdberge)
 - Fixed crash when using an External Storage on a fluid inventory (jeremiahwinsley)
-- Fixed craftable stacks not being visible using the "craftable only" view (BlueAgent)
 - Added some performance improvements for autocrafting (necauqua, Darkere)
 - Fixed a memory leak in the pattern cache (necauqua)
 - Fixed Detector crashing when dyed (Darkere)

src/main/java/com/refinedmods/refinedstorage/screen/grid/view/GridViewImpl.java

@@ -144,7 +144,6 @@ public class GridViewImpl implements IGridView {
         IGridStack existing = map.get(stack.getId());
         boolean stillExists = true;
         boolean shouldSort = screen.canSort();
-        boolean shouldDisplay = getActiveFilters().test(existing);
 
         if (existing == null) {
             stack.setQuantity(delta);
@@ -152,7 +151,7 @@ public class GridViewImpl implements IGridView {
             map.put(stack.getId(), stack);
             existing = stack;
 
-            if (craftingStack != null && shouldSort && shouldDisplay) {
+            if (craftingStack != null && shouldSort) {
                 stacks.remove(craftingStack);
             }
         } else {
@@ -164,7 +163,7 @@ public class GridViewImpl implements IGridView {
                 map.remove(existing.getId());
                 stillExists = false;
 
-                if (craftingStack != null && shouldSort && shouldDisplay && getActiveFilters().test(craftingStack)) {
+                if (craftingStack != null && shouldSort && getActiveFilters().test(craftingStack)) {
                     addStack(craftingStack);
                 }
             }
@@ -173,7 +172,7 @@ public class GridViewImpl implements IGridView {
         }
 
         if (shouldSort) {
-            if (stillExists && shouldDisplay) {
+            if (stillExists && getActiveFilters().test(existing)) {
                 addStack(existing);
             }
             this.screen.updateScrollbar();