From abb909a5ab23ad68385b8b7da880c03448e4ab7d Mon Sep 17 00:00:00 2001 From: raoulvdberge Date: Tue, 29 Oct 2019 16:03:56 +0100 Subject: [PATCH] Replace Exception printStackTrace with logger --- .../apiimpl/autocrafting/CraftingManager.java | 6 +++++- .../craftingmonitor/CraftingMonitorUpdateMessage.java | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/raoulvdberge/refinedstorage/apiimpl/autocrafting/CraftingManager.java b/src/main/java/com/raoulvdberge/refinedstorage/apiimpl/autocrafting/CraftingManager.java index 062731147..5e0af264a 100644 --- a/src/main/java/com/raoulvdberge/refinedstorage/apiimpl/autocrafting/CraftingManager.java +++ b/src/main/java/com/raoulvdberge/refinedstorage/apiimpl/autocrafting/CraftingManager.java @@ -21,6 +21,8 @@ import net.minecraft.util.text.ITextComponent; import net.minecraftforge.common.util.Constants; import net.minecraftforge.fluids.FluidStack; import net.minecraftforge.items.IItemHandlerModifiable; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; import javax.annotation.Nonnull; import javax.annotation.Nullable; @@ -29,6 +31,8 @@ import java.util.*; public class CraftingManager implements ICraftingManager { private static final int THROTTLE_DELAY_MS = 3000; + private static final Logger LOGGER = LogManager.getLogger(CraftingManager.class); + private static final String NBT_TASKS = "Tasks"; private static final String NBT_TASK_TYPE = "Type"; private static final String NBT_TASK_DATA = "Task"; @@ -140,7 +144,7 @@ public class CraftingManager implements ICraftingManager { tasks.put(task.getId(), task); } catch (CraftingTaskReadException e) { - e.printStackTrace(); + LOGGER.error("Could not deserialize crafting task", e); } } } diff --git a/src/main/java/com/raoulvdberge/refinedstorage/network/craftingmonitor/CraftingMonitorUpdateMessage.java b/src/main/java/com/raoulvdberge/refinedstorage/network/craftingmonitor/CraftingMonitorUpdateMessage.java index fae963885..150d29182 100644 --- a/src/main/java/com/raoulvdberge/refinedstorage/network/craftingmonitor/CraftingMonitorUpdateMessage.java +++ b/src/main/java/com/raoulvdberge/refinedstorage/network/craftingmonitor/CraftingMonitorUpdateMessage.java @@ -11,6 +11,8 @@ import com.raoulvdberge.refinedstorage.screen.CraftingMonitorScreen; import com.raoulvdberge.refinedstorage.tile.craftingmonitor.ICraftingMonitor; import net.minecraft.network.PacketBuffer; import net.minecraftforge.fml.network.NetworkEvent; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; import java.util.ArrayList; import java.util.List; @@ -19,6 +21,8 @@ import java.util.function.Function; import java.util.function.Supplier; public class CraftingMonitorUpdateMessage { + private static final Logger LOGGER = LogManager.getLogger(CraftingMonitorUpdateMessage.class); + private ICraftingMonitor craftingMonitor; private List tasks = new ArrayList<>(); @@ -47,7 +51,7 @@ public class CraftingMonitorUpdateMessage { try { requested = API.instance().createCraftingRequestInfo(buf.readCompoundTag()); } catch (CraftingTaskReadException e) { - e.printStackTrace(); + LOGGER.error("Could not create crafting request info", e); } int qty = buf.readInt();