Adressed PR comments

This commit is contained in:
Buuz135
2021-10-17 19:59:59 +02:00
parent 1da6e4d876
commit b6f4aec45c
3 changed files with 7 additions and 5 deletions

View File

@@ -164,8 +164,8 @@ public class CoverManager {
} }
@Nullable @Nullable
public static Block getBlock(@Nullable ItemStack item) { public static Block getBlock(ItemStack item) {
if (item == null) { if (item.isEmpty()) {
return null; return null;
} }
@@ -180,7 +180,7 @@ public class CoverManager {
@Nullable @Nullable
@SuppressWarnings("deprecation") @SuppressWarnings("deprecation")
public static BlockState getBlockState(@Nullable ItemStack item) { public static BlockState getBlockState(ItemStack item) {
Block block = getBlock(item); Block block = getBlock(item);
if (block == null) { if (block == null) {

View File

@@ -111,7 +111,7 @@ public class CubeBuilder {
} }
private BakedQuad bakeFace(Direction facing, Face cubeFace) { private BakedQuad bakeFace(Direction facing, Face cubeFace) {
BakedQuadBuilder builder = new BakedQuadBuilder(cubeFace.sprite); //TODO See if can change the vertex format BakedQuadBuilder builder = new BakedQuadBuilder(cubeFace.sprite);
builder.setQuadOrientation(facing); builder.setQuadOrientation(facing);
builder.setQuadTint(-1); builder.setQuadTint(-1);

View File

@@ -373,7 +373,9 @@ public final class RenderUtils {
} }
if (sprite == null) { if (sprite == null) {
sprite = null; //TODO Get missing sprite for (BakedQuad quad : Minecraft.getInstance().getModelManager().getMissingModel().getQuads(coverState, facing, rand)) {
return quad.getSprite();
}
} }
return sprite; return sprite;