Fixed useless mark dirty calls

This commit is contained in:
raoulvdberge
2017-02-14 21:14:26 +01:00
parent a8a0a1082c
commit be563c5649
4 changed files with 12 additions and 8 deletions

View File

@@ -24,11 +24,9 @@ public abstract class NetworkNode implements INetworkNode, INetworkNeighborhoodA
protected INetworkMaster network; protected INetworkMaster network;
protected INetworkNodeHolder holder; protected INetworkNodeHolder holder;
protected int ticks; protected int ticks;
protected RedstoneMode redstoneMode = RedstoneMode.IGNORE;
private RedstoneMode redstoneMode = RedstoneMode.IGNORE;
private boolean couldUpdate; private boolean couldUpdate;
private boolean active; private boolean active;
public NetworkNode(INetworkNodeHolder holder) { public NetworkNode(INetworkNodeHolder holder) {

View File

@@ -12,7 +12,7 @@ public class NetworkNodeRelay extends NetworkNode {
public NetworkNodeRelay(INetworkNodeHolder holder) { public NetworkNodeRelay(INetworkNodeHolder holder) {
super(holder); super(holder);
setRedstoneMode(RedstoneMode.LOW); this.redstoneMode = RedstoneMode.LOW;
} }
@Override @Override

View File

@@ -67,6 +67,8 @@ public class NetworkNodeSolderer extends NetworkNode {
if (wasWorking != working) { if (wasWorking != working) {
wasWorking = working; wasWorking = working;
markDirty();
RSUtils.updateBlock(holder.world(), holder.pos()); RSUtils.updateBlock(holder.world(), holder.pos());
} }
@@ -110,9 +112,9 @@ public class NetworkNodeSolderer extends NetworkNode {
recipe = null; recipe = null;
progress = 0; progress = 0;
// Don't set working to false yet, wait till the next update because we may have another stack waiting. // Don't set working to false yet, wait till the next update because we may have another stack waiting.
markDirty();
} }
markDirty();
} }
} }
} }
@@ -130,8 +132,6 @@ public class NetworkNodeSolderer extends NetworkNode {
progress = 0; progress = 0;
working = false; working = false;
recipe = null; recipe = null;
markDirty();
} }
@Override @Override

View File

@@ -8,6 +8,7 @@ import com.raoulvdberge.refinedstorage.inventory.ItemHandlerListenerNetworkNode;
import com.raoulvdberge.refinedstorage.tile.TileStorageMonitor; import com.raoulvdberge.refinedstorage.tile.TileStorageMonitor;
import com.raoulvdberge.refinedstorage.tile.config.IComparable; import com.raoulvdberge.refinedstorage.tile.config.IComparable;
import com.raoulvdberge.refinedstorage.tile.config.IType; import com.raoulvdberge.refinedstorage.tile.config.IType;
import com.raoulvdberge.refinedstorage.tile.config.RedstoneMode;
import net.minecraft.item.ItemStack; import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound; import net.minecraft.nbt.NBTTagCompound;
import net.minecraftforge.fluids.FluidStack; import net.minecraftforge.fluids.FluidStack;
@@ -179,4 +180,9 @@ public class NetworkNodeStorageMonitor extends NetworkNode implements IComparabl
public boolean hasConnectivityState() { public boolean hasConnectivityState() {
return true; return true;
} }
@Override
public void setRedstoneMode(RedstoneMode mode) {
// NO OP
}
} }