From d4994193b0b99548d9bb4b1134a7d11b5ad9cbfd Mon Sep 17 00:00:00 2001 From: Darkere Date: Sun, 7 Jun 2020 12:16:10 +0200 Subject: [PATCH] fix constructor extracting 2B from network upon placing fixes #2523 (#2549) * fix constructor extracting 2B from network upon placing fixes #2523 * turns out it does check for air now --- .../apiimpl/network/node/ConstructorNetworkNode.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/refinedmods/refinedstorage/apiimpl/network/node/ConstructorNetworkNode.java b/src/main/java/com/refinedmods/refinedstorage/apiimpl/network/node/ConstructorNetworkNode.java index bfbd10de7..15604860d 100644 --- a/src/main/java/com/refinedmods/refinedstorage/apiimpl/network/node/ConstructorNetworkNode.java +++ b/src/main/java/com/refinedmods/refinedstorage/apiimpl/network/node/ConstructorNetworkNode.java @@ -102,9 +102,8 @@ public class ConstructorNetworkNode extends NetworkNode implements IComparable, if (upgrades.hasUpgrade(UpgradeItem.Type.CRAFTING)) { network.getCraftingManager().request(this, stack, FluidAttributes.BUCKET_VOLUME); } - } else if (world.isAirBlock(front) && FluidUtil.tryPlaceFluid(WorldUtils.getFakePlayer((ServerWorld) world, getOwner()), world, Hand.MAIN_HAND, front, new NetworkFluidHandler(StackUtils.copy(stack, FluidAttributes.BUCKET_VOLUME)), stack)) { - // We manually have to check world.isAirBlock in the else if statement because tryPlaceFluid ignores this. - network.extractFluid(stack, FluidAttributes.BUCKET_VOLUME, Action.PERFORM); + } else { + FluidUtil.tryPlaceFluid(WorldUtils.getFakePlayer((ServerWorld) world, getOwner()), world, Hand.MAIN_HAND, front, new NetworkFluidHandler(StackUtils.copy(stack, FluidAttributes.BUCKET_VOLUME)), stack); } }