dave/smsgw-tester
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix issue with application crashing on long sms without long sms processing enabled

Browse Source
This commit is contained in:
David Majdandžić
2023-04-06 20:14:47 +02:00
parent 12dd92e980
commit 5576de3f71
2 changed files with 29 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/PDUProcessor/Preprocessor/Client/LongSmsProcessor.ts
View File

@@ -6,6 +6,7 @@ const smpp = require('smpp');
export default class LongSmsProcessor extends Preprocessor {
private iterator: number = 0;
static readonly maxMessageSizeBits = 1072;
constructor(type: string) {
// An sms can have a maximum length (short_message) of 1120 bits or 140 bytes.
@@ -31,25 +32,12 @@ export default class LongSmsProcessor extends Preprocessor {
processPdu(session: any, pdu: PDU, entity?: SmppSession | undefined): Promise<any> {
return new Promise<any>((resolve, reject) => {
if (!!pdu.short_message) {
let encoding: number | undefined = pdu.data_coding;
if (!encoding) {
encoding = 0;
}
let characterSizeBits: number = 0;
switch (encoding) {
case 0:
case 1:
characterSizeBits = 8;
break;
case 8:
characterSizeBits = 16;
break;
}
let characterSizeBits: number = LongSmsProcessor.getCharacterSizeForEncoding(pdu);
let maxMessageLength: number = LongSmsProcessor.maxMessageSizeBits / characterSizeBits;
if (characterSizeBits) {
let splitMessage: string[] = [];
let message: string = pdu.short_message;
let messageLength: number = message.length;
let maxMessageLength: number = 1072 / characterSizeBits;
let messageCount: number = Math.ceil(messageLength / maxMessageLength);
for (let i = 0; i < messageCount; i++) {
splitMessage.push(message.substr(i * maxMessageLength, maxMessageLength));
@@ -77,4 +65,22 @@ export default class LongSmsProcessor extends Preprocessor {
}
});
}
static getCharacterSizeForEncoding(pdu: PDU) {
let encoding: number | undefined = pdu.data_coding;
if (!encoding) {
encoding = 0;
}
let characterSizeBits: number = 0;
switch (encoding) {
case 0:
case 1:
characterSizeBits = 8;
break;
case 8:
characterSizeBits = 16;
break;
}
return characterSizeBits;
}
}