Fix issue with defaulting to reading from file while providing other args

To fix issue where folders were being linked as files

.gitignore

@@ -1,2 +1,3 @@
-
+*.exe
-main.exe
+*.exe
+cln

README.md

@@ -0,0 +1,35 @@
+# synclib
+
+A small Go tool for creating symbolic links
+
+Created out of infuriating difficulty of creating symbolic links on windows
+
+## Custom syntax
+
+The tool works with "instructions" that describe symbolic links
+
+They are, in any form, \<source>,\<destination>,\<force?>
+
+For example:
+`sync this,that`
+
+It supports input of these instructions through:
+
+- Stdin
+	- `echo "this,that" | sync`
+- Run arguments
+	- `sync this,that foo,bar "foo 2","C:/bar"`
+- Files
+	- `sync -f <file>`
+	- Where the file contains instructions, one instruction per line
+- Directories
+	- `sync -r <directory>`
+	- This mode will look for "sync" files recursively in directories and run their instructions
+
+## Use case
+
+I have a lot of folders (documents, projects, configurations) backed up via Seafile and to have the software using those folders find them at their usual location I'm creating soft symbolic links from the seafile drive to their original location
+
+It would be problematic to have to redo all (or some part) of these symlinks when reinstalling the OS or having something somewhere explode (say software uninstalled) so I have all the instructions in sync files in individual folders in the seafile drive
+
+Which means I can easily back up my configuration and `sync -r ~/Seafile` to symlink it where it belongs

colors.go

@@ -0,0 +1,99 @@
+package main
+
+import (
+	"fmt"
+	"math/rand/v2"
+)
+
+const (
+	// Reset
+	Reset = "\033[0m" // Text Reset
+
+	// Regular Colors
+	Black  = "\033[0;30m" // Black
+	Red    = "\033[0;31m" // Red
+	Green  = "\033[0;32m" // Green
+	Yellow = "\033[0;33m" // Yellow
+	Blue   = "\033[0;34m" // Blue
+	Purple = "\033[0;35m" // Purple
+	Cyan   = "\033[0;36m" // Cyan
+	White  = "\033[0;37m" // White
+
+	// Bold
+	BBlack  = "\033[1;30m" // Black
+	BRed    = "\033[1;31m" // Red
+	BGreen  = "\033[1;32m" // Green
+	BYellow = "\033[1;33m" // Yellow
+	BBlue   = "\033[1;34m" // Blue
+	BPurple = "\033[1;35m" // Purple
+	BCyan   = "\033[1;36m" // Cyan
+	BWhite  = "\033[1;37m" // White
+
+	// Underline
+	UBlack  = "\033[4;30m" // Black
+	URed    = "\033[4;31m" // Red
+	UGreen  = "\033[4;32m" // Green
+	UYellow = "\033[4;33m" // Yellow
+	UBlue   = "\033[4;34m" // Blue
+	UPurple = "\033[4;35m" // Purple
+	UCyan   = "\033[4;36m" // Cyan
+	UWhite  = "\033[4;37m" // White
+
+	// Background
+	On_Black  = "\033[40m" // Black
+	On_Red    = "\033[41m" // Red
+	On_Green  = "\033[42m" // Green
+	On_Yellow = "\033[43m" // Yellow
+	On_Blue   = "\033[44m" // Blue
+	On_Purple = "\033[45m" // Purple
+	On_Cyan   = "\033[46m" // Cyan
+	On_White  = "\033[47m" // White
+
+	// High Intensty
+	IBlack  = "\033[0;90m" // Black
+	IRed    = "\033[0;91m" // Red
+	IGreen  = "\033[0;92m" // Green
+	IYellow = "\033[0;93m" // Yellow
+	IBlue   = "\033[0;94m" // Blue
+	IPurple = "\033[0;95m" // Purple
+	ICyan   = "\033[0;96m" // Cyan
+	IWhite  = "\033[0;97m" // White
+
+	// Bold High Intensty
+	BIBlack  = "\033[1;90m" // Black
+	BIRed    = "\033[1;91m" // Red
+	BIGreen  = "\033[1;92m" // Green
+	BIYellow = "\033[1;93m" // Yellow
+	BIBlue   = "\033[1;94m" // Blue
+	BIPurple = "\033[1;95m" // Purple
+	BICyan   = "\033[1;96m" // Cyan
+	BIWhite  = "\033[1;97m" // White
+
+	// High Intensty backgrounds
+	On_IBlack  = "\033[0;100m" // Black
+	On_IRed    = "\033[0;101m" // Red
+	On_IGreen  = "\033[0;102m" // Green
+	On_IYellow = "\033[0;103m" // Yellow
+	On_IBlue   = "\033[0;104m" // Blue
+	On_IPurple = "\033[10;95m" // Purple
+	On_ICyan   = "\033[0;106m" // Cyan
+	On_IWhite  = "\033[0;107m" // White
+)
+
+// The acceptable range is [16, 231] but here we remove some very dark colors
+// That make text unreadable on a dark terminal
+// See https://www.hackitu.de/termcolor256/
+var colors = []int{22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 57, 62, 63, 64, 65, 67, 68, 69, 70, 71, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 148, 149, 150, 151, 152, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 184, 185, 186, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 226, 227, 228, 229, 230}
+var colorsIndex int = -1
+var shuffled bool
+
+func GenerateRandomAnsiColor() string {
+	if !shuffled {
+		rand.Shuffle(len(colors), func(i int, j int) {
+			colors[i], colors[j] = colors[j], colors[i]
+		})
+		shuffled = true
+	}
+	colorsIndex++
+	return fmt.Sprintf("\033[1;4;38;5;%dm", colors[colorsIndex%len(colors)])
+}

deploy.sh

@@ -1 +1,2 @@
-go build main && cp main.exe "/c/Program Files/Git/usr/bin/cln.exe"
+GOOS=windows GOARCH=amd64 go build -o main.exe main && cp main.exe "/c/Program Files/Git/usr/bin/cln.exe"
+GOOS=linux GOARCH=amd64 go build -o main_linux main

go.mod

@@ -1,3 +1,3 @@
-module main
+module cln
 
 go 1.21.7

instruction.go

@@ -1,132 +1,154 @@
-package main
+package main
-
+
-import (
+import (
-	"fmt"
+	"fmt"
-	"log"
+	"log"
-	"os"
+	"os"
-	"regexp"
+	"path/filepath"
-	"strconv"
+	"regexp"
-	"strings"
+	"strconv"
-)
+	"strings"
-
+)
-type LinkInstruction struct {
+
-	Source string
+type LinkInstruction struct {
-	Target string
+	Source string
-	Force  bool
+	Target string
-}
+	Force  bool
-
+	Hard   bool
-func (instruction *LinkInstruction) String() string {
+	Delete bool
-	return fmt.Sprintf("%s%s%s%s%s%s%s%s%s", SourceColor, instruction.Source, DefaultColor, deliminer, TargetColor, instruction.Target, DefaultColor, deliminer, strconv.FormatBool(instruction.Force))
+}
-}
+
-
+func (instruction *LinkInstruction) Tidy() {
-func ParseInstruction(line string) (LinkInstruction, error) {
+	instruction.Source = strings.ReplaceAll(instruction.Source, "\"", "")
-	parts := strings.Split(line, deliminer)
+	instruction.Source = strings.ReplaceAll(instruction.Source, "\\", "/")
-	instruction := LinkInstruction{}
+	instruction.Source = strings.TrimSpace(instruction.Source)
-
+
-	if len(parts) < 2 {
+	instruction.Target = strings.ReplaceAll(instruction.Target, "\"", "")
-		return instruction, fmt.Errorf("invalid format - not enough parameters (must have at least source and target)")
+	instruction.Target = strings.ReplaceAll(instruction.Target, "\\", "/")
-	}
+	instruction.Target = strings.TrimSpace(instruction.Target)
-
+}
-	instruction.Source = parts[0]
+
-	instruction.Target = parts[1]
+func (instruction *LinkInstruction) String() string {
-	instruction.Force = false
+	return fmt.Sprintf("%s%s%s%s%s%s%s%s%s%s%s%s%s", SourceColor, instruction.Source, DefaultColor, deliminer, TargetColor, instruction.Target, DefaultColor, deliminer, strconv.FormatBool(instruction.Force), deliminer, strconv.FormatBool(instruction.Hard), deliminer, strconv.FormatBool(instruction.Delete))
-	if len(parts) > 2 {
+}
-		res, _ := regexp.MatchString("^(?i)T|TRUE$", parts[2])
+
-		instruction.Force = res
+func ParseInstruction(line, workdir string) (LinkInstruction, error) {
-	}
+	line = strings.TrimSpace(line)
-
+	parts := strings.Split(line, deliminer)
-	instruction.Source, _ = ConvertHome(instruction.Source)
+	instruction := LinkInstruction{}
-	instruction.Target, _ = ConvertHome(instruction.Target)
+
-
+	if len(parts) < 2 {
-	instruction.Source = NormalizePath(instruction.Source)
+		return instruction, fmt.Errorf("invalid format - not enough parameters (must have at least source and target)")
-	instruction.Target = NormalizePath(instruction.Target)
+	}
-
+
-	return instruction, nil
+	instruction.Source = strings.TrimSpace(parts[0])
-}
+	instruction.Target = strings.TrimSpace(parts[1])
-
+	instruction.Force = false
-func (instruction *LinkInstruction) RunSync() error {
+	if len(parts) > 2 {
-	if !FileExists(instruction.Source) {
+		res, _ := regexp.MatchString(`^(?i)\s*T|TRUE\s*$`, parts[2])
-		return fmt.Errorf("instruction source %s%s%s does not exist", SourceColor, instruction.Source, DefaultColor)
+		instruction.Force = res
-	}
+	}
-
+	if len(parts) > 3 {
-	if AreSame(instruction.Source, instruction.Target) {
+		res, _ := regexp.MatchString(`^(?i)\s*T|TRUE\s*$`, parts[3])
-		log.Printf("Source %s%s%s and target %s%s%s are the same, %snothing to do...%s", SourceColor, instruction.Source, DefaultColor, TargetColor, instruction.Target, DefaultColor, PathColor, DefaultColor)
+		instruction.Hard = res
-		return nil
+	}
-	}
+	if len(parts) > 4 {
-
+		res, _ := regexp.MatchString(`^(?i)\s*T|TRUE\s*$`, parts[4])
-	if FileExists(instruction.Target) {
+		instruction.Delete = res
-		if instruction.Force {
+		instruction.Force = res
-			isSymlink, err := IsSymlink(instruction.Target)
+	}
-			if err != nil {
+
-				return fmt.Errorf("could not determine whether %s%s%s is a sym link or not, stopping; err: %s%+v%s", TargetColor, instruction.Target, DefaultColor, ErrorColor, err, DefaultColor)
+	instruction.Tidy()
-			}
+	instruction.Source, _ = ConvertHome(instruction.Source)
-
+	instruction.Target, _ = ConvertHome(instruction.Target)
-			if isSymlink {
+
-				log.Printf("Removing symlink at %s%s%s", TargetColor, instruction.Target, DefaultColor)
+	instruction.Source = NormalizePath(instruction.Source, workdir)
-				err = os.Remove(instruction.Target)
+	instruction.Target = NormalizePath(instruction.Target, workdir)
-				if err != nil {
+
-					return fmt.Errorf("failed deleting %s%s%s due to %s%+v%s", TargetColor, instruction.Target, DefaultColor, ErrorColor, err, DefaultColor)
+	return instruction, nil
-				}
+}
-			} else {
+
-				return fmt.Errorf("refusing to delte actual (non symlink) file %s%s%s", TargetColor, instruction.Target, DefaultColor)
+func (instruction *LinkInstruction) RunAsync(status chan (error)) {
-			}
+	defer close(status)
-		} else {
+	if !FileExists(instruction.Source) {
-			return fmt.Errorf("target %s%s%s exists - handle manually or set the 'forced' flag (3rd field)", TargetColor, instruction.Target, DefaultColor)
+		status <- fmt.Errorf("instruction source %s%s%s does not exist", SourceColor, instruction.Source, DefaultColor)
-		}
+		return
-	}
+	}
-
+
-	err := os.Symlink(instruction.Source, instruction.Target)
+	if !instruction.Force && AreSame(instruction.Source, instruction.Target) {
-	if err != nil {
+		status <- fmt.Errorf("source %s%s%s and target %s%s%s are the same, %snothing to do...%s", SourceColor, instruction.Source, DefaultColor, TargetColor, instruction.Target, DefaultColor, PathColor, DefaultColor)
-		return fmt.Errorf("failed creating symlink between %s%s%s and %s%s%s with error %s%+v%s", SourceColor, instruction.Source, DefaultColor, TargetColor, instruction.Target, DefaultColor, ErrorColor, err, DefaultColor)
+		return
-	}
+	}
-	log.Printf("Created symlink between %s%s%s and %s%s%s", SourceColor, instruction.Source, DefaultColor, TargetColor, instruction.Target, DefaultColor)
+
-
+	if FileExists(instruction.Target) {
-	return nil
+		if instruction.Force {
-}
+			isSymlink, err := IsSymlink(instruction.Target)
-
+			if err != nil {
-func (instruction *LinkInstruction) RunAsync(status chan (error)) {
+				status <- fmt.Errorf("could not determine whether %s%s%s is a sym link or not, stopping; err: %s%+v%s", TargetColor, instruction.Target, DefaultColor, ErrorColor, err, DefaultColor)
-	defer close(status)
+				return
-	if !FileExists(instruction.Source) {
+			}
-		status <- fmt.Errorf("instruction source %s%s%s does not exist", SourceColor, instruction.Source, DefaultColor)
+
-		return
+			if instruction.Hard {
-	}
+				info, err := os.Stat(instruction.Target)
-
+				if err != nil {
-	if AreSame(instruction.Source, instruction.Target) {
+					status <- fmt.Errorf("could not stat %s%s%s, stopping; err: %s%+v%s", TargetColor, instruction.Target, DefaultColor, ErrorColor, err, DefaultColor)
-		status <- fmt.Errorf("source %s%s%s and target %s%s%s are the same, %snothing to do...%s", SourceColor, instruction.Source, DefaultColor, TargetColor, instruction.Target, DefaultColor, PathColor, DefaultColor)
+					return
-		return
+				}
-	}
+				if info.Mode().IsRegular() && info.Name() == filepath.Base(instruction.Source) {
-
+					log.Printf("Overwriting existing file %s%s%s", TargetColor, instruction.Target, DefaultColor)
-	if FileExists(instruction.Target) {
+					err := os.Remove(instruction.Target)
-		if instruction.Force {
+					if err != nil {
-			isSymlink, err := IsSymlink(instruction.Target)
+						status <- fmt.Errorf("could not remove existing file %s%s%s; err: %s%+v%s", TargetColor, instruction.Target, DefaultColor, ErrorColor, err, DefaultColor)
-			if err != nil {
+						return
-				status <- fmt.Errorf("could not determine whether %s%s%s is a sym link or not, stopping; err: %s%+v%s", TargetColor, instruction.Target, DefaultColor, ErrorColor, err, DefaultColor)
+					}
-				return
+				}
-			}
+			}
-
+
-			if isSymlink {
+			if isSymlink {
-				log.Printf("Removing symlink at %s%s%s", TargetColor, instruction.Target, DefaultColor)
+				log.Printf("Removing symlink at %s%s%s", TargetColor, instruction.Target, DefaultColor)
-				err = os.Remove(instruction.Target)
+				err = os.Remove(instruction.Target)
-				if err != nil {
+				if err != nil {
-					status <- fmt.Errorf("failed deleting %s%s%s due to %s%+v%s", TargetColor, instruction.Target, DefaultColor, ErrorColor, err, DefaultColor)
+					status <- fmt.Errorf("failed deleting %s%s%s due to %s%+v%s", TargetColor, instruction.Target, DefaultColor, ErrorColor, err, DefaultColor)
-					return
+					return
-				}
+				}
-			} else {
+			} else {
-				status <- fmt.Errorf("refusing to delte actual (non symlink) file %s%s%s", TargetColor, instruction.Target, DefaultColor)
+				if !instruction.Delete {
-				return
+					status <- fmt.Errorf("refusing to delte actual (non symlink) file %s%s%s", TargetColor, instruction.Target, DefaultColor)
-			}
+					return
-		} else {
+				}
-			status <- fmt.Errorf("target %s%s%s exists - handle manually or set the 'forced' flag (3rd field)", TargetColor, instruction.Target, DefaultColor)
+				log.Printf("%sDeleting (!!!)%s %s%s%s", ImportantColor, DefaultColor, TargetColor, instruction.Target, DefaultColor)
-			return
+				err = os.RemoveAll(instruction.Target)
-		}
+				if err != nil {
-	}
+					status <- fmt.Errorf("failed deleting %s%s%s due to %s%+v%s", TargetColor, instruction.Target, DefaultColor, ErrorColor, err, DefaultColor)
-
+					return
-	err := os.Symlink(instruction.Source, instruction.Target)
+				}
-	if err != nil {
+			}
-		status <- fmt.Errorf("failed creating symlink between %s%s%s and %s%s%s with error %s%+v%s", SourceColor, instruction.Source, DefaultColor, TargetColor, instruction.Target, DefaultColor, ErrorColor, err, DefaultColor)
+		} else {
-		return
+			status <- fmt.Errorf("target %s%s%s exists - handle manually or set the 'forced' flag (3rd field)", TargetColor, instruction.Target, DefaultColor)
-	}
+			return
-	log.Printf("Created symlink between %s%s%s and %s%s%s", SourceColor, instruction.Source, DefaultColor, TargetColor, instruction.Target, DefaultColor)
+		}
-
+	}
-	status <- nil
+
-}
+	targetDir := filepath.Dir(instruction.Target)
+	if _, err := os.Stat(targetDir); os.IsNotExist(err) {
+		err = os.MkdirAll(targetDir, 0755)
+		if err != nil {
+			status <- fmt.Errorf("failed creating directory %s%s%s due to %s%+v%s", TargetColor, targetDir, DefaultColor, ErrorColor, err, DefaultColor)
+			return
+		}
+	}
+
+	var err error
+	if instruction.Hard {
+		err = os.Link(instruction.Source, instruction.Target)
+	} else {
+		err = os.Symlink(instruction.Source, instruction.Target)
+	}
+	if err != nil {
+		status <- fmt.Errorf("failed creating symlink between %s%s%s and %s%s%s with error %s%+v%s", SourceColor, instruction.Source, DefaultColor, TargetColor, instruction.Target, DefaultColor, ErrorColor, err, DefaultColor)
+		return
+	}
+	log.Printf("Created symlink between %s%s%s and %s%s%s", SourceColor, instruction.Source, DefaultColor, TargetColor, instruction.Target, DefaultColor)
+
+	status <- nil
+}

main.go

@@ -1,238 +1,252 @@
-package main
+package main
-
+
-import (
+import (
-	"bufio"
+	"bufio"
-	"flag"
+	"flag"
-	"io"
+	"io"
-	"log"
+	"log"
-	"os"
+	"os"
-	"regexp"
+	"path/filepath"
-	"sync"
+	"regexp"
-	"sync/atomic"
+	"sync"
-)
+	"sync/atomic"
-
+)
-const deliminer = ","
+
-const (
+const deliminer = ","
-	Black   = "\033[30m"
+const SourceColor = Purple
-	Red     = "\033[31m"
+const TargetColor = Yellow
-	Green   = "\033[32m"
+const ErrorColor = URed
-	Yellow  = "\033[33m"
+const ImportantColor = BRed
-	Blue    = "\033[34m"
+const DefaultColor = White
-	Magenta = "\033[35m"
+const PathColor = Green
-	Cyan    = "\033[36m"
+
-	White   = "\033[37m"
+var DirRegex, _ = regexp.Compile(`^(.+?)[/\\]sync$`)
-)
+var FileRegex, _ = regexp.Compile(`^sync$`)
-const SourceColor = Magenta
+var programName = os.Args[0]
-const TargetColor = Yellow
+
-const ErrorColor = Red
+func main() {
-const DefaultColor = White
+	recurse := flag.String("r", "", "recurse into directories")
-const PathColor = Green
+	file := flag.String("f", "", "file to read instructions from")
-
+	debug := flag.Bool("d", false, "debug")
-var DirRegex, _ = regexp.Compile(`^(.+?)[/\\]sync$`)
+	flag.Parse()
-var FileRegex, _ = regexp.Compile(`^sync$`)
+
-var programName = os.Args[0]
+	if *debug {
-
+		log.SetFlags(log.Lmicroseconds | log.Lshortfile)
-func main() {
+		logFile, err := os.Create("main.log")
-	recurse := flag.String("r", "", "recurse into directories")
+		if err != nil {
-	file := flag.String("f", "", "file to read instructions from")
+			log.Printf("Error creating log file: %v", err)
-	debug := flag.Bool("d", false, "debug")
+			os.Exit(1)
-	flag.Parse()
+		}
-
+		logger := io.MultiWriter(os.Stdout, logFile)
-	if *debug {
+		log.SetOutput(logger)
-		log.SetFlags(log.Lmicroseconds | log.Lshortfile)
+	} else {
-		logFile, err := os.Create("main.log")
+		log.SetFlags(log.Lmicroseconds)
-		if err != nil {
+	}
-			log.Printf("Error creating log file: %v", err)
+
-			os.Exit(1)
+	instructions := make(chan *LinkInstruction, 1000)
-		}
+	status := make(chan error)
-		logger := io.MultiWriter(os.Stdout, logFile)
+
-		log.SetOutput(logger)
+	// Check input sources in priority order
-	} else {
+	switch {
-		log.SetFlags(log.Lmicroseconds)
+	case *recurse != "":
-	}
+		log.Printf("Recurse: %s", *recurse)
-
+		go ReadFromFilesRecursively(*recurse, instructions, status)
-	log.Printf("Recurse: %s", *recurse)
+	
-	log.Printf("File: %s", *file)
+	case *file != "":
-
+		log.Printf("File: %s", *file)
-	instructions := make(chan LinkInstruction, 1000)
+		go ReadFromFile(*file, instructions, status, true)
-	status := make(chan error)
+	
-	if *recurse != "" {
+	case len(flag.Args()) > 0:
-		go ReadFromFilesRecursively(*recurse, instructions, status)
+		log.Printf("Reading from command line arguments")
-	} else if *file != "" {
+		go ReadFromArgs(instructions, status)
-		go ReadFromFile(*file, instructions, status, true)
+	
-	} else if len(os.Args) > 1 {
+	case IsPipeInput():
-		go ReadFromArgs(instructions, status)
+		log.Printf("Reading from stdin pipe")
-	} else {
+		go ReadFromStdin(instructions, status)
-		go ReadFromStdin(instructions, status)
+	
-	}
+	default:
-
+		if _, err := os.Stat("sync"); err == nil {
-	go func() {
+			log.Printf("Using default sync file")
-		for {
+			go ReadFromFile("sync", instructions, status, true)
-			err, ok := <-status
+		} else {
-			if !ok {
+			log.Printf("No input provided")
-				break
+			log.Printf("Provide input as: ")
-			}
+			log.Printf("Arguments - %s <source>,<target>,<force?>", programName)
-			if err != nil {
+			log.Printf("File - %s -f <file>", programName)
-				log.Println(err)
+			log.Printf("Folder (finding sync files in folder recursively) - %s -r <folder>", programName)
-			}
+			log.Printf("stdin - (cat <file> | %s)", programName)
-		}
+			os.Exit(1)
-	}()
+		}
-
+	}
-	var instructionsDone int32
+
-	var wg sync.WaitGroup
+	go func() {
-	for {
+		for {
-		instruction, ok := <-instructions
+			err, ok := <-status
-		if !ok {
+			if !ok {
-			log.Printf("No more instructions to process")
+				break
-			break
+			}
-		}
+			if err != nil {
-		log.Printf("Processing: %s", instruction.String())
+				log.Println(err)
-		status := make(chan error)
+			}
-		go instruction.RunAsync(status)
+		}
-		wg.Add(1)
+	}()
-		err := <-status
+
-		if err != nil {
+	var instructionsDone int32
-			log.Printf("Failed parsing instruction %s%s%s due to %s%+v%s", SourceColor, instruction.String(), DefaultColor, ErrorColor, err, DefaultColor)
+	var wg sync.WaitGroup
-		}
+	for {
-		atomic.AddInt32(&instructionsDone, 1)
+		instruction, ok := <-instructions
-		wg.Done()
+		if !ok {
-	}
+			log.Printf("No more instructions to process")
-	wg.Wait()
+			break
-	log.Println("All done")
+		}
-	if instructionsDone == 0 {
+		log.Printf("Processing: %s", instruction.String())
-		log.Printf("No input provided")
+		status := make(chan error)
-		log.Printf("Provide input as: ")
+		go instruction.RunAsync(status)
-		log.Printf("Arguments - %s <source>,<target>,<force?>", programName)
+		wg.Add(1)
-		log.Printf("File - %s -f <file>", programName)
+		err := <-status
-		log.Printf("Folder (finding sync files in folder recursively) - %s -r <folder>", programName)
+		if err != nil {
-		log.Printf("stdin - (cat <file> | %s)", programName)
+			log.Printf("Failed parsing instruction %s%s%s due to %s%+v%s", SourceColor, instruction.String(), DefaultColor, ErrorColor, err, DefaultColor)
-		os.Exit(1)
+		}
-	}
+		atomic.AddInt32(&instructionsDone, 1)
-}
+		wg.Done()
-
+	}
-func ReadFromFilesRecursively(input string, output chan LinkInstruction, status chan error) {
+	wg.Wait()
-	defer close(output)
+	log.Println("All done")
-	defer close(status)
+	if instructionsDone == 0 {
-
+		log.Printf("No instructions were processed")
-	input = NormalizePath(input)
+		os.Exit(1)
-	log.Printf("Reading input from files recursively starting in %s%s%s", PathColor, input, DefaultColor)
+	}
-
+}
-	files := make(chan string, 128)
+
-	recurseStatus := make(chan error)
+func IsPipeInput() bool {
-	go GetSyncFilesRecursively(input, files, recurseStatus)
+	info, err := os.Stdin.Stat()
-	go func() {
+	if err != nil {
-		for {
+		return false
-			err, ok := <-recurseStatus
+	}
-			if !ok {
+	return info.Mode()&os.ModeNamedPipe != 0
-				break
+}
-			}
+
-			if err != nil {
+func ReadFromFilesRecursively(input string, output chan *LinkInstruction, status chan error) {
-				log.Printf("Failed to get sync files recursively: %s%+v%s", ErrorColor, err, DefaultColor)
+	defer close(output)
-				status <- err
+	defer close(status)
-			}
+
-		}
+	workdir, _ := os.Getwd()
-	}()
+	input = NormalizePath(input, workdir)
-
+	log.Printf("Reading input from files recursively starting in %s%s%s", PathColor, input, DefaultColor)
-	var wg sync.WaitGroup
+
-	for {
+	files := make(chan string, 128)
-		file, ok := <-files
+	recurseStatus := make(chan error)
-		if !ok {
+	go GetSyncFilesRecursively(input, files, recurseStatus)
-			log.Printf("No more files to process")
+	go func() {
-			break
+		for {
-		}
+			err, ok := <-recurseStatus
-		wg.Add(1)
+			if !ok {
-		go func() {
+				break
-			defer wg.Done()
+			}
-			log.Println(file)
+			if err != nil {
-			file = NormalizePath(file)
+				log.Printf("Failed to get sync files recursively: %s%+v%s", ErrorColor, err, DefaultColor)
-			log.Printf("Processing file: %s%s%s", PathColor, file, DefaultColor)
+				status <- err
-
+			}
-			// This "has" to be done because instructions are resolved in relation to cwd
+		}
-			fileDir := DirRegex.FindStringSubmatch(file)
+	}()
-			if fileDir == nil {
+
-				log.Printf("Failed to extract directory from %s%s%s", SourceColor, file, DefaultColor)
+	var wg sync.WaitGroup
-				return
+	for {
-			}
+		file, ok := <-files
-			log.Printf("Changing directory to %s%s%s (for %s%s%s)", PathColor, fileDir[1], DefaultColor, PathColor, file, DefaultColor)
+		if !ok {
-			err := os.Chdir(fileDir[1])
+			log.Printf("No more files to process")
-			if err != nil {
+			break
-				log.Printf("Failed to change directory to %s%s%s: %s%+v%s", SourceColor, fileDir[1], DefaultColor, ErrorColor, err, DefaultColor)
+		}
-				return
+		wg.Add(1)
-			}
+		go func() {
-
+			defer wg.Done()
-			ReadFromFile(file, output, status, false)
+			log.Println(file)
-		}()
+			file = NormalizePath(file, workdir)
-	}
+			log.Printf("Processing file: %s%s%s", PathColor, file, DefaultColor)
-	wg.Wait()
+
-}
+			// This "has" to be done because instructions are resolved in relation to cwd
-func ReadFromFile(input string, output chan LinkInstruction, status chan error, doclose bool) {
+			fileDir := DirRegex.FindStringSubmatch(file)
-	if doclose {
+			if fileDir == nil {
-		defer close(output)
+				log.Printf("Failed to extract directory from %s%s%s", SourceColor, file, DefaultColor)
-		defer close(status)
+				return
-	}
+			}
-
+			log.Printf("Changing directory to %s%s%s (for %s%s%s)", PathColor, fileDir[1], DefaultColor, PathColor, file, DefaultColor)
-	input = NormalizePath(input)
+			err := os.Chdir(fileDir[1])
-	log.Printf("Reading input from file: %s%s%s", PathColor, input, DefaultColor)
+			if err != nil {
-	file, err := os.Open(input)
+				log.Printf("Failed to change directory to %s%s%s: %s%+v%s", SourceColor, fileDir[1], DefaultColor, ErrorColor, err, DefaultColor)
-	if err != nil {
+				return
-		log.Fatalf("Failed to open file %s%s%s: %s%+v%s", SourceColor, input, DefaultColor, ErrorColor, err, DefaultColor)
+			}
-		return
+
-	}
+			ReadFromFile(file, output, status, false)
-	defer file.Close()
+		}()
-
+	}
-	scanner := bufio.NewScanner(file)
+	wg.Wait()
-	for scanner.Scan() {
+}
-		line := scanner.Text()
+
-		instruction, err := ParseInstruction(line)
+func ReadFromFile(input string, output chan *LinkInstruction, status chan error, doclose bool) {
-		if err != nil {
+	if doclose {
-			log.Printf("Error parsing line: %s'%s'%s, error: %s%+v%s", SourceColor, line, DefaultColor, ErrorColor, err, DefaultColor)
+		defer close(output)
-			continue
+		defer close(status)
-		}
+	}
-		log.Printf("Read instruction: %s", instruction.String())
+
-		output <- instruction
+	input = NormalizePath(input, filepath.Dir(input))
-	}
+	log.Printf("Reading input from file: %s%s%s", PathColor, input, DefaultColor)
-}
+	file, err := os.Open(input)
-func ReadFromArgs(output chan LinkInstruction, status chan error) {
+	if err != nil {
-	defer close(output)
+		log.Fatalf("Failed to open file %s%s%s: %s%+v%s", SourceColor, input, DefaultColor, ErrorColor, err, DefaultColor)
-	defer close(status)
+		return
-
+	}
-	log.Printf("Reading input from args")
+	defer file.Close()
-	for _, arg := range os.Args[1:] {
+
-		instruction, err := ParseInstruction(arg)
+	scanner := bufio.NewScanner(file)
-		if err != nil {
+	for scanner.Scan() {
-			log.Printf("Error parsing arg: %s'%s'%s, error: %s%+v%s", SourceColor, arg, DefaultColor, ErrorColor, err, DefaultColor)
+		line := scanner.Text()
-			continue
+		instruction, err := ParseInstruction(line, filepath.Dir(input))
-		}
+		if err != nil {
-		output <- instruction
+			log.Printf("Error parsing line: %s'%s'%s, error: %s%+v%s", SourceColor, line, DefaultColor, ErrorColor, err, DefaultColor)
-	}
+			continue
-}
+		}
-func ReadFromStdin(output chan LinkInstruction, status chan error) {
+		log.Printf("Read instruction: %s", instruction.String())
-	defer close(output)
+		output <- &instruction
-	defer close(status)
+	}
-
+}
-	log.Printf("Reading input from stdin")
+
-
+func ReadFromArgs(output chan *LinkInstruction, status chan error) {
-	info, err := os.Stdin.Stat()
+	defer close(output)
-	if err != nil {
+	defer close(status)
-		log.Fatalf("Failed to stat stdin: %s%+v%s", ErrorColor, err, DefaultColor)
+
-		status <- err
+	workdir, _ := os.Getwd()
-		return
+	log.Printf("Reading input from args")
-	}
+	for _, arg := range flag.Args() {
-	if info.Mode()&os.ModeNamedPipe != 0 {
+		instruction, err := ParseInstruction(arg, workdir)
-		scanner := bufio.NewScanner(os.Stdin)
+		if err != nil {
-		for scanner.Scan() {
+			log.Printf("Error parsing arg: %s'%s'%s, error: %s%+v%s", SourceColor, arg, DefaultColor, ErrorColor, err, DefaultColor)
-			line := scanner.Text()
+			continue
-			instruction, err := ParseInstruction(line)
+		}
-			if err != nil {
+		output <- &instruction
-				log.Printf("Error parsing line: %s'%s'%s, error: %s%+v%s", SourceColor, line, DefaultColor, ErrorColor, err, DefaultColor)
+	}
-				continue
+}
-			}
+
-			output <- instruction
+func ReadFromStdin(output chan *LinkInstruction, status chan error) {
-		}
+	defer close(output)
-		if err := scanner.Err(); err != nil {
+	defer close(status)
-			log.Fatalf("Error reading from stdin: %s%+v%s", ErrorColor, err, DefaultColor)
+
-			status <- err
+	workdir, _ := os.Getwd()
-			return
+	log.Printf("Reading input from stdin")
-		}
+
-	}
+	scanner := bufio.NewScanner(os.Stdin)
-}
+	for scanner.Scan() {
+		line := scanner.Text()
+		instruction, err := ParseInstruction(line, workdir)
+		if err != nil {
+			log.Printf("Error parsing line: %s'%s'%s, error: %s%+v%s", SourceColor, line, DefaultColor, ErrorColor, err, DefaultColor)
+			continue
+		}
+		output <- &instruction
+	}
+	if err := scanner.Err(); err != nil {
+		log.Fatalf("Error reading from stdin: %s%+v%s", ErrorColor, err, DefaultColor)
+		status <- err
+		return
+	}
+}

sync

@@ -1 +1 @@
-test,testdir/test3
+foo,"~/bar"

util.go

@@ -1,132 +1,152 @@
-package main
+package main
-
+
-import (
+import (
-	"fmt"
+	"fmt"
-	"log"
+	"log"
-	"os"
+	"os"
-	"path/filepath"
+	"path/filepath"
-	"strings"
+	"strings"
-	"sync"
+	"sync"
-	"sync/atomic"
+	"sync/atomic"
-	"time"
+	"time"
-)
+)
-
+
-func IsSymlink(path string) (bool, error) {
+func IsSymlink(path string) (bool, error) {
-	fileInfo, err := os.Lstat(path)
+	fileInfo, err := os.Lstat(path)
-	if err != nil {
+	if err != nil {
-		return false, err
+		return false, err
-	}
+	}
-
+
-	// os.ModeSymlink is a bitmask that identifies the symlink mode.
+	// os.ModeSymlink is a bitmask that identifies the symlink mode.
-	// If the file mode & os.ModeSymlink is non-zero, the file is a symlink.
+	// If the file mode & os.ModeSymlink is non-zero, the file is a symlink.
-	return fileInfo.Mode()&os.ModeSymlink != 0, nil
+	return fileInfo.Mode()&os.ModeSymlink != 0, nil
-}
+}
-
+
-func FileExists(path string) bool {
+func FileExists(path string) bool {
-	_, err := os.Lstat(path)
+	_, err := os.Lstat(path)
-	return err == nil
+	return err == nil
-}
+}
-
+
-func NormalizePath(input string) string {
+func NormalizePath(input, workdir string) string {
-	workingdirectory, _ := os.Getwd()
+	input = filepath.Clean(input)
-	input = strings.ReplaceAll(input, "\\", "/")
+	input = filepath.ToSlash(input)
-	input = strings.ReplaceAll(input, "\"", "")
+	input = strings.ReplaceAll(input, "\"", "")
-
+
-	if !filepath.IsAbs(input) {
+	if !filepath.IsAbs(input) {
-		input = workingdirectory + "/" + input
+		log.Printf("Input '%s' is not absolute, prepending work dir '%s'", input, workdir)
-	}
+		var err error
-
+		input = filepath.Join(workdir, input)
-	return filepath.Clean(input)
+		input, err = filepath.Abs(input)
-}
+		if err != nil {
-
+			log.Printf("Failed to get absolute path for %s%s%s: %s%+v%s", SourceColor, input, DefaultColor, ErrorColor, err, DefaultColor)
-func AreSame(lhs string, rhs string) bool {
+			return input
-	lhsinfo, err := os.Stat(lhs)
+		}
-	if err != nil {
+	}
-		return false
+
-	}
+	input = filepath.Clean(input)
-	rhsinfo, err := os.Stat(rhs)
+	input = filepath.ToSlash(input)
-	if err != nil {
+	return input
-		return false
+}
-	}
+
-
+func AreSame(lhs string, rhs string) bool {
-	return os.SameFile(lhsinfo, rhsinfo)
+	lhsinfo, err := os.Stat(lhs)
-}
+	if err != nil {
-
+		return false
-func ConvertHome(input string) (string, error) {
+	}
-	if strings.Contains(input, "~") {
+	rhsinfo, err := os.Stat(rhs)
-		homedir, err := os.UserHomeDir()
+	if err != nil {
-		if err != nil {
+		return false
-			return input, fmt.Errorf("unable to convert ~ to user directory with error %+v", err)
+	}
-		}
+
-
+	return os.SameFile(lhsinfo, rhsinfo)
-		return strings.Replace(input, "~", homedir, 1), nil
+}
-	}
+
-	return input, nil
+func ConvertHome(input string) (string, error) {
-}
+	if strings.HasPrefix(input, "~/") {
-
+		homedir, err := os.UserHomeDir()
-func GetSyncFilesRecursively(input string, output chan string, status chan error) {
+		if err != nil {
-	defer close(output)
+			return input, fmt.Errorf("unable to convert ~ to user directory with error %+v", err)
-	defer close(status)
+		}
-
+
-	var filesProcessed int32
+		return strings.Replace(input, "~", homedir, 1), nil
-	var foldersProcessed int32
+	}
-	progressTicker := time.NewTicker(200 * time.Millisecond)
+	return input, nil
-	defer progressTicker.Stop()
+}
-
+
-	var wg sync.WaitGroup
+func GetSyncFilesRecursively(input string, output chan string, status chan error) {
-	var initial sync.Once
+	defer close(output)
-	wg.Add(1)
+	defer close(status)
-	directories := make(chan string, 100000)
+
-	workerPool := make(chan struct{}, 4000)
+	var filesProcessed int32
-	directories <- input
+	var foldersProcessed int32
-
+	progressTicker := time.NewTicker(200 * time.Millisecond)
-	go func() {
+	defer progressTicker.Stop()
-		for {
+
-			fmt.Printf("\rFiles processed: %d; Folders processed: %d; Workers: %d; Directory Stack Size: %d;", filesProcessed, foldersProcessed, len(workerPool), len(directories))
+	var wg sync.WaitGroup
-			<-progressTicker.C
+	var initial sync.Once
-		}
+	var done bool
-	}()
+	wg.Add(1)
-
+	directories := make(chan string, 100000)
-	log.Printf("%+v", len(workerPool))
+	workerPool := make(chan struct{}, 4000)
-	go func() {
+	directories <- input
-		for directory := range directories {
+
-			workerPool <- struct{}{}
+	go func() {
-			wg.Add(1)
+		for {
-			go func(directory string) {
+			fmt.Printf("\rFiles processed: %d; Folders processed: %d; Workers: %d; Directory Stack Size: %d;", atomic.LoadInt32((&filesProcessed)), atomic.LoadInt32(&foldersProcessed), len(workerPool), len(directories))
-				atomic.AddInt32(&foldersProcessed, 1)
+			<-progressTicker.C
-				defer wg.Done()
+		}
-				defer func() { <-workerPool }()
+	}()
-
+
-				files, err := os.ReadDir(directory)
+	// log.Printf("%+v", len(workerPool))
-				if err != nil {
+	go func() {
-					log.Printf("Error reading directory %s: %+v", directory, err)
+		for directory := range directories {
-					return
+			workerPool <- struct{}{}
-				}
+			wg.Add(1)
-
+			go func(directory string) {
-				for _, file := range files {
+				atomic.AddInt32(&foldersProcessed, 1)
-					// log.Printf("Processing file %s", file.Name())
+				defer wg.Done()
-					if file.IsDir() {
+				defer func() { <-workerPool }()
-						directories <- filepath.Join(directory, file.Name())
+
-					} else {
+				files, err := os.ReadDir(directory)
-						// log.Println(file.Name(), DirRegex.MatchString(file.Name()))
+				if err != nil {
-						if FileRegex.MatchString(file.Name()) {
+					log.Printf("Error reading directory %s: %+v", directory, err)
-							// log.Printf("Writing")
+					return
-							output <- filepath.Join(directory, file.Name())
+				}
-						}
+
-						atomic.AddInt32(&filesProcessed, 1)
+				for _, file := range files {
-					}
+					// log.Printf("Processing file %s", file.Name())
-				}
+					if file.IsDir() {
-				// log.Printf("Done reading directory %s", directory)
+						directories <- filepath.Join(directory, file.Name())
-
+					} else {
-				initial.Do(func() {
+						// log.Println(file.Name(), DirRegex.MatchString(file.Name()))
-					// Parallelism is very difficult...
+						if FileRegex.MatchString(file.Name()) {
-					time.Sleep(250 * time.Millisecond)
+							// log.Printf("Writing")
-					wg.Done()
+							output <- filepath.Join(directory, file.Name())
-				})
+						}
-			}(directory)
+						atomic.AddInt32(&filesProcessed, 1)
-		}
+					}
-	}()
+				}
-
+				// log.Printf("Done reading directory %s", directory)
-	wg.Wait()
+				done = len(directories) == 0
-	log.Printf("Files processed: %d; Folders processed: %d", filesProcessed, foldersProcessed)
+				if done {
-}
+					initial.Do(func() {
+						wg.Done()
+					})
+				}
+			}(directory)
+		}
+	}()
+
+	// This actually does not go through ALL files sadly...
+	// It so happens (very often) that we manage to quit between one iteration ending
+	// And another beginning
+	// In such a state workgroup is decreased and, before it has a chance to increase, we are done
+	// What I should do here is only terminate if directories is empty
+	// ...but how do I do that?
+	// I might be wrong... Fuck knows...
+	// It also sometimes happens that wg.Wait triggers after wg.Done on line 97 but before the next (what would be!) wg.Add on line 94
+	// This happens much more often with a small number of workers
+	// Such is the nature of race conditions...
+	wg.Wait()
+	log.Printf("Files processed: %d; Folders processed: %d", filesProcessed, foldersProcessed)
+}