Refactor DeathReporter, CombatAlerter, Commander, Configurator, and AgentTracker modules

Heimdall.lua

@@ -69,7 +69,6 @@ local function init()
 	---@field deathReporter HeimdallDeathReporterConfig
 	---@field inviter HeimdallInviterConfig
 	---@field dueler HeimdallDuelerConfig
-	---@field bully HeimdallBullyConfig
 	---@field agentTracker HeimdallAgentTrackerConfig
 	---@field emoter HeimdallEmoterConfig
 	---@field echoer HeimdallEchoerConfig
@@ -78,7 +77,6 @@ local function init()
 	---@field stinkyTracker HeimdallStinkyTrackerConfig
 	---@field combatAlerter HeimdallCombatAlerterConfig
 	---@field sniffer HeimdallSnifferConfig
-	---@field bonkDetector HeimdallBonkDetectorConfig
 	---@field noter HeimdallNoterConfig
 	---@field network HeimdallNetworkConfig
 	---@field networkMessenger HeimdallNetworkMessengerConfig
@@ -121,15 +119,6 @@ local function init()
 	---@field debug boolean
 	---@field interval number
 
-	---@class HeimdallDeathReporterConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field throttle number
-	---@field doWhisper boolean
-	---@field channels string[]
-	---@field zoneOverride string?
-	---@field duelThrottle number
-
 	---@class HeimdallInviterConfig
 	---@field enabled boolean
 	---@field debug boolean
@@ -148,15 +137,6 @@ local function init()
 	---@field debug boolean
 	---@field declineOther boolean
 
-	---@class HeimdallBullyConfig
-	---@field enabled boolean
-	---@field debug boolean
-
-	---@class HeimdallAgentTrackerConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-
 	---@class HeimdallEmoterConfig
 	---@field enabled boolean
 	---@field debug boolean
@@ -174,24 +154,12 @@ local function init()
 	---@field debug boolean
 	---@field priority string[]
 
-	---@class HeimdallCommanderConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-	---@field commander string
-	---@field commands table<string, boolean>
-
 	---@class HeimdallStinkyTrackerConfig
 	---@field enabled boolean
 	---@field debug boolean
 	---@field ignoredTimeout number
 	---@field channels string[]
 
-	---@class HeimdallCombatAlerterConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-
 	---@class HeimdallSnifferConfig
 	---@field enabled boolean
 	---@field debug boolean
@@ -227,12 +195,6 @@ local function init()
 	---@field helpSoundThrottle number
 	---@field helpTextureFile string
 
-	---@class HeimdallBonkDetectorConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-	---@field throttle number
-
 	---@class HeimdallNoterConfig
 	---@field enabled boolean
 	---@field debug boolean
@@ -250,10 +212,6 @@ local function init()
 	---@field debug boolean
 	---@field interval number
 
-	---@class HeimdallConfiguratorConfig
-	---@field enabled boolean
-	---@field debug boolean
-
 	---@class HeimdallStinkyCacheConfig
 	---@field enabled boolean
 	---@field debug boolean
@@ -666,7 +624,7 @@ local function init()
 	shared.Memoize = function(f)
 		local mem = {} -- memoizing table
 		setmetatable(mem, { __mode = "kv" }) -- make it weak
-		return function(x) -- new version of ’f’, with memoizing
+		return function(x) -- new version of 'f', with memoizing
 			if Heimdall_Data.config.debug then print(string.format("[Heimdall] Memoize %s", tostring(x))) end
 			local r = mem[x]
 			if r == nil then -- no previous result?

Modules/AgentTracker.lua

@@ -5,6 +5,11 @@ local ModuleName = "AgentTracker"
 ---@class AgentTrackerData
 ---@field agents ReactiveValue<table<string, string>>
 
+---@class HeimdallAgentTrackerConfig
+---@field enabled boolean
+---@field debug boolean
+---@field channels string[]
+
 shared.agentTracker.agents = ReactiveValue(Heimdall_Data.config.agents)
 
 ---@class AgentTracker

Modules/CombatAlerter.lua

@@ -2,6 +2,11 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "CombatAlerter"
 
+---@class HeimdallCombatAlerterConfig
+---@field enabled boolean
+---@field debug boolean
+---@field channels string[]
+
 ---@diagnostic disable-next-line: missing-fields
 shared.CombatAlerter = {}
 function shared.CombatAlerter.Init()

Modules/Commander.lua

@@ -1,5 +1,13 @@
 local _, shared = ...
 ---@cast shared HeimdallShared
+
+---@class HeimdallCommanderConfig
+---@field enabled boolean
+---@field debug boolean
+---@field channels string[]
+---@field commander string
+---@field commands table<string, boolean>
+
 local ModuleName = "Commander"
 
 local helpMessages = {

Modules/Configurator.lua

@@ -1,5 +1,10 @@
 local _, shared = ...
 ---@cast shared HeimdallShared
+
+---@class HeimdallConfiguratorConfig
+---@field enabled boolean
+---@field debug boolean
+
 local ModuleName = "Configurator"
 
 ---@diagnostic disable-next-line: missing-fields

Modules/DeathReporter.lua

@@ -1,5 +1,15 @@
 local _, shared = ...
 ---@cast shared HeimdallShared
+
+---@class HeimdallDeathReporterConfig
+---@field enabled boolean
+---@field debug boolean
+---@field throttle number
+---@field doWhisper boolean
+---@field channels string[]
+---@field zoneOverride string?
+---@field duelThrottle number
+
 local ModuleName = "DeathReporter"
 
 ---@diagnostic disable-next-line: missing-fields