From 6551e24069d24180fe5a0b1cdd28449e96adaece Mon Sep 17 00:00:00 2001 From: PhatPhuckDave Date: Wed, 15 Jan 2025 14:01:54 +0100 Subject: [PATCH] Rework network to use timer instead of onupdate --- Heimdall.lua | 4 ++++ Modules/Network.lua | 14 +++----------- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/Heimdall.lua b/Heimdall.lua index 962311b..f6b9c5b 100644 --- a/Heimdall.lua +++ b/Heimdall.lua @@ -20,6 +20,7 @@ local function init() ---@field who HeimdallWhoData ---@field stinkyTracker HeimdallStinkyTrackerData ---@field networkNodes string[] + ---@field network HeimdallNetworkData ---@field _L Localization ---@field VERSION string ---@field dumpTable fun(table: any, depth?: number): nil @@ -242,6 +243,9 @@ local function init() ---@class HeimdallStinkyTrackerData ---@field stinkies ReactiveValue + ---@class HeimdallNetworkData + ---@field ticker number? + shared.GetOrDefault = function(table, keys, default) local value = default if not table then return value end diff --git a/Modules/Network.lua b/Modules/Network.lua index cb2ea0e..31e7ff6 100644 --- a/Modules/Network.lua +++ b/Modules/Network.lua @@ -46,23 +46,15 @@ function shared.Network.Init() end end) - local function Update() + local function NetworkTick() if not Heimdall_Data.config.network.enabled then return end if Heimdall_Data.config.network.debug then print("Network module is updating.") end ShowFriends() + shared.network.ticker = C_Timer.NewTimer(Heimdall_Data.config.network.updateInterval, NetworkTick, 1) end - local networkFrame = CreateFrame("Frame") - networkFrame:SetScript("OnUpdate", function(self, elapsed) - if not Heimdall_Data.config.network.enabled then return end - updateTime = updateTime + elapsed - if updateTime >= Heimdall_Data.config.network.updateInterval then - Update() - updateTime = 0 - end - end) - Update() + NetworkTick() print("[Heimdall] Network module loaded") end