Refactor Heimdall modules to improve structure and clarity, including AchievementSniffer, BonkDetector, Bully, Commander, and Config.

Heimdall.lua

@@ -36,30 +36,30 @@ local function init()
 	---@field Memoize fun(f: function): function
 	---@field GetLocaleForChannel fun(channel: string): string
 	---@field WhoQueryService WhoQueryService
-	---@field Whoer InitTable|{ShouldNotifyForZone: fun(zone: string): boolean}
-	---@field AchievementSniffer InitTable
+	---@field AchievementSniffer AchievementSniffer
 	---@field AgentTracker AgentTracker
-	---@field BonkDetector InitTable
-	---@field Bully InitTable
-	---@field CombatAlerter InitTable
-	---@field Commander InitTable
-	---@field Config InitTable
-	---@field Configurator InitTable
-	---@field DeathReporter InitTable
-	---@field Dueler InitTable
-	---@field Echoer InitTable
-	---@field Emoter InitTable
-	---@field Inviter InitTable
-	---@field Macroer InitTable
-	---@field Messenger InitTable
-	---@field MinimapTagger InitTable
-	---@field Network InitTable
-	---@field NetworkMessenger InitTable
-	---@field Noter InitTable
-	---@field Sniffer InitTable
-	---@field Spotter InitTable
-	---@field StinkyCache InitTable
+	---@field BonkDetector BonkDetector
+	---@field Bully Bully
+	---@field CombatAlerter CombatAlerter
+	---@field Commander Commander
+	---@field Config Config
+	---@field Configurator Configurator
+	---@field DeathReporter DeathReporter
+	---@field Dueler Dueler
+	---@field Echoer Echoer
+	---@field Emoter Emoter
+	---@field Inviter Inviter
+	---@field Macroer Macroer
+	---@field Messenger Messenger
+	---@field MinimapTagger MinimapTagger
+	---@field Network Network
+	---@field NetworkMessenger NetworkMessenger
+	---@field Noter Noter
+	---@field Sniffer Sniffer
+	---@field Spotter Spotter
+	---@field StinkyCache StinkyCache
 	---@field StinkyTracker StinkyTracker
+	---@field Whoer Whoer
 
 	--- Config ---
 	---@class HeimdallConfig
@@ -119,19 +119,6 @@ local function init()
 	---@field debug boolean
 	---@field interval number
 
-	---@class HeimdallInviterConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-	---@field keyword string
-	---@field allAssist boolean
-	---@field agentsAssist boolean
-	---@field throttle number
-	---@field kickOffline boolean
-	---@field cleanupInterval number
-	---@field afkThreshold number
-	---@field listeningChannel table<string, boolean>
-
 	---@class HeimdallDuelerConfig
 	---@field enabled boolean
 	---@field debug boolean
@@ -149,25 +136,12 @@ local function init()
 	---@field channels string[]
 	---@field prefix string
 
-	---@class HeimdallMacroerConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field priority string[]
-
 	---@class HeimdallStinkyTrackerConfig
 	---@field enabled boolean
 	---@field debug boolean
 	---@field ignoredTimeout number
 	---@field channels string[]
 
-	---@class HeimdallSnifferConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-	---@field throttle number
-	---@field zoneOverride string?
-	---@field stinky boolean
-
 	---@class HeimdallMinimapTaggerConfig
 	---@field enabled boolean
 	---@field debug boolean