dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix banding issue in artic tree range

Browse Source 
Using tile index for randomization is a very very very bad idea
This commit is contained in:
Andreas Schmitt
2021-06-17 07:56:51 +02:00
committed by Jonathan G Rennison
parent 3b4cbd3323
commit 6c2152045a
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/tree_cmd.cpp
View File

@@ -194,8 +194,7 @@ static TreeType GetRandomTreeType(TileIndex tile, uint seed)
uint normalised_distance = (height_above_snow_line < 0) ? -height_above_snow_line : height_above_snow_line + 1;
bool arctic_tree = false;
if (normalised_distance < lengthof(_arctic_tree_occurance)) {
uint adjusted_seed = (seed ^ tile) & 0xFF;
arctic_tree = adjusted_seed < _arctic_tree_occurance[normalised_distance];
arctic_tree = RandomRange(256) < _arctic_tree_occurance[normalised_distance];
}
if (height_above_snow_line < 0) {
/* Below snow level mixed forest. */