dave/openttd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix data race warning in NetworkGameListHandleDelayedInsert

Browse Source 
Avoid thread-sanitizer warning on ins_item->next
This commit is contained in:
Jonathan G Rennison
2021-04-06 03:53:01 +01:00
parent 76624e6f58
commit d452517c66
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/network/network_gamelist.cpp
View File

@@ -40,7 +40,7 @@ void NetworkGameListAddItemDelayed(NetworkGameList *item)
static void NetworkGameListHandleDelayedInsert() static void NetworkGameListHandleDelayedInsert()
{ {
while (true) { while (true) {
NetworkGameList *ins_item = _network_game_delayed_insertion_list.load(std::memory_order_relaxed); NetworkGameList *ins_item = _network_game_delayed_insertion_list.load(std::memory_order_acquire);
while (ins_item != nullptr && !_network_game_delayed_insertion_list.compare_exchange_weak(ins_item, ins_item->next, std::memory_order_acq_rel)) {} while (ins_item != nullptr && !_network_game_delayed_insertion_list.compare_exchange_weak(ins_item, ins_item->next, std::memory_order_acq_rel)) {}
if (ins_item == nullptr) break; // No item left. if (ins_item == nullptr) break; // No item left.