Commit Graph

51044 Commits

Author SHA1 Message Date
Jonathan G Rennison
903ca18c01 Version: Committing version data for tag: jgrpp-0.41.2 2021-05-21 20:18:02 +01:00
Jonathan G Rennison
900a93ac59 Debug: Add sprite dumping to vehicle debug windows 2021-05-21 19:36:19 +01:00
Jonathan G Rennison
6f10b01ba2 Debug: Add general mechanism to dump a sprite group chain 2021-05-21 19:35:22 +01:00
Jonathan G Rennison
12e00624ba Debug: Fix scrollbar count and logged end marker in extra info only mode 2021-05-21 19:16:38 +01:00
Jonathan G Rennison
5d8f459066 Debug: Add button to debug window to log contents to console 2021-05-21 19:00:18 +01:00
Jonathan G Rennison
30409192f0 Fix f5183807: Tree planting scaling on extra large maps 2021-05-21 18:40:10 +01:00
PeterN
f5183807fe Fix #9242: Tree tick handler did not scale by map size. (#9246)
This means that random tree generation density is higher on small maps and lower on large maps. This difference is enough to make the Lumber Mill impractical to use on large maps.

This change skips ticks on maps smaller than 256x256 and increases iterations or shortens the interval on maps larger than 256x256.

(cherry picked from commit b972ed8604)
2021-05-21 18:32:53 +01:00
frosch
c2fce47340 Fix #9256, 12e43c697d: invalid read after free. (#9258)
This also changes ScriptEventVehicleAutoReplaced when replacing wagons:
The event is now only spawned, if the head engine changes, so only if the VehicleID of the consist changes.
Previously replacing wagons spawned an event with OldVehicleID==NewVehicleID.

(cherry picked from commit 5bd8144853)
2021-05-21 18:32:53 +01:00
PeterN
dcb0cc2c52 Fix #9186: Fix incorrect bounding box height causing station sprite glitch. (#9187)
Increased height of small station building bounding box to cover the build rather than just the platform.

(cherry picked from commit ba193f2e23)
2021-05-21 18:29:45 +01:00
PeterN
8677a2a4a2 Fix #9063: Caption of news window incorrectly aligned. (#9252)
(cherry picked from commit 7b7dbbc935)
2021-05-21 18:29:30 +01:00
Jonathan G Rennison
6d3a1935a0 Fix "(undefined string)" message when SlError called when saving 2021-05-21 02:05:18 +01:00
Jonathan G Rennison
66289bbda4 Log packet size parse failures in NetworkTCPSocketHandler 2021-05-21 01:42:31 +01:00
Jonathan G Rennison
6d58115458 Net: Log sent and received game packets with type and status names 2021-05-21 01:40:00 +01:00
Jonathan G Rennison
7677d2d01a Fix mishandling of PACKET_SERVER_MAP_BEGIN queuing at server
This could result in broken packet framing in the TCP stream
2021-05-21 00:58:24 +01:00
Jonathan G Rennison
7c706923f8 Fix a15e26f3: Leftover debugging statement 2021-05-20 22:07:38 +01:00
Jonathan G Rennison
31aec93cca Fix leftover strings in Frisian language 2021-05-20 22:05:13 +01:00
Jonathan G Rennison
3ecda2b735 Fix handling of SlError when called from game thread 2021-05-20 20:20:45 +01:00
Jonathan G Rennison
a8157770df Add fast path to vehicle var 0x42 if only upper byte is required 2021-05-20 18:34:06 +01:00
Jonathan G Rennison
aa0c1ba2e0 Only update vehicle image when in the vicinity of a viewport
This reduces the performance impact of expensive NewGRF
graphics chains.
2021-05-20 18:03:11 +01:00
Jonathan G Rennison
3e8ee4f49f Remove "Disable vehicle image update" setting 2021-05-19 20:42:04 +01:00
Milek7
7ab6ab7400 Fix: missing <limits> include in network/core/packet.h (#9123)
(cherry picked from commit a341852cd5)
2021-05-19 18:19:59 +01:00
Jonathan G Rennison
55915d8d55 Elide vehicle random trigger callbacks 2021-05-18 22:14:19 +01:00
Jonathan G Rennison
6ea97d6068 Viewport: Cache viewport areas for use in MarkAllViewportsDirty 2021-05-18 21:37:05 +01:00
Jonathan G Rennison
a15e26f369 NewGRF: Elide unmasked vehicle callbacks where possible
This includes:
* CBID_VEHICLE_32DAY_CALLBACK
* CBID_VEHICLE_REFIT_COST
* CBID_VEHICLE_MODIFY_PROPERTY
  This is on a per-property basis

The main benefit of this is to avoid callbacks not handled by the
vehicle's current sprite group from using the full graphics chain as
the "default" branch in the callback switch.
In the case where the graphics chain is long/expensive, a lot of work
had to be done before a callback failure result was eventually returned.
2021-05-18 19:07:44 +01:00
Rubidium
7274432987 Fix #9267, 47a99bb: [Squirrel] Heap use after free
Due to 47a99bb the order of elements in the garbage collection chain has
changed causing the class to be finalised before the instances of that class.
Since the instance's array of member values depends on the size of the values
in the class, the class finalisation resetting that size to 0 causes not all
finalisations to run, which subsequently causes a heap use after free. So,
just set the SQObjectPtrs to 'null' during the finalisation of the SQClass
so the SQInstance can release all instance variables during its finalisation.

(cherry picked from commit 5c01f9ea52)

See: #256
2021-05-16 09:54:56 +01:00
Jonathan G Rennison
8eb34b2f10 Do not attach temporary wagons to free wagon chains when autoreplacing
See: https://github.com/OpenTTD/OpenTTD/issues/9264
2021-05-15 22:32:50 +01:00
Jonathan G Rennison
f3e0507c54 Network: Include extra info in PACKET_CLIENT_ERROR packets
Log more details in server when PACKET_CLIENT_ERROR received
2021-05-14 20:31:31 +01:00
Jonathan G Rennison
e04218b528 Network: Log received packets at log level net=3 2021-05-14 19:34:15 +01:00
PeterN
66cac92028 Fix #9202: Invalid test for unset NewGRF override mapping. (#9226)
(cherry picked from commit 3d9436bd75)
2021-05-14 18:33:19 +01:00
Patric Stout
457b4f80b6 Fix 91b8ce07: dedicated servers could no longer create screenshots (#9232)
Although most commands are not useful on a dedicated server,
screenshot commands should be dequeued.

(cherry picked from commit 56050fc96f)
2021-05-14 18:25:34 +01:00
PeterN
f52da3de3a Codechange: Don't save unused NewGRF override mappings. (#9202)
(cherry picked from commit 69e5da0b54)
2021-05-14 18:15:17 +01:00
William Davis
879de9781b Change: Use gender-neutral pronouns in console command messages (and comments) (#9203)
(cherry picked from commit 881e1da51d)
2021-05-14 18:15:00 +01:00
Jonathan G Rennison
088922b120 Fix poor performance of recursive iteration of group hierarchies 2021-05-14 02:04:37 +01:00
Jonathan G Rennison
2e28bc8e6a Tracerestrict: Add engine class conditional 2021-05-13 23:49:03 +01:00
Jonathan G Rennison
892feb1665 Define __STDC_FORMAT_MACROS in stdafx.h 2021-05-12 18:09:09 +01:00
Jonathan G Rennison
19b99ee687 Fix 1ac0f186: Remove remaining use of CMAKE_PROJECT_VERSION_XXX 2021-05-12 17:52:46 +01:00
Jonathan G Rennison
59572fa415 Print message instead of asserting when route step sprite do not match
See: #255
2021-05-08 17:59:56 +01:00
Jonathan G Rennison
6c3ce55a0b Version: Committing version data for tag: jgrpp-0.41.1 2021-05-08 11:06:31 +01:00
PeterN
1db19dd88c Fix #9209: Excessive time resizing highscore/news window when screen is too small. (#9210)
If the highscore/news window panel size, which is now scaled by GUI zoom, is larger than the screen size, a loop will be entered where the window is repeatedly resized.

This is resolved by removing the minimal size from the panel, as the window is always resized to cover the screen anyway. This means the screen size can never be too small.

(cherry picked from commit 8c3fa2a3bf)
2021-05-08 10:22:22 +01:00
Peter Nelson
2b34256e51 Codechange: Slider widget used different range for drawing vs setting.
Using the same range for setting means that no workaround for setting the extremes is necessary.

(cherry picked from commit dd41de8931)
2021-05-08 10:22:22 +01:00
Peter Nelson
b414060f7c Codechange: Make GetCurrentRect() conform to usual Rect bounds, and reuse it.
Similar code is already repeated in other locations.

(cherry picked from commit d8e06e590a)
2021-05-08 10:22:22 +01:00
Peter Nelson
065ae3964a Codechange: Don't update window contents if scrollbar position has not moved.
(cherry picked from commit 52b16237ad)
2021-05-08 10:22:22 +01:00
Peter Nelson
ad554d913f Codechange: Set specific widgets dirty instead of window.
(cherry picked from commit 8321ef0061)
2021-05-08 10:22:22 +01:00
embeddedt
0676c1f470 Fix: [Emscripten] Use non-XDG directories to simplify lolac storage (#9207)
(cherry picked from commit a879996012)
2021-05-08 10:22:04 +01:00
Jonathan G Rennison
26992089d6 Fix use of _mm_cvtsi64_si128 which is not available on 32 bit x86
See: #254
2021-05-07 03:30:36 +01:00
Jonathan G Rennison
011b3b8b8d Avoid data race on map size when clearing link graph jobs in InitializeGame 2021-05-07 00:58:52 +01:00
Jonathan G Rennison
9900adae70 Fix #254: AdjustBrightnessOfTwoPixels used in 32bpp-sse2 but requires SSE3 2021-05-06 21:26:15 +01:00
rubidium42
9bfcea0397 Cleanup: [Fluidsynth] Comply better with the coding style
(cherry picked from commit a432009f06)
2021-05-06 21:22:42 +01:00
Tyler Trahan
54deb7516c Change: Use gender-neutral pronouns in english.txt (#9189)
(cherry picked from commit 176d65b472)
2021-05-06 21:22:14 +01:00
glx22
8333323090 Codechange: Replace FOR_ALL_ROADTRAMTYPES with range-based for loops
(cherry picked from commit 2feb801e56)
2021-05-06 21:21:41 +01:00