service/settings: make getProxyAuthDetails() return None again

2016-10-09 13:05:39 +05:00
parent c166fa6bf5
commit 2a9a4fbdff
1 changed files with 2 additions and 2 deletions
--- a/service/settings.py
+++ b/service/settings.py
@@ -218,9 +218,9 @@ class NetworkSettings():

    def getProxyAuthDetails(self):
        if self.getMode() == self.PROXY_MODE_NONE:
-            return ("", "")  # never return none, return tuple with empty strings
+            return None
        if (self.serviceNetworkSettings["login"] is None) or (self.serviceNetworkSettings["password"] is None):
-            return ("", "")  # never return none, return tuple with empty strings
+            return None
        # in all other cases, return tuple of (login, password)
        return (self.serviceNetworkSettings["login"], self.serviceNetworkSettings["password"])