dave/pyfa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 5 Wiki Activity

Fix improper use of operator "is" when comparing to literal values

Browse Source
This commit is contained in:
DarkPhoenix
2020-01-31 18:16:36 +03:00
parent 4d4680961e
commit 2f4a5a4830
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gui/characterEditor.py
View File

@@ -839,7 +839,7 @@ class APIView(wx.Panel):
def getActiveCharacter(self):
selection = self.charChoice.GetCurrentSelection()
return self.charChoice.GetClientData(selection) if selection is not -1 else None
return self.charChoice.GetClientData(selection) if selection != -1 else None
def ssoListChanged(self, event):
if not self: # todo: fix event not unbinding properly

2
gui/characterSelection.py
View File

@@ -122,7 +122,7 @@ class CharacterSelection(wx.Panel):
def getActiveCharacter(self):
selection = self.charChoice.GetCurrentSelection()
return self.charChoice.GetClientData(selection) if selection is not -1 else None
return self.charChoice.GetClientData(selection) if selection != -1 else None
def refreshCharacterList(self, event=None):
choice = self.charChoice

2
gui/mainFrame.py
View File

@@ -254,7 +254,7 @@ class MainFrame(wx.Frame):
except:
fits.remove(id)
if not self.prevOpenFits['enabled'] or len(fits) is 0:
if not self.prevOpenFits['enabled'] or len(fits) == 0:
# add blank page if there are no fits to be loaded
self.fitMultiSwitch.AddPage()
return

4
service/port/xml.py
View File

@@ -88,7 +88,7 @@ def _resolve_ship(fitting, sMkt, b_localized):
pyfalog.warning("Caught exception on _resolve_ship")
pyfalog.error(e)
limit -= 1
if limit is 0:
if limit == 0:
break
shipType = anything
must_retry = True
@@ -132,7 +132,7 @@ def _resolve_module(hardware, sMkt, b_localized):
pyfalog.warning("Caught exception on _resolve_module")
pyfalog.error(e)
limit -= 1
if limit is 0:
if limit == 0:
break
moduleName = emergency
must_retry = True