Fix some effects

eos/effects/cloaking.py

@@ -13,4 +13,4 @@ def handler(fit, module, context):
     # Doesn't apply to covops cloaks
     fit.extraAttributes["cloaked"] = True
     # Apply speed penalty
-    fit.ship.multiplyItemAttr("maxVelocity", module.getModifiedItemAttr("maxVelocityBonus"))
+    fit.ship.multiplyItemAttr("maxVelocity", module.getModifiedItemAttr("maxVelocityModifier"))

eos/effects/cloakingprototype.py

@@ -13,4 +13,4 @@ def handler(fit, module, context):
     # Doesn't apply to covops cloaks
     fit.extraAttributes["cloaked"] = True
     # Apply speed penalty
-    fit.ship.multiplyItemAttr("maxVelocity", module.getModifiedItemAttr("maxVelocityBonus"))
+    fit.ship.multiplyItemAttr("maxVelocity", module.getModifiedItemAttr("maxVelocityModifier"))

eos/effects/ignorecloakvelocitypenalty.py

@@ -8,4 +8,4 @@ runTime = "early"
 
 def handler(fit, src, context):
     fit.modules.filteredItemForce(lambda mod: mod.item.group.name == "Cloaking Device",
-                                  "maxVelocityBonus", src.getModifiedItemAttr("velocityPenaltyReduction"))
+                                  "maxVelocityModifier", src.getModifiedItemAttr("velocityPenaltyReduction"))

eos/effects/industrialbonusdronedamage.py

@@ -4,11 +4,8 @@
 # Orca
 type = "passive"
 
-
 def handler(fit, src, context):
     fit.drones.filteredItemBoost(lambda drone: drone.item.requiresSkill("Drones"),
                                  "damageMultiplier",
-                                 src.getModifiedItemAttr("industrialBonusDroneDamage"),
-                                 )
+                                 src.getModifiedItemAttr("industrialBonusDroneDamage"), stackingPenalties = True)
 
-#  TODO: test

eos/effects/miningdronespecbonus.py

@@ -1,5 +1,5 @@
 type = "passive"
 def handler(fit, src, context):
     lvl = src.level
-    fit.modules.filteredChargeBoost(lambda mod: mod.charge.requiresSkill("Mining Drone Specialization"), "maxVelocity", src.getModifiedItemAttr("maxVelocityBonus") * lvl)
     fit.modules.filteredChargeBoost(lambda mod: mod.charge.requiresSkill("Mining Drone Specialization"), "miningAmount", src.getModifiedItemAttr("miningAmountBonus") * lvl)
+    fit.modules.filteredChargeBoost(lambda mod: mod.charge.requiresSkill("Mining Drone Specialization"), "maxVelocity", src.getModifiedItemAttr("maxVelocityBonus") * lvl)

eos/effects/modifymaxvelocityofshippassive.py

@@ -6,5 +6,4 @@ type = "passive"
 
 
 def handler(fit, module, context):
-    fit.ship.multiplyItemAttr("maxVelocity", module.getModifiedItemAttr("maxVelocityBonus"),
-                              stackingPenalties=True)
+    fit.ship.multiplyItemAttr("maxVelocity", module.getModifiedItemAttr("maxVelocityModifier"), stackingPenalties=True)

eos/effects/overloadselfmissileguidancebonus5.py

@@ -10,7 +10,7 @@ def handler(fit, module, context):
             "aoeCloudSizeBonus",
             "explosionDelayBonus",
             "missileVelocityBonus",
-            "maxVelocityBonus",
+            "maxVelocityModifier",
             "aoeVelocityBonus"
     ):
         module.boostItemAttr(tgtAttr, module.getModifiedItemAttr("overloadTrackingModuleStrengthBonus"))

eos/effects/zcolinorcasurveyscannerbonus.py

@@ -1,10 +1,3 @@
-# zColinOrcaSurveyScannerBonus
-#
-# Used by:
-# Ship: Orca
 type = "passive"
-
-
-def handler(fit, ship, context):
-    fit.modules.filteredItemBoost(lambda mod: mod.item.group.name == "Survey Scanner",
-                                  "surveyScanRange", ship.getModifiedItemAttr("shipOrcaSurveyScannerBonus"))
+def handler(fit, src, context):
+    fit.modules.filteredItemBoost(lambda mod: mod.item.group.name == "Survey Scanner", "surveyScanRange", src.getModifiedItemAttr("roleBonusSurveyScannerRange"))

eos/effects/zcolinorcatractorrangebonus.py

@@ -1,10 +1,3 @@
-# zColinOrcaTractorRangeBonus
-#
-# Used by:
-# Ship: Orca
 type = "passive"
-
-
-def handler(fit, ship, context):
-    fit.modules.filteredItemBoost(lambda mod: mod.item.group.name == "Tractor Beam",
-                                  "maxRange", ship.getModifiedItemAttr("shipOrcaTractorBeamRangeBonus1"))
+def handler(fit, src, context):
+    fit.modules.filteredItemBoost(lambda mod: mod.item.group.name == "Tractor Beam", "maxRange", src.getModifiedItemAttr("roleBonusTractorBeamRange"), stackingPenalties=True)

eos/effects/zcolinorcatractorvelocitybonus.py

@@ -6,5 +6,4 @@ type = "passive"
 
 
 def handler(fit, ship, context):
-    fit.modules.filteredItemBoost(lambda mod: mod.item.group.name == "Tractor Beam",
-                                  "maxTractorVelocity", ship.getModifiedItemAttr("shipOrcaTractorBeamVelocityBonus2"))
+    fit.modules.filteredItemBoost(lambda mod: mod.item.group.name == "Tractor Beam", "maxTractorVelocity", ship.getModifiedItemAttr("roleBonusTractorBeamVelocity"))