Fix FriendsFrame_OnEvent to pass additional parameters so it actually works naturally

.gitignore

@@ -0,0 +1 @@
+scratch.lua

.luacheckrc

@@ -1,5 +1,5 @@
 globals = { "CykaPersistentData", "CreateFrame", "GetItemInfo", "aura_env" }
 unused_args = false
-max_line_length = 150
+max_line_length = 500
 exclude_files = { "Meta/" }
 global = false

Heimdall.lua

@@ -2,7 +2,7 @@ local addonname, shared = ...
 ---@cast shared HeimdallShared
 ---@cast addonname string
 
-local VERSION = "3.11.0"
+local VERSION = "3.12.0"
 shared.VERSION = VERSION
 
 local function init()
@@ -18,7 +18,8 @@ local function init()
 	---@field classColors table<string, string>
 	---@field messenger HeimdallMessengerData
 	---@field who HeimdallWhoData
-	---@field stinkyTracker HeimdallStinkyTrackerData
+	---@field stinkyTracker StinkyTrackerData
+	---@field agentTracker AgentTrackerData
 	---@field networkNodes string[]
 	---@field network HeimdallNetworkData
 	---@field networkMessenger HeimdallNetworkMessengerData
@@ -26,7 +27,7 @@ local function init()
 	---@field _L fun(key: string, locale: string): string
 	---@field _Locale Localization
 	---@field VERSION string
-	---@field dumpTable fun(table: any, depth?: number): nil
+	---@field dump fun(table: any, msg?: string, depth?: number): nil
 	---@field utf8len fun(input: string): number
 	---@field padString fun(input: string, targetLength: number, left?: boolean): string
 	---@field GetOrDefault fun(table: table<any, any>, keys: string[], default: any): any
@@ -35,30 +36,30 @@ local function init()
 	---@field Memoize fun(f: function): function
 	---@field GetLocaleForChannel fun(channel: string): string
 	---@field WhoQueryService WhoQueryService
-	---@field Whoer InitTable|{ShouldNotifyForZone: fun(zone: string): boolean}
-	---@field Messenger InitTable
-	---@field Spotter InitTable
-	---@field DeathReporter InitTable
-	---@field Inviter InitTable
-	---@field Dueler InitTable
-	---@field Bully InitTable
-	---@field AgentTracker InitTable
-	---@field Emoter InitTable
-	---@field Echoer InitTable
-	---@field Macroer InitTable
-	---@field Commander InitTable
-	---@field StinkyTracker InitTable
-	---@field CombatAlerter InitTable
-	---@field Config InitTable
-	---@field Sniffer InitTable
-	---@field MinimapTagger InitTable
-	---@field BonkDetector InitTable
-	---@field Noter InitTable
-	---@field Network InitTable
-	---@field NetworkMessenger InitTable
-	---@field StinkyCache InitTable
-	---@field Configurator InitTable
-	---@field AchievementSniffer InitTable
+	---@field AchievementSniffer AchievementSniffer
+	---@field AgentTracker AgentTracker
+	---@field BonkDetector BonkDetector
+	---@field Bully Bully
+	---@field CombatAlerter CombatAlerter
+	---@field Commander Commander
+	---@field Config Config
+	---@field Configurator Configurator
+	---@field DeathReporter DeathReporter
+	---@field Dueler Dueler
+	---@field Echoer Echoer
+	---@field Emoter Emoter
+	---@field Inviter Inviter
+	---@field Macroer Macroer
+	---@field Messenger Messenger
+	---@field MinimapTagger MinimapTagger
+	---@field Network Network
+	---@field NetworkMessenger NetworkMessenger
+	---@field Noter Noter
+	---@field Sniffer Sniffer
+	---@field Spotter Spotter
+	---@field StinkyCache StinkyCache
+	---@field StinkyTracker StinkyTracker
+	---@field Whoer Whoer
 
 	--- Config ---
 	---@class HeimdallConfig
@@ -68,7 +69,6 @@ local function init()
 	---@field deathReporter HeimdallDeathReporterConfig
 	---@field inviter HeimdallInviterConfig
 	---@field dueler HeimdallDuelerConfig
-	---@field bully HeimdallBullyConfig
 	---@field agentTracker HeimdallAgentTrackerConfig
 	---@field emoter HeimdallEmoterConfig
 	---@field echoer HeimdallEchoerConfig
@@ -77,7 +77,6 @@ local function init()
 	---@field stinkyTracker HeimdallStinkyTrackerConfig
 	---@field combatAlerter HeimdallCombatAlerterConfig
 	---@field sniffer HeimdallSnifferConfig
-	---@field bonkDetector HeimdallBonkDetectorConfig
 	---@field noter HeimdallNoterConfig
 	---@field network HeimdallNetworkConfig
 	---@field networkMessenger HeimdallNetworkMessengerConfig
@@ -94,203 +93,6 @@ local function init()
 	---@field locale string
 	---@field debug boolean
 
-	---@class HeimdallSpotterConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field everyone boolean
-	---@field hostile boolean
-	---@field alliance boolean
-	---@field stinky boolean
-	---@field channels string[]
-	---@field zoneOverride string?
-	---@field throttleTime number
-
-	---@class HeimdallWhoConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field ignored table<string, boolean>
-	---@field channels string[]
-	---@field ttl number
-	---@field doWhisper boolean
-	---@field zoneNotifyFor table<string, boolean>
-	---@field queries string
-
-	---@class HeimdallMessengerConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field interval number
-
-	---@class HeimdallDeathReporterConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field throttle number
-	---@field doWhisper boolean
-	---@field channels string[]
-	---@field zoneOverride string?
-	---@field duelThrottle number
-
-	---@class HeimdallInviterConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-	---@field keyword string
-	---@field allAssist boolean
-	---@field agentsAssist boolean
-	---@field throttle number
-	---@field kickOffline boolean
-	---@field cleanupInterval number
-	---@field afkThreshold number
-	---@field listeningChannel table<string, boolean>
-
-	---@class HeimdallDuelerConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field declineOther boolean
-
-	---@class HeimdallBullyConfig
-	---@field enabled boolean
-	---@field debug boolean
-
-	---@class HeimdallAgentTrackerConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-
-	---@class HeimdallEmoterConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-	---@field prefix string
-
-	---@class HeimdallEchoerConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-	---@field prefix string
-
-	---@class HeimdallMacroerConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field priority string[]
-
-	---@class HeimdallCommanderConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-	---@field commander string
-	---@field commands table<string, boolean>
-
-	---@class HeimdallStinkyTrackerConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-
-	---@class HeimdallCombatAlerterConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-
-	---@class HeimdallSnifferConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-	---@field throttle number
-	---@field zoneOverride string?
-	---@field stinky boolean
-
-	---@class HeimdallMinimapTaggerConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-	---@field throttle number
-	---@field scale number
-	---@field tagTTL number
-	---@field tagSound boolean
-	---@field tagSoundFile string
-	---@field tagSoundThrottle number
-	---@field tagTextureFile string
-	---@field alertTTL number
-	---@field alertSound boolean
-	---@field alertSoundFile string
-	---@field alertSoundThrottle number
-	---@field alertTextureFile string
-	---@field combatTTL number
-	---@field combatSound boolean
-	---@field combatSoundFile string
-	---@field combatSoundThrottle number
-	---@field combatTextureFile string
-	---@field helpTTL number
-	---@field helpSound boolean
-	---@field helpSoundFile string
-	---@field helpSoundThrottle number
-	---@field helpTextureFile string
-
-	---@class HeimdallBonkDetectorConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-	---@field throttle number
-
-	---@class HeimdallNoterConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field channels string[]
-	---@field lastNotes number
-
-	---@class HeimdallNetworkConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field members string[]
-	---@field updateInterval number
-
-	---@class HeimdallNetworkMessengerConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field interval number
-
-	---@class HeimdallConfiguratorConfig
-	---@field enabled boolean
-	---@field debug boolean
-
-	---@class HeimdallStinkyCacheConfig
-	---@field enabled boolean
-	---@field debug boolean
-	---@field commander string
-	---@field ttl number
-
-	---@class HeimdallAchievementSnifferConfig
-	---@field enabled boolean
-	---@field debug boolean
-	-----@field texture string
-	-----@field offsetX number
-	-----@field offsetY number
-	---@field rescan boolean
-	---@field scanInterval number
-	-----@field iconScale number
-
-	--- Data ---
-	---@class HeimdallMessengerData
-	---@field queue table<string, Message>
-	---@field ticker Timer?
-
-	---@class HeimdallNetworkMessengerData
-	---@field queue table<string, Message>
-	---@field ticker Timer?
-
-	---@class HeimdallWhoData
-	---@field updateTicker number?
-	---@field whoTicker number?
-	---@field ignored table<string, boolean>
-
-	---@class HeimdallStinkyTrackerData
-	---@field stinkies ReactiveValue
-
-	---@class HeimdallNetworkData
-	---@field ticker number?
-
-	---@class HeimdallStinkyCacheData
-	---@field stinkies table<string, {value: number, timestamp: number}>
-
 	shared.GetOrDefault = function(table, keys, default)
 		local value = default
 		if not table then return value end
@@ -310,13 +112,6 @@ local function init()
 		return value
 	end
 
-	shared.messenger = {
-		queue = {},
-	}
-	shared.who = {
-		ignored = {},
-	}
-
 	--/run Heimdall_Data.config.who.queries="g-\"БеспредеЛ\"|ally"
 	Heimdall_Data.config = {
 		debug = shared.GetOrDefault(Heimdall_Data, { "config", "debug" }, false),
@@ -418,6 +213,7 @@ local function init()
 			enabled = shared.GetOrDefault(Heimdall_Data, { "config", "stinkyTracker", "enabled" }, false),
 			debug = shared.GetOrDefault(Heimdall_Data, { "config", "stinkyTracker", "debug" }, false),
 			channels = shared.GetOrDefault(Heimdall_Data, { "config", "stinkyTracker", "channels" }, { "Agent" }),
+			ignoredTimeout = shared.GetOrDefault(Heimdall_Data, { "config", "stinkyTracker", "ignoredTimeout" }, 600),
 		},
 		combatAlerter = {
 			enabled = shared.GetOrDefault(Heimdall_Data, { "config", "combatAlerter", "enabled" }, false),
@@ -670,7 +466,7 @@ local function init()
 	shared.Memoize = function(f)
 		local mem = {} -- memoizing table
 		setmetatable(mem, { __mode = "kv" }) -- make it weak
-		return function(x) -- new version of ’f’, with memoizing
+		return function(x) -- new version of 'f', with memoizing
 			if Heimdall_Data.config.debug then print(string.format("[Heimdall] Memoize %s", tostring(x))) end
 			local r = mem[x]
 			if r == nil then -- no previous result?
@@ -745,3 +541,69 @@ loadedFrame:RegisterEvent("ADDON_LOADED")
 loadedFrame:SetScript("OnEvent", function(self, event, addonName)
 	if addonName == addonname then init() end
 end)
+
+-- Create the import/export frame
+local ccpFrame = CreateFrame("Frame", "CCPFrame", UIParent)
+ccpFrame:SetSize(512 * 1.5, 512 * 1.5)
+ccpFrame:SetPoint("CENTER")
+ccpFrame:SetFrameStrata("HIGH")
+ccpFrame:EnableMouse(true)
+ccpFrame:SetMovable(true)
+ccpFrame:SetResizable(false)
+ccpFrame:SetBackdrop({
+	bgFile = "Interface/Tooltips/UI-Tooltip-Background",
+	edgeFile = "Interface/Tooltips/UI-Tooltip-Border",
+	tile = true,
+	tileSize = 4,
+	edgeSize = 4,
+	insets = {
+		left = 4,
+		right = 4,
+		top = 4,
+		bottom = 4,
+	},
+})
+ccpFrame:SetBackdropColor(0, 0, 0, 0.8)
+ccpFrame:SetBackdropBorderColor(0.5, 0.5, 0.5, 1)
+
+ccpFrame:SetMovable(true)
+ccpFrame:EnableMouse(true)
+ccpFrame:RegisterForDrag("LeftButton")
+ccpFrame:SetScript("OnDragStart", function(self) self:StartMoving() end)
+ccpFrame:SetScript("OnDragStop", function(self) self:StopMovingOrSizing() end)
+ccpFrame:SetScript("OnShow", function(self) self:SetScale(1) end)
+ccpFrame:Hide()
+
+-- Create scroll frame
+local scrollFrame = CreateFrame("ScrollFrame", "CCPFrameScrollFrame", ccpFrame, "UIPanelScrollFrameTemplate")
+scrollFrame:SetPoint("TOPLEFT", ccpFrame, "TOPLEFT", 10, -10)
+scrollFrame:SetPoint("BOTTOMRIGHT", ccpFrame, "BOTTOMRIGHT", -30, 10)
+
+-- Create the text box
+local ccpFrameTextBox = CreateFrame("EditBox", "CCPFrameTextBox", scrollFrame)
+ccpFrameTextBox:SetSize(512 * 1.5 - 40, 512 * 1.5 - 20)
+ccpFrameTextBox:SetPoint("TOPLEFT", scrollFrame, "TOPLEFT", 0, 0)
+ccpFrameTextBox:SetFont("Fonts\\FRIZQT__.ttf", 12)
+ccpFrameTextBox:SetTextColor(1, 1, 1, 1)
+ccpFrameTextBox:SetTextInsets(10, 10, 10, 10)
+ccpFrameTextBox:SetMultiLine(true)
+ccpFrameTextBox:SetAutoFocus(true)
+ccpFrameTextBox:SetMaxLetters(1000000)
+ccpFrameTextBox:SetScript("OnEscapePressed", function(self) ccpFrame:Hide() end)
+
+-- Set the scroll frame's scroll child
+scrollFrame:SetScrollChild(ccpFrameTextBox)
+
+CCP = function(window)
+	window = window or 1
+	local charFrame = _G["ChatFrame" .. window]
+	local maxLines = charFrame:GetNumMessages() or 0
+	local chat = {}
+	for i = 1, maxLines do
+		local currentMsg = charFrame:GetMessageInfo(i)
+		chat[#chat + 1] = currentMsg
+	end
+	ccpFrameTextBox:SetText(table.concat(chat, "\n"))
+	ccpFrame:Show()
+	ccpFrameTextBox:SetFocus()
+end

Heimdall.toc

@@ -1,6 +1,6 @@
 ## Interface: 70300
 ## Title: Heimdall
-## Version: 3.11.0
+## Version: 3.12.0
 ## Notes: Watches over areas and alerts when hostiles spotted
 ## Author: Cyka
 ## SavedVariables: Heimdall_Data, Heimdall_Achievements

Modules/AchievementSniffer.lua

@@ -2,6 +2,16 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "AchievementSniffer"
 
+---@class HeimdallAchievementSnifferConfig
+---@field enabled boolean
+---@field debug boolean
+-----@field texture string
+-----@field offsetX number
+-----@field offsetY number
+---@field rescan boolean
+---@field scanInterval number
+-----@field iconScale number
+
 -- local HeimdallRoot = "Interface\\AddOns\\Heimdall\\"
 -- local TextureRoot = HeimdallRoot .. "Texture\\"
 
@@ -74,220 +84,221 @@ local Achievements = {
 	12448,
 }
 
----@diagnostic disable-next-line: missing-fields
-shared.AchievementSniffer = {}
-function shared.AchievementSniffer.Init()
-	if Heimdall_Data.config.achievementSniffer.debug then
-		print(string.format("[%s] Module initialized", ModuleName))
-	end
-	local guidMap = {}
-
-	---@class AchievementData
-	---@field id number
-	---@field date string
-	---@field completed boolean
-
-	---@class Heimdall_Achievements
-	---@field players table<string, table<number, AchievementData>>
-	---@field alreadySeen table<string, boolean>
-	---@field rescan boolean
-	if not Heimdall_Achievements then Heimdall_Achievements = {} end
-	if not Heimdall_Achievements.players then Heimdall_Achievements.players = {} end
-	if not Heimdall_Achievements.alreadySeen then Heimdall_Achievements.alreadySeen = {} end
-
-	--local framePool = {}
-	--for i = 1, 40 do
-	--	local frame = CreateFrame("Frame", "HeimdallAchievementSnifferNameplate" .. i, UIParent)
-	--	local texture = frame:CreateTexture(nil, "ARTWORK")
-	--	texture:SetAllPoints(frame)
-	--	texture:SetTexture(TextureRoot .. Heimdall_Data.config.achievementSniffer.texture)
-	--	frame.texture = texture
-	--	frame:Hide()
-	--	table.insert(framePool, frame)
-	--end
-
-	---@param name string
-	---@return boolean
-	local function ShouldInspect(name)
-		local should = false
-		if not Heimdall_Achievements.players[name] then
-			if Heimdall_Data.config.achievementSniffer.debug then
-				print(string.format("[%s] Player %s does not have prior achievement data", ModuleName, name))
-			end
-			should = true
-		end
-		if Heimdall_Achievements.alreadySeen[name] then
-			if Heimdall_Data.config.achievementSniffer.debug then
-				print(string.format("[%s] Player %s has already been seen", ModuleName, name))
-			end
-			-- Save some memory
-			Heimdall_Achievements.players[name] = nil
-			should = false
-		end
-		if Heimdall_Data.config.achievementSniffer.rescan then
-			if Heimdall_Data.config.achievementSniffer.debug then
-				print(string.format("[%s] Rescan is enabled", ModuleName))
-			end
-			should = true
-		end
-		return should
-	end
-
-	-- It's not working well AT ALL
-	-- I don't know how to do it better
-	-- It simply just does not work...
-	--local function UpdateFrames()
-	--	for i, frame in ipairs(framePool) do
-	--		local unit = "nameplate" .. i
-	--		if not UnitExists(unit) then
-	--			--if Heimdall_Data.config.achievementSniffer.debug then
-	--			--	print(string.format("[%s] Unit %s does not exist, hiding frame", ModuleName, unit))
-	--			--end
-	--			frame:Hide()
-	--		else
-	--			--local unitFrame = _G[string.format("ElvUI_NamePlate%dHealthBar", i)]
-	--			local unitFrame = _G[string.format("NamePlate%d", i)]
-	--			if unitFrame == nil then
-	--				if Heimdall_Data.config.achievementSniffer.debug then
-	--					print(string.format("[%s] Unit frame for %s not found", ModuleName, unit))
-	--				end
-	--				frame:Hide()
-	--			else
-	--				local unitName = UnitName(unit)
-	--				if Heimdall_Data.config.achievementSniffer.debug then
-	--					print(string.format("[%s] Unit frame found for %s (%s)", ModuleName, unit, unitName))
-	--				end
-	--				frame:Show()
-	--				frame:SetSize(32, 32)
-	--				frame:SetFrameStrata("HIGH")
-	--				frame:SetFrameLevel(100)
-	--				frame:SetScale(Heimdall_Data.config.achievementSniffer.iconScale)
-	--				frame.texture:SetTexture(TextureRoot .. Heimdall_Data.config.achievementSniffer.texture)
-	--				frame:SetPoint("CENTER", unitFrame, "CENTER",
-	--					Heimdall_Data.config.achievementSniffer.offsetX,
-	--					Heimdall_Data.config.achievementSniffer.offsetY)
-	--				frame:SetParent(unitFrame)
-	--				frame:SetAlpha(1)
-	--				local exists = ShouldInspect(unitName)
-	--				if exists then
-	--					frame.texture:SetVertexColor(1, 0, 0, 1)
-	--				else
-	--					frame.texture:SetVertexColor(0, 1, 0, 1)
-	--				end
-	--				if Heimdall_Data.config.achievementSniffer.debug then
-	--					print(string.format("[%s] Frame updated for %s", ModuleName, unitName))
-	--				end
-	--			end
-	--		end
-	--	end
-	--end
-
-	---@param unit string
-	local function TryInspect(unit)
-		local targetPlayer = UnitIsPlayer(unit)
-		if not targetPlayer then return end
-		local targetName = UnitName(unit)
-		local targetGuid = UnitGUID(unit)
-		guidMap[targetGuid] = targetName
-
-		if not ShouldInspect(targetName) then
-			if Heimdall_Data.config.achievementSniffer.debug then
-				print(string.format("[%s] Not inspecting player: %s", ModuleName, targetName))
-			end
-			return
-		end
-
-		local canInspect = CheckInteractDistance(unit, 1)
-		if canInspect then
-			if Heimdall_Data.config.achievementSniffer.debug then
-				print(string.format("[%s] Inspecting player: %s", ModuleName, targetName))
-			end
-			SetAchievementComparisonUnit(unit)
-		else
-			if Heimdall_Data.config.achievementSniffer.debug then
-				print(string.format("[%s] Cannot inspect player (too far?): %s", ModuleName, targetName))
-			end
-		end
-	end
-
-	---@param name string
-	local function Scan(name)
+---@class AchievementSniffer
+shared.AchievementSniffer = {
+	Init = function()
 		if Heimdall_Data.config.achievementSniffer.debug then
-			print(string.format("[%s] Scanning achievements for %s", ModuleName, name))
+			print(string.format("[%s] Module initialized", ModuleName))
 		end
-		Heimdall_Achievements.players[name] = {}
-		for i, aid in ipairs(Achievements) do
-			local completed, month, day, year = GetAchievementComparisonInfo(aid)
-			if completed then
-				---@type string
-				local yearstr = "" .. year
-				if year < 100 then yearstr = "20" .. year end
+		local guidMap = {}
 
-				local date = string.format("%04d-%02d-%02d", yearstr, month, day)
+		---@class AchievementData
+		---@field id number
+		---@field date string
+		---@field completed boolean
 
-				local data = {
-					id = aid,
-					date = date,
-					completed = completed,
-				}
+		---@class Heimdall_Achievements
+		---@field players table<string, table<number, AchievementData>>
+		---@field alreadySeen table<string, boolean>
+		---@field rescan boolean
+		if not Heimdall_Achievements then Heimdall_Achievements = {} end
+		if not Heimdall_Achievements.players then Heimdall_Achievements.players = {} end
+		if not Heimdall_Achievements.alreadySeen then Heimdall_Achievements.alreadySeen = {} end
+
+		--local framePool = {}
+		--for i = 1, 40 do
+		--	local frame = CreateFrame("Frame", "HeimdallAchievementSnifferNameplate" .. i, UIParent)
+		--	local texture = frame:CreateTexture(nil, "ARTWORK")
+		--	texture:SetAllPoints(frame)
+		--	texture:SetTexture(TextureRoot .. Heimdall_Data.config.achievementSniffer.texture)
+		--	frame.texture = texture
+		--	frame:Hide()
+		--	table.insert(framePool, frame)
+		--end
+
+		---@param name string
+		---@return boolean
+		local function ShouldInspect(name)
+			local should = false
+			if not Heimdall_Achievements.players[name] then
 				if Heimdall_Data.config.achievementSniffer.debug then
-					print(string.format("[%s] Achievement %d completed on %s", ModuleName, aid, date))
+					print(string.format("[%s] Player %s does not have prior achievement data", ModuleName, name))
+				end
+				should = true
+			end
+			if Heimdall_Achievements.alreadySeen[name] then
+				if Heimdall_Data.config.achievementSniffer.debug then
+					print(string.format("[%s] Player %s has already been seen", ModuleName, name))
+				end
+				-- Save some memory
+				Heimdall_Achievements.players[name] = nil
+				should = false
+			end
+			if Heimdall_Data.config.achievementSniffer.rescan then
+				if Heimdall_Data.config.achievementSniffer.debug then
+					print(string.format("[%s] Rescan is enabled", ModuleName))
+				end
+				should = true
+			end
+			return should
+		end
+
+		-- It's not working well AT ALL
+		-- I don't know how to do it better
+		-- It simply just does not work...
+		--local function UpdateFrames()
+		--	for i, frame in ipairs(framePool) do
+		--		local unit = "nameplate" .. i
+		--		if not UnitExists(unit) then
+		--			--if Heimdall_Data.config.achievementSniffer.debug then
+		--			--	print(string.format("[%s] Unit %s does not exist, hiding frame", ModuleName, unit))
+		--			--end
+		--			frame:Hide()
+		--		else
+		--			--local unitFrame = _G[string.format("ElvUI_NamePlate%dHealthBar", i)]
+		--			local unitFrame = _G[string.format("NamePlate%d", i)]
+		--			if unitFrame == nil then
+		--				if Heimdall_Data.config.achievementSniffer.debug then
+		--					print(string.format("[%s] Unit frame for %s not found", ModuleName, unit))
+		--				end
+		--				frame:Hide()
+		--			else
+		--				local unitName = UnitName(unit)
+		--				if Heimdall_Data.config.achievementSniffer.debug then
+		--					print(string.format("[%s] Unit frame found for %s (%s)", ModuleName, unit, unitName))
+		--				end
+		--				frame:Show()
+		--				frame:SetSize(32, 32)
+		--				frame:SetFrameStrata("HIGH")
+		--				frame:SetFrameLevel(100)
+		--				frame:SetScale(Heimdall_Data.config.achievementSniffer.iconScale)
+		--				frame.texture:SetTexture(TextureRoot .. Heimdall_Data.config.achievementSniffer.texture)
+		--				frame:SetPoint("CENTER", unitFrame, "CENTER",
+		--					Heimdall_Data.config.achievementSniffer.offsetX,
+		--					Heimdall_Data.config.achievementSniffer.offsetY)
+		--				frame:SetParent(unitFrame)
+		--				frame:SetAlpha(1)
+		--				local exists = ShouldInspect(unitName)
+		--				if exists then
+		--					frame.texture:SetVertexColor(1, 0, 0, 1)
+		--				else
+		--					frame.texture:SetVertexColor(0, 1, 0, 1)
+		--				end
+		--				if Heimdall_Data.config.achievementSniffer.debug then
+		--					print(string.format("[%s] Frame updated for %s", ModuleName, unitName))
+		--				end
+		--			end
+		--		end
+		--	end
+		--end
+
+		---@param unit string
+		local function TryInspect(unit)
+			local targetPlayer = UnitIsPlayer(unit)
+			if not targetPlayer then return end
+			local targetName = UnitName(unit)
+			local targetGuid = UnitGUID(unit)
+			guidMap[targetGuid] = targetName
+
+			if not ShouldInspect(targetName) then
+				if Heimdall_Data.config.achievementSniffer.debug then
+					print(string.format("[%s] Not inspecting player: %s", ModuleName, targetName))
+				end
+				return
+			end
+
+			local canInspect = CheckInteractDistance(unit, 1)
+			if canInspect then
+				if Heimdall_Data.config.achievementSniffer.debug then
+					print(string.format("[%s] Inspecting player: %s", ModuleName, targetName))
+				end
+				SetAchievementComparisonUnit(unit)
+			else
+				if Heimdall_Data.config.achievementSniffer.debug then
+					print(string.format("[%s] Cannot inspect player (too far?): %s", ModuleName, targetName))
 				end
-				Heimdall_Achievements.players[name][aid] = data
 			end
 		end
-		--UpdateFrames()
-	end
 
-	local nameplateFrame = CreateFrame("Frame")
-	nameplateFrame:RegisterEvent("NAME_PLATE_UNIT_ADDED")
-	nameplateFrame:RegisterEvent("NAME_PLATE_UNIT_REMOVED")
-	nameplateFrame:SetScript("OnEvent", function(self, event, unit)
-		if not Heimdall_Data.config.achievementSniffer.enabled then return end
-		if Heimdall_Data.config.achievementSniffer.debug then
-			print(string.format("[%s] Event triggered: %s for unit: %s", ModuleName, event, unit))
-		end
-		if event == "NAME_PLATE_UNIT_ADDED" then TryInspect(unit) end
-		--UpdateFrames()
-	end)
-
-	local inspectFrame = CreateFrame("Frame")
-	inspectFrame:RegisterEvent("INSPECT_ACHIEVEMENT_READY")
-	inspectFrame:SetScript("OnEvent", function(self, event, guid)
-		if not Heimdall_Data.config.achievementSniffer.enabled then return end
-		local name = guidMap[guid]
-		if not name then
+		---@param name string
+		local function Scan(name)
 			if Heimdall_Data.config.achievementSniffer.debug then
-				print(string.format("[%s] No name found for guid: %s", ModuleName, guid))
+				print(string.format("[%s] Scanning achievements for %s", ModuleName, name))
 			end
-			return
-		end
-		if Heimdall_Data.config.achievementSniffer.debug then
-			print(string.format("[%s] Event triggered: %s for player: %s", ModuleName, event, name))
-		end
-		Scan(name)
-	end)
+			Heimdall_Achievements.players[name] = {}
+			for i, aid in ipairs(Achievements) do
+				local completed, month, day, year = GetAchievementComparisonInfo(aid)
+				if completed then
+					---@type string
+					local yearstr = "" .. year
+					if year < 100 then yearstr = "20" .. year end
 
-	local function Tick()
-		C_Timer.NewTimer(Heimdall_Data.config.achievementSniffer.scanInterval, Tick)
-		if not Heimdall_Data.config.achievementSniffer.enabled then return end
+					local date = string.format("%04d-%02d-%02d", yearstr, month, day)
 
-		if Heimdall_Data.config.achievementSniffer.debug then
-			print(string.format("[%s] Scanning achievements for everyone on screen", ModuleName))
-		end
-		for i = 1, 40 do
-			local unit = "nameplate" .. i
-			if UnitExists(unit) then
-				TryInspect(unit)
-				--else
-				--	if Heimdall_Data.config.achievementSniffer.debug then
-				--		print(string.format("[%s] Unit %s does not exist, nothing to inspect", ModuleName, unit))
-				--	end
+					local data = {
+						id = aid,
+						date = date,
+						completed = completed,
+					}
+					if Heimdall_Data.config.achievementSniffer.debug then
+						print(string.format("[%s] Achievement %d completed on %s", ModuleName, aid, date))
+					end
+					Heimdall_Achievements.players[name][aid] = data
+				end
 			end
+			--UpdateFrames()
 		end
-		--UpdateFrames()
-	end
-	Tick()
 
-	print("[Heimdall] AchievementSniffer loaded")
-end
+		local nameplateFrame = CreateFrame("Frame")
+		nameplateFrame:RegisterEvent("NAME_PLATE_UNIT_ADDED")
+		nameplateFrame:RegisterEvent("NAME_PLATE_UNIT_REMOVED")
+		nameplateFrame:SetScript("OnEvent", function(self, event, unit)
+			if not Heimdall_Data.config.achievementSniffer.enabled then return end
+			if Heimdall_Data.config.achievementSniffer.debug then
+				print(string.format("[%s] Event triggered: %s for unit: %s", ModuleName, event, unit))
+			end
+			if event == "NAME_PLATE_UNIT_ADDED" then TryInspect(unit) end
+			--UpdateFrames()
+		end)
+
+		local inspectFrame = CreateFrame("Frame")
+		inspectFrame:RegisterEvent("INSPECT_ACHIEVEMENT_READY")
+		inspectFrame:SetScript("OnEvent", function(self, event, guid)
+			if not Heimdall_Data.config.achievementSniffer.enabled then return end
+			local name = guidMap[guid]
+			if not name then
+				if Heimdall_Data.config.achievementSniffer.debug then
+					print(string.format("[%s] No name found for guid: %s", ModuleName, guid))
+				end
+				return
+			end
+			if Heimdall_Data.config.achievementSniffer.debug then
+				print(string.format("[%s] Event triggered: %s for player: %s", ModuleName, event, name))
+			end
+			Scan(name)
+		end)
+
+		local function Tick()
+			C_Timer.NewTimer(Heimdall_Data.config.achievementSniffer.scanInterval, Tick)
+			if not Heimdall_Data.config.achievementSniffer.enabled then return end
+
+			if Heimdall_Data.config.achievementSniffer.debug then
+				print(string.format("[%s] Scanning achievements for everyone on screen", ModuleName))
+			end
+			for i = 1, 40 do
+				local unit = "nameplate" .. i
+				if UnitExists(unit) then
+					TryInspect(unit)
+					--else
+					--	if Heimdall_Data.config.achievementSniffer.debug then
+					--		print(string.format("[%s] Unit %s does not exist, nothing to inspect", ModuleName, unit))
+					--	end
+				end
+			end
+			--UpdateFrames()
+		end
+		Tick()
+
+		print("[Heimdall] AchievementSniffer loaded")
+	end,
+}

Modules/AgentTracker.lua

@@ -2,118 +2,143 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "AgentTracker"
 
----@diagnostic disable-next-line: missing-fields
-shared.AgentTracker = {}
-function shared.AgentTracker.Init()
-	--/run Heimdall_Data.config.agents["Cyheuraeth"]=date("%Y-%m-%dT%H:%M:%S")
-	---@type table<string, boolean>
-	local channelRosterFrame = CreateFrame("Frame")
-	channelRosterFrame:RegisterEvent("CHANNEL_ROSTER_UPDATE")
-	channelRosterFrame:SetScript("OnEvent", function(self, event, index)
-		if Heimdall_Data.config.agentTracker.debug then
-			print(string.format("[%s] Channel roster update received", ModuleName))
-		end
-		if not Heimdall_Data.config.agentTracker.enabled then
-			if Heimdall_Data.config.agentTracker.debug then
-				print(string.format("[%s] Module disabled, ignoring roster update", ModuleName))
-			end
-			return
-		end
-		local name = GetChannelDisplayInfo(index)
-		if Heimdall_Data.config.agentTracker.debug then
-			print(string.format("[%s] Processing channel update: %s (index: %d)", ModuleName, name or "nil", index))
-		end
-		if name ~= Heimdall_Data.config.agentTracker.masterChannel then
-			if Heimdall_Data.config.agentTracker.debug then
-				print(string.format("[%s] Ignoring non-master channel: %s", ModuleName, name or "nil"))
-			end
-			return
-		end
-		local count = select(5, GetChannelDisplayInfo(index))
-		if Heimdall_Data.config.agentTracker.debug then
-			print(string.format("[%s] Processing %d members in channel", ModuleName, count))
-		end
+---@class AgentTrackerData
+---@field agents ReactiveValue<table<string, string>>
 
-		local newAgents = 0
-		for i = 1, count do
-			name = GetChannelRosterInfo(index, i)
-			if name then
-				local isNewAgent = not Heimdall_Data.config.agents[name]
-				Heimdall_Data.config.agents[name] = date("%Y-%m-%dT%H:%M:%S")
-				if isNewAgent then newAgents = newAgents + 1 end
+---@class HeimdallAgentTrackerConfig
+---@field enabled boolean
+---@field debug boolean
+---@field channels string[]
+
+---@class AgentTracker
+shared.AgentTracker = {
+	---@param name string
+	---@return boolean
+	Track = function(name)
+		if not name then return false end
+		local exists = shared.AgentTracker.IsAgent(name)
+		if exists then return false end
+		shared.agentTracker.agents[name] = date("%Y-%m-%dT%H:%M:%S")
+		-- Heimdall_Data.config.agents[name] = date("%Y-%m-%dT%H:%M:%S")
+		if Heimdall_Data.config.agentTracker.debug then
+			print(string.format("[%s] Tracking new agent: %s", ModuleName, name))
+			shared.dump(shared.agentTracker.agents)
+		end
+		return true
+	end,
+	---@param name string
+	---@return boolean
+	IsAgent = function(name)
+		if not name then return false end
+		return shared.agentTracker.agents[name] ~= nil
+	end,
+	---@param callback fun(agent: string)
+	OnChange = function(callback) shared.agentTracker.agents:onChange(callback) end,
+	---@param callback fun(agent: string)
+	ForEach = function(callback)
+		---@type table<string, string>
+		local agents = shared.agentTracker.agents:get()
+		for name, _ in pairs(agents) do
+			callback(name)
+		end
+	end,
+	---@return nil
+	Init = function()
+		shared.agentTracker = {
+			agents = ReactiveValue.new(Heimdall_Data.config.agents),
+		}
+
+		--/run Heimdall_Data.config.agents["Cyheuraeth"]=date("%Y-%m-%dT%H:%M:%S")
+		---@type table<string, boolean>
+		local channelRosterFrame = CreateFrame("Frame")
+		channelRosterFrame:RegisterEvent("CHANNEL_ROSTER_UPDATE")
+		channelRosterFrame:SetScript("OnEvent", function(self, event, index)
+			if Heimdall_Data.config.agentTracker.debug then
+				print(string.format("[%s] Channel roster update received", ModuleName))
+			end
+			if not Heimdall_Data.config.agentTracker.enabled then
 				if Heimdall_Data.config.agentTracker.debug then
-					print(
-						string.format(
-							"[%s] %s agent: %s",
-							ModuleName,
-							isNewAgent and "Added new" or "Updated existing",
-							name
-						)
-					)
+					print(string.format("[%s] Module disabled, ignoring roster update", ModuleName))
+				end
+				return
+			end
+			local name = GetChannelDisplayInfo(index)
+			if Heimdall_Data.config.agentTracker.debug then
+				print(string.format("[%s] Processing channel update: %s (index: %d)", ModuleName, name or "nil", index))
+			end
+			if name ~= Heimdall_Data.config.agentTracker.masterChannel then
+				if Heimdall_Data.config.agentTracker.debug then
+					print(string.format("[%s] Ignoring non-master channel: %s", ModuleName, name or "nil"))
+				end
+				return
+			end
+			local count = select(5, GetChannelDisplayInfo(index))
+			if Heimdall_Data.config.agentTracker.debug then
+				print(string.format("[%s] Processing %d members in channel", ModuleName, count))
+			end
+
+			local newAgents = 0
+			for i = 1, count do
+				name = GetChannelRosterInfo(index, i)
+				shared.AgentTracker.Track(name)
+			end
+
+			if Heimdall_Data.config.agentTracker.debug then
+				print(string.format("[%s] Roster update complete - Added %d new agents", ModuleName, newAgents))
+			end
+		end)
+
+		local agentTrackerChannelSniffer = CreateFrame("Frame")
+		agentTrackerChannelSniffer:RegisterEvent("CHAT_MSG_CHANNEL")
+		agentTrackerChannelSniffer:SetScript("OnEvent", function(self, event, msg, sender, ...)
+			--		if Heimdall_Data.config.agentTracker.debug then
+			--			print(string.format("[%s] Channel message received from: %s", ModuleName, sender))
+			--		end
+			if not Heimdall_Data.config.agentTracker.enabled then
+				--			if Heimdall_Data.config.agentTracker.debug then
+				--				print(string.format("[%s] Module disabled, ignoring channel message", ModuleName))
+				--			end
+				return
+			end
+
+			local channelId = select(6, ...)
+			local _, channelname = GetChannelName(channelId)
+			local ok = false
+			for _, channel in pairs(Heimdall_Data.config.agentTracker.channels) do
+				if channel == channelname then
+					ok = true
+					break
 				end
 			end
-		end
-
-		if Heimdall_Data.config.agentTracker.debug then
-			print(string.format("[%s] Roster update complete - Added %d new agents", ModuleName, newAgents))
-		end
-	end)
-
-	local agentTrackerChannelSniffer = CreateFrame("Frame")
-	agentTrackerChannelSniffer:RegisterEvent("CHAT_MSG_CHANNEL")
-	agentTrackerChannelSniffer:SetScript("OnEvent", function(self, event, msg, sender, ...)
-		--		if Heimdall_Data.config.agentTracker.debug then
-		--			print(string.format("[%s] Channel message received from: %s", ModuleName, sender))
-		--		end
-		if not Heimdall_Data.config.agentTracker.enabled then
-			--			if Heimdall_Data.config.agentTracker.debug then
-			--				print(string.format("[%s] Module disabled, ignoring channel message", ModuleName))
-			--			end
-			return
-		end
-
-		local channelId = select(6, ...)
-		local _, channelname = GetChannelName(channelId)
-		local ok = false
-		for _, channel in pairs(Heimdall_Data.config.agentTracker.channels) do
-			if channel == channelname then
-				ok = true
-				break
+			if not ok then
+				if Heimdall_Data.config.agentTracker.debug then
+					print(string.format("[%s] Channel name does not match any of the channels", ModuleName))
+				end
+				return
 			end
-		end
-		if not ok then
 			if Heimdall_Data.config.agentTracker.debug then
-				print(string.format("[%s] Channel name does not match any of the channels", ModuleName))
+				print(string.format("[%s] Processing message from master channel: %s", ModuleName, sender))
 			end
-			return
-		end
-		if Heimdall_Data.config.agentTracker.debug then
-			print(string.format("[%s] Processing message from master channel: %s", ModuleName, sender))
-			shared.dumpTable(Heimdall_Data.config.agentTracker)
-		end
 
-		sender = string.match(sender, "^[^-]+")
-		local isNewAgent = not Heimdall_Data.config.agents[sender]
-		Heimdall_Data.config.agents[sender] = date("%Y-%m-%dT%H:%M:%S")
+			sender = string.match(sender, "^[^-]+")
+			local new = shared.AgentTracker.Track(sender)
 
-		if Heimdall_Data.config.agentTracker.debug then
-			print(
-				string.format(
-					"[%s] %s agent from message: %s",
-					ModuleName,
-					isNewAgent and "Added new" or "Updated existing",
-					sender
+			if Heimdall_Data.config.agentTracker.debug then
+				print(
+					string.format(
+						"[%s] %s agent from message: %s",
+						ModuleName,
+						new and "Added new" or "Updated existing",
+						sender
+					)
 				)
-			)
-		end
-	end)
+			end
+		end)
 
-	if Heimdall_Data.config.agentTracker.debug then
-		local count = 0
-		for _ in pairs(Heimdall_Data.config.agents) do
-			count = count + 1
+		if Heimdall_Data.config.agentTracker.debug then
+			print(string.format("[%s] Module initialized", ModuleName))
+			shared.dump(shared.agentTracker.agents:get(), "Agents")
 		end
-		print(string.format("[%s] Module initialized - Tracking %d agents", ModuleName, count))
-	end
-	print("[Heimdall] AgentTracker loaded")
-end
+		print("[Heimdall] AgentTracker loaded")
+	end,
+}

Modules/BonkDetector.lua

@@ -2,133 +2,141 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "BonkDetector"
 
----@diagnostic disable-next-line: missing-fields
-shared.BonkDetector = {}
-function shared.BonkDetector.Init()
-	---@type table<string, number>
-	local lastReportTime = {}
+---@class HeimdallBonkDetectorConfig
+---@field enabled boolean
+---@field debug boolean
+---@field channels string[]
+---@field throttle number
 
-	local frame = CreateFrame("Frame")
-	frame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
-	frame:SetScript("OnEvent", function(self, event, ...)
-		--		if Heimdall_Data.config.bonkDetector.debug then
-		--			print(string.format("[%s] Combat log event received", ModuleName))
-		--		end
-		if not Heimdall_Data.config.bonkDetector.enabled then
-			--			if Heimdall_Data.config.bonkDetector.debug then
-			--				print(string.format("[%s] Module disabled, ignoring combat event", ModuleName))
-			--			end
-			return
-		end
+---@class BonkDetector
+shared.BonkDetector = {
+	---@return nil
+	Init = function()
+		---@type table<string, number>
+		local lastReportTime = {}
 
-		local subevent = select(2, ...)
-		if not subevent:find("_DAMAGE") then
-			if Heimdall_Data.config.bonkDetector.debug then
-				print(string.format("[%s] Not a damage event, ignoring: %s", ModuleName, subevent))
+		local frame = CreateFrame("Frame")
+		frame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
+		frame:SetScript("OnEvent", function(self, event, ...)
+			--		if Heimdall_Data.config.bonkDetector.debug then
+			--			print(string.format("[%s] Combat log event received", ModuleName))
+			--		end
+			if not Heimdall_Data.config.bonkDetector.enabled then
+				--			if Heimdall_Data.config.bonkDetector.debug then
+				--				print(string.format("[%s] Module disabled, ignoring combat event", ModuleName))
+				--			end
+				return
 			end
-			return
-		end
 
-		---@type string|nil, string, string, string, string
-		local err, source, sourceGUID, destination, destinationGUID
+			local subevent = select(2, ...)
+			if not subevent:find("_DAMAGE") then
+				if Heimdall_Data.config.bonkDetector.debug then
+					print(string.format("[%s] Not a damage event, ignoring: %s", ModuleName, subevent))
+				end
+				return
+			end
 
-		source, err = CLEUParser.GetSourceName(...)
-		if err then
-			if Heimdall_Data.config.bonkDetector.debug then
-				print(string.format("[%s] Error getting source name: %s", ModuleName, err))
-			end
-			return
-		end
-		sourceGUID, err = CLEUParser.GetSourceGUID(...)
-		if err then
-			if Heimdall_Data.config.bonkDetector.debug then
-				print(string.format("[%s] Error getting source GUID: %s", ModuleName, err))
-			end
-			return
-		end
-		if not string.find(sourceGUID, "Player") then
-			if Heimdall_Data.config.bonkDetector.debug then
-				print(string.format("[%s] Source %s is not a player, nothing to do", ModuleName, source))
-			end
-			return
-		end
+			---@type string|nil, string, string, string, string
+			local err, source, sourceGUID, destination, destinationGUID
 
-		destination, err = CLEUParser.GetDestName(...)
-		if err then
-			if Heimdall_Data.config.bonkDetector.debug then
-				print(string.format("[%s] Error getting destination name: %s", ModuleName, err))
+			source, err = CLEUParser.GetSourceName(...)
+			if err then
+				if Heimdall_Data.config.bonkDetector.debug then
+					print(string.format("[%s] Error getting source name: %s", ModuleName, err))
+				end
+				return
 			end
-			return
-		end
-		destinationGUID, err = CLEUParser.GetDestGUID(...)
-		if err then
-			if Heimdall_Data.config.bonkDetector.debug then
-				print(string.format("[%s] Error getting destination GUID: %s", ModuleName, err))
+			sourceGUID, err = CLEUParser.GetSourceGUID(...)
+			if err then
+				if Heimdall_Data.config.bonkDetector.debug then
+					print(string.format("[%s] Error getting source GUID: %s", ModuleName, err))
+				end
+				return
 			end
-			return
-		end
-		if not string.find(destinationGUID, "Player") then
-			if Heimdall_Data.config.bonkDetector.debug then
-				print(string.format("[%s] Destination %s is not a player, nothing to do", ModuleName, destination))
+			if not string.find(sourceGUID, "Player") then
+				if Heimdall_Data.config.bonkDetector.debug then
+					print(string.format("[%s] Source %s is not a player, nothing to do", ModuleName, source))
+				end
+				return
 			end
-			return
-		end
 
-		if source == destination then
-			if Heimdall_Data.config.bonkDetector.debug then
-				print(string.format("[%s] Source and destination are the same, ignoring event", ModuleName))
+			destination, err = CLEUParser.GetDestName(...)
+			if err then
+				if Heimdall_Data.config.bonkDetector.debug then
+					print(string.format("[%s] Error getting destination name: %s", ModuleName, err))
+				end
+				return
+			end
+			destinationGUID, err = CLEUParser.GetDestGUID(...)
+			if err then
+				if Heimdall_Data.config.bonkDetector.debug then
+					print(string.format("[%s] Error getting destination GUID: %s", ModuleName, err))
+				end
+				return
+			end
+			if not string.find(destinationGUID, "Player") then
+				if Heimdall_Data.config.bonkDetector.debug then
+					print(string.format("[%s] Destination %s is not a player, nothing to do", ModuleName, destination))
+				end
+				return
 			end
-			return
-		end
 
-		local currentTime = GetTime()
-		local throttle = Heimdall_Data.config.bonkDetector.throttle
+			if source == destination then
+				if Heimdall_Data.config.bonkDetector.debug then
+					print(string.format("[%s] Source and destination are the same, ignoring event", ModuleName))
+				end
+				return
+			end
+
+			local currentTime = GetTime()
+			local throttle = Heimdall_Data.config.bonkDetector.throttle
+
+			if lastReportTime[source] and (currentTime - lastReportTime[source]) < throttle then
+				if Heimdall_Data.config.bonkDetector.debug then
+					local timeLeft = throttle - (currentTime - lastReportTime[source])
+					print(
+						string.format(
+							"[%s] Damage report throttled for %s (%.1f seconds remaining)",
+							ModuleName,
+							source,
+							timeLeft
+						)
+					)
+				end
+				return
+			end
+
+			lastReportTime[source] = currentTime
 
-		if lastReportTime[source] and (currentTime - lastReportTime[source]) < throttle then
 			if Heimdall_Data.config.bonkDetector.debug then
-				local timeLeft = throttle - (currentTime - lastReportTime[source])
 				print(
 					string.format(
-						"[%s] Damage report throttled for %s (%.1f seconds remaining)",
+						"[%s] Processing damage event - Source: %s, Target: %s, Type: %s",
 						ModuleName,
 						source,
-						timeLeft
+						destination,
+						subevent
 					)
 				)
 			end
-			return
-		end
 
-		lastReportTime[source] = currentTime
-
-		if Heimdall_Data.config.bonkDetector.debug then
-			print(
-				string.format(
-					"[%s] Processing damage event - Source: %s, Target: %s, Type: %s",
-					ModuleName,
-					source,
-					destination,
-					subevent
-				)
-			)
-		end
-
-		for _, channel in pairs(Heimdall_Data.config.bonkDetector.channels) do
-			local locale = shared.GetLocaleForChannel(channel)
-			local msg = string.format(shared._L("bonkDetected", locale), source, destination, subevent)
-			---@type Message
-			local message = {
-				channel = "C",
-				data = channel,
-				message = msg,
-			}
-			if Heimdall_Data.config.bonkDetector.debug then
-				print(string.format("[%s] Queuing bonk detector message", ModuleName))
-				shared.dumpTable(message)
+			for _, channel in pairs(Heimdall_Data.config.bonkDetector.channels) do
+				local locale = shared.GetLocaleForChannel(channel)
+				local msg = string.format(shared._L("bonkDetected", locale), source, destination, subevent)
+				---@type Message
+				local message = {
+					channel = "C",
+					data = channel,
+					message = msg,
+				}
+				if Heimdall_Data.config.bonkDetector.debug then
+					print(string.format("[%s] Queuing bonk detector message", ModuleName))
+					shared.dump(message)
+				end
+				table.insert(shared.messenger.queue, message)
 			end
-			table.insert(shared.messenger.queue, message)
-		end
-	end)
+		end)
 
-	print("[Heimdall] BonkDetector loaded")
-end
+		print("[Heimdall] BonkDetector loaded")
+	end,
+}

Modules/Bully.lua

@@ -2,9 +2,15 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "Bully"
 
----@diagnostic disable-next-line: missing-fields
-shared.Bully = {}
-function shared.Bully.Init()
-	if Heimdall_Data.config.bully.debug then print(string.format("[%s] Module initialized", ModuleName)) end
-	print("[Heimdall] Bully loaded")
-end
+---@class HeimdallBullyConfig
+---@field enabled boolean
+---@field debug boolean
+
+---@class Bully
+shared.Bully = {
+	---@return nil
+	Init = function()
+		if Heimdall_Data.config.bully.debug then print(string.format("[%s] Module initialized", ModuleName)) end
+		print("[Heimdall] Bully loaded")
+	end,
+}

Modules/CombatAlerter.lua

@@ -2,134 +2,140 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "CombatAlerter"
 
----@diagnostic disable-next-line: missing-fields
-shared.CombatAlerter = {}
-function shared.CombatAlerter.Init()
-	local alerted = {}
-	local combatAlerterFrame = CreateFrame("Frame")
-	combatAlerterFrame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
-	combatAlerterFrame:SetScript("OnEvent", function(self, event, ...)
-		if Heimdall_Data.config.combatAlerter.debug then
-			print(string.format("[%s] Combat log event received", ModuleName))
-		end
-		if not Heimdall_Data.config.combatAlerter.enabled then
+---@class HeimdallCombatAlerterConfig
+---@field enabled boolean
+---@field debug boolean
+---@field channels string[]
+
+---@class CombatAlerter
+shared.CombatAlerter = {
+	Init = function()
+		local alerted = {}
+		local combatAlerterFrame = CreateFrame("Frame")
+		combatAlerterFrame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
+		combatAlerterFrame:SetScript("OnEvent", function(self, event, ...)
 			if Heimdall_Data.config.combatAlerter.debug then
-				print(string.format("[%s] Module disabled, ignoring combat event", ModuleName))
+				print(string.format("[%s] Combat log event received", ModuleName))
 			end
-			return
-		end
-
-		---@type string|nil, string, string
-		local err, source, destination
-
-		destination, err = CLEUParser.GetDestName(...)
-		if err then
-			if Heimdall_Data.config.combatAlerter.debug then
-				print(string.format("[%s] Error getting destination: %s", ModuleName, err))
+			if not Heimdall_Data.config.combatAlerter.enabled then
+				if Heimdall_Data.config.combatAlerter.debug then
+					print(string.format("[%s] Module disabled, ignoring combat event", ModuleName))
+				end
+				return
 			end
-			return
-		end
 
-		if Heimdall_Data.config.combatAlerter.debug then
-			print(string.format("[%s] Combat event destination: %s", ModuleName, destination))
-		end
+			---@type string|nil, string, string
+			local err, source, destination
 
-		if destination ~= UnitName("player") then
-			if Heimdall_Data.config.combatAlerter.debug then
-				print(string.format("[%s] Ignoring event - not targeted at player", ModuleName))
+			destination, err = CLEUParser.GetDestName(...)
+			if err then
+				if Heimdall_Data.config.combatAlerter.debug then
+					print(string.format("[%s] Error getting destination: %s", ModuleName, err))
+				end
+				return
 			end
-			return
-		end
 
-		source, err = CLEUParser.GetSourceName(...)
-		if err then
 			if Heimdall_Data.config.combatAlerter.debug then
-				print(string.format("[%s] Error getting source, using 'unknown': %s", ModuleName, err))
+				print(string.format("[%s] Combat event destination: %s", ModuleName, destination))
 			end
-			source = "unknown"
-		end
 
-		if Heimdall_Data.config.combatAlerter.debug then
-			print(string.format("[%s] Combat event source: %s", ModuleName, source))
-		end
+			if destination ~= UnitName("player") then
+				if Heimdall_Data.config.combatAlerter.debug then
+					print(string.format("[%s] Ignoring event - not targeted at player", ModuleName))
+				end
+				return
+			end
+
+			source, err = CLEUParser.GetSourceName(...)
+			if err then
+				if Heimdall_Data.config.combatAlerter.debug then
+					print(string.format("[%s] Error getting source, using 'unknown': %s", ModuleName, err))
+				end
+				source = "unknown"
+			end
 
-		if shared.stinkyTracker.stinkies and shared.stinkyTracker.stinkies[source] then
 			if Heimdall_Data.config.combatAlerter.debug then
-				print(
-					string.format(
-						"[%s] Source is tracked stinky: %s (Already alerted: %s)",
-						ModuleName,
-						source,
-						tostring(alerted[source] or false)
+				print(string.format("[%s] Combat event source: %s", ModuleName, source))
+			end
+
+			if shared.StinkyTracker.IsStinky(source) then
+				if Heimdall_Data.config.combatAlerter.debug then
+					print(
+						string.format(
+							"[%s] Source is tracked stinky: %s (Already alerted: %s)",
+							ModuleName,
+							source,
+							tostring(alerted[source] or false)
+						)
 					)
-				)
-			end
-			if alerted[source] then return end
+				end
+				if alerted[source] then return end
 
-			alerted[source] = true
-			local x, y = GetPlayerMapPosition("player")
-			local zone, subZone = GetZoneText(), GetSubZoneText()
+				alerted[source] = true
+				local x, y = GetPlayerMapPosition("player")
+				local zone, subZone = GetZoneText(), GetSubZoneText()
 
-			if Heimdall_Data.config.combatAlerter.debug then
-				print(
-					string.format(
-						"[%s] Player location: %s/%s at %.2f,%.2f",
-						ModuleName,
-						zone,
-						subZone,
+				if Heimdall_Data.config.combatAlerter.debug then
+					print(
+						string.format(
+							"[%s] Player location: %s/%s at %.2f,%.2f",
+							ModuleName,
+							zone,
+							subZone,
+							x * 100,
+							y * 100
+						)
+					)
+				end
+
+				SetMapToCurrentZone()
+				SetMapByID(GetCurrentMapAreaID())
+				local areaId = GetCurrentMapAreaID()
+
+				for _, channel in pairs(Heimdall_Data.config.combatAlerter.channels) do
+					local locale = shared.GetLocaleForChannel(channel)
+					local text = string.format(
+						shared._L("combatAlerterInCombat", locale),
+						source,
+						shared._L("zone", locale),
+						shared._L("subZone", locale),
+						tostring(areaId),
 						x * 100,
 						y * 100
 					)
-				)
-			end
-
-			SetMapToCurrentZone()
-			SetMapByID(GetCurrentMapAreaID())
-			local areaId = GetCurrentMapAreaID()
-
-			for _, channel in pairs(Heimdall_Data.config.combatAlerter.channels) do
-				local locale = shared.GetLocaleForChannel(channel)
-				local text = string.format(
-					shared._L("combatAlerterInCombat", locale),
-					source,
-					shared._L("zone", locale),
-					shared._L("subZone", locale),
-					tostring(areaId),
-					x * 100,
-					y * 100
-				)
-				---@type Message
-				local msg = {
-					channel = "C",
-					data = channel,
-					message = text,
-				}
-				if Heimdall_Data.config.combatAlerter.debug then
-					print(string.format("[%s] Queuing alert message", ModuleName))
-					shared.dumpTable(msg)
+					---@type Message
+					local msg = {
+						channel = "C",
+						data = channel,
+						message = text,
+					}
+					if Heimdall_Data.config.combatAlerter.debug then
+						print(string.format("[%s] Queuing alert message", ModuleName))
+						shared.dump(msg)
+					end
+					table.insert(shared.messenger.queue, msg)
 				end
-				table.insert(shared.messenger.queue, msg)
+			elseif Heimdall_Data.config.combatAlerter.debug then
+				print(string.format("[%s] Source not in stinky list, ignoring: %s", ModuleName, source))
 			end
-		elseif Heimdall_Data.config.combatAlerter.debug then
-			print(string.format("[%s] Source not in stinky list, ignoring: %s", ModuleName, source))
-		end
-	end)
+		end)
 
-	local combatTriggerFrame = CreateFrame("Frame")
-	combatTriggerFrame:RegisterEvent("PLAYER_REGEN_DISABLED")
-	combatTriggerFrame:RegisterEvent("PLAYER_REGEN_ENABLED")
-	combatTriggerFrame:SetScript("OnEvent", function(self, event, ...)
-		if Heimdall_Data.config.combatAlerter.debug then
-			print(string.format("[%s] Combat state changed: %s", ModuleName, event))
-			if event == "PLAYER_REGEN_DISABLED" then
-				print(string.format("[%s] Entered combat - Resetting alerts", ModuleName))
-			else
-				print(string.format("[%s] Left combat - Resetting alerts", ModuleName))
+		local combatTriggerFrame = CreateFrame("Frame")
+		combatTriggerFrame:RegisterEvent("PLAYER_REGEN_DISABLED")
+		combatTriggerFrame:RegisterEvent("PLAYER_REGEN_ENABLED")
+		combatTriggerFrame:SetScript("OnEvent", function(self, event, ...)
+			if Heimdall_Data.config.combatAlerter.debug then
+				print(string.format("[%s] Combat state changed: %s", ModuleName, event))
+				if event == "PLAYER_REGEN_DISABLED" then
+					print(string.format("[%s] Entered combat - Resetting alerts", ModuleName))
+				else
+					print(string.format("[%s] Left combat - Resetting alerts", ModuleName))
+				end
 			end
-		end
-		alerted = {}
-	end)
+			alerted = {}
+		end)
 
-	if Heimdall_Data.config.combatAlerter.debug then print(string.format("[%s] Module initialized", ModuleName)) end
-	print("[Heimdall] CombatAlerter loaded")
-end
+		if Heimdall_Data.config.combatAlerter.debug then print(string.format("[%s] Module initialized", ModuleName)) end
+		print("[Heimdall] CombatAlerter loaded")
+	end,
+}

Modules/Commander.lua

@@ -2,6 +2,13 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "Commander"
 
+---@class HeimdallCommanderConfig
+---@field enabled boolean
+---@field debug boolean
+---@field channels string[]
+---@field commander string
+---@field commands table<string, boolean>
+
 local helpMessages = {
 	ru = {
 		"1) who - пишет вам никнеймы текущих врагов и локу.",
@@ -31,315 +38,354 @@ local helpMessages = {
 	},
 }
 
----@diagnostic disable-next-line: missing-fields
-shared.Commander = {}
-function shared.Commander.Init()
-	---@param text string
-	---@param size number
-	---@return string[]
-	local function Partition(text, size)
-		local words = {}
-		for word in text:gmatch("[^,]+") do
-			words[#words + 1] = word
-		end
-
-		local ret = {}
-		local currentChunk = ""
-
-		for _, word in ipairs(words) do
-			if #currentChunk + #word + 1 <= size then
-				currentChunk = currentChunk .. (currentChunk == "" and word or " " .. word)
-			else
-				if #currentChunk > 0 then ret[#ret + 1] = currentChunk end
-				currentChunk = word
+---@class Commander
+shared.Commander = {
+	Init = function()
+		---@param text string
+		---@param size number
+		---@return string[]
+		local function Partition(text, size)
+			local words = {}
+			for word in text:gmatch("[^,]+") do
+				words[#words + 1] = word
 			end
-		end
 
-		if #currentChunk > 0 then ret[#ret + 1] = currentChunk end
+			local ret = {}
+			local currentChunk = ""
 
-		return ret
-	end
-	---@param arr table<string, Player>
-	---@return string[]
-	local function Count(arr)
-		local ret = {}
-		for _, player in pairs(arr) do
-			if shared.Whoer.ShouldNotifyForZone(player.zone) then ret[player.zone] = (ret[player.zone] or 0) + 1 end
-		end
-		local text = {}
-		for zone, count in pairs(ret) do
-			text[#text + 1] = string.format("%s: %d", zone, count)
-		end
-		return text
-	end
-	---@param arr table<string, Player>
-	---@return string[]
-	local function CountPartitioned(arr)
-		local count = Count(arr)
-		local text = {}
-		---@diagnostic disable-next-line: param-type-mismatch something wrong with luals, it's picking up the "wrong" unpack
-		for _, line in pairs(Partition(strjoin(", ", unpack(count)), 200)) do
-			text[#text + 1] = line
-		end
-		return text
-	end
-	---@param arr table<string, Player>
-	---@return string[]
-	local function Who(arr)
-		local ret = {}
-		for _, player in pairs(arr) do
-			if shared.Whoer.ShouldNotifyForZone(player.zone) then
-				ret[#ret + 1] = string.format(
-					"%s/%s (%s) %s",
-					player.name,
-					player.class,
-					player.zone,
-					player.stinky and "(!!!!)" or ""
-				)
+			for _, word in ipairs(words) do
+				if #currentChunk + #word + 1 <= size then
+					currentChunk = currentChunk .. (currentChunk == "" and word or " " .. word)
+				else
+					if #currentChunk > 0 then ret[#ret + 1] = currentChunk end
+					currentChunk = word
+				end
 			end
-		end
-		if Heimdall_Data.config.commander.debug then
-			print(string.format("[%s] Command result: %s", ModuleName, strjoin(", ", unpack(ret))))
-		end
-		return ret
-	end
-	---@param arr table<string, Player>
-	---@return string[]
-	local function WhoPartitioned(arr)
-		local who = Who(arr)
-		local text = {}
-		---@diagnostic disable-next-line: param-type-mismatch something wrong with luals, it's picking up the "wrong" unpack
-		for _, line in pairs(Partition(strjoin(", ", unpack(who)), 200)) do
-			text[#text + 1] = "who: " .. line
-		end
-		return text
-	end
-	---@param arr table<string, Player>
-	---@return string[]
-	local function CountClass(arr)
-		local ret = {}
-		for _, player in pairs(arr) do
-			if shared.Whoer.ShouldNotifyForZone(player.zone) then ret[player.class] = (ret[player.class] or 0) + 1 end
-		end
-		local text = {}
-		for class, count in pairs(ret) do
-			text[#text + 1] = string.format("%s: %d", class, count)
-		end
-		if Heimdall_Data.config.commander.debug then
-			print(string.format("[%s] Message text: %s", ModuleName, strjoin(", ", unpack(text))))
-		end
-		return text
-	end
-	---@param arr table<string, Player>
-	---@return string[]
-	local function CountClassPartitioned(arr)
-		local countClass = CountClass(arr)
-		local text = {}
-		---@diagnostic disable-next-line: param-type-mismatch something wrong with luals, it's picking up the "wrong" unpack
-		for _, line in pairs(Partition(strjoin(", ", unpack(countClass)), 200)) do
-			text[#text + 1] = line
-		end
-		return text
-	end
-	local function CountClassPartitionedStinkies()
-		if Heimdall_Data.config.commander.debug then
-			print(string.format("[%s] Executing: CountClassPartitionedStinkies", ModuleName))
-		end
-		local res = CountClassPartitioned(HeimdallStinkies)
-		if #res == 0 then return { "No stinkies found" } end
-		return res
-	end
-	local function WhoPartitionedStinkies()
-		if Heimdall_Data.config.commander.debug then
-			print(string.format("[%s] Executing: WhoPartitionedStinkies", ModuleName))
-			shared.dumpTable(HeimdallStinkies)
-		end
-		local res = WhoPartitioned(HeimdallStinkies)
-		if #res == 0 then return { "No stinkies found" } end
-		return res
-	end
-	local function CountPartitionedStinkies()
-		if Heimdall_Data.config.commander.debug then
-			print(string.format("[%s] Executing: CountPartitionedStinkies", ModuleName))
-		end
-		local res = CountPartitioned(HeimdallStinkies)
-		if #res == 0 then return { "No stinkies found" } end
-		return res
-	end
-	local function HelpRu()
-		if Heimdall_Data.config.commander.debug then print(string.format("[%s] Executing: HelpRu", ModuleName)) end
-		return helpMessages.ru
-	end
-	local function HelpEn()
-		if Heimdall_Data.config.commander.debug then print(string.format("[%s] Executing: HelpEn", ModuleName)) end
-		return helpMessages.en
-	end
-	local groupInviteFrame = CreateFrame("Frame")
-	groupInviteFrame:SetScript("OnEvent", function(self, event, ...)
-		if Heimdall_Data.config.commander.debug then print(string.format("[%s] Event received", ModuleName)) end
-		AcceptGroup()
-		groupInviteFrame:UnregisterEvent("PARTY_INVITE_REQUEST")
-		C_Timer.NewTimer(0.1, function()
-			if Heimdall_Data.config.commander.debug then
-				print(string.format("[%s] Click event triggered", ModuleName))
-			end
-			_G["StaticPopup1Button1"]:Click()
-		end, 1)
-	end)
-	local function JoinGroup()
-		if Heimdall_Data.config.commander.debug then
-			print(string.format("[%s] JoinGroup command received", ModuleName))
-		end
-		groupInviteFrame:RegisterEvent("PARTY_INVITE_REQUEST")
-		C_Timer.NewTimer(10, function() groupInviteFrame:UnregisterEvent("PARTY_INVITE_REQUEST") end, 1)
-		return { "+" }
-	end
-	local function LeaveGroup()
-		if Heimdall_Data.config.commander.debug then
-			print(string.format("[%s] LeaveGroup command received", ModuleName))
-		end
-		LeaveParty()
-		return {}
-	end
-	---@param target string
-	local function FollowTarget(target)
-		if Heimdall_Data.config.commander.debug then
-			print(string.format("[%s] Following target: %s", ModuleName, target))
-		end
-		if not target then return end
-		FollowUnit(target)
-		return {}
-	end
 
-	---@param args string[]
-	local function MacroTarget(args)
-		if Heimdall_Data.config.commander.debug then
+			if #currentChunk > 0 then ret[#ret + 1] = currentChunk end
+
+			return ret
+		end
+		---@param arr table<string, Player>
+		---@return string[]
+		local function Count(arr)
+			local ret = {}
+			for _, player in pairs(arr) do
+				if shared.Whoer.ShouldNotifyForZone(player.zone) then ret[player.zone] = (ret[player.zone] or 0) + 1 end
+			end
+			local text = {}
+			for zone, count in pairs(ret) do
+				text[#text + 1] = string.format("%s: %d", zone, count)
+			end
+			return text
+		end
+		---@param arr table<string, Player>
+		---@return string[]
+		local function CountPartitioned(arr)
+			local count = Count(arr)
+			local text = {}
 			---@diagnostic disable-next-line: param-type-mismatch something wrong with luals, it's picking up the "wrong" unpack
-			print(string.format("[%s] Macroing: %s", ModuleName, strjoin(" ", unpack(args))))
+			for _, line in pairs(Partition(strjoin(", ", unpack(count)), 200)) do
+				text[#text + 1] = line
+			end
+			return text
 		end
-		if #args < 2 or #args % 2 ~= 0 then
-			if #args < 2 or #args % 2 ~= 0 then
+		---@param arr table<string, Player>
+		---@return string[]
+		local function Who(arr)
+			local ret = {}
+			for _, player in pairs(arr) do
+				if shared.Whoer.ShouldNotifyForZone(player.zone) then
+					ret[#ret + 1] = string.format(
+						"%s/%s (%s) %s",
+						player.name,
+						player.class,
+						player.zone,
+						player.stinky and "(!!!!)" or ""
+					)
+				end
+			end
+			if Heimdall_Data.config.commander.debug then
+				print(string.format("[%s] Command result: %s", ModuleName, strjoin(", ", unpack(ret))))
+			end
+			return ret
+		end
+		---@param arr table<string, Player>
+		---@return string[]
+		local function WhoPartitioned(arr)
+			local who = Who(arr)
+			local text = {}
+			---@diagnostic disable-next-line: param-type-mismatch something wrong with luals, it's picking up the "wrong" unpack
+			for _, line in pairs(Partition(strjoin(", ", unpack(who)), 200)) do
+				text[#text + 1] = "who: " .. line
+			end
+			return text
+		end
+		---@param arr table<string, Player>
+		---@return string[]
+		local function CountClass(arr)
+			local ret = {}
+			for _, player in pairs(arr) do
+				if shared.Whoer.ShouldNotifyForZone(player.zone) then
+					ret[player.class] = (ret[player.class] or 0) + 1
+				end
+			end
+			local text = {}
+			for class, count in pairs(ret) do
+				text[#text + 1] = string.format("%s: %d", class, count)
+			end
+			if Heimdall_Data.config.commander.debug then
+				print(string.format("[%s] Message text: %s", ModuleName, strjoin(", ", unpack(text))))
+			end
+			return text
+		end
+		---@param arr table<string, Player>
+		---@return string[]
+		local function CountClassPartitioned(arr)
+			local countClass = CountClass(arr)
+			local text = {}
+			---@diagnostic disable-next-line: param-type-mismatch something wrong with luals, it's picking up the "wrong" unpack
+			for _, line in pairs(Partition(strjoin(", ", unpack(countClass)), 200)) do
+				text[#text + 1] = line
+			end
+			return text
+		end
+		local function CountClassPartitionedStinkies()
+			if Heimdall_Data.config.commander.debug then
+				print(string.format("[%s] Executing: CountClassPartitionedStinkies", ModuleName))
+			end
+			local res = CountClassPartitioned(HeimdallStinkies)
+			if #res == 0 then return { "No stinkies found" } end
+			return res
+		end
+		local function WhoPartitionedStinkies()
+			if Heimdall_Data.config.commander.debug then
+				print(string.format("[%s] Executing: WhoPartitionedStinkies", ModuleName))
+				shared.dump(HeimdallStinkies)
+			end
+			local res = WhoPartitioned(HeimdallStinkies)
+			if #res == 0 then return { "No stinkies found" } end
+			return res
+		end
+		local function CountPartitionedStinkies()
+			if Heimdall_Data.config.commander.debug then
+				print(string.format("[%s] Executing: CountPartitionedStinkies", ModuleName))
+			end
+			local res = CountPartitioned(HeimdallStinkies)
+			if #res == 0 then return { "No stinkies found" } end
+			return res
+		end
+		local function HelpRu()
+			if Heimdall_Data.config.commander.debug then print(string.format("[%s] Executing: HelpRu", ModuleName)) end
+			return helpMessages.ru
+		end
+		local function HelpEn()
+			if Heimdall_Data.config.commander.debug then print(string.format("[%s] Executing: HelpEn", ModuleName)) end
+			return helpMessages.en
+		end
+		local groupInviteFrame = CreateFrame("Frame")
+		groupInviteFrame:SetScript("OnEvent", function(self, event, ...)
+			if Heimdall_Data.config.commander.debug then print(string.format("[%s] Event received", ModuleName)) end
+			AcceptGroup()
+			groupInviteFrame:UnregisterEvent("PARTY_INVITE_REQUEST")
+			C_Timer.NewTimer(0.1, function()
 				if Heimdall_Data.config.commander.debug then
-					print(string.format("[%s] Invalid number of arguments for MacroTarget", ModuleName))
+					print(string.format("[%s] Click event triggered", ModuleName))
+				end
+				_G["StaticPopup1Button1"]:Click()
+			end, 1)
+		end)
+		local function JoinGroup()
+			if Heimdall_Data.config.commander.debug then
+				print(string.format("[%s] JoinGroup command received", ModuleName))
+			end
+			groupInviteFrame:RegisterEvent("PARTY_INVITE_REQUEST")
+			C_Timer.NewTimer(10, function() groupInviteFrame:UnregisterEvent("PARTY_INVITE_REQUEST") end, 1)
+			return { "+" }
+		end
+		local function LeaveGroup()
+			if Heimdall_Data.config.commander.debug then
+				print(string.format("[%s] LeaveGroup command received", ModuleName))
+			end
+			LeaveParty()
+			return {}
+		end
+		---@param target string
+		local function FollowTarget(target)
+			if Heimdall_Data.config.commander.debug then
+				print(string.format("[%s] Following target: %s", ModuleName, target))
+			end
+			if not target then return end
+			FollowUnit(target)
+			return {}
+		end
+
+		---@param args string[]
+		local function MacroTarget(args)
+			if Heimdall_Data.config.commander.debug then
+				---@diagnostic disable-next-line: param-type-mismatch something wrong with luals, it's picking up the "wrong" unpack
+				print(string.format("[%s] Macroing: %s", ModuleName, strjoin(" ", unpack(args))))
+			end
+			if #args < 2 or #args % 2 ~= 0 then
+				if #args < 2 or #args % 2 ~= 0 then
+					if Heimdall_Data.config.commander.debug then
+						print(string.format("[%s] Invalid number of arguments for MacroTarget", ModuleName))
+					end
+					return {}
+				end
+			end
+			table.remove(args, 1)
+
+			for i = 1, #args do
+				local stinky = strtrim(args[i])
+				local name = stinky:match("([^/]+)")
+				local class = stinky:match("/([^ $]+)")
+				if Heimdall_Data.config.commander.debug then
+					print(string.format("[%s] Adding stinky: %s/%s", ModuleName, name, tostring(class)))
+				end
+				shared.StinkyTracker.Track({
+					name = name,
+					class = class or "unknown",
+					seenAt = GetTime(),
+					hostile = true,
+				})
+				if Heimdall_Data.config.commander.debug then
+					print(string.format("[%s] Added stinky: %s/%s", ModuleName, name, tostring(class)))
+				end
+			end
+			return {}
+		end
+
+		---@param args string[]
+		local function IgnoreMacroTarget(args)
+			if Heimdall_Data.config.commander.debug then
+				---@diagnostic disable-next-line: param-type-mismatch something wrong with luals, it's picking up the "wrong" unpack
+				print(string.format("[%s] Macroing: %s", ModuleName, strjoin(" ", unpack(args))))
+			end
+			if #args < 1 then
+				if Heimdall_Data.config.commander.debug then
+					print(string.format("[%s] Invalid number of arguments for IgnoreMacroTarget", ModuleName))
 				end
 				return {}
 			end
-		end
-		table.remove(args, 1)
+			table.remove(args, 1)
 
-		for i = 1, #args do
-			local stinky = strtrim(args[i])
-			local name = stinky:match("([^/]+)")
-			local class = stinky:match("/([^ $]+)")
-			if Heimdall_Data.config.commander.debug then
-				print(string.format("[%s] Adding stinky: %s/%s", ModuleName, name, tostring(class)))
+			for i = 1, #args do
+				local stinky = strtrim(args[i])
+				local name = stinky:match("([^/]+)")
+				if Heimdall_Data.config.commander.debug then
+					print(string.format("[%s] Ignoring stinky: %s", ModuleName, name))
+				end
+				shared.StinkyTracker.Ignore(name)
 			end
-			shared.stinkyTracker.stinkies[name] = {
-				name = name,
-				class = class or "unknown",
-				seenAt = GetTime(),
-				hostile = true,
-			}
+			return {}
 		end
-		return {}
-	end
 
-	---@class Command
-	---@field keywordRe string
-	---@field commanderOnly boolean
-	---@field callback fun(...: any): string[]
+		---@class Command
+		---@field keywordRe string
+		---@field commanderOnly boolean
+		---@field callback fun(...: any): string[]
 
-	local commands = {
-		{ keywordRe = "^who$", commanderOnly = false, callback = WhoPartitionedStinkies },
-		{ keywordRe = "^howmany$", commanderOnly = false, callback = CountPartitionedStinkies },
-		{ keywordRe = "^classes$", commanderOnly = false, callback = CountClassPartitionedStinkies },
-		{ keywordRe = "^help$", commanderOnly = false, callback = HelpRu },
-		{ keywordRe = "^helpen$", commanderOnly = false, callback = HelpEn },
-		{ keywordRe = "^joingroup$", commanderOnly = false, callback = JoinGroup },
-		{ keywordRe = "^leavegroup$", commanderOnly = false, callback = LeaveGroup },
-		{ keywordRe = "^follow$", commanderOnly = false, callback = FollowTarget },
-		{ keywordRe = "^macro", commanderOnly = false, callback = MacroTarget },
-	}
+		local commands = {
+			{ keywordRe = "^who$", commanderOnly = false, callback = WhoPartitionedStinkies },
+			{ keywordRe = "^howmany$", commanderOnly = false, callback = CountPartitionedStinkies },
+			{ keywordRe = "^classes$", commanderOnly = false, callback = CountClassPartitionedStinkies },
+			{ keywordRe = "^help$", commanderOnly = false, callback = HelpRu },
+			{ keywordRe = "^helpen$", commanderOnly = false, callback = HelpEn },
+			{ keywordRe = "^joingroup$", commanderOnly = false, callback = JoinGroup },
+			{ keywordRe = "^leavegroup$", commanderOnly = false, callback = LeaveGroup },
+			{ keywordRe = "^follow$", commanderOnly = false, callback = FollowTarget },
+			{ keywordRe = "^macro", commanderOnly = false, callback = MacroTarget },
+			{ keywordRe = "^ignore", commanderOnly = false, callback = IgnoreMacroTarget },
+		}
 
-	local commanderChannelFrame = CreateFrame("Frame")
-	commanderChannelFrame:RegisterEvent("CHAT_MSG_CHANNEL")
-	commanderChannelFrame:SetScript("OnEvent", function(self, event, msg, sender, ...)
-		--if Heimdall_Data.config.commander.debug then
-		--	print(string.format("[%s] Event received", ModuleName))
-		--	shared.dumpTable(Heimdall_Data.config.commander)
-		--end
-		if not Heimdall_Data.config.commander.enabled then
+		local commanderChannelFrame = CreateFrame("Frame")
+		commanderChannelFrame:RegisterEvent("CHAT_MSG_CHANNEL")
+		commanderChannelFrame:SetScript("OnEvent", function(self, event, msg, sender, ...)
 			--if Heimdall_Data.config.commander.debug then
-			--	print(string.format("[%s] Module disabled, ignoring event", ModuleName))
+			--	print(string.format("[%s] Event received", ModuleName))
+			--	shared.dump(Heimdall_Data.config.commander)
 			--end
-			return
-		end
-		local channelId = select(6, ...)
-		local _, channelname = GetChannelName(channelId)
-		local ok = false
-		for _, channel in pairs(Heimdall_Data.config.commander.channels) do
-			if channel == channelname then
-				ok = true
-				break
+			if not Heimdall_Data.config.commander.enabled then
+				--if Heimdall_Data.config.commander.debug then
+				--	print(string.format("[%s] Module disabled, ignoring event", ModuleName))
+				--end
+				return
 			end
-		end
-		if not ok then
-			if Heimdall_Data.config.commander.debug then
-				print(
-					string.format(
-						"[%s] Channel name '%s' does not match any of the channels '%s'",
-						ModuleName,
-						channelname,
-						table.concat(Heimdall_Data.config.commander.channels, ", ")
+			local channelId = select(6, ...)
+			local _, channelname = GetChannelName(channelId)
+			local ok = false
+			for _, channel in pairs(Heimdall_Data.config.commander.channels) do
+				if channel == channelname then
+					ok = true
+					break
+				end
+			end
+			if not ok then
+				if Heimdall_Data.config.commander.debug then
+					print(
+						string.format(
+							"[%s] Channel name '%s' does not match any of the channels '%s'",
+							ModuleName,
+							channelname,
+							table.concat(Heimdall_Data.config.commander.channels, ", ")
+						)
 					)
-				)
+				end
+				return
 			end
-			return
-		end
 
-		sender = string.match(sender, "^[^-]+")
-		if Heimdall_Data.config.commander.debug then
-			print(string.format("[%s] Message from: %s", ModuleName, sender))
-			shared.dumpTable(Heimdall_Data.config.commander)
-		end
-
-		for _, command in ipairs(commands) do
-			local enabled = Heimdall_Data.config.commander.commands[command.keywordRe] == true or false
+			sender = string.match(sender, "^[^-]+")
 			if Heimdall_Data.config.commander.debug then
-				print(string.format("[%s] Command match: %s = %s", ModuleName, command.keywordRe, tostring(enabled)))
+				print(string.format("[%s] Message from: %s", ModuleName, sender))
+				shared.dump(Heimdall_Data.config.commander)
 			end
-			if
-				enabled
-				and (
-					not command.commanderOnly
-					or (command.commanderOnly and sender == Heimdall_Data.config.commander.commander)
-				)
-			then
-				if msg:match(command.keywordRe) then
-					---@diagnostic disable-next-line: redundant-parameter Currently luals does not support variadic functions as a @field
-					local messages = command.callback({ strsplit(",", msg) })
-					if Heimdall_Data.config.commander.debug then
-						---@diagnostic disable-next-line: param-type-mismatch
-						print(string.format("[%s] Messages to send: %s", ModuleName, strjoin(", ", unpack(messages))))
-					end
-					for _, message in ipairs(messages) do
-						---@type Message
-						local returnmsg = {
-							channel = "C",
-							data = channelname,
-							message = message,
-						}
+
+			for _, command in ipairs(commands) do
+				local enabled = Heimdall_Data.config.commander.commands[command.keywordRe] == true or false
+				if Heimdall_Data.config.commander.debug then
+					print(
+						string.format("[%s] Command match: %s = %s", ModuleName, command.keywordRe, tostring(enabled))
+					)
+				end
+				if
+					enabled
+					and (
+						not command.commanderOnly
+						-- if Heimdall_Data.config.commander.debug then print(string.format("[%s] Ignoring command, sender %s not commander %s", ModuleName, sender, Heimdall_Data.config.commander.commander)) end
+
+						or (command.commanderOnly and sender == Heimdall_Data.config.commander.commander)
+					)
+				then
+					if msg:match(command.keywordRe) then
+						---@diagnostic disable-next-line: redundant-parameter Currently luals does not support variadic functions as a @field
+						local messages = command.callback({ strsplit(",", msg) })
 						if Heimdall_Data.config.commander.debug then
-							print(string.format("[%s] Queuing message", ModuleName))
-							shared.dumpTable(msg)
+							print(string.format("[%s] Messages to send: %s", ModuleName, #messages))
+							shared.dump(messages)
+						end
+						for _, message in ipairs(messages) do
+							---@type Message
+							local returnmsg = {
+								channel = "C",
+								data = channelname,
+								message = message,
+							}
+							if Heimdall_Data.config.commander.debug then
+								print(string.format("[%s] Queuing message", ModuleName))
+								shared.dump(msg)
+							end
+							if Heimdall_Data.config.networkMessenger.enabled then
+								shared.NetworkMessenger.Enqueue(returnmsg)
+							elseif Heimdall_Data.config.messenger.enabled then
+								shared.Messenger.Enqueue(returnmsg)
+							end
 						end
-						--table.insert(shared.messenger.queue, msg)
-						table.insert(shared.networkMessenger.queue, returnmsg)
 					end
 				end
 			end
-		end
-	end)
+		end)
 
-	print("[Heimdall] Commander module loaded")
-end
+		print("[Heimdall] Commander module loaded")
+	end,
+}

Modules/Configurator.lua

@@ -2,6 +2,11 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "Configurator"
 
----@diagnostic disable-next-line: missing-fields
-shared.Configurator = {}
-function shared.Configurator.Init() print(string.format("[Heimdall] %s module loaded", ModuleName)) end
+---@class HeimdallConfiguratorConfig
+---@field enabled boolean
+---@field debug boolean
+
+---@class Configurator
+shared.Configurator = {
+	Init = function() print(string.format("[Heimdall] %s module loaded", ModuleName)) end,
+}

Modules/DeathReporter.lua

@@ -2,93 +2,65 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "DeathReporter"
 
----@diagnostic disable-next-line: missing-fields
-shared.DeathReporter = {}
-function shared.DeathReporter.Init()
-	---@type table<string, number>
-	local recentDeaths = {}
-	---@type table<string, number>
-	local recentDuels = {}
+---@class HeimdallDeathReporterConfig
+---@field enabled boolean
+---@field debug boolean
+---@field throttle number
+---@field doWhisper boolean
+---@field channels string[]
+---@field zoneOverride string?
+---@field duelThrottle number
 
-	---@param source string
-	---@param destination string
-	---@param spellName string
-	local function RegisterDeath(source, destination, spellName)
-		if Heimdall_Data.config.deathReporter.debug then
-			print(
-				string.format(
-					"[%s] Processing death event - Source: %s, Target: %s, Spell: %s",
-					ModuleName,
-					source,
-					destination,
-					spellName
-				)
-			)
-		end
+---@class DeathReporter
+shared.DeathReporter = {
+	Init = function()
+		---@type table<string, number>
+		local recentDeaths = {}
+		---@type table<string, number>
+		local recentDuels = {}
 
-		if not Heimdall_Data.config.deathReporter.enabled then
+		---@param source string
+		---@param destination string
+		---@param spellName string
+		local function RegisterDeath(source, destination, spellName)
 			if Heimdall_Data.config.deathReporter.debug then
-				print(string.format("[%s] Module disabled, ignoring death event", ModuleName))
-			end
-			return
-		end
-
-		if
-			recentDeaths[destination]
-			and GetTime() - recentDeaths[destination] < Heimdall_Data.config.deathReporter.throttle
-		then
-			if Heimdall_Data.config.deathReporter.debug then
-				local timeLeft = Heimdall_Data.config.deathReporter.throttle - (GetTime() - recentDeaths[destination])
 				print(
 					string.format(
-						"[%s] Death report throttled for %s (%.1f seconds remaining)",
+						"[%s] Processing death event - Source: %s, Target: %s, Spell: %s",
 						ModuleName,
+						source,
 						destination,
-						timeLeft
+						spellName
 					)
 				)
 			end
-			return
-		end
 
-		if
-			recentDuels[destination]
-			and GetTime() - recentDuels[destination] < Heimdall_Data.config.deathReporter.duelThrottle
-		then
-			if Heimdall_Data.config.deathReporter.debug then
-				print(
-					string.format(
-						"[%s] Ignoring death report - Recent duel detected for target: %s",
-						ModuleName,
-						destination
-					)
-				)
+			if not Heimdall_Data.config.deathReporter.enabled then
+				if Heimdall_Data.config.deathReporter.debug then
+					print(string.format("[%s] Module disabled, ignoring death event", ModuleName))
+				end
+				return
 			end
-			return
-		end
 
-		if
-			recentDuels[source]
-			and GetTime() - recentDuels[source] < Heimdall_Data.config.deathReporter.duelThrottle
-		then
-			if Heimdall_Data.config.deathReporter.debug then
-				print(
-					string.format(
-						"[%s] Ignoring death report - Recent duel detected for source: %s",
-						ModuleName,
-						source
+			if
+				recentDeaths[destination]
+				and GetTime() - recentDeaths[destination] < Heimdall_Data.config.deathReporter.throttle
+			then
+				if Heimdall_Data.config.deathReporter.debug then
+					local timeLeft = Heimdall_Data.config.deathReporter.throttle
+						- (GetTime() - recentDeaths[destination])
+					print(
+						string.format(
+							"[%s] Death report throttled for %s (%.1f seconds remaining)",
+							ModuleName,
+							destination,
+							timeLeft
+						)
 					)
-				)
+				end
+				return
 			end
-			return
-		end
 
-		if Heimdall_Data.config.deathReporter.debug then
-			print(string.format("[%s] Recording death for %s", ModuleName, destination))
-		end
-		recentDeaths[destination] = GetTime()
-
-		C_Timer.NewTimer(3, function()
 			if
 				recentDuels[destination]
 				and GetTime() - recentDuels[destination] < Heimdall_Data.config.deathReporter.duelThrottle
@@ -96,7 +68,7 @@ function shared.DeathReporter.Init()
 				if Heimdall_Data.config.deathReporter.debug then
 					print(
 						string.format(
-							"[%s] Cancelling delayed death report - Recent duel detected for: %s",
+							"[%s] Ignoring death report - Recent duel detected for target: %s",
 							ModuleName,
 							destination
 						)
@@ -112,7 +84,7 @@ function shared.DeathReporter.Init()
 				if Heimdall_Data.config.deathReporter.debug then
 					print(
 						string.format(
-							"[%s] Cancelling delayed death report - Recent duel detected for: %s",
+							"[%s] Ignoring death report - Recent duel detected for source: %s",
 							ModuleName,
 							source
 						)
@@ -122,131 +94,175 @@ function shared.DeathReporter.Init()
 			end
 
 			if Heimdall_Data.config.deathReporter.debug then
-				print(
-					string.format(
-						"[%s] Sending death report - %s killed %s with %s",
-						ModuleName,
+				print(string.format("[%s] Recording death for %s", ModuleName, destination))
+			end
+			recentDeaths[destination] = GetTime()
+
+			C_Timer.NewTimer(3, function()
+				if
+					recentDuels[destination]
+					and GetTime() - recentDuels[destination] < Heimdall_Data.config.deathReporter.duelThrottle
+				then
+					if Heimdall_Data.config.deathReporter.debug then
+						print(
+							string.format(
+								"[%s] Cancelling delayed death report - Recent duel detected for: %s",
+								ModuleName,
+								destination
+							)
+						)
+					end
+					return
+				end
+
+				if
+					recentDuels[source]
+					and GetTime() - recentDuels[source] < Heimdall_Data.config.deathReporter.duelThrottle
+				then
+					if Heimdall_Data.config.deathReporter.debug then
+						print(
+							string.format(
+								"[%s] Cancelling delayed death report - Recent duel detected for: %s",
+								ModuleName,
+								source
+							)
+						)
+					end
+					return
+				end
+
+				if Heimdall_Data.config.deathReporter.debug then
+					print(
+						string.format(
+							"[%s] Sending death report - %s killed %s with %s",
+							ModuleName,
+							source,
+							destination,
+							spellName
+						)
+					)
+				end
+
+				local zone, subzone = GetZoneText() or "Unknown", GetSubZoneText() or "Unknown"
+				if Heimdall_Data.config.spotter.zoneOverride then
+					zone = Heimdall_Data.config.spotter.zoneOverride or ""
+					subzone = ""
+				end
+
+				local x, y = GetPlayerMapPosition("player")
+				if Heimdall_Data.config.deathReporter.debug then
+					print(string.format("[%s] Player coordinates: %.2f, %.2f", ModuleName, x * 100, y * 100))
+				end
+				SetMapToCurrentZone()
+				SetMapByID(GetCurrentMapAreaID())
+				local zoneId = GetCurrentMapAreaID()
+
+				for _, channel in pairs(Heimdall_Data.config.deathReporter.channels) do
+					local locale = shared.GetLocaleForChannel(channel)
+					local text = string.format(
+						shared._L("killed", locale),
 						source,
 						destination,
-						spellName
+						shared._L(spellName, locale),
+						shared._L(zone, locale),
+						shared._L(subzone, locale),
+						zoneId,
+						x * 100,
+						y * 100
+					)
+					---@type Message
+					local msg = {
+						channel = "C",
+						data = channel,
+						message = text,
+					}
+					if Heimdall_Data.config.deathReporter.debug then
+						print(string.format("[%s] Queuing death report message", ModuleName))
+						shared.dump(msg)
+					end
+					table.insert(shared.messenger.queue, msg)
+				end
+			end)
+		end
+
+		local cleuFrame = CreateFrame("Frame")
+		cleuFrame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
+		cleuFrame:SetScript("OnEvent", function(self, event, ...)
+			--		if Heimdall_Data.config.deathReporter.debug then
+			--			print(string.format("[%s] Received combat log event", ModuleName))
+			--		end
+			if not Heimdall_Data.config.deathReporter.enabled then return end
+			local overkill, source, destination, spellName, sourceGUID, destinationGUID, err
+			overkill, err = CLEUParser.GetOverkill(...)
+			if not err and overkill > 0 then
+				source, err = CLEUParser.GetSourceName(...)
+				if err then
+					source = "unknown"
+					if Heimdall_Data.config.deathReporter.debug then
+						print(string.format("[%s] Error getting source name", ModuleName))
+					end
+				end
+				destination, err = CLEUParser.GetDestName(...)
+				if err then
+					destination = "unknown"
+					if Heimdall_Data.config.deathReporter.debug then
+						print(string.format("[%s] Error getting destination name", ModuleName))
+					end
+				end
+				spellName, err = CLEUParser.GetSpellName(...)
+				if err then
+					spellName = "unknown"
+					if Heimdall_Data.config.deathReporter.debug then
+						print(string.format("[%s] Error getting spell name", ModuleName))
+					end
+				end
+				sourceGUID, err = CLEUParser.GetSourceGUID(...)
+				if err or not string.match(sourceGUID, "Player") then return end
+				destinationGUID, err = CLEUParser.GetDestGUID(...)
+				if err or not string.match(destinationGUID, "Player") then return end
+				RegisterDeath(source, destination, spellName)
+			end
+		end)
+
+		local systemMessageFrame = CreateFrame("Frame")
+		systemMessageFrame:RegisterEvent("CHAT_MSG_SYSTEM")
+		systemMessageFrame:SetScript("OnEvent", function(self, event, msg)
+			if not Heimdall_Data.config.deathReporter.enabled then return end
+			local source, destination = string.match(msg, "([^ ]+) has defeated ([^ ]+) in a duel")
+			if Heimdall_Data.config.deathReporter.debug then
+				print(string.format("[%s] Received system message: %s", ModuleName, msg))
+				print(
+					string.format(
+						"[%s] Source: %s, Destination: %s",
+						ModuleName,
+						tostring(source),
+						tostring(destination)
 					)
 				)
 			end
-
-			local zone, subzone = GetZoneText() or "Unknown", GetSubZoneText() or "Unknown"
-			if Heimdall_Data.config.spotter.zoneOverride then
-				zone = Heimdall_Data.config.spotter.zoneOverride or ""
-				subzone = ""
-			end
-
-			local x, y = GetPlayerMapPosition("player")
-			if Heimdall_Data.config.deathReporter.debug then
-				print(string.format("[%s] Player coordinates: %.2f, %.2f", ModuleName, x * 100, y * 100))
-			end
-			SetMapToCurrentZone()
-			SetMapByID(GetCurrentMapAreaID())
-			local zoneId = GetCurrentMapAreaID()
-
-			for _, channel in pairs(Heimdall_Data.config.deathReporter.channels) do
-				local locale = shared.GetLocaleForChannel(channel)
-				local text = string.format(
-					shared._L("killed", locale),
-					source,
-					destination,
-					shared._L(spellName, locale),
-					shared._L(zone, locale),
-					shared._L(subzone, locale),
-					zoneId,
-					x * 100,
-					y * 100
-				)
-				---@type Message
-				local msg = {
-					channel = "C",
-					data = channel,
-					message = text,
-				}
+			if not source or not destination then return end
+			source = string.match(source, "([^-]+)")
+			destination = string.match(destination, "([^-]+)")
+			if source and destination then
 				if Heimdall_Data.config.deathReporter.debug then
-					print(string.format("[%s] Queuing death report message", ModuleName))
-					shared.dumpTable(msg)
+					print(string.format("[%s] Detected duel between %s and %s", ModuleName, source, destination))
 				end
-				table.insert(shared.messenger.queue, msg)
+				local now = GetTime()
+				recentDuels[source] = now
+				recentDuels[destination] = now
 			end
 		end)
-	end
 
-	local cleuFrame = CreateFrame("Frame")
-	cleuFrame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
-	cleuFrame:SetScript("OnEvent", function(self, event, ...)
-		--		if Heimdall_Data.config.deathReporter.debug then
-		--			print(string.format("[%s] Received combat log event", ModuleName))
-		--		end
-		if not Heimdall_Data.config.deathReporter.enabled then return end
-		local overkill, source, destination, spellName, sourceGUID, destinationGUID, err
-		overkill, err = CLEUParser.GetOverkill(...)
-		if not err and overkill > 0 then
-			source, err = CLEUParser.GetSourceName(...)
-			if err then
-				source = "unknown"
-				if Heimdall_Data.config.deathReporter.debug then
-					print(string.format("[%s] Error getting source name", ModuleName))
-				end
-			end
-			destination, err = CLEUParser.GetDestName(...)
-			if err then
-				destination = "unknown"
-				if Heimdall_Data.config.deathReporter.debug then
-					print(string.format("[%s] Error getting destination name", ModuleName))
-				end
-			end
-			spellName, err = CLEUParser.GetSpellName(...)
-			if err then
-				spellName = "unknown"
-				if Heimdall_Data.config.deathReporter.debug then
-					print(string.format("[%s] Error getting spell name", ModuleName))
-				end
-			end
-			sourceGUID, err = CLEUParser.GetSourceGUID(...)
-			if err or not string.match(sourceGUID, "Player") then return end
-			destinationGUID, err = CLEUParser.GetDestGUID(...)
-			if err or not string.match(destinationGUID, "Player") then return end
-			RegisterDeath(source, destination, spellName)
-		end
-	end)
-
-	local systemMessageFrame = CreateFrame("Frame")
-	systemMessageFrame:RegisterEvent("CHAT_MSG_SYSTEM")
-	systemMessageFrame:SetScript("OnEvent", function(self, event, msg)
-		if not Heimdall_Data.config.deathReporter.enabled then return end
-		local source, destination = string.match(msg, "([^ ]+) has defeated ([^ ]+) in a duel")
 		if Heimdall_Data.config.deathReporter.debug then
-			print(string.format("[%s] Received system message: %s", ModuleName, msg))
 			print(
-				string.format("[%s] Source: %s, Destination: %s", ModuleName, tostring(source), tostring(destination))
+				string.format(
+					"[%s] Module initialized with throttle: %.1fs, duel throttle: %.1fs",
+					ModuleName,
+					Heimdall_Data.config.deathReporter.throttle,
+					Heimdall_Data.config.deathReporter.duelThrottle
+				)
 			)
 		end
-		if not source or not destination then return end
-		source = string.match(source, "([^-]+)")
-		destination = string.match(destination, "([^-]+)")
-		if source and destination then
-			if Heimdall_Data.config.deathReporter.debug then
-				print(string.format("[%s] Detected duel between %s and %s", ModuleName, source, destination))
-			end
-			local now = GetTime()
-			recentDuels[source] = now
-			recentDuels[destination] = now
-		end
-	end)
-
-	if Heimdall_Data.config.deathReporter.debug then
-		print(
-			string.format(
-				"[%s] Module initialized with throttle: %.1fs, duel throttle: %.1fs",
-				ModuleName,
-				Heimdall_Data.config.deathReporter.throttle,
-				Heimdall_Data.config.deathReporter.duelThrottle
-			)
-		)
-	end
-	print("[Heimdall] DeathReporter loaded")
-end
+		print("[Heimdall] DeathReporter loaded")
+	end,
+}

Modules/Dueler.lua

@@ -2,54 +2,62 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "Dueler"
 
----@diagnostic disable-next-line: missing-fields
-shared.Dueler = {}
-function shared.Dueler.Init()
-	local frame = CreateFrame("Frame")
-	frame:RegisterEvent("DUEL_REQUESTED")
-	frame:SetScript("OnEvent", function(self, event, sender)
-		if Heimdall_Data.config.dueler.debug then
-			print(string.format("[%s] Duel request received from: %s", ModuleName, sender))
-		end
-		if not Heimdall_Data.config.dueler.enabled then
-			if Heimdall_Data.config.dueler.debug then
-				print(string.format("[%s] Module disabled, ignoring duel request", ModuleName))
-			end
-			return
-		end
+---@class HeimdallDuelerConfig
+---@field enabled boolean
+---@field debug boolean
+---@field declineOther boolean
 
-		if Heimdall_Data.config.dueler.debug then
-			print(string.format("[%s] Checking if sender '%s' is in agents list", ModuleName, sender))
-		end
-
-		local allow = Heimdall_Data.config.agents[sender]
-		if allow then
+---@class Dueler
+shared.Dueler = {
+	Init = function()
+		local frame = CreateFrame("Frame")
+		frame:RegisterEvent("DUEL_REQUESTED")
+		frame:SetScript("OnEvent", function(self, event, sender)
 			if Heimdall_Data.config.dueler.debug then
-				print(string.format("[%s] Accepting duel from trusted agent: %s", ModuleName, sender))
+				print(string.format("[%s] Duel request received from: %s", ModuleName, sender))
 			end
-			AcceptDuel()
-		else
-			if Heimdall_Data.config.dueler.declineOther then
+			if not Heimdall_Data.config.dueler.enabled then
 				if Heimdall_Data.config.dueler.debug then
-					print(string.format("[%s] Auto-declining duel from untrusted sender: %s", ModuleName, sender))
+					print(string.format("[%s] Module disabled, ignoring duel request", ModuleName))
 				end
-				CancelDuel()
+				return
+			end
+
+			if Heimdall_Data.config.dueler.debug then
+				print(string.format("[%s] Checking if sender '%s' is in agents list", ModuleName, sender))
+			end
+
+			local allow = shared.AgentTracker.IsAgent(sender)
+			if allow then
+				if Heimdall_Data.config.dueler.debug then
+					print(string.format("[%s] Accepting duel from trusted agent: %s", ModuleName, sender))
+				end
+				AcceptDuel()
 			else
-				if Heimdall_Data.config.dueler.debug then
-					print(string.format("[%s] Leaving duel request from %s for manual response", ModuleName, sender))
+				if Heimdall_Data.config.dueler.declineOther then
+					if Heimdall_Data.config.dueler.debug then
+						print(string.format("[%s] Auto-declining duel from untrusted sender: %s", ModuleName, sender))
+					end
+					CancelDuel()
+				else
+					if Heimdall_Data.config.dueler.debug then
+						print(
+							string.format("[%s] Leaving duel request from %s for manual response", ModuleName, sender)
+						)
+					end
 				end
 			end
-		end
-	end)
+		end)
 
-	if Heimdall_Data.config.dueler.debug then
-		print(
-			string.format(
-				"[%s] Module initialized with auto-decline: %s",
-				ModuleName,
-				tostring(Heimdall_Data.config.dueler.declineOther)
+		if Heimdall_Data.config.dueler.debug then
+			print(
+				string.format(
+					"[%s] Module initialized with auto-decline: %s",
+					ModuleName,
+					tostring(Heimdall_Data.config.dueler.declineOther)
+				)
 			)
-		)
-	end
-	print("[Heimdall] Dueler loaded")
-end
+		end
+		print("[Heimdall] Dueler loaded")
+	end,
+}

Modules/DumpTable.lua

@@ -1,25 +1,31 @@
 local _, shared = ...
 ---@cast shared HeimdallShared
 
-if not shared.dumpTable then
-	---@param table table
+if not shared.dump then
+	---@param value any
+	---@param msg string?
 	---@param depth number?
-	shared.dumpTable = function(table, depth)
-		if not table then
-			print(tostring(table))
+	shared.dump = function(value, msg, depth)
+		if not value then
+			print(tostring(value))
 			return
 		end
+		if type(value) ~= "table" then
+			print(tostring(value))
+			return
+		end
+		if msg then print(msg) end
 		if depth == nil then depth = 0 end
 		if depth > 200 then
-			print("Error: Depth > 200 in dumpTable()")
+			print("Error: Depth > 200 in dump()")
 			return
 		end
-		for k, v in pairs(table) do
+		for k, v in pairs(value) do
 			if type(v) == "table" then
-				print(string.rep("  ", depth) .. k .. ":")
-				shared.dumpTable(v, depth + 1)
+				print(string.rep("  ", depth) .. tostring(k) .. ":")
+				shared.dump(v, msg, depth + 1)
 			else
-				print(string.rep("  ", depth) .. k .. ": ", v)
+				print(string.rep("  ", depth) .. tostring(k) .. ": " .. tostring(v))
 			end
 		end
 	end

Modules/Echoer.lua

@@ -2,57 +2,64 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "Echoer"
 
----@diagnostic disable-next-line: missing-fields
-shared.Echoer = {}
-function shared.Echoer.Init()
-	local frame = CreateFrame("Frame")
-	frame:RegisterEvent("CHAT_MSG_CHANNEL")
-	frame:SetScript("OnEvent", function(self, event, msg, sender, ...)
-		--if Heimdall_Data.config.echoer.debug then
-		--	print(string.format("[%s] Channel message received from: %s", ModuleName, sender))
-		--end
+---@class HeimdallEchoerConfig
+---@field enabled boolean
+---@field debug boolean
+---@field channels string[]
+---@field prefix string
 
-		if not Heimdall_Data.config.echoer.enabled then
+---@class Echoer
+shared.Echoer = {
+	Init = function()
+		local frame = CreateFrame("Frame")
+		frame:RegisterEvent("CHAT_MSG_CHANNEL")
+		frame:SetScript("OnEvent", function(self, event, msg, sender, ...)
 			--if Heimdall_Data.config.echoer.debug then
-			--	print(string.format("[%s] Module disabled, ignoring message", ModuleName))
+			--	print(string.format("[%s] Channel message received from: %s", ModuleName, sender))
 			--end
-			return
-		end
 
-		local channelId = select(6, ...)
-		local _, channelname = GetChannelName(channelId)
-		local ok = false
-		for _, channel in pairs(Heimdall_Data.config.echoer.channels) do
-			if channel == channelname then
-				ok = true
-				break
+			if not Heimdall_Data.config.echoer.enabled then
+				--if Heimdall_Data.config.echoer.debug then
+				--	print(string.format("[%s] Module disabled, ignoring message", ModuleName))
+				--end
+				return
 			end
-		end
-		if not ok then
-			if Heimdall_Data.config.echoer.debug then
-				print(string.format("[%s] Channel name does not match any of the channels", ModuleName))
-			end
-			return
-		end
-		if Heimdall_Data.config.echoer.debug then
-			print(string.format("[%s] Processing message from master channel: %s", ModuleName, sender))
-			shared.dumpTable(Heimdall_Data.config.echoer)
-		end
 
-		if string.find(msg, "^" .. Heimdall_Data.config.echoer.prefix) then
-			if Heimdall_Data.config.echoer.debug then
-				print(string.format("[%s] Found echo command in message: %s", ModuleName, msg))
+			local channelId = select(6, ...)
+			local _, channelname = GetChannelName(channelId)
+			local ok = false
+			for _, channel in pairs(Heimdall_Data.config.echoer.channels) do
+				if channel == channelname then
+					ok = true
+					break
+				end
 			end
-			local echomsg = string.sub(msg, string.len(Heimdall_Data.config.echoer.prefix) + 1)
-			if Heimdall_Data.config.echoer.debug then
-				print(string.format("[%s] Echoing message: %s", ModuleName, echomsg))
+			if not ok then
+				if Heimdall_Data.config.echoer.debug then
+					print(string.format("[%s] Channel name does not match any of the channels", ModuleName))
+				end
+				return
+			end
+			if Heimdall_Data.config.echoer.debug then
+				print(string.format("[%s] Processing message from master channel: %s", ModuleName, sender))
+				shared.dump(Heimdall_Data.config.echoer)
 			end
-			SendChatMessage(echomsg, "SAY")
-		elseif Heimdall_Data.config.echoer.debug then
-			print(string.format("[%s] Message does not start with echo prefix", ModuleName))
-		end
-	end)
 
-	if Heimdall_Data.config.echoer.debug then print(string.format("[%s] Module initialized", ModuleName)) end
-	print("[Heimdall] Echoer loaded")
-end
+			if string.find(msg, "^" .. Heimdall_Data.config.echoer.prefix) then
+				if Heimdall_Data.config.echoer.debug then
+					print(string.format("[%s] Found echo command in message: %s", ModuleName, msg))
+				end
+				local echomsg = string.sub(msg, string.len(Heimdall_Data.config.echoer.prefix) + 1)
+				if Heimdall_Data.config.echoer.debug then
+					print(string.format("[%s] Echoing message: %s", ModuleName, echomsg))
+				end
+				SendChatMessage(echomsg, "SAY")
+			elseif Heimdall_Data.config.echoer.debug then
+				print(string.format("[%s] Message does not start with echo prefix", ModuleName))
+			end
+		end)
+
+		if Heimdall_Data.config.echoer.debug then print(string.format("[%s] Module initialized", ModuleName)) end
+		print("[Heimdall] Echoer loaded")
+	end,
+}

Modules/Emoter.lua

@@ -2,58 +2,65 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "Emoter"
 
----@diagnostic disable-next-line: missing-fields
-shared.Emoter = {}
-function shared.Emoter.Init()
-	local frame = CreateFrame("Frame")
-	frame:RegisterEvent("CHAT_MSG_CHANNEL")
-	frame:SetScript("OnEvent", function(self, event, msg, sender, ...)
-		--if Heimdall_Data.config.emoter.debug then
-		--	print(string.format("[%s] Channel message received from: %s", ModuleName, sender))
-		--end
+---@class HeimdallEmoterConfig
+---@field enabled boolean
+---@field debug boolean
+---@field channels string[]
+---@field prefix string
 
-		if not Heimdall_Data.config.emoter.enabled then
+---@class Emoter
+shared.Emoter = {
+	Init = function()
+		local frame = CreateFrame("Frame")
+		frame:RegisterEvent("CHAT_MSG_CHANNEL")
+		frame:SetScript("OnEvent", function(self, event, msg, sender, ...)
 			--if Heimdall_Data.config.emoter.debug then
-			--	print(string.format("[%s] Module disabled, ignoring message", ModuleName))
+			--	print(string.format("[%s] Channel message received from: %s", ModuleName, sender))
 			--end
-			return
-		end
 
-		local channelId = select(6, ...)
-		local _, channelname = GetChannelName(channelId)
-		local ok = false
-		for _, channel in pairs(Heimdall_Data.config.emoter.channels) do
-			if channel == channelname then
-				ok = true
-				break
+			if not Heimdall_Data.config.emoter.enabled then
+				--if Heimdall_Data.config.emoter.debug then
+				--	print(string.format("[%s] Module disabled, ignoring message", ModuleName))
+				--end
+				return
 			end
-		end
-		if not ok then
+
+			local channelId = select(6, ...)
+			local _, channelname = GetChannelName(channelId)
+			local ok = false
+			for _, channel in pairs(Heimdall_Data.config.emoter.channels) do
+				if channel == channelname then
+					ok = true
+					break
+				end
+			end
+			if not ok then
+				if Heimdall_Data.config.emoter.debug then
+					print(string.format("[%s] Channel name does not match any of the channels", ModuleName))
+				end
+				return
+			end
+
 			if Heimdall_Data.config.emoter.debug then
-				print(string.format("[%s] Channel name does not match any of the channels", ModuleName))
+				print(string.format("[%s] Processing message from master channel: %s", ModuleName, sender))
+				shared.dump(Heimdall_Data.config.emoter)
 			end
-			return
-		end
 
-		if Heimdall_Data.config.emoter.debug then
-			print(string.format("[%s] Processing message from master channel: %s", ModuleName, sender))
-			shared.dumpTable(Heimdall_Data.config.emoter)
-		end
-
-		if string.find(msg, "^" .. Heimdall_Data.config.emoter.prefix) then
-			if Heimdall_Data.config.emoter.debug then
-				print(string.format("[%s] Found emote command in message: %s", ModuleName, msg))
+			if string.find(msg, "^" .. Heimdall_Data.config.emoter.prefix) then
+				if Heimdall_Data.config.emoter.debug then
+					print(string.format("[%s] Found emote command in message: %s", ModuleName, msg))
+				end
+				local emote = string.sub(msg, string.len(Heimdall_Data.config.emoter.prefix) + 1)
+				if Heimdall_Data.config.emoter.debug then
+					print(string.format("[%s] Performing emote: %s", ModuleName, emote))
+				end
+				DoEmote(emote)
+			elseif Heimdall_Data.config.emoter.debug then
+				print(string.format("[%s] Message does not start with emote prefix", ModuleName))
 			end
-			local emote = string.sub(msg, string.len(Heimdall_Data.config.emoter.prefix) + 1)
-			if Heimdall_Data.config.emoter.debug then
-				print(string.format("[%s] Performing emote: %s", ModuleName, emote))
-			end
-			DoEmote(emote)
-		elseif Heimdall_Data.config.emoter.debug then
-			print(string.format("[%s] Message does not start with emote prefix", ModuleName))
-		end
-	end)
+		end)
 
-	if Heimdall_Data.config.emoter.debug then print(string.format("[%s] Module initialized", ModuleName)) end
-	print("[Heimdall] Emoter loaded")
-end
+		if Heimdall_Data.config.emoter.debug then print(string.format("[%s] Module initialized", ModuleName)) end
+		print("[Heimdall] Emoter loaded")
+	end,
+}

Modules/Inviter.lua

@@ -2,262 +2,274 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "Inviter"
 
----@diagnostic disable-next-line: missing-fields
-shared.Inviter = {}
-function shared.Inviter.Init()
-	-- Fallback for old config
-	if type(Heimdall_Data.config.inviter.listeningChannel) == "string" then
-		Heimdall_Data.config.inviter.listeningChannel = {
-			[Heimdall_Data.config.inviter.listeningChannel] = true,
-		}
-	end
-	---@type Timer
-	local updateTimer = nil
+---@class HeimdallInviterConfig
+---@field enabled boolean
+---@field debug boolean
+---@field channels string[]
+---@field keyword string
+---@field allAssist boolean
+---@field agentsAssist boolean
+---@field throttle number
+---@field kickOffline boolean
+---@field cleanupInterval number
+---@field afkThreshold number
+---@field listeningChannel table<string, boolean>
 
-	local function FixGroup()
-		if Heimdall_Data.config.inviter.debug then
-			print(string.format("[%s] Checking and fixing group configuration", ModuleName))
+---@class Inviter
+shared.Inviter = {
+	Init = function()
+		-- Fallback for old config
+		if type(Heimdall_Data.config.inviter.listeningChannel) == "string" then
+			Heimdall_Data.config.inviter.listeningChannel = {
+				[Heimdall_Data.config.inviter.listeningChannel] = true,
+			}
 		end
+		---@type Timer
+		local updateTimer = nil
 
-		if not IsInRaid() then
+		local function FixGroup()
 			if Heimdall_Data.config.inviter.debug then
-				print(string.format("[%s] Converting party to raid", ModuleName))
-			end
-			ConvertToRaid()
-		end
-
-		if Heimdall_Data.config.inviter.allAssist then
-			if Heimdall_Data.config.inviter.debug then
-				print(string.format("[%s] Setting all members to assistant", ModuleName))
-			end
-			SetEveryoneIsAssistant()
-		end
-
-		if Heimdall_Data.config.inviter.agentsAssist then
-			if Heimdall_Data.config.inviter.debug then
-				local agentCount = 0
-				for _ in pairs(Heimdall_Data.config.agents) do
-					agentCount = agentCount + 1
-				end
-				print(string.format("[%s] Processing %d agents for assistant promotion", ModuleName, agentCount))
+				print(string.format("[%s] Checking and fixing group configuration", ModuleName))
 			end
 
-			for name, _ in pairs(Heimdall_Data.config.agents) do
-				if UnitInParty(name) and not UnitIsGroupLeader(name) and not UnitIsRaidOfficer(name) then
-					if Heimdall_Data.config.inviter.debug then
-						print(string.format("[%s] Promoting agent to assistant: %s", ModuleName, name))
-					end
-					PromoteToAssistant(name, true)
-				elseif Heimdall_Data.config.inviter.debug then
-					if not UnitInParty(name) then
-						print(string.format("[%s] Agent not in party: %s", ModuleName, name))
-					elseif UnitIsGroupLeader(name) then
-						print(string.format("[%s] Agent is already leader: %s", ModuleName, name))
-					elseif UnitIsRaidOfficer(name) then
-						print(string.format("[%s] Agent is already assistant: %s", ModuleName, name))
-					end
-				end
-			end
-		end
-
-		if Heimdall_Data.config.inviter.debug then
-			print(string.format("[%s] Group configuration update complete", ModuleName))
-		end
-	end
-
-	---@param name string
-	---@return Frame?
-	local function FindPlayerRaidFrame(name)
-		for group = 1, 8 do
-			for player = 1, 5 do
-				local button = _G[string.format("ElvUF_RaidGroup%dUnitButton%d", group, player)]
+			if not IsInRaid() then
 				if Heimdall_Data.config.inviter.debug then
-					print(string.format("[%s] button = %s", ModuleName, tostring(button)))
-				end
-
-				local unitName = button and button.unit and UnitName(button.unit)
-				if Heimdall_Data.config.inviter.debug then
-					print(string.format("[%s] unitName = %s", ModuleName, tostring(unitName)))
-				end
-				if unitName == name then
-					if Heimdall_Data.config.inviter.debug then
-						print(string.format("[%s] unitName == name", ModuleName))
-					end
-					return button
+					print(string.format("[%s] Converting party to raid", ModuleName))
 				end
+				ConvertToRaid()
 			end
-		end
-		return nil
-	end
 
-	local framePool = {}
-	local playerButtons = {}
-	setmetatable(playerButtons, { __mode = "kv" })
-	---@param players string[]
-	local function OverlayKickButtons(players)
-		for _, frame in pairs(framePool) do
-			frame:Hide()
-		end
-		for _, name in pairs(players) do
-			local frame = FindPlayerRaidFrame(name)
-			if frame then
-				playerButtons[name] = frame
-				-- All of these are ELVUI specific so they won't be in our meta...
-				---@diagnostic disable-next-line: undefined-field
-				local button = framePool[frame.unit]
-					or CreateFrame(
-						"Button",
-						---@diagnostic disable-next-line: undefined-field
-						string.format("HeimdallKickButton%s", frame.unit, frame, "SecureActionButtonTemplate")
-					)
-				---@diagnostic disable-next-line: undefined-field
-				framePool[frame.unit] = button
+			if Heimdall_Data.config.inviter.allAssist then
+				if Heimdall_Data.config.inviter.debug then
+					print(string.format("[%s] Setting all members to assistant", ModuleName))
+				end
+				SetEveryoneIsAssistant()
+			end
 
-				---@diagnostic disable-next-line: undefined-field
-				button:SetSize(frame.UNIT_WIDTH / 2, frame.UNIT_HEIGHT / 2)
-				button:SetPoint("CENTER", frame, "CENTER", 0, 0)
-				button:SetNormalTexture("Interface\\Buttons\\UI-GroupLoot-KickIcon")
-				button:SetHighlightTexture("Interface\\Buttons\\UI-GroupLoot-KickIcon")
-				button:SetPushedTexture("Interface\\Buttons\\UI-GroupLoot-KickIcon")
-				button:SetDisabledTexture("Interface\\Buttons\\UI-GroupLoot-KickIcon")
-				button:SetAlpha(0.5)
-				button:Show()
-				button:SetScript("OnClick", function()
-					UninviteUnit(name)
-					button:Hide()
+			if Heimdall_Data.config.inviter.agentsAssist then
+				if Heimdall_Data.config.inviter.debug then
+					print(string.format("[%s] Processing agents for assistant promotion", ModuleName))
+				end
+
+				shared.AgentTracker.ForEach(function(agent)
+					if UnitInParty(agent) and not UnitIsGroupLeader(agent) and not UnitIsRaidOfficer(agent) then
+						if Heimdall_Data.config.inviter.debug then
+							print(string.format("[%s] Promoting agent to assistant: %s", ModuleName, agent))
+						end
+						PromoteToAssistant(agent, true)
+					elseif Heimdall_Data.config.inviter.debug then
+						if not UnitInParty(agent) then
+							print(string.format("[%s] Agent not in party: %s", ModuleName, agent))
+						elseif UnitIsGroupLeader(agent) then
+							print(string.format("[%s] Agent is already leader: %s", ModuleName, agent))
+						elseif UnitIsRaidOfficer(agent) then
+							print(string.format("[%s] Agent is already assistant: %s", ModuleName, agent))
+						end
+					end
 				end)
-			else
-				if Heimdall_Data.config.inviter.debug then
-					print(string.format("[%s] Frame for player %s not found", ModuleName, name))
-				end
+			end
+
+			if Heimdall_Data.config.inviter.debug then
+				print(string.format("[%s] Group configuration update complete", ModuleName))
 			end
 		end
-	end
 
-	---@type table<string, number>
-	local groupMembers = {}
-	local function CleanGroups()
-		if not Heimdall_Data.config.inviter.kickOffline then return end
-		print("Cleaning groups")
-		local now = GetTime()
-		for i = 1, 40 do
-			local unit = "raid" .. i
-			if UnitExists(unit) then
-				local name = UnitName(unit)
-				if name then
-					-- When we load (into game) we want to consider everyone "online"
-					-- In other words everyone we haven't seen before is "online" the first time we see them
-					-- This is to avoid kicking people who might not be offline which we don't know because we just logged in
-					if not groupMembers[name] then
-						groupMembers[name] = now
-					else
-						local online = UnitIsConnected(unit)
-						if online then groupMembers[name] = now end
+		---@param name string
+		---@return Frame?
+		local function FindPlayerRaidFrame(name)
+			for group = 1, 8 do
+				for player = 1, 5 do
+					local button = _G[string.format("ElvUF_RaidGroup%dUnitButton%d", group, player)]
+					if Heimdall_Data.config.inviter.debug then
+						print(string.format("[%s] button = %s", ModuleName, tostring(button)))
+					end
+
+					local unitName = button and button.unit and UnitName(button.unit)
+					if Heimdall_Data.config.inviter.debug then
+						print(string.format("[%s] unitName = %s", ModuleName, tostring(unitName)))
+					end
+					if unitName == name then
+						if Heimdall_Data.config.inviter.debug then
+							print(string.format("[%s] unitName == name", ModuleName))
+						end
+						return button
+					end
+				end
+			end
+			return nil
+		end
+
+		local framePool = {}
+		local playerButtons = {}
+		setmetatable(playerButtons, { __mode = "kv" })
+		---@param players string[]
+		local function OverlayKickButtons(players)
+			for _, frame in pairs(framePool) do
+				frame:Hide()
+			end
+			for _, name in pairs(players) do
+				local frame = FindPlayerRaidFrame(name)
+				if frame then
+					playerButtons[name] = frame
+					-- All of these are ELVUI specific so they won't be in our meta...
+					---@diagnostic disable-next-line: undefined-field
+					local button = framePool[frame.unit]
+						or CreateFrame(
+							"Button",
+							---@diagnostic disable-next-line: undefined-field
+							string.format("HeimdallKickButton%s", frame.unit, frame, "SecureActionButtonTemplate")
+						)
+					---@diagnostic disable-next-line: undefined-field
+					framePool[frame.unit] = button
+
+					---@diagnostic disable-next-line: undefined-field
+					button:SetSize(frame.UNIT_WIDTH / 2, frame.UNIT_HEIGHT / 2)
+					button:SetPoint("CENTER", frame, "CENTER", 0, 0)
+					button:SetNormalTexture("Interface\\Buttons\\UI-GroupLoot-KickIcon")
+					button:SetHighlightTexture("Interface\\Buttons\\UI-GroupLoot-KickIcon")
+					button:SetPushedTexture("Interface\\Buttons\\UI-GroupLoot-KickIcon")
+					button:SetDisabledTexture("Interface\\Buttons\\UI-GroupLoot-KickIcon")
+					button:SetAlpha(0.5)
+					button:Show()
+					button:SetScript("OnClick", function()
+						UninviteUnit(name)
+						button:Hide()
+					end)
+				else
+					if Heimdall_Data.config.inviter.debug then
+						print(string.format("[%s] Frame for player %s not found", ModuleName, name))
 					end
 				end
 			end
 		end
-		local afkPlayers = {}
-		for name, time in pairs(groupMembers) do
-			if not UnitInParty(name) then
-				print(string.format("%s no longer in party", name))
-				groupMembers[name] = nil
-			else
-				if time < now - Heimdall_Data.config.inviter.afkThreshold then
-					print(string.format("Kicking %s for being offline", name))
-					afkPlayers[#afkPlayers + 1] = name
-					-- Blyat this is protected...
-					-- UninviteUnit(name)
+
+		---@type table<string, number>
+		local groupMembers = {}
+		local function CleanGroups()
+			if not Heimdall_Data.config.inviter.kickOffline then return end
+			print("Cleaning groups")
+			local now = GetTime()
+			for i = 1, 40 do
+				local unit = "raid" .. i
+				if UnitExists(unit) then
+					local name = UnitName(unit)
+					if name then
+						-- When we load (into game) we want to consider everyone "online"
+						-- In other words everyone we haven't seen before is "online" the first time we see them
+						-- This is to avoid kicking people who might not be offline which we don't know because we just logged in
+						if not groupMembers[name] then
+							groupMembers[name] = now
+						else
+							local online = UnitIsConnected(unit)
+							if online then groupMembers[name] = now end
+						end
+					end
 				end
 			end
-		end
-		OverlayKickButtons(afkPlayers)
-	end
-	local function Tick()
-		CleanGroups()
-		C_Timer.NewTimer(Heimdall_Data.config.inviter.cleanupInterval, Tick, 1)
-	end
-	Tick()
-
-	local groupRosterUpdateFrame = CreateFrame("Frame")
-	groupRosterUpdateFrame:RegisterEvent("GROUP_ROSTER_UPDATE")
-	groupRosterUpdateFrame:SetScript("OnEvent", function(self, event, ...)
-		if Heimdall_Data.config.inviter.debug then
-			print(string.format("[%s] Event received: %s", ModuleName, event))
-		end
-
-		if not Heimdall_Data.config.inviter.enabled then
-			if Heimdall_Data.config.inviter.debug then
-				print(string.format("[%s] Module disabled, ignoring event", ModuleName))
+			local afkPlayers = {}
+			for name, time in pairs(groupMembers) do
+				if not UnitInParty(name) then
+					print(string.format("%s no longer in party", name))
+					groupMembers[name] = nil
+				else
+					if time < now - Heimdall_Data.config.inviter.afkThreshold then
+						print(string.format("Kicking %s for being offline", name))
+						afkPlayers[#afkPlayers + 1] = name
+						-- Blyat this is protected...
+						-- UninviteUnit(name)
+					end
+				end
 			end
-			return
+			OverlayKickButtons(afkPlayers)
 		end
+		local function Tick()
+			CleanGroups()
+			C_Timer.NewTimer(Heimdall_Data.config.inviter.cleanupInterval, Tick, 1)
+		end
+		Tick()
+
+		local groupRosterUpdateFrame = CreateFrame("Frame")
+		groupRosterUpdateFrame:RegisterEvent("GROUP_ROSTER_UPDATE")
+		groupRosterUpdateFrame:SetScript("OnEvent", function(self, event, ...)
+			if Heimdall_Data.config.inviter.debug then
+				print(string.format("[%s] Event received: %s", ModuleName, event))
+			end
+
+			if not Heimdall_Data.config.inviter.enabled then
+				if Heimdall_Data.config.inviter.debug then
+					print(string.format("[%s] Module disabled, ignoring event", ModuleName))
+				end
+				return
+			end
+
+			if Heimdall_Data.config.inviter.debug then
+				print(string.format("[%s] Group roster changed - Checking configuration", ModuleName))
+			end
+			if updateTimer then updateTimer:Cancel() end
+			updateTimer = C_Timer.NewTimer(Heimdall_Data.config.inviter.throttle, FixGroup)
+		end)
+
+		local inviterChannelFrame = CreateFrame("Frame")
+		inviterChannelFrame:RegisterEvent("CHAT_MSG_CHANNEL")
+		inviterChannelFrame:SetScript("OnEvent", function(self, event, msg, sender, ...)
+			--if Heimdall_Data.config.inviter.debug then
+			--	print(string.format("[%s] Chat message received: %s", ModuleName, msg))
+			--	shared.dump(Heimdall_Data.config.inviter)
+			--end
+			if not Heimdall_Data.config.inviter.enabled then return end
+			local channelId = select(6, ...)
+			local _, channelname = GetChannelName(channelId)
+			if Heimdall_Data.config.inviter.debug then
+				print(string.format("[%s] Channel name: %s", ModuleName, channelname))
+			end
+
+			local ok = false
+			for _, channel in pairs(Heimdall_Data.config.inviter.channels) do
+				if channel == channelname then
+					ok = true
+					break
+				end
+			end
+
+			if not ok then
+				if Heimdall_Data.config.inviter.debug then
+					print(string.format("[%s] Channel name does not match any of the channels", ModuleName))
+				end
+				return
+			end
+			if msg == Heimdall_Data.config.inviter.keyword then
+				if Heimdall_Data.config.inviter.debug then
+					print(string.format("[%s] Inviting %s", ModuleName, sender))
+				end
+				InviteUnit(sender)
+			else
+				if Heimdall_Data.config.inviter.debug then
+					print(string.format("[%s] Message does not match keyword", ModuleName))
+				end
+			end
+		end)
 
 		if Heimdall_Data.config.inviter.debug then
-			print(string.format("[%s] Group roster changed - Checking configuration", ModuleName))
-		end
-		if updateTimer then updateTimer:Cancel() end
-		updateTimer = C_Timer.NewTimer(Heimdall_Data.config.inviter.throttle, FixGroup)
-	end)
-
-	local inviterChannelFrame = CreateFrame("Frame")
-	inviterChannelFrame:RegisterEvent("CHAT_MSG_CHANNEL")
-	inviterChannelFrame:SetScript("OnEvent", function(self, event, msg, sender, ...)
-		--if Heimdall_Data.config.inviter.debug then
-		--	print(string.format("[%s] Chat message received: %s", ModuleName, msg))
-		--	shared.dumpTable(Heimdall_Data.config.inviter)
-		--end
-		if not Heimdall_Data.config.inviter.enabled then return end
-		local channelId = select(6, ...)
-		local _, channelname = GetChannelName(channelId)
-		if Heimdall_Data.config.inviter.debug then
-			print(string.format("[%s] Channel name: %s", ModuleName, channelname))
-		end
-
-		local ok = false
-		for _, channel in pairs(Heimdall_Data.config.inviter.channels) do
-			if channel == channelname then
-				ok = true
-				break
-			end
-		end
-
-		if not ok then
-			if Heimdall_Data.config.inviter.debug then
-				print(string.format("[%s] Channel name does not match any of the channels", ModuleName))
-			end
-			return
-		end
-		if msg == Heimdall_Data.config.inviter.keyword then
-			if Heimdall_Data.config.inviter.debug then print(string.format("[%s] Inviting %s", ModuleName, sender)) end
-			InviteUnit(sender)
-		else
-			if Heimdall_Data.config.inviter.debug then
-				print(string.format("[%s] Message does not match keyword", ModuleName))
-			end
-		end
-	end)
-
-	if Heimdall_Data.config.inviter.debug then
-		print(
-			string.format(
-				"[%s] Module initialized - All assist: %s, Agents assist: %s",
-				ModuleName,
-				tostring(Heimdall_Data.config.inviter.allAssist),
-				tostring(Heimdall_Data.config.inviter.agentsAssist)
+			print(
+				string.format(
+					"[%s] Module initialized - All assist: %s, Agents assist: %s",
+					ModuleName,
+					tostring(Heimdall_Data.config.inviter.allAssist),
+					tostring(Heimdall_Data.config.inviter.agentsAssist)
+				)
 			)
-		)
-	end
+		end
 
-	if Heimdall_Data.config.inviter.debug then
-		print(
-			string.format(
-				"[%s] Module initialized - All assist: %s, Agents assist: %s",
-				ModuleName,
-				tostring(Heimdall_Data.config.inviter.allAssist),
-				tostring(Heimdall_Data.config.inviter.agentsAssist)
+		if Heimdall_Data.config.inviter.debug then
+			print(
+				string.format(
+					"[%s] Module initialized - All assist: %s, Agents assist: %s",
+					ModuleName,
+					tostring(Heimdall_Data.config.inviter.allAssist),
+					tostring(Heimdall_Data.config.inviter.agentsAssist)
+				)
 			)
-		)
-	end
-	print("[Heimdall] Inviter loaded")
-end
+		end
+		print("[Heimdall] Inviter loaded")
+	end,
+}

Modules/Macroer.lua

@@ -2,100 +2,100 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "Macroer"
 
----@diagnostic disable-next-line: missing-fields
-shared.Macroer = {}
-function shared.Macroer.Init()
-	---@class stinky
-	---@field name string
-	---@field class string
-	---@field seenAt number
-	---@field hostile boolean
+---@class HeimdallMacroerConfig
+---@field enabled boolean
+---@field debug boolean
+---@field priority string[]
 
-	local function FindOrCreateMacro(macroName)
-		if Heimdall_Data.config.macroer.debug then
-			print(string.format("[%s] Finding or creating macro: %s", ModuleName, macroName))
-		end
-		local idx = GetMacroIndexByName(macroName)
-		if idx == 0 then
+---@class Macroer
+shared.Macroer = {
+	Init = function()
+		local function FindOrCreateMacro(macroName)
 			if Heimdall_Data.config.macroer.debug then
-				print(string.format("[%s] Creating new macro: %s", ModuleName, macroName))
+				print(string.format("[%s] Finding or creating macro: %s", ModuleName, macroName))
 			end
-			CreateMacro(macroName, "INV_Misc_QuestionMark", "")
-		end
-		idx = GetMacroIndexByName(macroName)
-		if Heimdall_Data.config.macroer.debug then print(string.format("[%s] Macro index: %d", ModuleName, idx)) end
-		return idx
-	end
-
-	---@param stinkies table<string, stinky>
-	local function FixMacro(stinkies)
-		if Heimdall_Data.config.macroer.debug then
-			print(string.format("[%s] Fixing macro with %d stinkies", ModuleName, #stinkies))
-		end
-		if not Heimdall_Data.config.macroer.enabled then
-			if Heimdall_Data.config.macroer.debug then
-				print(string.format("[%s] Module disabled, skipping macro update", ModuleName))
-			end
-			return
-		end
-		if InCombatLockdown() then
-			if Heimdall_Data.config.macroer.debug then
-				print(string.format("[%s] In combat, skipping macro update", ModuleName))
-			end
-			return
-		end
-
-		local priorityMap = {}
-		for priority, className in ipairs(Heimdall_Data.config.macroer.priority) do
-			priorityMap[className] = priority
-		end
-		local minPriority = #Heimdall_Data.config.macroer.priority + 1
-
-		local sortedStinkies = {}
-		for _, stinky in pairs(stinkies) do
-			if not Heimdall_Data.config.agents[stinky.name] then sortedStinkies[#sortedStinkies + 1] = stinky end
-		end
-
-		if Heimdall_Data.config.macroer.debug then
-			print(string.format("[%s] Processing %d non-agent stinkies", ModuleName, #sortedStinkies))
-		end
-
-		table.sort(sortedStinkies, function(a, b)
-			local aPriority = priorityMap[a.class] or minPriority
-			local bPriority = priorityMap[b.class] or minPriority
-			return aPriority > bPriority
-		end)
-
-		if Heimdall_Data.config.macroer.debug then
-			print(string.format("[%s] Sorted stinkies: %d", ModuleName, #sortedStinkies))
-			shared.dumpTable(sortedStinkies)
-		end
-		local lines = { "/targetenemy" }
-		for _, stinky in pairs(sortedStinkies) do
-			if stinky.seenAt > GetTime() - 600 then
+			local idx = GetMacroIndexByName(macroName)
+			if idx == 0 then
 				if Heimdall_Data.config.macroer.debug then
-					print(string.format("[%s] Adding target macro for: %s", ModuleName, stinky.name))
+					print(string.format("[%s] Creating new macro: %s", ModuleName, macroName))
 				end
-				lines[#lines + 1] = string.format("/tar %s", stinky.name)
+				CreateMacro(macroName, "INV_Misc_QuestionMark", "")
 			end
+			idx = GetMacroIndexByName(macroName)
+			if Heimdall_Data.config.macroer.debug then print(string.format("[%s] Macro index: %d", ModuleName, idx)) end
+			return idx
 		end
 
-		local idx = FindOrCreateMacro("HeimdallTarget")
-		---@diagnostic disable-next-line: param-type-mismatch
-		local body = strjoin("\n", unpack(lines))
-		if Heimdall_Data.config.macroer.debug then
-			print(string.format("[%s] Updating macro with %d lines", ModuleName, #lines))
-		end
-		EditMacro(idx, "HeimdallTarget", "INV_Misc_QuestionMark", body)
-	end
+		---@param stinkies table<string, Stinky>
+		local function FixMacro(stinkies)
+			if Heimdall_Data.config.macroer.debug then
+				print(string.format("[%s] Fixing macro with %d stinkies", ModuleName, #stinkies))
+			end
+			if not Heimdall_Data.config.macroer.enabled then
+				if Heimdall_Data.config.macroer.debug then
+					print(string.format("[%s] Module disabled, skipping macro update", ModuleName))
+				end
+				return
+			end
+			if InCombatLockdown() then
+				if Heimdall_Data.config.macroer.debug then
+					print(string.format("[%s] In combat, skipping macro update", ModuleName))
+				end
+				return
+			end
 
-	shared.stinkyTracker.stinkies:onChange(function(value)
-		if Heimdall_Data.config.macroer.debug then
-			print(string.format("[%s] Stinkies changed, updating macro", ModuleName))
-		end
-		FixMacro(value)
-	end)
+			local priorityMap = {}
+			for priority, className in ipairs(Heimdall_Data.config.macroer.priority) do
+				priorityMap[className] = priority
+			end
+			local minPriority = #Heimdall_Data.config.macroer.priority + 1
 
-	if Heimdall_Data.config.macroer.debug then print(string.format("[%s] Module initialized", ModuleName)) end
-	print("[Heimdall] Macroer loaded")
-end
+			local sortedStinkies = {}
+			for _, stinky in pairs(stinkies) do
+				if not shared.AgentTracker.IsAgent(stinky.name) then sortedStinkies[#sortedStinkies + 1] = stinky end
+			end
+
+			if Heimdall_Data.config.macroer.debug then
+				print(string.format("[%s] Processing %d non-agent stinkies", ModuleName, #sortedStinkies))
+			end
+
+			table.sort(sortedStinkies, function(a, b)
+				local aPriority = priorityMap[a.class] or minPriority
+				local bPriority = priorityMap[b.class] or minPriority
+				return aPriority > bPriority
+			end)
+
+			if Heimdall_Data.config.macroer.debug then
+				print(string.format("[%s] Sorted stinkies: %d", ModuleName, #sortedStinkies))
+				shared.dump(sortedStinkies)
+			end
+			local lines = { "/targetenemy" }
+			for _, stinky in pairs(sortedStinkies) do
+				if stinky.seenAt > GetTime() - 600 then
+					if Heimdall_Data.config.macroer.debug then
+						print(string.format("[%s] Adding target macro for: %s", ModuleName, stinky.name))
+					end
+					lines[#lines + 1] = string.format("/tar %s", stinky.name)
+				end
+			end
+
+			local idx = FindOrCreateMacro("HeimdallTarget")
+			---@diagnostic disable-next-line: param-type-mismatch
+			local body = strjoin("\n", unpack(lines))
+			if Heimdall_Data.config.macroer.debug then
+				print(string.format("[%s] Updating macro with %d lines", ModuleName, #lines))
+			end
+			EditMacro(idx, "HeimdallTarget", "INV_Misc_QuestionMark", body)
+		end
+
+		shared.StinkyTracker.OnChange(function(stinkies)
+			if Heimdall_Data.config.macroer.debug then
+				print(string.format("[%s] Stinkies changed, updating macro", ModuleName))
+				shared.dump(stinkies)
+			end
+			FixMacro(stinkies)
+		end)
+		if Heimdall_Data.config.macroer.debug then print(string.format("[%s] Module initialized", ModuleName)) end
+		print("[Heimdall] Macroer loaded")
+	end,
+}

Modules/Messenger.lua

@@ -2,175 +2,181 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "Messenger"
 
----@diagnostic disable-next-line: missing-fields
-shared.Messenger = {}
-function shared.Messenger.Init()
-	---@class Message
-	---@field message string
-	---@field channel string
-	---@field data string
+---@class HeimdallMessengerConfig
+---@field enabled boolean
+---@field debug boolean
+---@field interval number
 
-	local function FindOrJoinChannel(channelName, password)
-		local channelId = GetChannelName(channelName)
-		if channelId == 0 then
+---@class HeimdallMessengerData
+---@field queue ReactiveValue<table<string, Message>>
+---@field ticker Timer?
+
+---@class Message
+---@field message string
+---@field channel string
+---@field data string
+
+---@class Messenger
+shared.Messenger = {
+	---@param message Message
+	Enqueue = function(message) table.insert(shared.messenger.queue, message) end,
+	Init = function()
+		shared.messenger = {
+			queue = ReactiveValue.new({}),
+		}
+
+		local function FindOrJoinChannel(channelName, password)
+			local channelId = GetChannelName(channelName)
+			if channelId == 0 then
+				if Heimdall_Data.config.messenger.debug then
+					print(string.format("[%s] Channel not found, joining: %s", ModuleName, channelName))
+				end
+				if password then
+					JoinPermanentChannel(channelName, password)
+				else
+					JoinPermanentChannel(channelName)
+				end
+			end
+			channelId = GetChannelName(channelName)
 			if Heimdall_Data.config.messenger.debug then
-				print(string.format("[%s] Channel not found, joining: %s", ModuleName, channelName))
-			end
-			if password then
-				JoinPermanentChannel(channelName, password)
-			else
-				JoinPermanentChannel(channelName)
+				print(string.format("[%s] Channel found with ID: %s (%s)", ModuleName, channelId, channelName))
 			end
+			return channelId
 		end
-		channelId = GetChannelName(channelName)
-		if Heimdall_Data.config.messenger.debug then
-			print(string.format("[%s] Channel found with ID: %s (%s)", ModuleName, channelId, channelName))
-		end
-		return channelId
-	end
 
-	---@diagnostic disable-next-line: missing-fields
-	if not shared.messenger then shared.messenger = {} end
-	if not shared.messenger.queue then shared.messenger.queue = {} end
-	if not shared.messenger.ticker then
-		local function DoMessage()
-			if Heimdall_Data.config.messenger.debug then
-				print(string.format("[%s] Processing message queue - Size: %d", ModuleName, #shared.messenger.queue))
-			end
+		if not shared.messenger.ticker then
+			local function DoMessage()
+				-- if Heimdall_Data.config.messenger.debug then
+				-- 	print(
+				-- 		string.format(
+				-- 			"[%s] Processing message queue - Size: %d",
+				-- 			ModuleName,
+				-- 			#shared.messenger.queue:get()
+				-- 		)
+				-- 	)
+				-- end
 
-			if not Heimdall_Data.config.messenger.enabled then
-				if Heimdall_Data.config.messenger.debug then
-					print(string.format("[%s] Module disabled, skipping message processing", ModuleName))
+				if not Heimdall_Data.config.messenger.enabled then
+					-- if Heimdall_Data.config.messenger.debug then
+					-- 	print(string.format("[%s] Module disabled, skipping message processing", ModuleName))
+					-- end
+					return
 				end
-				return
-			end
 
-			---@type Message
-			local message = shared.messenger.queue[1]
-			if not message then
-				if Heimdall_Data.config.messenger.debug then
-					print(string.format("[%s] Message queue empty", ModuleName))
+				---@type Message
+				local message = shared.messenger.queue[1]
+				if not message then
+					-- if Heimdall_Data.config.messenger.debug then
+					-- 	print(string.format("[%s] Message queue empty", ModuleName))
+					-- end
+					return
 				end
-				return
-			end
 
-			if Heimdall_Data.config.messenger.debug then
-				print(
-					string.format(
-						"[%s] Processing message - Channel: %s, Data: %s",
-						ModuleName,
-						message.channel or "nil",
-						message.data or "nil"
-					)
-				)
-				print(string.format("[%s] Message content: %s", ModuleName, message.message or "nil"))
-			end
+				if Heimdall_Data.config.messenger.debug then shared.dump(message, "[%s] Processing message:") end
 
-			if not message.message or message.message == "" then
-				if Heimdall_Data.config.messenger.debug then
-					print(string.format("[%s] Invalid message: empty content", ModuleName))
+				if not message.message or message.message == "" then
+					if Heimdall_Data.config.messenger.debug then
+						shared.dump(message, string.format("[%s] Invalid message: empty content", ModuleName))
+					end
+					return
 				end
-				return
-			end
 
-			if not message.channel or message.channel == "" then
-				if Heimdall_Data.config.messenger.debug then
-					print(string.format("[%s] Invalid message: no channel specified", ModuleName))
-				end
-				return
-			end
-
-			if string.find(message.channel, "^C") then
-				if Heimdall_Data.config.messenger.debug then
-					print(string.format("[%s] Converting channel type from C to CHANNEL", ModuleName))
-				end
-				message.channel = "CHANNEL"
-			elseif string.find(message.channel, "^W") then
-				if Heimdall_Data.config.messenger.debug then
-					print(string.format("[%s] Converting channel type from W to WHISPER", ModuleName))
-				end
-				message.channel = "WHISPER"
-			end
-
-			if message.channel == "CHANNEL" and message.data and string.match(message.data, "%D") then
-				if Heimdall_Data.config.messenger.debug then
-					print(
-						string.format(
-							"[%s] Processing channel message: '%s' to '%s'",
-							ModuleName,
-							message.message,
-							message.data
+				if not message.channel or message.channel == "" then
+					if Heimdall_Data.config.messenger.debug then
+						shared.dump(
+							message,
+							string.format("[%s] Invalid message: no channel specified", ModuleName)
 						)
-					)
-				end
-				local channelId = GetChannelName(message.data)
-				if channelId == 0 then
-					if Heimdall_Data.config.messenger.debug then
-						print(string.format("[%s] Channel not found, attempting to join: %s", ModuleName, message.data))
 					end
-					channelId = FindOrJoinChannel(message.data)
+					return
+				end
+
+				if string.find(message.channel, "^C") then
 					if Heimdall_Data.config.messenger.debug then
-						print(string.format("[%s] Channel join result - ID: %s", ModuleName, channelId))
+						shared.dump(
+							message,
+							string.format("[%s] Converting channel type from C to CHANNEL", ModuleName)
+						)
 					end
+					message.channel = "CHANNEL"
+				elseif string.find(message.channel, "^W") then
+					if Heimdall_Data.config.messenger.debug then
+						shared.dump(
+							message,
+							string.format("[%s] Converting channel type from W to WHISPER", ModuleName)
+						)
+					end
+					message.channel = "WHISPER"
 				end
-				message.data = tostring(channelId)
-			end
 
-			table.remove(shared.messenger.queue, 1)
-			if not message.message or message.message == "" then
-				if Heimdall_Data.config.messenger.debug then
-					print(string.format("[%s] Skipping empty message", ModuleName))
+				if message.channel == "CHANNEL" and message.data and string.match(message.data, "%D") then
+					if Heimdall_Data.config.messenger.debug then
+						shared.dump(message, string.format("[%s] Processing channel message:", ModuleName))
+					end
+					local channelId = GetChannelName(message.data)
+					if channelId == 0 then
+						if Heimdall_Data.config.messenger.debug then
+							shared.dump(message, string.format("[%s] Channel not found, joining:", ModuleName))
+						end
+						channelId = FindOrJoinChannel(message.data)
+						if Heimdall_Data.config.messenger.debug then
+							print(string.format("[%s] Channel join result - ID: %s", ModuleName, channelId))
+						end
+					end
+					message.data = tostring(channelId)
 				end
-				return
-			end
-			if not message.channel or message.channel == "" then
-				if Heimdall_Data.config.messenger.debug then
-					print(string.format("[%s] Skipping message with no channel", ModuleName))
-				end
-				return
-			end
-			if not message.data or message.data == "" then
-				if Heimdall_Data.config.messenger.debug then
-					print(string.format("[%s] Skipping message with no data", ModuleName))
-				end
-				return
-			end
 
-			if Heimdall_Data.config.messenger.debug then
-				print(
-					string.format(
-						"[%s] Sending message: '%s' to %s:%s",
-						ModuleName,
-						message.message,
-						message.channel,
-						message.data
+				table.remove(shared.messenger.queue, 1)
+				if not message.message or message.message == "" then
+					if Heimdall_Data.config.messenger.debug then
+						shared.dump(message, string.format("[%s] Skipping empty message", ModuleName))
+					end
+					return
+				end
+				if not message.channel or message.channel == "" then
+					if Heimdall_Data.config.messenger.debug then
+						shared.dump(message, string.format("[%s] Skipping message with no channel", ModuleName))
+					end
+					return
+				end
+				if not message.data or message.data == "" then
+					if Heimdall_Data.config.messenger.debug then
+						shared.dump(message, string.format("[%s] Skipping message with no data", ModuleName))
+					end
+					return
+				end
+
+				if Heimdall_Data.config.messenger.debug then
+					shared.dump(message, string.format("[%s] Sending message:", ModuleName))
+				end
+				if string.len(message.message) > 255 then
+					shared.dump(
+						message,
+						string.format("[%s] Message too long!!!!: %s", ModuleName, message.message)
 					)
+					return
+				end
+				SendChatMessage(message.message, message.channel, nil, message.data)
+			end
+			local function Tick()
+				-- if Heimdall_Data.config.messenger.debug then
+				-- 	print(string.format("[%s] Tick - Queue size: %d", ModuleName, #shared.messenger.queue:get()))
+				-- end
+				DoMessage()
+				shared.messenger.ticker = C_Timer.NewTimer(Heimdall_Data.config.messenger.interval, Tick, 1)
+			end
+			Tick()
+		end
+
+		if Heimdall_Data.config.messenger.debug then
+			print(
+				string.format(
+					"[%s] Module initialized with interval: %s",
+					ModuleName,
+					Heimdall_Data.config.messenger.interval
 				)
-			end
-			if string.len(message.message) > 255 then
-				print(string.format("[%s] Message too long!!!!: %s", ModuleName, message.message))
-				return
-			end
-			SendChatMessage(message.message, message.channel, nil, message.data)
-		end
-		local function Tick()
-			if Heimdall_Data.config.messenger.debug then
-				print(string.format("[%s] Tick - Queue size: %d", ModuleName, #shared.messenger.queue))
-			end
-			DoMessage()
-			shared.messenger.ticker = C_Timer.NewTimer(Heimdall_Data.config.messenger.interval, Tick, 1)
-		end
-		Tick()
-	end
-
-	if Heimdall_Data.config.messenger.debug then
-		print(
-			string.format(
-				"[%s] Module initialized with interval: %s",
-				ModuleName,
-				Heimdall_Data.config.messenger.interval
 			)
-		)
-	end
-	print("[Heimdall] Messenger loaded")
-end
+		end
+		print("[Heimdall] Messenger loaded")
+	end,
+}

Modules/Network.lua

@@ -2,72 +2,84 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "Network"
 
----@diagnostic disable-next-line: missing-fields
-shared.Network = {}
-function shared.Network.Init()
-	if not shared.network then shared.network = {} end
-	local updatePending = false
+---@class HeimdallNetworkConfig
+---@field enabled boolean
+---@field debug boolean
+---@field members string[]
+---@field updateInterval number
 
-	local function FriendListUpdate()
-		updatePending = false
-		if not Heimdall_Data.config.network.enabled then return end
-		---@type table<string, boolean>
-		local friends = {}
-		for i = 1, GetNumFriends() do
-			local name, _, _, _, connected, _, _, _ = GetFriendInfo(i)
-			if name then
-				friends[name] = connected
-				if Heimdall_Data.config.network.debug then
-					print(string.format("[%s] Friend %s is %s", ModuleName, name, connected and "online" or "offline"))
+---@class HeimdallNetworkData
+---@field ticker Timer?
+
+---@class Network
+shared.Network = {
+	Init = function()
+		if not shared.network then shared.network = {} end
+		local updatePending = false
+
+		local function FriendListUpdate()
+			updatePending = false
+			if not Heimdall_Data.config.network.enabled then return end
+			---@type table<string, boolean>
+			local friends = {}
+			for i = 1, GetNumFriends() do
+				local name, _, _, _, connected, _, _, _ = GetFriendInfo(i)
+				if name then
+					friends[name] = connected
+					if Heimdall_Data.config.network.debug then
+						print(
+							string.format("[%s] Friend %s is %s", ModuleName, name, connected and "online" or "offline")
+						)
+					end
+				else
+					if Heimdall_Data.config.network.debug then
+						print(string.format("[%s] Friend %s is nil", ModuleName, i))
+					end
 				end
-			else
-				if Heimdall_Data.config.network.debug then
-					print(string.format("[%s] Friend %s is nil", ModuleName, i))
+			end
+
+			for _, member in ipairs(Heimdall_Data.config.network.members) do
+				if friends[member] == nil and member ~= UnitName("player") then
+					if Heimdall_Data.config.network.debug then
+						print(string.format("[%s] Adding friend %s", ModuleName, member))
+					end
+					AddFriend(member)
 				end
 			end
+			friends[UnitName("player")] = true
+
+			shared.networkNodes = {}
+			-- Why are we skipping this again...?
+			-- if false then shared.networkNodes[#shared.networkNodes + 1] = UnitName("player") end
+			for _, player in ipairs(Heimdall_Data.config.network.members) do
+				if friends[player] then
+					shared.networkNodes[#shared.networkNodes + 1] = player
+					if Heimdall_Data.config.network.debug then
+						print(string.format("[%s] Adding network node %s", ModuleName, player))
+					end
+				end
+			end
+			if Heimdall_Data.config.network.debug then
+				print(string.format("[%s] Network nodes:", ModuleName))
+				shared.dump(shared.networkNodes)
+			end
 		end
 
-		for _, member in ipairs(Heimdall_Data.config.network.members) do
-			if friends[member] == nil and member ~= UnitName("player") then
-				if Heimdall_Data.config.network.debug then
-					print(string.format("[%s] Adding friend %s", ModuleName, member))
-				end
-				AddFriend(member)
-			end
+		local friendsFrame = CreateFrame("Frame")
+		friendsFrame:RegisterEvent("FRIENDLIST_UPDATE")
+		friendsFrame:SetScript("OnEvent", function(self, event, ...) end)
+
+		local function NetworkTick()
+			if Heimdall_Data.config.network.debug then print("Network module is updating.") end
+			ShowFriends()
+			updatePending = true
+			C_Timer.After(1, function()
+				if updatePending then FriendListUpdate() end
+			end)
+			shared.network.ticker = C_Timer.NewTimer(Heimdall_Data.config.network.updateInterval, NetworkTick, 1)
 		end
-		friends[UnitName("player")] = true
 
-		shared.networkNodes = {}
-		-- Why are we skipping this again...?
-		-- if false then shared.networkNodes[#shared.networkNodes + 1] = UnitName("player") end
-		for _, player in ipairs(Heimdall_Data.config.network.members) do
-			if friends[player] then
-				shared.networkNodes[#shared.networkNodes + 1] = player
-				if Heimdall_Data.config.network.debug then
-					print(string.format("[%s] Adding network node %s", ModuleName, player))
-				end
-			end
-		end
-		if Heimdall_Data.config.network.debug then
-			print(string.format("[%s] Network nodes:", ModuleName))
-			shared.dumpTable(shared.networkNodes)
-		end
-	end
-
-	local friendsFrame = CreateFrame("Frame")
-	friendsFrame:RegisterEvent("FRIENDLIST_UPDATE")
-	friendsFrame:SetScript("OnEvent", function(self, event, ...) end)
-
-	local function NetworkTick()
-		if Heimdall_Data.config.network.debug then print("Network module is updating.") end
-		ShowFriends()
-		updatePending = true
-		C_Timer.After(1, function()
-			if updatePending then FriendListUpdate() end
-		end)
-		shared.network.ticker = C_Timer.NewTimer(Heimdall_Data.config.network.updateInterval, NetworkTick, 1)
-	end
-
-	NetworkTick()
-	print("[Heimdall] Network module loaded")
-end
+		NetworkTick()
+		print("[Heimdall] Network module loaded")
+	end,
+}

Modules/NetworkMessenger.lua

@@ -2,182 +2,203 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "NetworkMessenger"
 
----@diagnostic disable-next-line: missing-fields
-shared.NetworkMessenger = {}
-function shared.NetworkMessenger.Init()
-	RegisterAddonMessagePrefix(Heimdall_Data.config.addonPrefix)
+---@class HeimdallNetworkMessengerConfig
+---@field enabled boolean
+---@field debug boolean
+---@field interval number
 
-	if not shared.networkMessenger then shared.networkMessenger = {} end
-	if not shared.networkMessenger.queue then shared.networkMessenger.queue = {} end
-	if not shared.networkMessenger.ticker then
-		local function DoMessage()
-			--if Heimdall_Data.config.networkMessenger.debug then
-			--	print(string.format("[%s] Processing network message queue", ModuleName))
-			--end
-			if not Heimdall_Data.config.networkMessenger.enabled then
+---@class HeimdallNetworkMessengerData
+---@field queue table<string, Message>
+---@field ticker Timer?
+
+---@class NetworkMessenger
+shared.NetworkMessenger = {
+	---@param message Message
+	Enqueue = function(message) table.insert(shared.networkMessenger.queue, message) end,
+	Init = function()
+		RegisterAddonMessagePrefix(Heimdall_Data.config.addonPrefix)
+
+		shared.networkMessenger = {
+			queue = ReactiveValue.new({}),
+		}
+
+		if not shared.networkMessenger.ticker then
+			local function DoMessage()
 				--if Heimdall_Data.config.networkMessenger.debug then
-				--	print(string.format("[%s] Module disabled, skipping network message processing", ModuleName))
+				--	print(string.format("[%s] Processing network message queue", ModuleName))
 				--end
-				return
-			end
-			---@type Message
-			local message = shared.networkMessenger.queue[1]
-			if not message then
-				--if Heimdall_Data.config.networkMessenger.debug then
-				--	print(string.format("[%s] Network message queue empty", ModuleName))
-				--end
-				return
-			end
-			if not message.message or message.message == "" then
-				if Heimdall_Data.config.networkMessenger.debug then
-					print(string.format("[%s] Invalid network message: empty content", ModuleName))
+				if not Heimdall_Data.config.networkMessenger.enabled then
+					--if Heimdall_Data.config.networkMessenger.debug then
+					--	print(string.format("[%s] Module disabled, skipping network message processing", ModuleName))
+					--end
+					return
 				end
-				return
-			end
-			if not message.channel or message.channel == "" then
-				if Heimdall_Data.config.networkMessenger.debug then
-					print(string.format("[%s] Invalid network message: no channel specified", ModuleName))
+				---@type Message
+				local message = shared.networkMessenger.queue[1]
+				if not message then
+					--if Heimdall_Data.config.networkMessenger.debug then
+					--	print(string.format("[%s] Network message queue empty", ModuleName))
+					--end
+					return
+				end
+				if not message.message or message.message == "" then
+					if Heimdall_Data.config.networkMessenger.debug then
+						print(string.format("[%s] Invalid network message: empty content", ModuleName))
+					end
+					return
+				end
+				if not message.channel or message.channel == "" then
+					if Heimdall_Data.config.networkMessenger.debug then
+						print(string.format("[%s] Invalid network message: no channel specified", ModuleName))
+					end
+					return
 				end
-				return
-			end
 
-			table.remove(shared.networkMessenger.queue, 1)
-			if not message.message or message.message == "" then
-				if Heimdall_Data.config.networkMessenger.debug then
-					print(string.format("[%s] Skipping empty network message", ModuleName))
+				table.remove(shared.networkMessenger.queue, 1)
+				if not message.message or message.message == "" then
+					if Heimdall_Data.config.networkMessenger.debug then
+						print(string.format("[%s] Skipping empty network message", ModuleName))
+					end
+					return
 				end
-				return
-			end
-			if not message.channel or message.channel == "" then
-				if Heimdall_Data.config.networkMessenger.debug then
-					print(string.format("[%s] Skipping network message with no channel", ModuleName))
+				if not message.channel or message.channel == "" then
+					if Heimdall_Data.config.networkMessenger.debug then
+						print(string.format("[%s] Skipping network message with no channel", ModuleName))
+					end
+					return
 				end
-				return
-			end
-			if not message.data or message.data == "" then
-				if Heimdall_Data.config.networkMessenger.debug then
-					print(string.format("[%s] Skipping network message with no data", ModuleName))
+				if not message.data or message.data == "" then
+					if Heimdall_Data.config.networkMessenger.debug then
+						print(string.format("[%s] Skipping network message with no data", ModuleName))
+					end
+					return
 				end
-				return
-			end
 
-			if Heimdall_Data.config.networkMessenger.debug then
-				print(
-					string.format(
-						"[%s] Sending network message: '%s' to %s:%s",
-						ModuleName,
-						message.message,
-						message.channel,
-						message.data
+				if Heimdall_Data.config.networkMessenger.debug then
+					print(
+						string.format(
+							"[%s] Sending network message: '%s' to %s:%s",
+							ModuleName,
+							message.message,
+							message.channel,
+							message.data
+						)
 					)
-				)
+				end
+				local payload = string.format("dmessage|%s|%s|%s", message.message, message.channel, message.data)
+				if Heimdall_Data.config.networkMessenger.debug then
+					print(string.format("[%s] Payload: %s", ModuleName, payload))
+				end
+				if not shared.networkNodes or #shared.networkNodes == 0 then
+					if Heimdall_Data.config.networkMessenger.debug then
+						print(string.format("[%s] No network nodes found, wtf????", ModuleName))
+					end
+					return
+				end
+				local target = shared.networkNodes[1]
+				SendAddonMessage(Heimdall_Data.config.addonPrefix, payload, "WHISPER", target)
 			end
-			local payload = string.format("dmessage|%s|%s|%s", message.message, message.channel, message.data)
+			local function Tick()
+				--if Heimdall_Data.config.networkMessenger.debug then
+				--	local queueSize = #shared.networkMessenger.queue
+				--	print(string.format("[%s] Queue check - Network messages pending: %d", ModuleName, queueSize))
+				--end
+				DoMessage()
+				shared.networkMessenger.ticker =
+					C_Timer.NewTimer(Heimdall_Data.config.networkMessenger.interval, Tick, 1)
+			end
+			Tick()
+		end
+
+		-- If we are the leader then we delegate messages (dmessage)
+		-- If we get a "message" command from leader then we send the message
+
+		local nextIdx = 1
+		local addonMsgFrame = CreateFrame("Frame")
+		addonMsgFrame:RegisterEvent("CHAT_MSG_ADDON")
+		addonMsgFrame:SetScript("OnEvent", function(self, event, prefix, message, channel, source)
+			if not Heimdall_Data.config.networkMessenger.enabled then return end
+			if prefix ~= Heimdall_Data.config.addonPrefix then return end
+			source = string.match(source, "[^%-]+")
+
 			if Heimdall_Data.config.networkMessenger.debug then
-				print(string.format("[%s] Payload: %s", ModuleName, payload))
+				print(string.format("[%s] Received message from %s: %s", ModuleName, source, message))
 			end
-			if not shared.networkNodes or #shared.networkNodes == 0 then
+			if #shared.networkNodes == 0 then
 				if Heimdall_Data.config.networkMessenger.debug then
 					print(string.format("[%s] No network nodes found, wtf????", ModuleName))
 				end
 				return
 			end
-			local target = shared.networkNodes[1]
-			SendAddonMessage(Heimdall_Data.config.addonPrefix, payload, "WHISPER", target)
-		end
-		local function Tick()
-			--if Heimdall_Data.config.networkMessenger.debug then
-			--	local queueSize = #shared.networkMessenger.queue
-			--	print(string.format("[%s] Queue check - Network messages pending: %d", ModuleName, queueSize))
+
+			-- There should always be at least one network node ergo should always exist a leader
+			-- Because the us, the player, is also a node
+			--local networkLeader = shared.networkNodes[1]
+			--if source ~= networkLeader then
+			--	if Heimdall_Data.config.networkMessenger.debug then
+			--		print(string.format("[%s] Message from %s is not from the network leader (%s)", ModuleName, source,
+			--			networkLeader))
+			--	end
+			--	return
 			--end
-			DoMessage()
-			shared.networkMessenger.ticker = C_Timer.NewTimer(Heimdall_Data.config.networkMessenger.interval, Tick, 1)
-		end
-		Tick()
-	end
 
-	-- If we are the leader then we delegate messages (dmessage)
-	-- If we get a "message" command from leader then we send the message
-
-	local nextIdx = 1
-	local addonMsgFrame = CreateFrame("Frame")
-	addonMsgFrame:RegisterEvent("CHAT_MSG_ADDON")
-	addonMsgFrame:SetScript("OnEvent", function(self, event, prefix, message, channel, source)
-		if not Heimdall_Data.config.networkMessenger.enabled then return end
-		if prefix ~= Heimdall_Data.config.addonPrefix then return end
-		source = string.match(source, "[^%-]+")
-
-		if Heimdall_Data.config.networkMessenger.debug then
-			print(string.format("[%s] Received message from %s: %s", ModuleName, source, message))
-		end
-		if #shared.networkNodes == 0 then
+			local parts = shared.Split(message, "|")
 			if Heimdall_Data.config.networkMessenger.debug then
-				print(string.format("[%s] No network nodes found, wtf????", ModuleName))
+				print(string.format("[%s] Received message parts:", ModuleName))
+				shared.dump(parts)
 			end
-			return
-		end
+			local command = strtrim(parts[1])
+			if command == "message" then
+				local content = strtrim(tostring(parts[2]))
+				local targetchannel = strtrim(tostring(parts[3]))
+				local target = strtrim(tostring(parts[4]))
+				if Heimdall_Data.config.networkMessenger.debug then
+					print(
+						string.format(
+							"[%s] Received message command: %s %s %s",
+							ModuleName,
+							content,
+							targetchannel,
+							target
+						)
+					)
+				end
+				---@type Message
+				local msg = {
+					channel = targetchannel,
+					message = content,
+					data = target,
+				}
+				table.insert(shared.messenger.queue, msg)
+			elseif command == "dmessage" then
+				if Heimdall_Data.config.networkMessenger.debug then
+					print(string.format("[%s] Received dmessage command", ModuleName))
+				end
+				parts[1] = "message"
+				local content = table.concat(parts, "|")
 
-		-- There should always be at least one network node ergo should always exist a leader
-		-- Because the us, the player, is also a node
-		--local networkLeader = shared.networkNodes[1]
-		--if source ~= networkLeader then
-		--	if Heimdall_Data.config.networkMessenger.debug then
-		--		print(string.format("[%s] Message from %s is not from the network leader (%s)", ModuleName, source,
-		--			networkLeader))
-		--	end
-		--	return
-		--end
-
-		local parts = shared.Split(message, "|")
-		if Heimdall_Data.config.networkMessenger.debug then
-			print(string.format("[%s] Received message parts:", ModuleName))
-			shared.dumpTable(parts)
-		end
-		local command = strtrim(parts[1])
-		if command == "message" then
-			local content = strtrim(tostring(parts[2]))
-			local targetchannel = strtrim(tostring(parts[3]))
-			local target = strtrim(tostring(parts[4]))
-			if Heimdall_Data.config.networkMessenger.debug then
-				print(
-					string.format("[%s] Received message command: %s %s %s", ModuleName, content, targetchannel, target)
-				)
+				if nextIdx > #shared.networkNodes then nextIdx = 1 end
+				local recipient = shared.networkNodes[nextIdx]
+				nextIdx = nextIdx + 1
+				if Heimdall_Data.config.networkMessenger.debug then
+					print(string.format("[%s] Sending message %s to %s", ModuleName, content, recipient))
+				end
+				SendAddonMessage(Heimdall_Data.config.addonPrefix, content, "WHISPER", recipient)
 			end
-			---@type Message
-			local msg = {
-				channel = targetchannel,
-				message = content,
-				data = target,
+		end)
+
+		--/run Heimdall_Data.Test()
+		Heimdall_Data.Test = function()
+			local testmsg = {
+				channel = "W",
+				message = "Hi, mom!",
+				data = "Secundus",
 			}
-			table.insert(shared.messenger.queue, msg)
-		elseif command == "dmessage" then
-			if Heimdall_Data.config.networkMessenger.debug then
-				print(string.format("[%s] Received dmessage command", ModuleName))
+			for i = 1, 36 do
+				table.insert(shared.networkMessenger.queue, testmsg)
 			end
-			parts[1] = "message"
-			local content = table.concat(parts, "|")
-
-			if nextIdx > #shared.networkNodes then nextIdx = 1 end
-			local recipient = shared.networkNodes[nextIdx]
-			nextIdx = nextIdx + 1
-			if Heimdall_Data.config.networkMessenger.debug then
-				print(string.format("[%s] Sending message %s to %s", ModuleName, content, recipient))
-			end
-			SendAddonMessage(Heimdall_Data.config.addonPrefix, content, "WHISPER", recipient)
 		end
-	end)
 
-	--/run Heimdall_Data.Test()
-	Heimdall_Data.Test = function()
-		local testmsg = {
-			channel = "W",
-			message = "Hi, mom!",
-			data = "Secundus",
-		}
-		for i = 1, 36 do
-			table.insert(shared.networkMessenger.queue, testmsg)
-		end
-	end
-
-	print("[Heimdall] NetworkMessenger module loaded")
-end
+		print("[Heimdall] NetworkMessenger module loaded")
+	end,
+}

Modules/Noter.lua

@@ -2,294 +2,306 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "Noter"
 
+---@class HeimdallNoterConfig
+---@field enabled boolean
+---@field debug boolean
+---@field channels string[]
+---@field lastNotes number
+
 ---@class Note
 ---@field source string
 ---@field for string
 ---@field date string
 ---@field note string
 
----@diagnostic disable-next-line: missing-fields
-shared.Noter = {}
-function shared.Noter.Init()
-	-- ---Hopefully this will not be necessary
-	-- ---@param text string
-	-- ---@param size number
-	-- ---@return string[]
-	-- local function Partition(text, size)
-	-- 	local words = {}
-	-- 	for word in text:gmatch("[^,]+") do
-	-- 		words[#words + 1] = word
-	-- 	end
+---@class Noter
+shared.Noter = {
+	Init = function()
+		-- ---Hopefully this will not be necessary
+		-- ---@param text string
+		-- ---@param size number
+		-- ---@return string[]
+		-- local function Partition(text, size)
+		-- 	local words = {}
+		-- 	for word in text:gmatch("[^,]+") do
+		-- 		words[#words + 1] = word
+		-- 	end
 
-	-- 	local ret = {}
-	-- 	local currentChunk = ""
+		-- 	local ret = {}
+		-- 	local currentChunk = ""
 
-	-- 	for _, word in ipairs(words) do
-	-- 		if #currentChunk + #word + 1 <= size then
-	-- 			currentChunk = currentChunk .. (currentChunk == "" and word or " " .. word)
-	-- 		else
-	-- 			if #currentChunk > 0 then ret[#ret + 1] = currentChunk end
-	-- 			currentChunk = word
-	-- 		end
-	-- 	end
+		-- 	for _, word in ipairs(words) do
+		-- 		if #currentChunk + #word + 1 <= size then
+		-- 			currentChunk = currentChunk .. (currentChunk == "" and word or " " .. word)
+		-- 		else
+		-- 			if #currentChunk > 0 then ret[#ret + 1] = currentChunk end
+		-- 			currentChunk = word
+		-- 		end
+		-- 	end
 
-	-- 	if #currentChunk > 0 then ret[#ret + 1] = currentChunk end
+		-- 	if #currentChunk > 0 then ret[#ret + 1] = currentChunk end
 
-	-- 	return ret
-	-- end
-	---@param array any[]
-	---@return any[]
-	local function Compact(array)
-		local compacted = {}
-		for _, v in pairs(array) do
-			compacted[#compacted + 1] = v
-		end
-		return compacted
-	end
-
-	---@param name string
-	---@param args string[]
-	local function DeleteNotes(name, args)
-		if Heimdall_Data.config.noter.debug then
-			print(string.format("[%s] Delete note command received for: %s", ModuleName, name))
-		end
-		local range = args[4]
-		if range then
-			if Heimdall_Data.config.noter.debug then
-				print(string.format("[%s] Range received for delete note: %s", ModuleName, range))
+		-- 	return ret
+		-- end
+		---@param array any[]
+		---@return any[]
+		local function Compact(array)
+			local compacted = {}
+			for _, v in pairs(array) do
+				compacted[#compacted + 1] = v
 			end
-			local indices = shared.Split(range, "..")
-			if Heimdall_Data.config.noter.debug then
-				print(string.format("[%s] Indices for range deletion: %s", ModuleName, table.concat(indices, ", ")))
-				shared.dumpTable(indices)
-			end
-			local start = tonumber(indices[1])
-			local finish = tonumber(indices[2])
+			return compacted
+		end
 
-			if not start then
+		---@param name string
+		---@param args string[]
+		local function DeleteNotes(name, args)
+			if Heimdall_Data.config.noter.debug then
+				print(string.format("[%s] Delete note command received for: %s", ModuleName, name))
+			end
+			local range = args[4]
+			if range then
 				if Heimdall_Data.config.noter.debug then
-					print(string.format("[%s] Invalid start range for delete note: %s", ModuleName, tostring(start)))
+					print(string.format("[%s] Range received for delete note: %s", ModuleName, range))
 				end
-				return
-			end
-
-			if not finish then finish = start end
-			if Heimdall_Data.config.noter.debug then
-				print(string.format("[%s] Deleting note range %s to %s for: %s", ModuleName, start, finish, name))
-			end
-
-			-- Here, because we are deleting random notes, we lose the "iterative" index property
-			-- Ie it's not longer 1..100, it might be 1..47, 50, 68..100
-			-- Which means that we cannot use ipairs, bad!
-			for i = start, finish do
-				if not Heimdall_Data.config.notes[name] then Heimdall_Data.config.notes[name] = {} end
-				if not Heimdall_Data.config.notes[name][i] then
-					if Heimdall_Data.config.noter.debug then
-						print(string.format("[%s] Note at index %s does not exist", ModuleName, i))
-					end
-				else
-					if Heimdall_Data.config.noter.debug then
-						print(string.format("[%s] Deleting note %s at index %s", ModuleName, name, i))
-						shared.dumpTable(Heimdall_Data.config.notes[name][i])
-					end
-					Heimdall_Data.config.notes[name][i] = nil
+				local indices = shared.Split(range, "..")
+				if Heimdall_Data.config.noter.debug then
+					print(string.format("[%s] Indices for range deletion: %s", ModuleName, table.concat(indices, ", ")))
+					shared.dump(indices)
 				end
-			end
-			Heimdall_Data.config.notes[name] = Compact(Heimdall_Data.config.notes[name])
-		end
-	end
+				local start = tonumber(indices[1])
+				local finish = tonumber(indices[2])
 
-	---@param channel string
-	---@param index number
-	---@param note Note
-	local function PrintNote(channel, index, note)
-		if Heimdall_Data.config.noter.debug then
-			print(string.format("[%s] Printing note at index %d for: %s", ModuleName, index, note.source))
-			print(string.format("[%s] [%s][%d] %s: %s", ModuleName, note.source, index, note.date, note.note))
+				if not start then
+					if Heimdall_Data.config.noter.debug then
+						print(
+							string.format("[%s] Invalid start range for delete note: %s", ModuleName, tostring(start))
+						)
+					end
+					return
+				end
+
+				if not finish then finish = start end
+				if Heimdall_Data.config.noter.debug then
+					print(string.format("[%s] Deleting note range %s to %s for: %s", ModuleName, start, finish, name))
+				end
+
+				-- Here, because we are deleting random notes, we lose the "iterative" index property
+				-- Ie it's not longer 1..100, it might be 1..47, 50, 68..100
+				-- Which means that we cannot use ipairs, bad!
+				for i = start, finish do
+					if not Heimdall_Data.config.notes[name] then Heimdall_Data.config.notes[name] = {} end
+					if not Heimdall_Data.config.notes[name][i] then
+						if Heimdall_Data.config.noter.debug then
+							print(string.format("[%s] Note at index %s does not exist", ModuleName, i))
+						end
+					else
+						if Heimdall_Data.config.noter.debug then
+							print(string.format("[%s] Deleting note %s at index %s", ModuleName, name, i))
+							shared.dump(Heimdall_Data.config.notes[name][i])
+						end
+						Heimdall_Data.config.notes[name][i] = nil
+					end
+				end
+				Heimdall_Data.config.notes[name] = Compact(Heimdall_Data.config.notes[name])
+			end
 		end
-		---@type Message
-		local msg = {
-			channel = "C",
-			data = channel,
-			message = string.format("[%s][%d] %s: %s", note.source, index, note.date, note.note),
-		}
-		--table.insert(shared.messenger.queue, msg)
-		table.insert(shared.networkMessenger.queue, msg)
-	end
-	---@param name string
-	---@param args string[]
-	local function PrintNotes(channel, name, args)
-		if Heimdall_Data.config.noter.debug then
-			print(string.format("[%s] Print note command received for: %s", ModuleName, name))
-		end
-		local range = args[3]
-		if not range then
+
+		---@param channel string
+		---@param index number
+		---@param note Note
+		local function PrintNote(channel, index, note)
 			if Heimdall_Data.config.noter.debug then
-				print(
-					string.format(
-						"[%s] No range specified for print note, defaulting to last %d notes",
-						ModuleName,
-						Heimdall_Data.config.noter.lastNotes
+				print(string.format("[%s] Printing note at index %d for: %s", ModuleName, index, note.source))
+				print(string.format("[%s] [%s][%d] %s: %s", ModuleName, note.source, index, note.date, note.note))
+			end
+			---@type Message
+			local msg = {
+				channel = "C",
+				data = channel,
+				message = string.format("[%s][%d] %s: %s", note.source, index, note.date, note.note),
+			}
+			if Heimdall_Data.config.networkMessenger.enabled then
+				shared.NetworkMessenger.Enqueue(msg)
+			elseif Heimdall_Data.config.messenger.enabled then
+				shared.Messenger.Enqueue(msg)
+			end
+		end
+		---@param name string
+		---@param args string[]
+		local function PrintNotes(channel, name, args)
+			if Heimdall_Data.config.noter.debug then
+				print(string.format("[%s] Print note command received for: %s", ModuleName, name))
+			end
+			local range = args[3]
+			if not range then
+				if Heimdall_Data.config.noter.debug then
+					print(
+						string.format(
+							"[%s] No range specified for print note, defaulting to last %d notes",
+							ModuleName,
+							Heimdall_Data.config.noter.lastNotes
+						)
 					)
-				)
-			end
-			local notes = Heimdall_Data.config.notes[name] or {}
-			local start = math.max(1, #notes - Heimdall_Data.config.noter.lastNotes + 1)
-			local finish = #notes
-			if Heimdall_Data.config.noter.debug then
-				print(string.format("[%s] Printing notes from %d to %d for: %s", ModuleName, start, finish, name))
-			end
-			for i = start, finish do
-				PrintNote(channel, i, notes[i])
-			end
-			return
-		end
-		if range then
-			if Heimdall_Data.config.noter.debug then
-				print(string.format("[%s] Range received for print note: %s", ModuleName, range))
-			end
-			local indices = shared.Split(range, "..")
-			if Heimdall_Data.config.noter.debug then
-				print(string.format("[%s] Indices for range printing: %s", ModuleName, table.concat(indices, ", ")))
-				shared.dumpTable(indices)
-			end
-			local start = tonumber(indices[1])
-			local finish = tonumber(indices[2])
-
-			if not start then
+				end
+				local notes = Heimdall_Data.config.notes[name] or {}
+				local start = math.max(1, #notes - Heimdall_Data.config.noter.lastNotes + 1)
+				local finish = #notes
 				if Heimdall_Data.config.noter.debug then
-					print(string.format("[%s] Invalid start range for print note: %s", ModuleName, tostring(start)))
+					print(string.format("[%s] Printing notes from %d to %d for: %s", ModuleName, start, finish, name))
+				end
+				for i = start, finish do
+					PrintNote(channel, i, notes[i])
+				end
+				return
+			end
+			if range then
+				if Heimdall_Data.config.noter.debug then
+					print(string.format("[%s] Range received for print note: %s", ModuleName, range))
+				end
+				local indices = shared.Split(range, "..")
+				if Heimdall_Data.config.noter.debug then
+					print(string.format("[%s] Indices for range printing: %s", ModuleName, table.concat(indices, ", ")))
+					shared.dump(indices)
+				end
+				local start = tonumber(indices[1])
+				local finish = tonumber(indices[2])
+
+				if not start then
+					if Heimdall_Data.config.noter.debug then
+						print(string.format("[%s] Invalid start range for print note: %s", ModuleName, tostring(start)))
+					end
+					return
+				end
+
+				if not finish then finish = start end
+				if Heimdall_Data.config.noter.debug then
+					print(string.format("[%s] Printing note range %s to %s for: %s", ModuleName, start, finish, name))
+				end
+
+				for i = start, finish do
+					if not Heimdall_Data.config.notes[name] then Heimdall_Data.config.notes[name] = {} end
+					if not Heimdall_Data.config.notes[name][i] then
+						if Heimdall_Data.config.noter.debug then
+							print(string.format("[%s] Note at index %s does not exist", ModuleName, i))
+						end
+					else
+						if Heimdall_Data.config.noter.debug then
+							print(string.format("[%s] Printing note %s at index %s", ModuleName, name, i))
+							shared.dump(Heimdall_Data.config.notes[name][i])
+						end
+						PrintNote(channel, i, Heimdall_Data.config.notes[name][i])
+					end
+				end
+			end
+		end
+
+		---@param name string
+		---@param sender string
+		---@param args string[]
+		local function AddNote(name, sender, args)
+			if not Heimdall_Data.config.notes[name] then Heimdall_Data.config.notes[name] = {} end
+			if Heimdall_Data.config.noter.debug then
+				print(string.format("[%s] Adding note for: %s from: %s", ModuleName, name, sender))
+				shared.dump(args)
+			end
+			local msgparts = {}
+			for i = 3, #args do
+				msgparts[#msgparts + 1] = args[i]
+			end
+			local msg = table.concat(msgparts, " ")
+
+			if Heimdall_Data.config.noter.debug then
+				print(string.format("[%s] Adding note for: %s from: %s", ModuleName, name, sender))
+				print(string.format("[%s] Note: %s", ModuleName, msg))
+			end
+
+			local note = {
+				source = sender,
+				date = date("%Y-%m-%dT%H:%M:%S"),
+				note = msg,
+			}
+
+			if Heimdall_Data.config.noter.debug then
+				print(string.format("[%s] Adding note", ModuleName))
+				shared.dump(note)
+			end
+			table.insert(Heimdall_Data.config.notes[name], note)
+		end
+
+		-- Here's the plan:
+		-- Implement a "note" command, that will do everything
+		-- Saying "note <name> <note>" will add a note to the list for the character
+		-- Saying "note <name>" will list last N notes
+		-- Saying "note <name> i" will list the i-th note
+		-- Saying "note <name> i..j" will list notes from i to j
+		-- Saying "note <name> delete i" will delete the i-th note
+		-- Saying "note <name> delete i..j" will delete notes from i to j
+		local noterChannelFrame = CreateFrame("Frame")
+		noterChannelFrame:RegisterEvent("CHAT_MSG_CHANNEL")
+		noterChannelFrame:SetScript("OnEvent", function(self, event, msg, sender, ...)
+			--if Heimdall_Data.config.noter.debug then
+			--	print(string.format("[%s] Event received", ModuleName))
+			--	shared.dump(Heimdall_Data.config.noter)
+			--end
+			if not Heimdall_Data.config.noter.enabled then
+				--if Heimdall_Data.config.noter.debug then
+				--	print(string.format("[%s] Module disabled, ignoring event", ModuleName))
+				--end
+				return
+			end
+			local channelId = select(6, ...)
+			local _, channelname = GetChannelName(channelId)
+			local ok = false
+			for _, channel in pairs(Heimdall_Data.config.noter.channels) do
+				if channelname == channel then
+					ok = true
+					break
+				end
+			end
+			if not ok then
+				--if Heimdall_Data.config.noter.debug then
+				--	print(string.format("[%s] Channel %s does not match the master channel %s", ModuleName, channelname, Heimdall_Data.config.noter.masterChannel))
+				--end
+				return
+			end
+
+			sender = string.match(sender, "^[^-]+")
+			if Heimdall_Data.config.noter.debug then
+				print(string.format("[%s] Message from: %s", ModuleName, sender))
+				shared.dump(Heimdall_Data.config.noter)
+			end
+
+			if not msg or msg == "" then
+				if Heimdall_Data.config.noter.debug then
+					print(string.format("[%s] Empty message, ignoring", ModuleName))
 				end
 				return
 			end
 
-			if not finish then finish = start end
+			local args = { strsplit(" ", msg) }
 			if Heimdall_Data.config.noter.debug then
-				print(string.format("[%s] Printing note range %s to %s for: %s", ModuleName, start, finish, name))
+				print(string.format("[%s] Arguments received: %s", ModuleName, table.concat(args, ", ")))
+				shared.dump(args)
 			end
-
-			for i = start, finish do
-				if not Heimdall_Data.config.notes[name] then Heimdall_Data.config.notes[name] = {} end
-				if not Heimdall_Data.config.notes[name][i] then
-					if Heimdall_Data.config.noter.debug then
-						print(string.format("[%s] Note at index %s does not exist", ModuleName, i))
-					end
+			local command = args[1]
+			if command == "note" then
+				local name = strtrim(string.lower(args[2] or ""))
+				if Heimdall_Data.config.noter.debug then
+					print(string.format("[%s] Note command received for: %s", ModuleName, name))
+				end
+				local note = strtrim(args[3] or "")
+				if Heimdall_Data.config.noter.debug then print(string.format("[%s] Note: %s", ModuleName, note)) end
+				if note == "delete" then
+					DeleteNotes(name, args)
+				elseif string.find(note, "^[%d%.]*$") then
+					PrintNotes(channelname, name, args)
 				else
-					if Heimdall_Data.config.noter.debug then
-						print(string.format("[%s] Printing note %s at index %s", ModuleName, name, i))
-						shared.dumpTable(Heimdall_Data.config.notes[name][i])
-					end
-					PrintNote(channel, i, Heimdall_Data.config.notes[name][i])
+					AddNote(name, sender, args)
 				end
 			end
-		end
-	end
+		end)
 
-	---@param name string
-	---@param sender string
-	---@param args string[]
-	local function AddNote(name, sender, args)
-		if not Heimdall_Data.config.notes[name] then Heimdall_Data.config.notes[name] = {} end
-		if Heimdall_Data.config.noter.debug then
-			print(string.format("[%s] Adding note for: %s from: %s", ModuleName, name, sender))
-			shared.dumpTable(args)
-		end
-		local msgparts = {}
-		for i = 3, #args do
-			msgparts[#msgparts + 1] = args[i]
-		end
-		local msg = table.concat(msgparts, " ")
-
-		if Heimdall_Data.config.noter.debug then
-			print(string.format("[%s] Adding note for: %s from: %s", ModuleName, name, sender))
-			print(string.format("[%s] Note: %s", ModuleName, msg))
-		end
-
-		local note = {
-			source = sender,
-			date = date("%Y-%m-%dT%H:%M:%S"),
-			note = msg,
-		}
-
-		if Heimdall_Data.config.noter.debug then
-			print(string.format("[%s] Adding note", ModuleName))
-			shared.dumpTable(note)
-		end
-		table.insert(Heimdall_Data.config.notes[name], note)
-	end
-
-	-- Here's the plan:
-	-- Implement a "note" command, that will do everything
-	-- Saying "note <name> <note>" will add a note to the list for the character
-	-- Saying "note <name>" will list last N notes
-	-- Saying "note <name> i" will list the i-th note
-	-- Saying "note <name> i..j" will list notes from i to j
-	-- Saying "note <name> delete i" will delete the i-th note
-	-- Saying "note <name> delete i..j" will delete notes from i to j
-	local noterChannelFrame = CreateFrame("Frame")
-	noterChannelFrame:RegisterEvent("CHAT_MSG_CHANNEL")
-	noterChannelFrame:SetScript("OnEvent", function(self, event, msg, sender, ...)
-		--if Heimdall_Data.config.noter.debug then
-		--	print(string.format("[%s] Event received", ModuleName))
-		--	shared.dumpTable(Heimdall_Data.config.noter)
-		--end
-		if not Heimdall_Data.config.noter.enabled then
-			--if Heimdall_Data.config.noter.debug then
-			--	print(string.format("[%s] Module disabled, ignoring event", ModuleName))
-			--end
-			return
-		end
-		local channelId = select(6, ...)
-		local _, channelname = GetChannelName(channelId)
-		local ok = false
-		for _, channel in pairs(Heimdall_Data.config.noter.channels) do
-			if channelname == channel then
-				ok = true
-				break
-			end
-		end
-		if not ok then
-			--if Heimdall_Data.config.noter.debug then
-			--	print(string.format("[%s] Channel %s does not match the master channel %s", ModuleName, channelname, Heimdall_Data.config.noter.masterChannel))
-			--end
-			return
-		end
-
-		sender = string.match(sender, "^[^-]+")
-		if Heimdall_Data.config.noter.debug then
-			print(string.format("[%s] Message from: %s", ModuleName, sender))
-			shared.dumpTable(Heimdall_Data.config.noter)
-		end
-
-		if not msg or msg == "" then
-			if Heimdall_Data.config.noter.debug then
-				print(string.format("[%s] Empty message, ignoring", ModuleName))
-			end
-			return
-		end
-
-		local args = { strsplit(" ", msg) }
-		if Heimdall_Data.config.noter.debug then
-			print(string.format("[%s] Arguments received: %s", ModuleName, table.concat(args, ", ")))
-			shared.dumpTable(args)
-		end
-		local command = args[1]
-		if command == "note" then
-			local name = strtrim(string.lower(args[2] or ""))
-			if Heimdall_Data.config.noter.debug then
-				print(string.format("[%s] Note command received for: %s", ModuleName, name))
-			end
-			local note = strtrim(args[3] or "")
-			if Heimdall_Data.config.noter.debug then print(string.format("[%s] Note: %s", ModuleName, note)) end
-			if note == "delete" then
-				DeleteNotes(name, args)
-			elseif string.find(note, "^[%d%.]*$") then
-				PrintNotes(channelname, name, args)
-			else
-				AddNote(name, sender, args)
-			end
-		end
-	end)
-
-	print("[Heimdall] Commander module loaded")
-end
+		print("[Heimdall] Commander module loaded")
+	end,
+}

Modules/ReactiveValue.lua

@@ -483,7 +483,7 @@ local function Init()
 	-- S local clbk = test:onChange(function(value)
 	-- S     invocations = invocations + 1
 	-- S     print("test changed to")
-	-- S     dumpTable(value, 0)
+	-- S     dump(value, 0)
 	-- S end)
 	-- S test:set({1, 2, 3, 4})
 	-- S assert(invocations == 1)
@@ -516,7 +516,7 @@ local function Init()
 	-- S test:once(function(value)
 	-- S     invocations = invocations + 1
 	-- S     print("test changed to")
-	-- S     dumpTable(value, 0)
+	-- S     dump(value, 0)
 	-- S end)
 	-- S test:set({3, 2, 1})
 	-- S assert(invocations == 1)
@@ -527,7 +527,7 @@ local function Init()
 	-- S test:onChange(function(value)
 	-- S     invocations = invocations + 1
 	-- S     print("test changed to")
-	-- S     dumpTable(value, 0)
+	-- S     dump(value, 0)
 	-- S end)
 	-- S test:onAnyFieldChange(function(field, value)
 	-- S     invocations = invocations + 1

Modules/Sniffer.lua

@@ -2,82 +2,91 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "Sniffer"
 
----@diagnostic disable-next-line: missing-fields
-shared.Sniffer = {}
-function shared.Sniffer.Init()
-	if Heimdall_Data.config.sniffer.debug then print(string.format("[%s] Module initializing", ModuleName)) end
-	local smellThrottle = {}
-	local SmellStinky = function(stinky)
-		if Heimdall_Data.config.sniffer.debug then
-			print(string.format("%s: SmellStinky", ModuleName))
-			shared.dumpTable(Heimdall_Data.config.sniffer)
-		end
-		if not Heimdall_Data.config.sniffer.enabled then return end
-		if Heimdall_Data.config.sniffer.stinky and not shared.IsStinky(stinky) then
-			if Heimdall_Data.config.sniffer.debug then
-				print(string.format("%s: Stinky not found in config", ModuleName))
-			end
-			return
-		end
-		if smellThrottle[stinky] and GetTime() - smellThrottle[stinky] < Heimdall_Data.config.sniffer.throttleTime then
-			if Heimdall_Data.config.sniffer.debug then print(string.format("%s: Throttled", ModuleName)) end
-			return
-		end
-		smellThrottle[stinky] = GetTime()
+---@class HeimdallSnifferConfig
+---@field enabled boolean
+---@field debug boolean
+---@field channels string[]
+---@field throttle number -- throttleTime in the original code, matching config name now
+---@field zoneOverride string?
+---@field stinky boolean
 
-		for _, channel in pairs(Heimdall_Data.config.sniffer.channels) do
-			local locale = shared.GetLocaleForChannel(channel)
-			local text = string.format(shared._L("snifferStinky", locale), stinky)
-			---@type Message
-			local msg = {
-				channel = "C",
-				data = channel,
-				message = text,
-			}
+---@class Sniffer
+shared.Sniffer = {
+	Init = function()
+		if Heimdall_Data.config.sniffer.debug then print(string.format("[%s] Module initializing", ModuleName)) end
+		local smellThrottle = {}
+		local SmellStinky = function(stinky)
 			if Heimdall_Data.config.sniffer.debug then
-				print(string.format("[%s] Queuing sniffer message", ModuleName))
-				shared.dumpTable(msg)
+				print(string.format("%s: SmellStinky", ModuleName))
+				shared.dump(Heimdall_Data.config.sniffer)
 			end
-			table.insert(shared.messenger.queue, msg)
-		end
-	end
+			if not Heimdall_Data.config.sniffer.enabled then return end
+			if Heimdall_Data.config.sniffer.stinky and not shared.IsStinky(stinky) then
+				if Heimdall_Data.config.sniffer.debug then
+					print(string.format("%s: Stinky not found in config", ModuleName))
+				end
+				return
+			end
+			if smellThrottle[stinky] and GetTime() - smellThrottle[stinky] < Heimdall_Data.config.sniffer.throttle then
+				if Heimdall_Data.config.sniffer.debug then print(string.format("%s: Throttled", ModuleName)) end
+				return
+			end
+			smellThrottle[stinky] = GetTime()
 
-	local cleuFrame = CreateFrame("Frame")
-	cleuFrame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
-	cleuFrame:SetScript("OnEvent", function(self, event, ...)
-		if Heimdall_Data.config.sniffer.debug then
-			print(string.format("[%s] Received event: %s", ModuleName, event))
-		end
-		if not Heimdall_Data.config.sniffer.enabled then
-			if Heimdall_Data.config.sniffer.debug then
-				print(string.format("[%s] Module disabled, ignoring event", ModuleName))
+			for _, channel in pairs(Heimdall_Data.config.sniffer.channels) do
+				local locale = shared.GetLocaleForChannel(channel)
+				local text = string.format(shared._L("snifferStinky", locale), stinky)
+				---@type Message
+				local msg = {
+					channel = "C",
+					data = channel,
+					message = text,
+				}
+				if Heimdall_Data.config.sniffer.debug then
+					print(string.format("[%s] Queuing sniffer message", ModuleName))
+					shared.dump(msg)
+				end
+				table.insert(shared.messenger.queue, msg)
 			end
-			return
 		end
-		local source, destination, err
-		source, err = CLEUParser.GetSourceName(...)
-		if Heimdall_Data.config.sniffer.debug then
-			print(string.format("[%s] Processing source: %s", ModuleName, source))
-		end
-		if err then
+
+		local cleuFrame = CreateFrame("Frame")
+		cleuFrame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
+		cleuFrame:SetScript("OnEvent", function(self, event, ...)
 			if Heimdall_Data.config.sniffer.debug then
-				print(string.format("[%s] Error parsing source: %s", ModuleName, err))
+				print(string.format("[%s] Received event: %s", ModuleName, event))
 			end
-			return
-		end
-		SmellStinky(source)
-		destination, err = CLEUParser.GetDestName(...)
-		if Heimdall_Data.config.sniffer.debug then
-			print(string.format("[%s] Processing destination: %s", ModuleName, destination))
-		end
-		if err then
+			if not Heimdall_Data.config.sniffer.enabled then
+				if Heimdall_Data.config.sniffer.debug then
+					print(string.format("[%s] Module disabled, ignoring event", ModuleName))
+				end
+				return
+			end
+			local source, destination, err
+			source, err = CLEUParser.GetSourceName(...)
 			if Heimdall_Data.config.sniffer.debug then
-				print(string.format("[%s] Error parsing destination: %s", ModuleName, err))
+				print(string.format("[%s] Processing source: %s", ModuleName, source))
 			end
-			return
-		end
-		SmellStinky(destination)
-	end)
-	if Heimdall_Data.config.sniffer.debug then print(string.format("[%s] Module initialized", ModuleName)) end
-	print("[Heimdall] Sniffer loaded")
-end
+			if err then
+				if Heimdall_Data.config.sniffer.debug then
+					print(string.format("[%s] Error parsing source: %s", ModuleName, err))
+				end
+				return
+			end
+			SmellStinky(source)
+			destination, err = CLEUParser.GetDestName(...)
+			if Heimdall_Data.config.sniffer.debug then
+				print(string.format("[%s] Processing destination: %s", ModuleName, destination))
+			end
+			if err then
+				if Heimdall_Data.config.sniffer.debug then
+					print(string.format("[%s] Error parsing destination: %s", ModuleName, err))
+				end
+				return
+			end
+			SmellStinky(destination)
+		end)
+		if Heimdall_Data.config.sniffer.debug then print(string.format("[%s] Module initialized", ModuleName)) end
+		print("[Heimdall] Sniffer loaded")
+	end,
+}

Modules/Spotter.lua

@@ -2,223 +2,237 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "Spotter"
 
----@diagnostic disable-next-line: missing-fields
-shared.Spotter = {}
-function shared.Spotter.Init()
-	local function FormatHP(hp)
-		if hp > 1e9 then
-			return string.format("%.1fB", hp / 1e9)
-		elseif hp > 1e6 then
-			return string.format("%.1fM", hp / 1e6)
-		elseif hp > 1e3 then
-			return string.format("%.1fK", hp / 1e3)
-		else
-			return hp
-		end
-	end
+---@class HeimdallSpotterConfig
+---@field enabled boolean
+---@field debug boolean
+---@field everyone boolean
+---@field hostile boolean
+---@field alliance boolean
+---@field stinky boolean
+---@field channels string[]
+---@field zoneOverride string?
+---@field throttleTime number
 
-	---@type table<string, number>
-	local throttleTable = {}
-
-	---@param unit string
-	---@param name string
-	---@param faction string
-	---@param hostile boolean
-	---@return boolean
-	---@return string? error
-	local function ShouldNotify(unit, name, faction, hostile)
-		if Heimdall_Data.config.spotter.debug then
-			print(string.format("[%s] Checking notification criteria for %s (%s)", ModuleName, name, faction))
+---@class Spotter
+shared.Spotter = {
+	Init = function()
+		local function FormatHP(hp)
+			if hp > 1e9 then
+				return string.format("%.1fB", hp / 1e9)
+			elseif hp > 1e6 then
+				return string.format("%.1fM", hp / 1e6)
+			elseif hp > 1e3 then
+				return string.format("%.1fK", hp / 1e3)
+			else
+				return hp
+			end
 		end
 
-		if Heimdall_Data.config.agents[name] then
+		---@type table<string, number>
+		local throttleTable = {}
+
+		---@param unit string
+		---@param name string
+		---@param faction string
+		---@param hostile boolean
+		---@return boolean
+		---@return string? error
+		local function ShouldNotify(unit, name, faction, hostile)
 			if Heimdall_Data.config.spotter.debug then
-				print(string.format("[%s] Skipping agent: %s", ModuleName, name))
+				print(string.format("[%s] Checking notification criteria for %s (%s)", ModuleName, name, faction))
 			end
-			return false
-		end
 
-		if Heimdall_Data.config.spotter.stinky then
-			if shared.IsStinky(name) then
+			if shared.AgentTracker.IsAgent(name) then
 				if Heimdall_Data.config.spotter.debug then
-					print(string.format("[%s] Notifying - Found stinky: %s", ModuleName, name))
+					print(string.format("[%s] Skipping agent: %s", ModuleName, name))
 				end
-				return true
+				return false
 			end
-		end
 
-		if Heimdall_Data.config.spotter.alliance then
-			if faction == "Alliance" then
-				if Heimdall_Data.config.spotter.debug then
-					print(string.format("[%s] Notifying - Found Alliance player: %s", ModuleName, name))
+			if Heimdall_Data.config.spotter.stinky then
+				if shared.IsStinky(name) then
+					if Heimdall_Data.config.spotter.debug then
+						print(string.format("[%s] Notifying - Found stinky: %s", ModuleName, name))
+					end
+					return true
 				end
-				return true
 			end
-		end
 
-		if Heimdall_Data.config.spotter.hostile then
-			if hostile then
-				if Heimdall_Data.config.spotter.debug then
-					print(string.format("[%s] Notifying - Found hostile player: %s", ModuleName, name))
+			if Heimdall_Data.config.spotter.alliance then
+				if faction == "Alliance" then
+					if Heimdall_Data.config.spotter.debug then
+						print(string.format("[%s] Notifying - Found Alliance player: %s", ModuleName, name))
+					end
+					return true
 				end
-				return true
 			end
-		end
 
-		if Heimdall_Data.config.spotter.debug then
-			print(
-				string.format(
-					"[%s] Using everyone setting: %s",
-					ModuleName,
-					tostring(Heimdall_Data.config.spotter.everyone)
+			if Heimdall_Data.config.spotter.hostile then
+				if hostile then
+					if Heimdall_Data.config.spotter.debug then
+						print(string.format("[%s] Notifying - Found hostile player: %s", ModuleName, name))
+					end
+					return true
+				end
+			end
+
+			if Heimdall_Data.config.spotter.debug then
+				print(
+					string.format(
+						"[%s] Using everyone setting: %s",
+						ModuleName,
+						tostring(Heimdall_Data.config.spotter.everyone)
+					)
 				)
-			)
-		end
-		return Heimdall_Data.config.spotter.everyone
-	end
-
-	---@param unit string
-	---@return string?
-	local function NotifySpotted(unit)
-		if Heimdall_Data.config.spotter.debug then
-			print(string.format("[%s] Processing spotted unit: %s", ModuleName, unit))
-		end
-
-		if not unit then return string.format("Could not find unit %s", tostring(unit)) end
-		if not UnitIsPlayer(unit) then
-			if Heimdall_Data.config.spotter.debug then
-				print(string.format("[%s] Ignoring non-player unit: %s", ModuleName, unit))
 			end
-			return nil
+			return Heimdall_Data.config.spotter.everyone
 		end
 
-		local name = UnitName(unit)
-		if not name then return string.format("Could not find name for unit %s", tostring(unit)) end
-		if Heimdall_Data.config.spotter.debug then
-			print(string.format("[%s] Processing player: %s", ModuleName, name))
-		end
-
-		local time = GetTime()
-		if throttleTable[name] and time - throttleTable[name] < Heimdall_Data.config.spotter.throttleTime then
+		---@param unit string
+		---@return string?
+		local function NotifySpotted(unit)
 			if Heimdall_Data.config.spotter.debug then
-				local remainingTime = Heimdall_Data.config.spotter.throttleTime - (time - throttleTable[name])
-				print(string.format("[%s] Player %s throttled for %.1f more seconds", ModuleName, name, remainingTime))
+				print(string.format("[%s] Processing spotted unit: %s", ModuleName, unit))
 			end
-			return string.format("Throttled %s", tostring(name))
-		end
-		throttleTable[name] = time
 
-		local race = UnitRace(unit)
-		if not race then return string.format("Could not find race for unit %s", tostring(unit)) end
-		local faction = shared.raceMap[race]
-		if not faction then return string.format("Could not find faction for race %s", tostring(race)) end
-		if Heimdall_Data.config.spotter.debug then
-			print(string.format("[%s] Player %s is %s (%s)", ModuleName, name, race, faction))
-		end
-
-		local hostile = UnitCanAttack("player", unit)
-		if Heimdall_Data.config.spotter.debug then
-			print(string.format("[%s] Player %s is %s", ModuleName, name, hostile and "hostile" or "friendly"))
-		end
-
-		local doNotify = ShouldNotify(unit, name, faction, hostile)
-		if not doNotify then
-			if Heimdall_Data.config.spotter.debug then
-				print(string.format("[%s] Skipping notification for %s", ModuleName, name))
+			if not unit then return string.format("Could not find unit %s", tostring(unit)) end
+			if not UnitIsPlayer(unit) then
+				if Heimdall_Data.config.spotter.debug then
+					print(string.format("[%s] Ignoring non-player unit: %s", ModuleName, unit))
+				end
+				return nil
 			end
-			return string.format("Not notifying for %s", tostring(name))
-		end
 
-		local hp = UnitHealth(unit)
-		if not hp then return string.format("Could not find hp for unit %s", tostring(unit)) end
-		local maxHp = UnitHealthMax(unit)
-		if not maxHp then return string.format("Could not find maxHp for unit %s", tostring(unit)) end
-		if Heimdall_Data.config.spotter.debug then
-			print(string.format("[%s] Player %s health: %s/%s", ModuleName, name, FormatHP(hp), FormatHP(maxHp)))
-		end
-
-		local class = UnitClass(unit)
-		if not class then return string.format("Could not find class for unit %s", tostring(unit)) end
-
-		local zone, subzone = GetZoneText() or "Unknown", GetSubZoneText() or "Unknown"
-		if Heimdall_Data.config.spotter.zoneOverride then
-			zone = Heimdall_Data.config.spotter.zoneOverride or ""
-			subzone = ""
-		end
-
-		local x, y = GetPlayerMapPosition("player")
-		if Heimdall_Data.config.spotter.debug then
-			print(string.format("[%s] Player %s coordinates: %.2f, %.2f", ModuleName, name, x * 100, y * 100))
-		end
-
-		local pvpOn = UnitIsPVP(unit)
-		local stinky = shared.IsStinky(name) or false
-		SetMapToCurrentZone()
-		SetMapByID(GetCurrentMapAreaID())
-		local areaId = tostring(GetCurrentMapAreaID())
-
-		for _, channel in pairs(Heimdall_Data.config.spotter.channels) do
+			local name = UnitName(unit)
+			if not name then return string.format("Could not find name for unit %s", tostring(unit)) end
 			if Heimdall_Data.config.spotter.debug then
-				print(string.format("[%s] Processing channel: %s", ModuleName, channel))
+				print(string.format("[%s] Processing player: %s", ModuleName, name))
 			end
-			local locale = shared.GetLocaleForChannel(channel)
-			local text = string.format(
-				shared._L("spotterSpotted", locale),
-				hostile and shared._L("hostile", locale) or shared._L("friendly", locale),
-				name,
-				shared._L(class, locale),
-				stinky and string.format("(%s)", "!!!!") or "",
-				shared._L(race, locale),
-				shared._L(faction, locale),
-				pvpOn and shared._L("pvpOn", locale) or shared._L("pvpOff", locale),
-				string.gsub(FormatHP(hp), "M", "kk"),
-				string.gsub(FormatHP(maxHp), "M", "kk"),
-				shared._L(zone, locale),
-				shared._L(subzone, locale),
-				areaId,
-				x * 100,
-				y * 100
-			)
 
-			---@type Message
-			local msg = {
-				channel = "C",
-				data = channel,
-				message = text,
-			}
-			if Heimdall_Data.config.spotter.debug then
-				print(string.format("[%s] Queuing spotter message", ModuleName))
-				shared.dumpTable(msg)
+			local time = GetTime()
+			if throttleTable[name] and time - throttleTable[name] < Heimdall_Data.config.spotter.throttleTime then
+				if Heimdall_Data.config.spotter.debug then
+					local remainingTime = Heimdall_Data.config.spotter.throttleTime - (time - throttleTable[name])
+					print(
+						string.format("[%s] Player %s throttled for %.1f more seconds", ModuleName, name, remainingTime)
+					)
+				end
+				return string.format("Throttled %s", tostring(name))
 			end
-			table.insert(shared.messenger.queue, msg)
-		end
-	end
+			throttleTable[name] = time
 
-	local frame = CreateFrame("Frame")
-	frame:RegisterEvent("NAME_PLATE_UNIT_ADDED")
-	frame:RegisterEvent("UNIT_TARGET")
-	frame:SetScript("OnEvent", function(self, event, unit)
-		if Heimdall_Data.config.spotter.debug then
-			print(string.format("[%s] Event received: %s for unit: %s", ModuleName, event, unit or "target"))
-		end
-
-		if not Heimdall_Data.config.spotter.enabled then
+			local race = UnitRace(unit)
+			if not race then return string.format("Could not find race for unit %s", tostring(unit)) end
+			local faction = shared.raceMap[race]
+			if not faction then return string.format("Could not find faction for race %s", tostring(race)) end
 			if Heimdall_Data.config.spotter.debug then
-				print(string.format("[%s] Module disabled, ignoring event", ModuleName))
+				print(string.format("[%s] Player %s is %s (%s)", ModuleName, name, race, faction))
 			end
-			return
-		end
 
-		if event == "UNIT_TARGET" then unit = "target" end
-
-		local err = NotifySpotted(unit)
-		if err then
+			local hostile = UnitCanAttack("player", unit)
 			if Heimdall_Data.config.spotter.debug then
-				print(string.format("[%s] Error processing unit %s: %s", ModuleName, unit, err))
+				print(string.format("[%s] Player %s is %s", ModuleName, name, hostile and "hostile" or "friendly"))
+			end
+
+			local doNotify = ShouldNotify(unit, name, faction, hostile)
+			if not doNotify then
+				if Heimdall_Data.config.spotter.debug then
+					print(string.format("[%s] Skipping notification for %s", ModuleName, name))
+				end
+				return string.format("Not notifying for %s", tostring(name))
+			end
+
+			local hp = UnitHealth(unit)
+			if not hp then return string.format("Could not find hp for unit %s", tostring(unit)) end
+			local maxHp = UnitHealthMax(unit)
+			if not maxHp then return string.format("Could not find maxHp for unit %s", tostring(unit)) end
+			if Heimdall_Data.config.spotter.debug then
+				print(string.format("[%s] Player %s health: %s/%s", ModuleName, name, FormatHP(hp), FormatHP(maxHp)))
+			end
+
+			local class = UnitClass(unit)
+			if not class then return string.format("Could not find class for unit %s", tostring(unit)) end
+
+			local zone, subzone = GetZoneText() or "Unknown", GetSubZoneText() or "Unknown"
+			if Heimdall_Data.config.spotter.zoneOverride then
+				zone = Heimdall_Data.config.spotter.zoneOverride or ""
+				subzone = ""
+			end
+
+			local x, y = GetPlayerMapPosition("player")
+			if Heimdall_Data.config.spotter.debug then
+				print(string.format("[%s] Player %s coordinates: %.2f, %.2f", ModuleName, name, x * 100, y * 100))
+			end
+
+			local pvpOn = UnitIsPVP(unit)
+			local stinky = shared.IsStinky(name) or false
+			SetMapToCurrentZone()
+			SetMapByID(GetCurrentMapAreaID())
+			local areaId = tostring(GetCurrentMapAreaID())
+
+			for _, channel in pairs(Heimdall_Data.config.spotter.channels) do
+				if Heimdall_Data.config.spotter.debug then
+					print(string.format("[%s] Processing channel: %s", ModuleName, channel))
+				end
+				local locale = shared.GetLocaleForChannel(channel)
+				local text = string.format(
+					shared._L("spotterSpotted", locale),
+					hostile and shared._L("hostile", locale) or shared._L("friendly", locale),
+					name,
+					shared._L(class, locale),
+					stinky and string.format("(%s)", "!!!!") or "",
+					shared._L(race, locale),
+					shared._L(faction, locale),
+					pvpOn and shared._L("pvpOn", locale) or shared._L("pvpOff", locale),
+					string.gsub(FormatHP(hp), "M", "kk"),
+					string.gsub(FormatHP(maxHp), "M", "kk"),
+					shared._L(zone, locale),
+					shared._L(subzone, locale),
+					areaId,
+					x * 100,
+					y * 100
+				)
+
+				---@type Message
+				local msg = {
+					channel = "C",
+					data = channel,
+					message = text,
+				}
+				if Heimdall_Data.config.spotter.debug then
+					print(string.format("[%s] Queuing spotter message", ModuleName))
+					shared.dump(msg)
+				end
+				table.insert(shared.messenger.queue, msg)
 			end
 		end
-	end)
 
-	if Heimdall_Data.config.spotter.debug then print(string.format("[%s] Module initialized", ModuleName)) end
-	print("[Heimdall] Spotter loaded")
-end
+		local frame = CreateFrame("Frame")
+		frame:RegisterEvent("NAME_PLATE_UNIT_ADDED")
+		frame:RegisterEvent("UNIT_TARGET")
+		frame:SetScript("OnEvent", function(self, event, unit)
+			if Heimdall_Data.config.spotter.debug then
+				print(string.format("[%s] Event received: %s for unit: %s", ModuleName, event, unit or "target"))
+			end
+
+			if not Heimdall_Data.config.spotter.enabled then
+				if Heimdall_Data.config.spotter.debug then
+					print(string.format("[%s] Module disabled, ignoring event", ModuleName))
+				end
+				return
+			end
+
+			if event == "UNIT_TARGET" then unit = "target" end
+
+			local err = NotifySpotted(unit)
+			if err then
+				if Heimdall_Data.config.spotter.debug then
+					print(string.format("[%s] Error processing unit %s: %s", ModuleName, unit, err))
+				end
+			end
+		end)
+
+		if Heimdall_Data.config.spotter.debug then print(string.format("[%s] Module initialized", ModuleName)) end
+		print("[Heimdall] Spotter loaded")
+	end,
+}

Modules/StinkyCache.lua

@@ -1,72 +1,83 @@
-local addonname, shared = ...
+local _, shared = ...
 ---@cast shared HeimdallShared
----@cast addonname string
 local ModuleName = "StinkyCache"
 
----@diagnostic disable-next-line: missing-fields
-shared.StinkyCache = {}
-function shared.StinkyCache.Init()
-	shared.stinkyCache = {
-		stinkies = {},
-	}
+---@class HeimdallStinkyCacheConfig
+---@field enabled boolean
+---@field debug boolean
+---@field commander string
+---@field ttl number
 
-	---@param name string
-	local function AskCommander(name)
-		if Heimdall_Data.config.stinkyCache.debug then
-			print(
-				string.format(
-					"[%s] Asking commander %s about %s",
-					ModuleName,
-					Heimdall_Data.config.stinkyCache.commander,
-					name
-				)
-			)
-		end
-		local messageParts = { "isstinky", name }
-		local message = table.concat(messageParts, "|")
-		SendAddonMessage(
-			Heimdall_Data.config.addonPrefix,
-			message,
-			"WHISPER",
-			Heimdall_Data.config.stinkyCache.commander
-		)
-		return
-	end
+---@class HeimdallStinkyCacheData
+---@field stinkies table<string, {value: number, timestamp: number}>
 
-	local addonMessageFrame = CreateFrame("Frame")
-	addonMessageFrame:RegisterEvent("CHAT_MSG_ADDON")
-	addonMessageFrame:SetScript("OnEvent", function(self, event, msg, sender, ...)
-		if sender == Heimdall_Data.config.stinkyCache.commander then
+---@class StinkyCache
+shared.StinkyCache = {
+	Init = function()
+		shared.stinkyCache = {
+			stinkies = {},
+		}
+
+		---@param name string
+		local function AskCommander(name)
 			if Heimdall_Data.config.stinkyCache.debug then
 				print(
 					string.format(
-						"[%s] Received stinky from commander %s: %s",
+						"[%s] Asking commander %s about %s",
 						ModuleName,
 						Heimdall_Data.config.stinkyCache.commander,
-						msg
+						name
 					)
 				)
 			end
-			local parts = { strsplit("|", msg) }
-			local name, value = parts[1], parts[2]
-			shared.stinkyCache.stinkies[name] = { value = value, timestamp = time() }
-		else
-			if Heimdall_Data.config.stinkyCache.debug then
-				print(string.format("[%s] Received stinky from non-commander %s: %s", ModuleName, sender, msg))
-			end
-			local parts = { strsplit("|", msg) }
-			local command, name = parts[1], parts[2]
-			if parts[1] == "isstinky" then local res = Heimdall_Data.config.stinkies[parts[2]] end
+			local messageParts = { "isstinky", name }
+			local message = table.concat(messageParts, "|")
+			SendAddonMessage(
+				Heimdall_Data.config.addonPrefix,
+				message,
+				"WHISPER",
+				Heimdall_Data.config.stinkyCache.commander
+			)
+			return
 		end
-	end)
 
-	setmetatable(shared.stinkyCache.stinkies, {
-		__index = function(self, key)
-			local value = rawget(self, key)
-			local now = GetTime()
-			if value == nil or now - value.timestamp > Heimdall_Data.config.stinkyCache.ttl then AskCommander(key) end
-			return rawget(self, key)
-		end,
-	})
-	print("[Heimdall] StinkyCache module loaded")
-end
+		local addonMessageFrame = CreateFrame("Frame")
+		addonMessageFrame:RegisterEvent("CHAT_MSG_ADDON")
+		addonMessageFrame:SetScript("OnEvent", function(self, event, msg, sender, ...)
+			if sender == Heimdall_Data.config.stinkyCache.commander then
+				if Heimdall_Data.config.stinkyCache.debug then
+					print(
+						string.format(
+							"[%s] Received stinky from commander %s: %s",
+							ModuleName,
+							Heimdall_Data.config.stinkyCache.commander,
+							msg
+						)
+					)
+				end
+				local parts = { strsplit("|", msg) }
+				local name, value = parts[1], parts[2]
+				shared.stinkyCache.stinkies[name] = { value = value, timestamp = time() }
+			else
+				if Heimdall_Data.config.stinkyCache.debug then
+					print(string.format("[%s] Received stinky from non-commander %s: %s", ModuleName, sender, msg))
+				end
+				local parts = { strsplit("|", msg) }
+				local command, name = parts[1], parts[2]
+				if parts[1] == "isstinky" then local res = Heimdall_Data.config.stinkies[parts[2]] end
+			end
+		end)
+
+		setmetatable(shared.stinkyCache.stinkies, {
+			__index = function(self, key)
+				local value = rawget(self, key)
+				local now = GetTime()
+				if value == nil or now - value.timestamp > Heimdall_Data.config.stinkyCache.ttl then
+					AskCommander(key)
+				end
+				return rawget(self, key)
+			end,
+		})
+		print("[Heimdall] StinkyCache module loaded")
+	end,
+}

Modules/StinkyTracker.lua

@@ -2,276 +2,363 @@ local _, shared = ...
 ---@cast shared HeimdallShared
 local ModuleName = "StinkyTracker"
 
----@diagnostic disable-next-line: missing-fields
-shared.StinkyTracker = {}
-function shared.StinkyTracker.Init()
-	shared.stinkyTracker = {
-		stinkies = ReactiveValue.new({}),
-	}
+---@class Stinky
+---@field name string
+---@field class string
+---@field seenAt number
+---@field hostile boolean
 
-	local whoRegex = "([^ -/]+)-?%w*/(%w+)"
-	---@param msg string
-	---@return table<string, stinky>
-	local function ParseWho(msg)
+---@class HeimdallStinkyTrackerConfig
+---@field enabled boolean
+---@field debug boolean
+---@field ignoredTimeout number
+---@field channels string[]
+
+---@class StinkyTrackerData
+---@field stinkies ReactiveValue<table<string, Stinky>>
+---@field ignored ReactiveValue<table<string, number>>
+
+---@class 	StinkyTracker
+shared.StinkyTracker = {
+	---@param stinky Stinky
+	---@return boolean
+	Track = function(stinky)
 		if Heimdall_Data.config.stinkyTracker.debug then
-			print(string.format("[%s] Parsing WHO message: '%s'", ModuleName, msg))
+			print(string.format("[%s] Request to track stinky: %s (%s)", ModuleName, stinky.name, stinky.class))
 		end
-		local stinkies = {}
-		for name, class in string.gmatch(msg, whoRegex) do
-			stinkies[name] = {
+		local ignored = shared.stinkyTracker.ignored[stinky.name]
+		-- TODO: Add a config option for the ignored timeout
+		if ignored and ignored > GetTime() - 60 then
+			if Heimdall_Data.config.stinkyTracker.debug then
+				print(
+					string.format(
+						"[%s] Stinky is ignored, not tracking: %s (%s)",
+						ModuleName,
+						stinky.name,
+						stinky.class
+					)
+				)
+				shared.dump(shared.stinkyTracker.ignored:get())
+				shared.dump(shared.stinkyTracker.stinkies:get())
+			end
+			return false
+		else
+			-- Timed out or was never ignored
+			shared.stinkyTracker.stinkies[stinky.name] = nil
+		end
+
+		shared.stinkyTracker.stinkies[stinky.name] = stinky
+		if Heimdall_Data.config.stinkyTracker.debug then
+			print(string.format("[%s] Stinky is now tracked: %s (%s)", ModuleName, stinky.name, stinky.class))
+			shared.dump(shared.stinkyTracker.stinkies:get())
+			shared.dump(shared.stinkyTracker.ignored:get())
+		end
+		return true
+	end,
+
+	---@param name string
+	---@return nil
+	Ignore = function(name)
+		if Heimdall_Data.config.stinkyTracker.debug then
+			print(string.format("[%s] Request to ignore stinky: %s", ModuleName, name))
+		end
+		shared.stinkyTracker.ignored[name] = GetTime()
+		shared.stinkyTracker.stinkies[name] = nil
+		if Heimdall_Data.config.stinkyTracker.debug then
+			print(string.format("[%s] Stinky is now ignored: %s", ModuleName, name))
+			shared.dump(shared.stinkyTracker.ignored:get())
+			shared.dump(shared.stinkyTracker.stinkies:get())
+		end
+	end,
+
+	---@param name string
+	---@return boolean
+	IsStinky = function(name)
+		if not shared.stinkyTracker.stinkies then return false end
+		if not shared.stinkyTracker.stinkies[name] then return false end
+		if shared.stinkyTracker.ignored[name] then return false end
+		return true
+	end,
+
+	---@param callback fun(stinkies: table<string, Stinky>)
+	---@return nil
+	OnChange = function(callback) shared.stinkyTracker.stinkies:onChange(callback) end,
+
+	---@param callback fun(name: string, stinky: Stinky)
+	---@return nil
+	ForEach = function(callback)
+		---@type table<string, Stinky>
+		local stinkies = shared.stinkyTracker.stinkies:get()
+		for name, stinky in pairs(stinkies) do
+			callback(name, stinky)
+		end
+	end,
+
+	Init = function()
+		shared.stinkyTracker = {
+			stinkies = ReactiveValue.new({}),
+			ignored = ReactiveValue.new({}),
+		}
+
+		local whoRegex = "([^ -/]+)-?%w*/(%w+)"
+		---@param msg string
+		---@return table<string, Stinky>
+		local function ParseWho(msg)
+			if Heimdall_Data.config.stinkyTracker.debug then
+				print(string.format("[%s] Parsing WHO message: '%s'", ModuleName, msg))
+			end
+			local stinkies = {}
+			for name, class in string.gmatch(msg, whoRegex) do
+				stinkies[name] = {
+					name = name,
+					class = class,
+					seenAt = GetTime(),
+					hostile = true,
+				}
+				if Heimdall_Data.config.stinkyTracker.debug then
+					print(
+						string.format(
+							"[%s] Found hostile player: %s (%s) at %s",
+							ModuleName,
+							name,
+							class,
+							date("%H:%M:%S", time())
+						)
+					)
+					shared.dump(stinkies)
+				end
+			end
+			return stinkies
+		end
+
+		local seeRegex = "I see %((%w+)%) ([^ -/]+)-?%w*/(%w+)"
+		---@param msg string
+		---@return table<string, Stinky>
+		local function ParseSee(msg)
+			if Heimdall_Data.config.stinkyTracker.debug then
+				print(string.format("[%s] Parsing SEE message: '%s'", ModuleName, msg))
+			end
+			local stinkies = {}
+			local aggression, name, class = string.match(msg, seeRegex)
+			if not name or not class then
+				if Heimdall_Data.config.stinkyTracker.debug then
+					print(string.format("[%s] Error: Invalid SEE message format", ModuleName))
+				end
+				return stinkies
+			end
+			local stinky = {
+				name = name,
+				class = class,
+				seenAt = GetTime(),
+				hostile = aggression == "hostile",
+			}
+			stinkies[name] = stinky
+			if Heimdall_Data.config.stinkyTracker.debug then
+				print(
+					string.format(
+						"[%s] Found stinky in SEE: %s (%s) - %s at %s",
+						ModuleName,
+						name,
+						class,
+						aggression,
+						date("%H:%M:%S", time())
+					)
+				)
+				shared.dump(stinkies)
+			end
+			return stinkies
+		end
+
+		local arrivedRegex = "([^ -/]+)-?%w*; c:([^;]+)"
+		local arrivedRegexAlt = "([^ -/]+)-?%w*%(!!!!%); c:([^;]+)"
+		---@param msg string
+		---@return table<string, Stinky>
+		local function ParseArrived(msg)
+			if Heimdall_Data.config.stinkyTracker.debug then
+				print(string.format("%s: Parsing arrived message: %s", ModuleName, msg))
+			end
+			local stinkies = {}
+			local name, class = string.match(msg, arrivedRegex)
+			if not name or not class then
+				name, class = string.match(msg, arrivedRegexAlt)
+			end
+			if not name or not class then
+				if Heimdall_Data.config.stinkyTracker.debug then
+					print(string.format("%s: No valid stinky found in arrived message", ModuleName))
+				end
+				return stinkies
+			end
+			local stinky = {
 				name = name,
 				class = class,
 				seenAt = GetTime(),
 				hostile = true,
 			}
+			stinkies[name] = stinky
 			if Heimdall_Data.config.stinkyTracker.debug then
-				print(
-					string.format(
-						"[%s] Found hostile player: %s (%s) at %s",
-						ModuleName,
-						name,
-						class,
-						date("%H:%M:%S", time())
-					)
-				)
-				shared.dumpTable(stinkies)
-			end
-		end
-		return stinkies
-	end
-
-	local seeRegex = "I see %((%w+)%) ([^ -/]+)-?%w*/(%w+)"
-	---@param msg string
-	---@return table<string, stinky>
-	local function ParseSee(msg)
-		if Heimdall_Data.config.stinkyTracker.debug then
-			print(string.format("[%s] Parsing SEE message: '%s'", ModuleName, msg))
-		end
-		local stinkies = {}
-		local aggression, name, class = string.match(msg, seeRegex)
-		if not name or not class then
-			if Heimdall_Data.config.stinkyTracker.debug then
-				print(string.format("[%s] Error: Invalid SEE message format", ModuleName))
+				print(string.format("%s: Found stinky in arrived: %s/%s", ModuleName, name, class))
+				shared.dump(stinkies)
 			end
 			return stinkies
 		end
-		local stinky = {
-			name = name,
-			class = class,
-			seenAt = GetTime(),
-			hostile = aggression == "hostile",
-		}
-		stinkies[name] = stinky
-		if Heimdall_Data.config.stinkyTracker.debug then
-			print(
-				string.format(
-					"[%s] Found stinky in SEE: %s (%s) - %s at %s",
-					ModuleName,
-					name,
-					class,
-					aggression,
-					date("%H:%M:%S", time())
-				)
-			)
-			shared.dumpTable(stinkies)
-		end
-		return stinkies
-	end
 
-	local arrivedRegex = "([^ -/]+)-?%w*; c:([^;]+)"
-	local arrivedRegexAlt = "([^ -/]+)-?%w*%(!!!!%); c:([^;]+)"
-	---@param msg string
-	---@return table<string, stinky>
-	local function ParseArrived(msg)
-		if Heimdall_Data.config.stinkyTracker.debug then
-			print(string.format("%s: Parsing arrived message: %s", ModuleName, msg))
-		end
-		local stinkies = {}
-		local name, class = string.match(msg, arrivedRegex)
-		if not name or not class then
-			name, class = string.match(msg, arrivedRegexAlt)
-		end
-		if not name or not class then
-			if Heimdall_Data.config.stinkyTracker.debug then
-				print(string.format("%s: No valid stinky found in arrived message", ModuleName))
-			end
-			return stinkies
-		end
-		local stinky = {
-			name = name,
-			class = class,
-			seenAt = GetTime(),
-			hostile = true,
-		}
-		stinkies[name] = stinky
-		if Heimdall_Data.config.stinkyTracker.debug then
-			print(string.format("%s: Found stinky in arrived: %s/%s", ModuleName, name, class))
-			shared.dumpTable(stinkies)
-		end
-		return stinkies
-	end
-
-	local frame = CreateFrame("Frame")
-	frame:RegisterEvent("CHAT_MSG_CHANNEL")
-	frame:SetScript("OnEvent", function(self, event, msg, sender, ...)
-		--if Heimdall_Data.config.stinkyTracker.debug then
-		--	print(string.format("[%s] Event received: %s from %s", ModuleName, event, sender))
-		--end
-		if not Heimdall_Data.config.stinkyTracker.enabled then
+		local frame = CreateFrame("Frame")
+		frame:RegisterEvent("CHAT_MSG_CHANNEL")
+		frame:SetScript("OnEvent", function(self, event, msg, sender, ...)
 			--if Heimdall_Data.config.stinkyTracker.debug then
-			--	print(string.format("[%s] Module disabled, ignoring event", ModuleName))
+			--	print(string.format("[%s] Event received: %s from %s", ModuleName, event, sender))
 			--end
-			return
-		end
-		local channelId = select(6, ...)
-		local _, channelname = GetChannelName(channelId)
-		local ok = false
-		for _, channel in pairs(Heimdall_Data.config.stinkyTracker.channels) do
-			if channel == channelname then
-				ok = true
-				break
+			if not Heimdall_Data.config.stinkyTracker.enabled then
+				--if Heimdall_Data.config.stinkyTracker.debug then
+				--	print(string.format("[%s] Module disabled, ignoring event", ModuleName))
+				--end
+				return
+			end
+			local channelId = select(6, ...)
+			local _, channelname = GetChannelName(channelId)
+			local ok = false
+			for _, channel in pairs(Heimdall_Data.config.stinkyTracker.channels) do
+				if channel == channelname then
+					ok = true
+					break
+				end
+			end
+			if not ok then
+				if Heimdall_Data.config.stinkyTracker.debug then
+					print(string.format("[%s] Ignoring message from non-master channel: %s", ModuleName, channelname))
+				end
+				return
 			end
-		end
-		if not ok then
 			if Heimdall_Data.config.stinkyTracker.debug then
-				print(string.format("[%s] Ignoring message from non-master channel: %s", ModuleName, channelname))
+				print(string.format("[%s] Processing message from master channel: %s", ModuleName, sender))
+				shared.dump(Heimdall_Data.config.stinkyTracker)
 			end
-			return
-		end
-		if Heimdall_Data.config.stinkyTracker.debug then
-			print(string.format("[%s] Processing message from master channel: %s", ModuleName, sender))
-			shared.dumpTable(Heimdall_Data.config.stinkyTracker)
-		end
 
-		if string.find(msg, "^who:") then
-			if Heimdall_Data.config.stinkyTracker.debug then
-				print(string.format("[%s] Processing WHO message from %s", ModuleName, sender))
+			local stinkies = {}
+			if string.find(msg, "^who:") then
+				if Heimdall_Data.config.stinkyTracker.debug then
+					print(string.format("[%s] Processing WHO message from %s", ModuleName, sender))
+				end
+				local whoStinkies = ParseWho(msg)
+				if Heimdall_Data.config.stinkyTracker.debug then
+					print(string.format("[%s] Found stinkies in WHO message", ModuleName))
+					shared.dump(whoStinkies)
+				end
+				for name, stinky in pairs(whoStinkies) do
+					stinkies[name] = stinky
+				end
 			end
-			local whoStinkies = ParseWho(msg)
-			if Heimdall_Data.config.stinkyTracker.debug then
-				print(string.format("[%s] Found stinkies in WHO message", ModuleName))
+			if string.find(msg, "^I see") then
+				if Heimdall_Data.config.stinkyTracker.debug then
+					print(string.format("[%s] Processing SEE message from %s", ModuleName, sender))
+				end
+				local seeStinkies = ParseSee(msg)
+				if Heimdall_Data.config.stinkyTracker.debug then
+					print(string.format("[%s] Found stinkies in SEE message", ModuleName))
+					shared.dump(seeStinkies)
+				end
+				for name, stinky in pairs(seeStinkies) do
+					stinkies[name] = stinky
+				end
 			end
-			for name, stinky in pairs(whoStinkies) do
-				if stinky.hostile then
+			if string.find(msg, "arrived to") or string.find(msg, "moved to") then
+				if Heimdall_Data.config.stinkyTracker.debug then
+					print(string.format("[%s] Processing ARRIVED message from %s", ModuleName, sender))
+				end
+				local arrivedStinkies = ParseArrived(msg)
+				if Heimdall_Data.config.stinkyTracker.debug then
+					print(string.format("[%s] Found stinkies in ARRIVED message", ModuleName))
+					shared.dump(arrivedStinkies)
+				end
+				for name, stinky in pairs(arrivedStinkies) do
+					stinkies[name] = stinky
+				end
+			end
+
+			for name, stinky in pairs(stinkies) do
+				if shared.stinkyTracker.ignored[name] then
+					if Heimdall_Data.config.stinkyTracker.debug then
+						print(string.format("[%s] Ignoring stinky: %s (%s)", ModuleName, name, stinky.class))
+					end
+					shared.stinkyTracker.ignored[name] = nil
+				else
 					shared.stinkyTracker.stinkies[name] = stinky
 					if Heimdall_Data.config.stinkyTracker.debug then
-						print(
-							string.format("[%s] Added hostile stinky from WHO: %s (%s)", ModuleName, name, stinky.class)
-						)
+						print(string.format("[%s] Added stinky: %s (%s)", ModuleName, name, stinky.class))
 					end
 				end
 			end
-		end
-		if string.find(msg, "^I see") then
+
+			-- Log total stinky count after processing
 			if Heimdall_Data.config.stinkyTracker.debug then
-				print(string.format("[%s] Processing SEE message from %s", ModuleName, sender))
-			end
-			local seeStinkies = ParseSee(msg)
-			if Heimdall_Data.config.stinkyTracker.debug then
-				print(string.format("[%s] Found stinkies in SEE message", ModuleName))
-			end
-			for name, stinky in pairs(seeStinkies) do
-				if stinky.hostile then
-					shared.stinkyTracker.stinkies[name] = stinky
-					if Heimdall_Data.config.stinkyTracker.debug then
-						print(
-							string.format("[%s] Added hostile stinky from SEE: %s (%s)", ModuleName, name, stinky.class)
-						)
-					end
+				local count = 0
+				for _ in pairs(shared.stinkyTracker.stinkies:get()) do
+					count = count + 1
 				end
-				if not stinky.hostile then
+				print(string.format("[%s] Current total stinkies tracked: %d", ModuleName, count))
+			end
+
+			shared.StinkyTracker.ForEach(function(name, stinky)
+				if shared.AgentTracker.IsAgent(name) then
 					shared.stinkyTracker.stinkies[name] = nil
 					if Heimdall_Data.config.stinkyTracker.debug then
-						print(string.format("[%s] Removed non-hostile stinky from SEE: %s", ModuleName, name))
+						print(string.format("[%s] Removed agent from stinkies: %s", ModuleName, name))
 					end
 				end
-			end
-		end
-		if string.find(msg, "arrived to") or string.find(msg, "moved to") then
+			end)
+		end)
+
+		local targetFrame = CreateFrame("Frame")
+		targetFrame:RegisterEvent("UNIT_TARGET")
+		targetFrame:SetScript("OnEvent", function(self, event, unit)
 			if Heimdall_Data.config.stinkyTracker.debug then
-				print(string.format("[%s] Processing ARRIVED message from %s", ModuleName, sender))
+				print(string.format("[%s] Event received: %s for unit: %s", ModuleName, event, unit or "target"))
 			end
-			local arrivedStinkies = ParseArrived(msg)
-			if Heimdall_Data.config.stinkyTracker.debug then
-				print(string.format("[%s] Found stinkies in ARRIVED message", ModuleName))
-			end
-			for name, stinky in pairs(arrivedStinkies) do
-				shared.stinkyTracker.stinkies[name] = stinky
+			unit = "target"
+
+			if not Heimdall_Data.config.stinkyTracker.enabled then
 				if Heimdall_Data.config.stinkyTracker.debug then
-					print(string.format("[%s] Added stinky from ARRIVED: %s (%s)", ModuleName, name, stinky.class))
+					print(string.format("[%s] Module disabled, ignoring event", ModuleName))
 				end
+				return
 			end
-		end
 
-		-- Log total stinky count after processing
-		if Heimdall_Data.config.stinkyTracker.debug then
-			local count = 0
-			for _ in pairs(shared.stinkyTracker.stinkies:get()) do
-				count = count + 1
-			end
-			print(string.format("[%s] Current total stinkies tracked: %d", ModuleName, count))
-		end
-
-		for name, stinky in pairs(shared.stinkyTracker.stinkies) do
-			if Heimdall_Data.config.agents[name] then
-				shared.stinkyTracker.stinkies[name] = nil
+			local name = UnitName(unit)
+			if not UnitIsPlayer(unit) then
 				if Heimdall_Data.config.stinkyTracker.debug then
-					print(string.format("[%s] Removed agent from stinkies: %s", ModuleName, name))
+					print(string.format("[%s] Target %s is not a player, nothing to do", ModuleName, name))
 				end
+				return
 			end
-		end
-	end)
 
-	local targetFrame = CreateFrame("Frame")
-	targetFrame:RegisterEvent("UNIT_TARGET")
-	targetFrame:SetScript("OnEvent", function(self, event, unit)
-		if Heimdall_Data.config.stinkyTracker.debug then
-			print(string.format("[%s] Event received: %s for unit: %s", ModuleName, event, unit or "target"))
-		end
-		unit = "target"
+			local enemy = UnitCanAttack("player", unit)
+			if enemy then
+				if Heimdall_Data.config.stinkyTracker.debug then
+					print(string.format("[%s] Target %s is enemy - tracking as stinky", ModuleName, name))
+				end
+				shared.stinkyTracker.stinkies[name] = {
+					name = name,
+					class = UnitClass(unit),
+					seenAt = GetTime(),
+					hostile = true,
+				}
+				return
+			end
+
+			if not shared.stinkyTracker.stinkies[name] then
+				if Heimdall_Data.config.stinkyTracker.debug then
+					print(string.format("[%s] Target %s is friendly and not stinky, nothing to do", ModuleName, name))
+				end
+				return
+			end
 
-		if not Heimdall_Data.config.stinkyTracker.enabled then
 			if Heimdall_Data.config.stinkyTracker.debug then
-				print(string.format("[%s] Module disabled, ignoring event", ModuleName))
+				print(string.format("[%s] Target %s is friendly and stinky - removing from stinkies", ModuleName, name))
 			end
-			return
-		end
+			shared.stinkyTracker.stinkies[name] = nil
+		end)
 
-		local name = UnitName(unit)
-		if not UnitIsPlayer(unit) then
-			if Heimdall_Data.config.stinkyTracker.debug then
-				print(string.format("[%s] Target %s is not a player, nothing to do", ModuleName, name))
-			end
-			return
-		end
-
-		local enemy = UnitCanAttack("player", unit)
-		if enemy then
-			if Heimdall_Data.config.stinkyTracker.debug then
-				print(string.format("[%s] Target %s is enemy - tracking as stinky", ModuleName, name))
-			end
-			shared.stinkyTracker.stinkies[name] = {
-				name = name,
-				class = UnitClass(unit),
-				seenAt = GetTime(),
-				hostile = true,
-			}
-			return
-		end
-
-		if not shared.stinkyTracker.stinkies[name] then
-			if Heimdall_Data.config.stinkyTracker.debug then
-				print(string.format("[%s] Target %s is friendly and not stinky, nothing to do", ModuleName, name))
-			end
-			return
-		end
-
-		if Heimdall_Data.config.stinkyTracker.debug then
-			print(string.format("[%s] Target %s is friendly and stinky - removing from stinkies", ModuleName, name))
-		end
-		shared.stinkyTracker.stinkies[name] = nil
-	end)
-
-	if Heimdall_Data.config.stinkyTracker.debug then print(string.format("[%s] Module initialized", ModuleName)) end
-	print("[Heimdall] StinkyTracker loaded")
-end
+		if Heimdall_Data.config.stinkyTracker.debug then print(string.format("[%s] Module initialized", ModuleName)) end
+		print("[Heimdall] StinkyTracker loaded")
+	end,
+}