Merge pull request #1336 from pyfa-org/release/v1.33.2

Release/v1.33.2

.appveyor.yml

@@ -0,0 +1,186 @@
+environment:
+
+  global:
+    # SDK v7.0 MSVC Express 2008's SetEnv.cmd script will fail if the
+    # /E:ON and /V:ON options are not enabled in the batch script intepreter
+    # See: http://stackoverflow.com/a/13751649/163740
+    CMD_IN_ENV: "cmd /E:ON /V:ON /C .\\appveyor\\run_with_env.cmd"
+
+  matrix:
+
+    # Python 2.7.10 is the latest version and is not pre-installed.
+
+    - PYTHON: "C:\\Python27.10"
+      PYTHON_VERSION: "2.7.10"
+      PYTHON_ARCH: "32"
+
+    #- PYTHON: "C:\\Python27.10-x64"
+    #  PYTHON_VERSION: "2.7.10"
+    #  PYTHON_ARCH: "64"
+
+    # Pre-installed Python versions, which Appveyor may upgrade to
+    # a later point release.
+    # See: http://www.appveyor.com/docs/installed-software#python
+
+    #- PYTHON: "C:\\Python27"
+    #  PYTHON_VERSION: "2.7.x" # currently 2.7.9
+    #  PYTHON_ARCH: "32"
+
+    #- PYTHON: "C:\\Python27-x64"
+    #  PYTHON_VERSION: "2.7.x" # currently 2.7.9
+    #  PYTHON_ARCH: "64"
+
+    #- PYTHON: "C:\\Python33"
+    #  PYTHON_VERSION: "3.3.x" # currently 3.3.5
+    #  PYTHON_ARCH: "32"
+
+    #- PYTHON: "C:\\Python33-x64"
+    #  PYTHON_VERSION: "3.3.x" # currently 3.3.5
+    #  PYTHON_ARCH: "64"
+
+    #- PYTHON: "C:\\Python34"
+    #  PYTHON_VERSION: "3.4.x" # currently 3.4.3
+    #  PYTHON_ARCH: "32"
+
+    #- PYTHON: "C:\\Python34-x64"
+    #  PYTHON_VERSION: "3.4.x" # currently 3.4.3
+    #  PYTHON_ARCH: "64"
+
+    # Python versions not pre-installed
+
+    # Python 2.6.6 is the latest Python 2.6 with a Windows installer
+    # See: https://github.com/ogrisel/python-appveyor-demo/issues/10
+
+    #- PYTHON: "C:\\Python266"
+    #  PYTHON_VERSION: "2.6.6"
+    #  PYTHON_ARCH: "32"
+
+    #- PYTHON: "C:\\Python266-x64"
+    #  PYTHON_VERSION: "2.6.6"
+    #  PYTHON_ARCH: "64"
+
+    #- PYTHON: "C:\\Python35"
+    #  PYTHON_VERSION: "3.5.0"
+    #  PYTHON_ARCH: "32"
+
+    #- PYTHON: "C:\\Python35-x64"
+    #  PYTHON_VERSION: "3.5.0"
+    #  PYTHON_ARCH: "64"
+
+    # Major and minor releases (i.e x.0.0 and x.y.0) prior to 3.3.0 use
+    # a different naming scheme.
+
+    #- PYTHON: "C:\\Python270"
+    #  PYTHON_VERSION: "2.7.0"
+    #  PYTHON_ARCH: "32"
+
+    #- PYTHON: "C:\\Python270-x64"
+    #  PYTHON_VERSION: "2.7.0"
+    #  PYTHON_ARCH: "64"
+
+install:
+  # If there is a newer build queued for the same PR, cancel this one.
+  # The AppVeyor 'rollout builds' option is supposed to serve the same
+  # purpose but it is problematic because it tends to cancel builds pushed
+  # directly to master instead of just PR builds (or the converse).
+  # credits: JuliaLang developers.
+  - ps: if ($env:APPVEYOR_PULL_REQUEST_NUMBER -and $env:APPVEYOR_BUILD_NUMBER -ne ((Invoke-RestMethod `
+        https://ci.appveyor.com/api/projects/$env:APPVEYOR_ACCOUNT_NAME/$env:APPVEYOR_PROJECT_SLUG/history?recordsNumber=50).builds | `
+        Where-Object pullRequestId -eq $env:APPVEYOR_PULL_REQUEST_NUMBER)[0].buildNumber) { `
+          throw "There are newer queued builds for this pull request, failing early." }
+
+  # Install wxPython
+  - 'ECHO Downloading wxPython.'
+  - "appveyor DownloadFile https://goo.gl/yvO8PB -FileName C:\\wxpython.exe"
+  #- "appveyor DownloadFile https://goo.gl/Uj0jV3 -FileName C:\\wxpython64.exe"
+
+  - 'ECHO Install wxPython'
+  - "C:\\wxpython.exe /SP- /VERYSILENT /NORESTART"
+  #- "C:\\wxpython64.exe /SP- /VERYSILENT /NORESTART"
+
+  - ECHO "Filesystem root:"
+  - ps: "ls \"C:/\""
+
+  - ECHO "Filesystem pyfa root:"
+  - ps: "ls \"C:\\projects\\pyfa\\\""
+
+  - ECHO "Installed SDKs:"
+  - ps: "ls \"C:/Program Files/Microsoft SDKs/Windows\""
+
+  # Install Python (from the official .msi of http://python.org) and pip when
+  # not already installed.
+  # - ps: if (-not(Test-Path($env:PYTHON))) { & appveyor\install.ps1 }
+
+  # Prepend newly installed Python to the PATH of this build (this cannot be
+  # done from inside the powershell script as it would require to restart
+  # the parent CMD process).
+  - "SET PATH=%PYTHON%;%PYTHON%\\Scripts;%PATH%"
+
+  # Check that we have the expected version and architecture for Python
+  - "python --version"
+  - "python -c \"import struct; print(struct.calcsize('P') * 8)\""
+
+  # Upgrade to the latest version of pip to avoid it displaying warnings
+  # about it being out of date.
+  - "pip install --disable-pip-version-check --user --upgrade pip"
+
+  # Install the build dependencies of the project. If some dependencies contain
+  # compiled extensions and are not provided as pre-built wheel packages,
+  # pip will build them from source using the MSVC compiler matching the
+  # target Python version and architecture
+  # C:\\projects\\eve-gnosis\\
+  - ECHO "Install pip requirements:"
+  - "pip install -r requirements.txt"
+  - "pip install -r requirements_test.txt"
+  - "pip install -r requirements_build_windows.txt"
+
+build_script:
+  # Build the compiled extension
+  # - "python setup.py build"
+  - ECHO "Build pyfa:"
+  #- copy C:\projects\pyfa\dist_assets\win\pyfa.spec C:\projects\pyfa\pyfa.spec
+  - "python C:\\projects\\pyfa\\setup.py build"
+
+  #- ECHO "Build pyfa (Debug):"
+  #- copy C:\projects\pyfa\dist_assets\win\pyfa_debug.spec C:\projects\pyfa\pyfa_debug.spec
+  #- "pyinstaller.exe --clean --noconfirm --windowed --upx-dir=C:\\projects\\pyfa\\scripts\\upx.exe C:\\projects\\pyfa\\pyfa_debug.spec"
+
+build: on
+
+after_build:
+  - ps: "ls \"./\""
+  #- ps: "ls \"C:\\projects\\pyfa\\build\\pyfa\\\""
+  - ps: "ls \"C:\\projects\\pyfa\\build\\\""
+  - ps: "ls \"C:\\projects\\pyfa\\build\\exe.win32-2.7\\\""
+  # Zip
+  # APPVEYOR_PULL_REQUEST_NUMBER -and $env:APPVEYOR_BUILD_NUMBER
+  #- 7z a build.zip -r C:\projects\pyfa\build\pyfa\*.*
+  - 7z a pyfa.zip -r C:\projects\pyfa\build\exe.win32-2.7\*.*
+  #- 7z a pyfa_debug.zip -r C:\projects\pyfa\dist\pyfa_debug\*.*
+
+on_success:
+  # Do nothing right now
+
+test_script:
+  #- tox
+  #- "py.test --cov=./"
+  # Run the project tests
+  # - "%CMD_IN_ENV% python C:/projects/eve-gnosis/setup.py nosetests"
+
+after_test:
+  # If tests are successful, create binary packages for the project.
+  # - "%CMD_IN_ENV% python setup.py bdist_wheel"
+  # - "%CMD_IN_ENV% python setup.py bdist_wininst"
+  # - "%CMD_IN_ENV% python setup.py bdist_msi"
+  # - ps: "ls dist"
+
+artifacts:
+  # Archive the generated packages in the ci.appveyor.com build report.
+  - path: pyfa.zip
+    name: 'pyfa.zip'
+  #- path: pyfa_debug.zip
+  #  name: Pyfa_debug
+
+#on_success:
+#  - TODO: upload the content of dist/*.whl to a public wheelhouse
+#

.codecov.yml

@@ -0,0 +1,26 @@
+codecov:
+  notify:
+    require_ci_to_pass: yes
+
+coverage:
+  precision: 2
+  round: down
+  range: "70...100"
+
+  status:
+    project: yes
+    patch: yes
+    changes: no
+
+parsers:
+  gcov:
+    branch_detection:
+      conditional: yes
+      loop: yes
+      method: no
+      macro: no
+
+comment:
+  layout: "header, diff"
+  behavior: default
+  require_changes: no

.gitattributes

@@ -0,0 +1,40 @@
+# Set the default behavior, in case people don't have core.autocrlf set.
+* text=auto
+
+# Explicitly declare text files you want to always be normalized and converted
+# to native line endings on checkout.
+# *.c text
+# *.h text
+
+# Declare files that will always have CRLF line endings on checkout.
+# Source files
+# ============
+*.pxd		text eol=crlf
+*.py 		text eol=crlf
+*.py3 		text eol=crlf
+*.pyw 		text eol=crlf
+*.pyx  		text eol=crlf
+pyfa.py     text eol=lf
+
+# Denote all files that are truly binary and should not be modified.
+# Binary files
+# ============
+*.db		binary
+*.p 		binary
+*.pkl 		binary
+*.pyc 		binary
+*.pyd		binary
+*.pyo 		binary
+
+# Note: .db, .p, and .pkl files are associated
+# with the python modules ``pickle``, ``dbm.*``,
+# ``shelve``, ``marshal``, ``anydbm``, & ``bsddb``
+# (among others).
+
+# Denote all files that are truly binary and should not be modified.
+# Image files
+# ============
+*.png binary
+*.jpg binary
+*.icns binary
+*.ico binary

.gitignore

@@ -49,7 +49,6 @@ Pyfa.egg-info/
 #  Usually these files are written by a python script from a template
 #  before PyInstaller builds the exe, so as to inject date/other infos into it.
 *.manifest
-*.spec
 
 # Installer logs
 pip-log.txt

.travis.yml

@@ -0,0 +1,39 @@
+language: python
+cache: pip
+python:
+  - '2.7'
+env:
+  - TOXENV=pep8
+addons:
+  apt:
+    packages:
+before_install:
+  - sudo apt-get update && sudo apt-get --reinstall install -qq language-pack-en language-pack-ru language-pack-he language-pack-zh-hans
+  - pip install tox
+  # We're not actually installing Tox, but have to run it before we install wxPython via Conda. This is fugly but vOv
+  - tox
+  # get Conda
+  - if [[ "$TRAVIS_PYTHON_VERSION" == "2.7" ]]; then
+      wget https://repo.continuum.io/miniconda/Miniconda-latest-Linux-x86_64.sh -O miniconda.sh;
+    else
+      wget https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh -O miniconda.sh;
+    fi
+  - bash miniconda.sh -b -p $HOME/miniconda
+  - export PATH="$HOME/miniconda/bin:$PATH"
+  - hash -r
+  - conda config --set always_yes yes --set changeps1 no
+  - conda update -q conda
+  # Useful for debugging any issues with conda
+  - conda info -a
+install:
+  # install wxPython 3.0.0.0
+  - conda install -c https://conda.anaconda.org/travis wxpython
+before_script:
+  - pip install -r requirements.txt
+  - pip install -r requirements_test.txt
+script:
+  - py.test --cov=./
+after_success:
+  - bash <(curl -s https://codecov.io/bash)
+before_deploy:
+  - pip install -r requirements_build_linux.txt

ISSUE_TEMPLATE.md

@@ -0,0 +1,32 @@
+# Submit a bug report bug report or feature request
+
+Here you can inform pyfa developers of potential bugs or suggest features / improvements to the project. Please check
+to make sure that the bug hasn't been reported or feature requested before submitting. If you have general questions
+about the project and want to reach out to the developers personally, please check out out our [Slack]
+(https://pyfainvite.azurewebsites.net/).
+
+---
+
+## Bug Report
+
+
+### Expected behavior:
+
+
+### Actual behavior:
+
+
+### Detailed steps to reproduce:
+
+
+### Fits involved in EFT format (Edit > To Clipboard > EFT):
+
+
+### Release or development git branch? Please note the release version or commit hash:
+
+
+### Operating system and version (eg: Windows 10, OS X 10.9, OS X 10.11, Ubuntu 16.10):
+
+
+### Other relevant information:
+

README.md

@@ -1,6 +1,6 @@
 # pyfa
 
-[![Join us on Slack!](https://pyfainvite.azurewebsites.net/badge.svg)](https://pyfainvite.azurewebsites.net/)
+[![Join us on Slack!](https://pyfainvite.azurewebsites.net/badge.svg)](https://pyfainvite.azurewebsites.net/) [![Build Status](https://travis-ci.org/pyfa-org/Pyfa.svg?branch=master)](https://travis-ci.org/pyfa-org/Pyfa)
 
 ![pyfa](https://cloud.githubusercontent.com/assets/3904767/10271512/af385ef2-6ade-11e5-8f67-52b8b1e4c797.PNG)
 
@@ -38,10 +38,11 @@ If you wish to help with development or simply need to run pyfa through a Python
 
 * Python 2.7
 * `wxPython` 2.8/3.0
-* `sqlalchemy` >= 0.6
+* `sqlalchemy` >= 1.0.5
 * `dateutil`
 * `matplotlib` (for some Linux distributions you may need to install separate wxPython bindings such as `python-matplotlib-wx`)
 * `requests`
+* `logbook` >= 1.0.0
 
 ## Bug Reporting
 The preferred method of reporting bugs is through the project's [GitHub Issues interface](https://github.com/pyfa-org/Pyfa/issues). Alternatively, posting a report in the [pyfa thread](http://forums.eveonline.com/default.aspx?g=posts&t=247609) on the official EVE Online forums is acceptable. Guidelines for bug reporting can be found on [this wiki page](https://github.com/DarkFenX/Pyfa/wiki/Bug-Reporting). 
@@ -51,8 +52,7 @@ pyfa is licensed under the GNU GPL v3.0, see LICENSE
 
 ## Resources
 * Development repository: [https://github.com/pyfa-org/Pyfa](https://github.com/pyfa-org/Pyfa)
-* XMPP conference: [pyfa@conference.jabber.org](pyfa@conference.jabber.org)
-* [EVE forum thread](http://forums.eveonline.com/default.aspx?g=posts&t=247609)
+* [EVE forum thread](https://forums.eveonline.com/t/27156)
 * [EVE University guide using pyfa](http://wiki.eveuniversity.org/Guide_to_using_PYFA)
 * [EVE Online website](http://www.eveonline.com/)
 

_development/Pyfa_CodeStyle.xml

@@ -0,0 +1,13 @@
+<code_scheme name="Pyfa">
+  <option name="LINE_SEPARATOR" value="&#xD;&#xA;" />
+  <option name="RIGHT_MARGIN" value="165" />
+  <Python>
+    <option name="NEW_LINE_AFTER_COLON" value="true" />
+    <option name="DICT_ALIGNMENT" value="2" />
+    <option name="DICT_NEW_LINE_AFTER_LEFT_BRACE" value="true" />
+    <option name="DICT_NEW_LINE_BEFORE_RIGHT_BRACE" value="true" />
+    <option name="USE_CONTINUATION_INDENT_FOR_ARGUMENTS" value="true" />
+    <option name="OPTIMIZE_IMPORTS_SORT_NAMES_IN_FROM_IMPORTS" value="true" />
+    <option name="OPTIMIZE_IMPORTS_JOIN_FROM_IMPORTS_WITH_SAME_SOURCE" value="true" />
+  </Python>
+</code_scheme>

_development/Pyfa_Inspections.xml

@@ -0,0 +1,54 @@
+<profile version="1.0">
+  <option name="myName" value="Pyfa" />
+  <inspection_tool class="IgnoreUnusedEntry" enabled="false" level="UNUSED ENTRY" enabled_by_default="false" />
+  <inspection_tool class="InconsistentLineSeparators" enabled="true" level="ERROR" enabled_by_default="true" />
+  <inspection_tool class="ProblematicWhitespace" enabled="true" level="WARNING" enabled_by_default="true" />
+  <inspection_tool class="PyBehaveInspection" enabled="true" level="WARNING" enabled_by_default="true" />
+  <inspection_tool class="PyClassicStyleClassInspection" enabled="true" level="WARNING" enabled_by_default="true" />
+  <inspection_tool class="PyCompatibilityInspection" enabled="true" level="WARNING" enabled_by_default="true">
+    <option name="ourVersions">
+      <value>
+        <list size="1">
+          <item index="0" class="java.lang.String" itemvalue="2.7" />
+        </list>
+      </value>
+    </option>
+  </inspection_tool>
+  <inspection_tool class="PyMissingTypeHintsInspection" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
+  <inspection_tool class="PyPackageRequirementsInspection" enabled="true" level="WARNING" enabled_by_default="true">
+    <option name="ignoredPackages">
+      <value>
+        <list size="1">
+          <item index="0" class="java.lang.String" itemvalue="wxPython" />
+        </list>
+      </value>
+    </option>
+  </inspection_tool>
+  <inspection_tool class="PyPep8Inspection" enabled="true" level="TYPO" enabled_by_default="true">
+    <option name="ignoredErrors">
+      <list>
+        <option value="E203" />
+        <option value="E127" />
+        <option value="E128" />
+        <option value="E126" />
+      </list>
+    </option>
+  </inspection_tool>
+  <inspection_tool class="PyPep8NamingInspection" enabled="true" level="TYPO" enabled_by_default="true">
+    <option name="ignoredErrors">
+      <list>
+        <option value="N802" />
+        <option value="N806" />
+        <option value="N803" />
+        <option value="N814" />
+      </list>
+    </option>
+  </inspection_tool>
+  <inspection_tool class="PyShadowingBuiltinsInspection" enabled="true" level="WARNING" enabled_by_default="true" />
+  <inspection_tool class="PyShadowingNamesInspection" enabled="true" level="WARNING" enabled_by_default="true" />
+  <inspection_tool class="SpellCheckingInspection" enabled="false" level="TYPO" enabled_by_default="false">
+    <option name="processCode" value="true" />
+    <option name="processLiterals" value="true" />
+    <option name="processComments" value="true" />
+  </inspection_tool>
+</profile>

_development/helpers.py

@@ -0,0 +1,145 @@
+# noinspection PyPackageRequirements
+import pytest
+
+import os
+import sys
+import threading
+
+from sqlalchemy import MetaData, create_engine
+from sqlalchemy.orm import sessionmaker
+
+script_dir = os.path.dirname(os.path.abspath(__file__))
+# Add root folder to python paths
+sys.path.append(os.path.realpath(os.path.join(script_dir, '..', '..')))
+sys._called_from_test = True
+
+# noinspection PyUnresolvedReferences,PyUnusedLocal
+@pytest.fixture
+def DBInMemory_test():
+    def rollback():
+        with sd_lock:
+            saveddata_session.rollback()
+
+
+    print("Creating database in memory")
+    from os.path import realpath, join, dirname, abspath
+
+    debug = False
+    gamedataCache = True
+    saveddataCache = True
+    gamedata_version = ""
+    gamedata_connectionstring = 'sqlite:///' + realpath(join(dirname(abspath(unicode(__file__))), "..", "eve.db"))
+    saveddata_connectionstring = 'sqlite:///:memory:'
+
+    class ReadOnlyException(Exception):
+        pass
+
+    if callable(gamedata_connectionstring):
+        gamedata_engine = create_engine("sqlite://", creator=gamedata_connectionstring, echo=debug)
+    else:
+        gamedata_engine = create_engine(gamedata_connectionstring, echo=debug)
+
+    gamedata_meta = MetaData()
+    gamedata_meta.bind = gamedata_engine
+    gamedata_session = sessionmaker(bind=gamedata_engine, autoflush=False, expire_on_commit=False)()
+
+    # This should be moved elsewhere, maybe as an actual query. Current, without try-except, it breaks when making a new
+    # game db because we haven't reached gamedata_meta.create_all()
+    try:
+        gamedata_version = gamedata_session.execute(
+            "SELECT `field_value` FROM `metadata` WHERE `field_name` LIKE 'client_build'"
+        ).fetchone()[0]
+    except Exception as e:
+        print("Missing gamedata version.")
+        gamedata_version = None
+
+    if saveddata_connectionstring is not None:
+        if callable(saveddata_connectionstring):
+            saveddata_engine = create_engine(creator=saveddata_connectionstring, echo=debug)
+        else:
+            saveddata_engine = create_engine(saveddata_connectionstring, echo=debug)
+
+        saveddata_meta = MetaData()
+        saveddata_meta.bind = saveddata_engine
+        saveddata_session = sessionmaker(bind=saveddata_engine, autoflush=False, expire_on_commit=False)()
+    else:
+        saveddata_meta = None
+
+    # Lock controlling any changes introduced to session
+    sd_lock = threading.Lock()
+
+    # Import all the definitions for all our database stuff
+    # noinspection PyPep8
+    #from eos.db.gamedata import alphaClones, attribute, category, effect, group, icon, item, marketGroup, metaData, metaGroup, queries, traits, unit
+    # noinspection PyPep8
+    #from eos.db.saveddata import booster, cargo, character, crest, damagePattern, databaseRepair, drone, fighter, fit, implant, implantSet, loadDefaultDatabaseValues, miscData, module, override, price, queries, skill, targetResists, user
+
+    # If using in memory saveddata, you'll want to reflect it so the data structure is good.
+    if saveddata_connectionstring == "sqlite:///:memory:":
+        saveddata_meta.create_all()
+
+    # Output debug info to help us troubleshoot Travis
+    print(saveddata_engine)
+    print(gamedata_engine)
+
+    helper = {
+        #'config': eos.config,
+        'gamedata_session'    : gamedata_session,
+        'saveddata_session'    : saveddata_session,
+    }
+    return helper
+
+# noinspection PyUnresolvedReferences,PyUnusedLocal
+@pytest.fixture
+def DBInMemory():
+    print("Creating database in memory")
+
+    import eos.config
+
+    import eos
+    import eos.db
+
+    # Output debug info to help us troubleshoot Travis
+    print(eos.db.saveddata_engine)
+    print(eos.db.gamedata_engine)
+
+    helper = {
+        'config': eos.config,
+        'db'    : eos.db,
+        'gamedata_session' : eos.db.gamedata_session,
+        'saveddata_session' : eos.db.saveddata_session,
+    }
+    return helper
+
+
+@pytest.fixture
+def Gamedata():
+    print("Building Gamedata")
+    from eos.gamedata import Item
+
+    helper = {
+        'Item': Item,
+    }
+    return helper
+
+
+@pytest.fixture
+def Saveddata():
+    print("Building Saveddata")
+    from eos.saveddata.ship import Ship
+    from eos.saveddata.fit import Fit
+    from eos.saveddata.character import Character
+    from eos.saveddata.module import Module, State
+    from eos.saveddata.citadel import Citadel
+    from eos.saveddata.booster import Booster
+
+    helper = {
+        'Structure': Citadel,
+        'Ship'     : Ship,
+        'Fit'      : Fit,
+        'Character': Character,
+        'Module'   : Module,
+        'State'    : State,
+        'Booster'  : Booster,
+    }
+    return helper

_development/helpers_fits.py

@@ -0,0 +1,66 @@
+import pytest
+
+# noinspection PyPackageRequirements
+from _development.helpers import DBInMemory as DB, Gamedata, Saveddata
+
+
+# noinspection PyShadowingNames
+@pytest.fixture
+def RifterFit(DB, Gamedata, Saveddata):
+    print("Creating Rifter")
+    item = DB['gamedata_session'].query(Gamedata['Item']).filter(Gamedata['Item'].name == "Rifter").first()
+    ship = Saveddata['Ship'](item)
+    # setup fit
+    fit = Saveddata['Fit'](ship, "My Rifter Fit")
+
+    return fit
+
+
+# noinspection PyShadowingNames
+@pytest.fixture
+def KeepstarFit(DB, Gamedata, Saveddata):
+    print("Creating Keepstar")
+    item = DB['gamedata_session'].query(Gamedata['Item']).filter(Gamedata['Item'].name == "Keepstar").first()
+    ship = Saveddata['Structure'](item)
+    # setup fit
+    fit = Saveddata['Fit'](ship, "Keepstar Fit")
+
+    return fit
+
+
+# noinspection PyShadowingNames
+@pytest.fixture
+def CurseFit(DB, Gamedata, Saveddata):
+    print("Creating Curse - With Neuts")
+    item = DB['gamedata_session'].query(Gamedata['Item']).filter(Gamedata['Item'].name == "Curse").first()
+    ship = Saveddata['Ship'](item)
+    # setup fit
+    fit = Saveddata['Fit'](ship, "Curse - With Neuts")
+
+    mod = Saveddata['Module'](DB['db'].getItem("Medium Energy Neutralizer II"))
+    mod.state = Saveddata['State'].ONLINE
+
+    # Add 5 neuts
+    for _ in xrange(5):
+        fit.modules.append(mod)
+
+    return fit
+
+
+# noinspection PyShadowingNames
+@pytest.fixture
+def HeronFit(DB, Gamedata, Saveddata):
+    print("Creating Heron - RemoteSebo")
+    item = DB['gamedata_session'].query(Gamedata['Item']).filter(Gamedata['Item'].name == "Heron").first()
+    ship = Saveddata['Ship'](item)
+    # setup fit
+    fit = Saveddata['Fit'](ship, "Heron - RemoteSebo")
+
+    mod = Saveddata['Module'](DB['db'].getItem("Remote Sensor Booster II"))
+    mod.state = Saveddata['State'].ONLINE
+
+    # Add 5 neuts
+    for _ in xrange(4):
+        fit.modules.append(mod)
+
+    return fit

_development/helpers_items.py

@@ -0,0 +1,12 @@
+import pytest
+
+# noinspection PyPackageRequirements
+from _development.helpers import DBInMemory as DB, Gamedata, Saveddata
+
+
+# noinspection PyShadowingNames
+@pytest.fixture
+def StrongBluePillBooster (DB, Gamedata, Saveddata):
+    print("Creating Strong Blue Pill Booster")
+    item = DB['gamedata_session'].query(Gamedata['Item']).filter(Gamedata['Item'].name == "Strong Blue Pill Booster").first()
+    return Saveddata['Booster'](item)

_development/helpers_locale.py

@@ -0,0 +1,101 @@
+import os
+
+# https://msdn.microsoft.com/en-us/library/windows/desktop/dd317756(v=vs.85).aspx
+windows_codecs = {
+    'cp1252',  # Standard Windows
+    'cp1251',  # Russian
+    'cp037',
+    'cp424',
+    'cp437',
+    'cp500',
+    'cp720',
+    'cp737',
+    'cp775',
+    'cp850',
+    'cp852',
+    'cp855',
+    'cp856',
+    'cp857',
+    'cp858',
+    'cp860',
+    'cp861',
+    'cp862',
+    'cp863',
+    'cp864',
+    'cp865',
+    'cp866',
+    'cp869',
+    'cp874',
+    'cp875',
+    'cp932',
+    'cp949',
+    'cp950',
+    'cp1006',
+    'cp1026',
+    'cp1140',
+    'cp1250',
+    'cp1253',
+    'cp1254',
+    'cp1255',
+    'cp1256',
+    'cp1257',
+    'cp1258',
+}
+
+linux_codecs = {
+    'utf_8',  # Generic Linux/Mac
+}
+
+mac_codecs = [
+    'utf_8',  # Generic Linux/Mac
+    'mac_cyrillic',
+    'mac_greek',
+    'mac_iceland',
+    'mac_latin2',
+    'mac_roman',
+    'mac_turkish',
+]
+
+universal_codecs = [
+    'utf_16', 'utf_32', 'utf_32_be', 'utf_32_le', 'utf_16_be', 'utf_16_le', 'utf_7', 'utf_8_sig',
+]
+
+other_codecs = [
+    'scii', 'big5', 'big5hkscs', 'euc_jp', 'euc_jis_2004', 'euc_jisx0213', 'euc_kr', 'gb2312', 'gbk', 'gb18030', 'hz', 'iso2022_jp', 'iso2022_jp_1',
+    'iso2022_jp_2', 'iso2022_jp_2004', 'iso2022_jp_3', 'iso2022_jp_ext', 'iso2022_kr', 'latin_1', 'iso8859_2', 'iso8859_3', 'iso8859_4', 'iso8859_5',
+    'iso8859_6', 'iso8859_7', 'iso8859_8', 'iso8859_9', 'iso8859_10', 'iso8859_11', 'iso8859_13', 'iso8859_14', 'iso8859_15', 'iso8859_16', 'johab', 'koi8_r',
+    'koi8_u', 'ptcp154', 'shift_jis', 'shift_jis_2004', 'shift_jisx0213'
+]
+
+system_names = {
+    'Windows': windows_codecs,
+    'Linux': linux_codecs,
+    'Darwin': mac_codecs,
+}
+
+
+def GetPath(root, file=None, codec=None):
+    # Replace this with the function we actually use for this
+    path = os.path.realpath(os.path.abspath(root))
+
+    if file:
+        path = os.path.join(path, file)
+
+    if codec:
+        path = path.decode(codec)
+
+    return path
+
+def GetUnicodePath(root, file=None, codec=None):
+    # Replace this with the function we actually use for this
+    path = os.path.realpath(os.path.abspath(root))
+
+    if file:
+        path = os.path.join(path, file)
+
+    if codec:
+        path = unicode(path, codec)
+    else:
+        path = unicode(path)
+
+    return path

config.py

@@ -1,64 +1,59 @@
 import os
 import sys
 
-# TODO: move all logging back to pyfa.py main loop
-# We moved it here just to avoid rebuilding windows skeleton for now (any change to pyfa.py needs it)
-import logging
-import logging.handlers
+from logbook import Logger
+
+pyfalog = Logger(__name__)
 
 # Load variable overrides specific to distribution type
 try:
     import configforced
 except ImportError:
+    pyfalog.warning("Failed to import: configforced")
     configforced = None
 
+
 # Turns on debug mode
 debug = False
 # Defines if our saveddata will be in pyfa root or not
 saveInRoot = False
 
 # Version data
-version = "1.24.1"
-tag = "git"
-expansionName = "Singularity"
-expansionVersion = "1099916"
+version = "1.33.2"
+tag = "Stable"
+expansionName = "Lifeblood"
+expansionVersion = "1.7"
 evemonMinVersion = "4081"
 
 pyfaPath = None
 savePath = None
 saveDB = None
 gameDB = None
+logPath = None
 
 
-class StreamToLogger(object):
-   """
-   Fake file-like stream object that redirects writes to a logger instance.
-   From: http://www.electricmonk.nl/log/2011/08/14/redirect-stdout-and-stderr-to-a-logger-in-python/
-   """
-   def __init__(self, logger, log_level=logging.INFO):
-      self.logger = logger
-      self.log_level = log_level
-      self.linebuf = ''
-
-   def write(self, buf):
-      for line in buf.rstrip().splitlines():
-         self.logger.log(self.log_level, line.rstrip())
-
 def isFrozen():
     if hasattr(sys, 'frozen'):
         return True
     else:
         return False
 
+
+def __createDirs(path):
+    if not os.path.exists(path):
+        os.makedirs(path)
+
+
 def getPyfaRoot():
     base = getattr(sys.modules['__main__'], "__file__", sys.executable) if isFrozen() else sys.argv[0]
     root = os.path.dirname(os.path.realpath(os.path.abspath(base)))
     root = unicode(root, sys.getfilesystemencoding())
     return root
 
-def __createDirs(path):
-    if not os.path.exists(path):
-        os.makedirs(path)
+
+def getDefaultSave():
+    return unicode(os.path.expanduser(os.path.join("~", ".pyfa")), sys.getfilesystemencoding())
+
 
 def defPaths(customSavePath):
     global debug
@@ -68,10 +63,7 @@ def defPaths(customSavePath):
     global gameDB
     global saveInRoot
 
-    if debug:
-        logLevel = logging.DEBUG
-    else:
-        logLevel = logging.WARN
+    pyfalog.debug("Configuring Pyfa")
 
     # The main pyfa directory which contains run.py
     # Python 2.X uses ANSI by default, so we need to convert the character encoding
@@ -87,36 +79,16 @@ def defPaths(customSavePath):
     else:
         savePath = getattr(configforced, "savePath", None)
         if savePath is None:
-            if customSavePath is None: # customSavePath is not overriden
-                savePath = unicode(os.path.expanduser(os.path.join("~", ".pyfa")),
-                               sys.getfilesystemencoding())
+            if customSavePath is None:  # customSavePath is not overriden
+                savePath = getDefaultSave()
             else:
                 savePath = customSavePath
 
     __createDirs(savePath)
 
     if isFrozen():
-        os.environ["REQUESTS_CA_BUNDLE"] = os.path.join(pyfaPath, "cacert.pem")
-        os.environ["SSL_CERT_FILE"] = os.path.join(pyfaPath, "cacert.pem")
-
-    format = '%(asctime)s %(name)-24s %(levelname)-8s %(message)s'
-    logging.basicConfig(format=format, level=logLevel)
-    handler = logging.handlers.RotatingFileHandler(os.path.join(savePath, "log.txt"), maxBytes=1000000, backupCount=3)
-    formatter = logging.Formatter(format)
-    handler.setFormatter(formatter)
-    logging.getLogger('').addHandler(handler)
-
-    logging.info("Starting pyfa")
-
-    if hasattr(sys, 'frozen'):
-        stdout_logger = logging.getLogger('STDOUT')
-        sl = StreamToLogger(stdout_logger, logging.INFO)
-        sys.stdout = sl
-
-        # This interferes with cx_Freeze's own handling of exceptions. Find a way to fix this.
-        #stderr_logger = logging.getLogger('STDERR')
-        #sl = StreamToLogger(stderr_logger, logging.ERROR)
-        #sys.stderr = sl
+        os.environ["REQUESTS_CA_BUNDLE"] = os.path.join(pyfaPath, "cacert.pem").encode('utf8')
+        os.environ["SSL_CERT_FILE"] = os.path.join(pyfaPath, "cacert.pem").encode('utf8')
 
     # The database where we store all the fits etc
     saveDB = os.path.join(savePath, "saveddata.db")
@@ -124,13 +96,19 @@ def defPaths(customSavePath):
     # The database where the static EVE data from the datadump is kept.
     # This is not the standard sqlite datadump but a modified version created by eos
     # maintenance script
-    gameDB = os.path.join(pyfaPath, "eve.db")
+    gameDB = getattr(configforced, "gameDB", gameDB)
+    if not gameDB:
+        gameDB = os.path.join(pyfaPath, "eve.db")
 
-    ## DON'T MODIFY ANYTHING BELOW ##
+    # DON'T MODIFY ANYTHING BELOW
     import eos.config
 
-    #Caching modifiers, disable all gamedata caching, its unneeded.
+    # Caching modifiers, disable all gamedata caching, its unneeded.
     eos.config.gamedataCache = False
     # saveddata db location modifier, shouldn't ever need to touch this
     eos.config.saveddata_connectionstring = "sqlite:///" + saveDB + "?check_same_thread=False"
     eos.config.gamedata_connectionstring = "sqlite:///" + gameDB + "?check_same_thread=False"
+
+    # initialize the settings
+    from service.settings import EOSSettings
+    eos.config.settings = EOSSettings.getInstance().EOSSettings  # this is kind of confusing, but whatever

dist_assets/win/pyfa.spec

@@ -0,0 +1,83 @@
+# -*- mode: python -*-
+
+# Note: This script is provided AS-IS for those that may be interested.
+# pyfa does not currently support pyInstaller (or any other build process) 100% at the moment
+
+# Command line to build:
+# (Run from directory where pyfa.py and pyfa.spec lives.)
+# c:\Python27\scripts\pyinstaller.exe --clean --noconfirm --windowed --upx-dir=.\scripts\upx.exe pyfa.spec
+
+# Don't forget to change the path to where your pyfa.py and pyfa.spec lives
+#  pathex=['C:\\Users\\Ebag333\\Documents\\GitHub\\Ebag333\\Pyfa'],
+
+import os
+
+block_cipher = None
+
+added_files = [
+             ( 'imgs/gui/*.png', 'imgs/gui' ),
+             ( 'imgs/gui/*.gif', 'imgs/gui' ),
+             ( 'imgs/icons/*.png', 'imgs/icons' ),
+             ( 'imgs/renders/*.png', 'imgs/renders' ),
+             ( 'dist_assets/win/pyfa.ico', '.' ),
+             ( 'dist_assets/cacert.pem', '.' ),
+             ( 'eve.db', '.' ),
+             ( 'README.md', '.' ),
+             ( 'LICENSE', '.' ),
+             ]
+
+import_these = []
+
+# Walk eos.effects and add all effects so we can import them properly
+for root, folders, files in os.walk("eos/effects"):
+    for file_ in files:
+        if file_.endswith(".py") and not file_.startswith("_"):
+            mod_name = "{}.{}".format(
+                root.replace("/", "."),
+                file_.split(".py")[0],
+            )
+            import_these.append(mod_name)
+
+a = Analysis(
+             ['pyfa.py'],
+             pathex=['C:\\projects\\pyfa\\'],
+             binaries=[],
+             datas=added_files,
+             hiddenimports=import_these,
+             hookspath=[],
+             runtime_hooks=[],
+             excludes=[],
+             win_no_prefer_redirects=False,
+             win_private_assemblies=False,
+             cipher=block_cipher,
+             )
+
+pyz = PYZ(
+          a.pure,
+          a.zipped_data,
+          cipher=block_cipher,
+          )
+
+exe = EXE(pyz,
+          a.scripts,
+          exclude_binaries=True,
+          debug=False,
+          console=False,
+          strip=False,
+          upx=True,
+          name='pyfa',
+          icon='dist_assets/win/pyfa.ico',
+          onefile=False,
+          )
+
+coll = COLLECT(
+               exe,
+               a.binaries,
+               a.zipfiles,
+               a.datas,
+               strip=False,
+               upx=True,
+               onefile=False,
+               name='pyfa',
+               icon='dist_assets/win/pyfa.ico',
+               )

dist_assets/win/pyfa_debug.spec

@@ -0,0 +1,83 @@
+# -*- mode: python -*-
+
+# Note: This script is provided AS-IS for those that may be interested.
+# pyfa does not currently support pyInstaller (or any other build process) 100% at the moment
+
+# Command line to build:
+# (Run from directory where pyfa.py and pyfa.spec lives.)
+# c:\Python27\scripts\pyinstaller.exe --clean --noconfirm --windowed --upx-dir=.\scripts\upx.exe pyfa.spec
+
+# Don't forget to change the path to where your pyfa.py and pyfa.spec lives
+#  pathex=['C:\\Users\\Ebag333\\Documents\\GitHub\\Ebag333\\Pyfa'],
+
+import os
+
+block_cipher = None
+
+added_files = [
+             ( 'imgs/gui/*.png', 'imgs/gui' ),
+             ( 'imgs/gui/*.gif', 'imgs/gui' ),
+             ( 'imgs/icons/*.png', 'imgs/icons' ),
+             ( 'imgs/renders/*.png', 'imgs/renders' ),
+             ( 'dist_assets/win/pyfa.ico', '.' ),
+             ( 'dist_assets/cacert.pem', '.' ),
+             ( 'eve.db', '.' ),
+             ( 'README.md', '.' ),
+             ( 'LICENSE', '.' ),
+             ]
+
+import_these = []
+
+# Walk eos.effects and add all effects so we can import them properly
+for root, folders, files in os.walk("eos/effects"):
+    for file_ in files:
+        if file_.endswith(".py") and not file_.startswith("_"):
+            mod_name = "{}.{}".format(
+                root.replace("/", "."),
+                file_.split(".py")[0],
+            )
+            import_these.append(mod_name)
+
+a = Analysis(
+             ['pyfa.py'],
+             pathex=['C:\\projects\\pyfa\\'],
+             binaries=[],
+             datas=added_files,
+             hiddenimports=import_these,
+             hookspath=[],
+             runtime_hooks=[],
+             excludes=[],
+             win_no_prefer_redirects=False,
+             win_private_assemblies=False,
+             cipher=block_cipher,
+             )
+
+pyz = PYZ(
+          a.pure,
+          a.zipped_data,
+          cipher=block_cipher,
+          )
+
+exe = EXE(pyz,
+          a.scripts,
+          exclude_binaries=True,
+          debug=True,
+          console=True,
+          strip=False,
+          upx=True,
+          name='pyfa_debug',
+          icon='dist_assets/win/pyfa.ico',
+          onefile=False,
+          )
+
+coll = COLLECT(
+               exe,
+               a.binaries,
+               a.zipfiles,
+               a.datas,
+               strip=False,
+               upx=True,
+               onefile=False,
+               name='pyfa_debug',
+               icon='dist_assets/win/pyfa.ico',
+               )

eos/__init__.py

@@ -1,8 +1,2 @@
-version = "0.2.3"
-tag = "git"
-
-
-def test():
-    import tests.runTests
-    import unittest
-    unittest.main(defaultTest="discover", testLoader=tests.runTests.loader)
+version = "0.2.3"
+tag = "git"

eos/config.py

@@ -1,13 +1,31 @@
 import sys
 from os.path import realpath, join, dirname, abspath
 
+from logbook import Logger
+import os
+
+istravis = os.environ.get('TRAVIS') == 'true'
+pyfalog = Logger(__name__)
+
 debug = False
 gamedataCache = True
 saveddataCache = True
-gamedata_connectionstring = 'sqlite:///' + unicode(realpath(join(dirname(abspath(__file__)), "..", "eve.db")),
-                                                   sys.getfilesystemencoding())
-saveddata_connectionstring = 'sqlite:///' + unicode(
-    realpath(join(dirname(abspath(__file__)), "..", "saveddata", "saveddata.db")), sys.getfilesystemencoding())
+gamedata_version = ""
+gamedata_connectionstring = 'sqlite:///' + unicode(realpath(join(dirname(abspath(__file__)), "..", "eve.db")), sys.getfilesystemencoding())
+pyfalog.debug("Gamedata connection string: {0}", gamedata_connectionstring)
+
+if istravis is True or hasattr(sys, '_called_from_test'):
+    # Running in Travis. Run saveddata database in memory.
+    saveddata_connectionstring = 'sqlite:///:memory:'
+else:
+    saveddata_connectionstring = 'sqlite:///' + unicode(realpath(join(dirname(abspath(__file__)), "..", "saveddata", "saveddata.db")), sys.getfilesystemencoding())
+
+pyfalog.debug("Saveddata connection string: {0}", saveddata_connectionstring)
+
+settings = {
+    "useStaticAdaptiveArmorHardener": False,
+    "strictSkillLevels": True,
+}
 
 # Autodetect path, only change if the autodetection bugs out.
 path = dirname(unicode(__file__, sys.getfilesystemencoding()))

eos/db/__init__.py

@@ -20,14 +20,16 @@
 import threading
 
 from sqlalchemy import MetaData, create_engine
-from sqlalchemy.orm import sessionmaker, scoped_session
-from sqlalchemy.ext.declarative import declarative_base
-from sqlalchemy import pool
-
+from sqlalchemy.orm import sessionmaker
 
 import migration
 from eos import config
+from logbook import Logger
 
+pyfalog = Logger(__name__)
+pyfalog.info("Initializing database")
+pyfalog.info("Gamedata connection: {0}", config.gamedata_connectionstring)
+pyfalog.info("Saveddata connection: {0}", config.saveddata_connectionstring)
 
 class ReadOnlyException(Exception):
     pass
@@ -47,9 +49,11 @@ gamedata_session = sessionmaker(bind=gamedata_engine, autoflush=False, expire_on
 # game db because we haven't reached gamedata_meta.create_all()
 try:
     config.gamedata_version = gamedata_session.execute(
-        "SELECT `field_value` FROM `metadata` WHERE `field_name` LIKE 'client_build'"
+            "SELECT `field_value` FROM `metadata` WHERE `field_name` LIKE 'client_build'"
     ).fetchone()[0]
-except:
+except Exception as e:
+    pyfalog.warning("Missing gamedata version.")
+    pyfalog.critical(e)
     config.gamedata_version = None
 
 saveddata_connectionstring = config.saveddata_connectionstring
@@ -62,23 +66,32 @@ if saveddata_connectionstring is not None:
     saveddata_meta = MetaData()
     saveddata_meta.bind = saveddata_engine
     saveddata_session = sessionmaker(bind=saveddata_engine, autoflush=False, expire_on_commit=False)()
+else:
+    saveddata_meta = None
 
 # Lock controlling any changes introduced to session
-sd_lock = threading.Lock()
+sd_lock = threading.RLock()
 
 # Import all the definitions for all our database stuff
-from eos.db.gamedata import *
-from eos.db.saveddata import *
+# noinspection PyPep8
+from eos.db.gamedata import alphaClones, attribute, category, effect, group, icon, item, marketGroup, metaData, metaGroup, queries, traits, unit
+# noinspection PyPep8
+from eos.db.saveddata import booster, cargo, character, crest, damagePattern, databaseRepair, drone, fighter, fit, implant, implantSet, loadDefaultDatabaseValues, \
+    miscData, module, override, price, queries, skill, targetResists, user
 
 # Import queries
+# noinspection PyPep8
 from eos.db.gamedata.queries import *
+# noinspection PyPep8
 from eos.db.saveddata.queries import *
 
 # If using in memory saveddata, you'll want to reflect it so the data structure is good.
 if config.saveddata_connectionstring == "sqlite:///:memory:":
     saveddata_meta.create_all()
+    pyfalog.info("Running database out of memory.")
 
 
 def rollback():
     with sd_lock:
+        pyfalog.warning("Session rollback triggered.")
         saveddata_session.rollback()

eos/db/gamedata/__init__.py

@@ -1,2 +1,2 @@
 __all__ = ["attribute", "category", "effect", "group", "metaData",
-           "icon", "item", "marketGroup", "metaGroup", "unit"]
+           "icon", "item", "marketGroup", "metaGroup", "unit", "alphaClones"]

eos/db/gamedata/alphaClones.py

@@ -0,0 +1,50 @@
+# ===============================================================================
+# Copyright (C) 2010 Diego Duclos
+#
+# This file is part of eos.
+#
+# eos is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License as published by
+# the Free Software Foundation, either version 2 of the License, or
+# (at your option) any later version.
+#
+# eos is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with eos.  If not, see <http://www.gnu.org/licenses/>.
+# ===============================================================================
+
+from sqlalchemy import Column, String, Integer, Table, ForeignKey
+from sqlalchemy.orm import relation, mapper, synonym
+
+from eos.db import gamedata_meta
+from eos.gamedata import AlphaClone, AlphaCloneSkill
+
+alphaclones_table = Table(
+        "alphaClones",
+        gamedata_meta,
+        Column("alphaCloneID", Integer, primary_key=True),
+        Column("alphaCloneName", String),
+)
+
+alphacloneskskills_table = Table(
+        "alphaCloneSkills",
+        gamedata_meta,
+        Column("alphaCloneID", Integer, ForeignKey("alphaClones.alphaCloneID"), primary_key=True),
+        Column("typeID", Integer, primary_key=True),
+        Column("level", Integer),
+)
+
+mapper(AlphaClone, alphaclones_table,
+       properties={
+           "ID"    : synonym("alphaCloneID"),
+           "skills": relation(
+                   AlphaCloneSkill,
+                   cascade="all,delete-orphan",
+                   backref="clone")
+       })
+
+mapper(AlphaCloneSkill, alphacloneskskills_table)

eos/db/gamedata/attribute.py

@@ -22,7 +22,7 @@ from sqlalchemy.ext.associationproxy import association_proxy
 from sqlalchemy.orm import relation, mapper, synonym, deferred
 
 from eos.db import gamedata_meta
-from eos.types import Attribute, Icon, AttributeInfo, Unit
+from eos.gamedata import Attribute, AttributeInfo, Unit, Icon
 
 typeattributes_table = Table("dgmtypeattribs", gamedata_meta,
                              Column("value", Float),
@@ -45,11 +45,13 @@ mapper(Attribute, typeattributes_table,
        properties={"info": relation(AttributeInfo, lazy=False)})
 
 mapper(AttributeInfo, attributes_table,
-       properties={"icon": relation(Icon),
-                   "unit": relation(Unit),
-                   "ID": synonym("attributeID"),
-                   "name": synonym("attributeName"),
-                   "description": deferred(attributes_table.c.description)})
+       properties={
+           "icon"       : relation(Icon),
+           "unit"       : relation(Unit),
+           "ID"         : synonym("attributeID"),
+           "name"       : synonym("attributeName"),
+           "description": deferred(attributes_table.c.description)
+       })
 
 Attribute.ID = association_proxy("info", "attributeID")
 Attribute.name = association_proxy("info", "attributeName")

eos/db/gamedata/category.py

@@ -21,7 +21,7 @@ from sqlalchemy import Column, String, Integer, ForeignKey, Boolean, Table
 from sqlalchemy.orm import relation, mapper, synonym, deferred
 
 from eos.db import gamedata_meta
-from eos.types import Category, Icon
+from eos.gamedata import Category, Icon
 
 categories_table = Table("invcategories", gamedata_meta,
                          Column("categoryID", Integer, primary_key=True),
@@ -31,7 +31,9 @@ categories_table = Table("invcategories", gamedata_meta,
                          Column("iconID", Integer, ForeignKey("icons.iconID")))
 
 mapper(Category, categories_table,
-       properties={"icon": relation(Icon),
-                   "ID": synonym("categoryID"),
-                   "name": synonym("categoryName"),
-                   "description": deferred(categories_table.c.description)})
+       properties={
+           "icon"       : relation(Icon),
+           "ID"         : synonym("categoryID"),
+           "name"       : synonym("categoryName"),
+           "description": deferred(categories_table.c.description)
+       })

eos/db/gamedata/effect.py

@@ -18,11 +18,10 @@
 # ===============================================================================
 
 from sqlalchemy import Column, String, Integer, Boolean, Table, ForeignKey
-from sqlalchemy.ext.associationproxy import association_proxy
-from sqlalchemy.orm import mapper, synonym, relation, deferred
+from sqlalchemy.orm import mapper, synonym, deferred
 
 from eos.db import gamedata_meta
-from eos.types import Effect, EffectInfo
+from eos.gamedata import Effect, ItemEffect
 
 typeeffects_table = Table("dgmtypeeffects", gamedata_meta,
                           Column("typeID", Integer, ForeignKey("invtypes.typeID"), primary_key=True, index=True),
@@ -34,17 +33,14 @@ effects_table = Table("dgmeffects", gamedata_meta,
                       Column("description", String),
                       Column("published", Boolean),
                       Column("isAssistance", Boolean),
-                      Column("isOffensive", Boolean))
+                      Column("isOffensive", Boolean),
+                      Column("resistanceID", Integer))
 
-mapper(EffectInfo, effects_table,
-       properties={"ID": synonym("effectID"),
-                   "name": synonym("effectName"),
-                   "description": deferred(effects_table.c.description)})
+mapper(Effect, effects_table,
+       properties={
+           "ID"         : synonym("effectID"),
+           "name"       : synonym("effectName"),
+           "description": deferred(effects_table.c.description)
+       })
 
-mapper(Effect, typeeffects_table,
-       properties={"ID": synonym("effectID"),
-                   "info": relation(EffectInfo, lazy=False)})
-
-Effect.name = association_proxy("info", "name")
-Effect.description = association_proxy("info", "description")
-Effect.published = association_proxy("info", "published")
+mapper(ItemEffect, typeeffects_table)

eos/db/gamedata/group.py

@@ -21,7 +21,7 @@ from sqlalchemy import Column, String, Integer, Boolean, ForeignKey, Table
 from sqlalchemy.orm import relation, mapper, synonym, deferred
 
 from eos.db import gamedata_meta
-from eos.types import Group, Icon, Category
+from eos.gamedata import Category, Group, Icon
 
 groups_table = Table("invgroups", gamedata_meta,
                      Column("groupID", Integer, primary_key=True),
@@ -32,8 +32,10 @@ groups_table = Table("invgroups", gamedata_meta,
                      Column("iconID", Integer, ForeignKey("icons.iconID")))
 
 mapper(Group, groups_table,
-       properties={"category": relation(Category, backref="groups"),
-                   "icon": relation(Icon),
-                   "ID": synonym("groupID"),
-                   "name": synonym("groupName"),
-                   "description": deferred(groups_table.c.description)})
+       properties={
+           "category"   : relation(Category, backref="groups"),
+           "icon"       : relation(Icon),
+           "ID"         : synonym("groupID"),
+           "name"       : synonym("groupName"),
+           "description": deferred(groups_table.c.description)
+       })

eos/db/gamedata/icon.py

@@ -21,7 +21,7 @@ from sqlalchemy import Column, String, Integer, Table
 from sqlalchemy.orm import mapper, synonym, deferred
 
 from eos.db import gamedata_meta
-from eos.types import Icon
+from eos.gamedata import Icon
 
 icons_table = Table("icons", gamedata_meta,
                     Column("iconID", Integer, primary_key=True),
@@ -29,5 +29,7 @@ icons_table = Table("icons", gamedata_meta,
                     Column("iconFile", String))
 
 mapper(Icon, icons_table,
-       properties={"ID": synonym("iconID"),
-                   "description": deferred(icons_table.c.description)})
+       properties={
+           "ID"         : synonym("iconID"),
+           "description": deferred(icons_table.c.description)
+       })

eos/db/gamedata/item.py

@@ -21,9 +21,10 @@ from sqlalchemy import Column, String, Integer, Boolean, ForeignKey, Table, Floa
 from sqlalchemy.ext.associationproxy import association_proxy
 from sqlalchemy.orm import relation, mapper, synonym, deferred
 from sqlalchemy.orm.collections import attribute_mapped_collection
+from eos.db.gamedata.effect import typeeffects_table
 
 from eos.db import gamedata_meta
-from eos.types import Icon, Attribute, Item, Effect, MetaType, Group, Traits
+from eos.gamedata import Attribute, Effect, Group, Icon, Item, MetaType, Traits
 
 items_table = Table("invtypes", gamedata_meta,
                     Column("typeID", Integer, primary_key=True),
@@ -39,23 +40,24 @@ items_table = Table("invtypes", gamedata_meta,
                     Column("iconID", Integer, ForeignKey("icons.iconID")),
                     Column("groupID", Integer, ForeignKey("invgroups.groupID"), index=True))
 
-from .metaGroup import metatypes_table
-from .traits import traits_table
+from .metaGroup import metatypes_table  # noqa
+from .traits import traits_table  # noqa
 
 mapper(Item, items_table,
-       properties={"group": relation(Group, backref="items"),
-                   "icon": relation(Icon),
-                   "_Item__attributes": relation(Attribute, collection_class=attribute_mapped_collection('name')),
-                   "effects": relation(Effect, collection_class=attribute_mapped_collection('name')),
-                   "metaGroup": relation(MetaType,
+       properties={
+           "group"            : relation(Group, backref="items"),
+           "icon"             : relation(Icon),
+           "_Item__attributes": relation(Attribute, cascade='all, delete, delete-orphan', collection_class=attribute_mapped_collection('name')),
+           "effects": relation(Effect, secondary=typeeffects_table, collection_class=attribute_mapped_collection('name')),
+           "metaGroup"        : relation(MetaType,
                                          primaryjoin=metatypes_table.c.typeID == items_table.c.typeID,
                                          uselist=False),
-                   "ID": synonym("typeID"),
-                   "name": synonym("typeName"),
-                   "description": deferred(items_table.c.description),
-                   "traits": relation(Traits,
-                                      primaryjoin=traits_table.c.typeID == items_table.c.typeID,
-                                      uselist=False)
-                   })
+           "ID"               : synonym("typeID"),
+           "name"             : synonym("typeName"),
+           "description"      : deferred(items_table.c.description),
+           "traits"           : relation(Traits,
+                                         primaryjoin=traits_table.c.typeID == items_table.c.typeID,
+                                         uselist=False)
+       })
 
 Item.category = association_proxy("group", "category")

eos/db/gamedata/marketGroup.py

@@ -21,7 +21,7 @@ from sqlalchemy import Column, String, Integer, Boolean, ForeignKey, Table
 from sqlalchemy.orm import relation, mapper, synonym, deferred
 
 from eos.db import gamedata_meta
-from eos.types import Item, MarketGroup, Icon
+from eos.gamedata import Icon, Item, MarketGroup
 
 marketgroups_table = Table("invmarketgroups", gamedata_meta,
                            Column("marketGroupID", Integer, primary_key=True),
@@ -33,10 +33,12 @@ marketgroups_table = Table("invmarketgroups", gamedata_meta,
                            Column("iconID", Integer, ForeignKey("icons.iconID")))
 
 mapper(MarketGroup, marketgroups_table,
-       properties={"items": relation(Item, backref="marketGroup"),
-                   "parent": relation(MarketGroup, backref="children",
-                                      remote_side=[marketgroups_table.c.marketGroupID]),
-                   "icon": relation(Icon),
-                   "ID": synonym("marketGroupID"),
-                   "name": synonym("marketGroupName"),
-                   "description": deferred(marketgroups_table.c.description)})
+       properties={
+           "items"      : relation(Item, backref="marketGroup"),
+           "parent"     : relation(MarketGroup, backref="children",
+                                   remote_side=[marketgroups_table.c.marketGroupID]),
+           "icon"       : relation(Icon),
+           "ID"         : synonym("marketGroupID"),
+           "name"       : synonym("marketGroupName"),
+           "description": deferred(marketgroups_table.c.description)
+        })

eos/db/gamedata/metaData.py

@@ -1,30 +1,30 @@
-# ===============================================================================
-# Copyright (C) 2010 Diego Duclos
-#
-# This file is part of eos.
-#
-# eos is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Lesser General Public License as published by
-# the Free Software Foundation, either version 2 of the License, or
-# (at your option) any later version.
-#
-# eos is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU Lesser General Public License for more details.
-#
-# You should have received a copy of the GNU Lesser General Public License
-# along with eos.  If not, see <http://www.gnu.org/licenses/>.
-# ===============================================================================
-
-from sqlalchemy import Column, Table, String
-from sqlalchemy.orm import mapper
-
-from eos.db import gamedata_meta
-from eos.types import MetaData
-
-metadata_table = Table("metadata", gamedata_meta,
-                       Column("field_name", String, primary_key=True),
-                       Column("field_value", String))
-
-mapper(MetaData, metadata_table)
+# ===============================================================================
+# Copyright (C) 2010 Diego Duclos
+#
+# This file is part of eos.
+#
+# eos is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License as published by
+# the Free Software Foundation, either version 2 of the License, or
+# (at your option) any later version.
+#
+# eos is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with eos.  If not, see <http://www.gnu.org/licenses/>.
+# ===============================================================================
+
+from sqlalchemy import Column, Table, String
+from sqlalchemy.orm import mapper
+
+from eos.db import gamedata_meta
+from eos.gamedata import MetaData
+
+metadata_table = Table("metadata", gamedata_meta,
+                       Column("field_name", String, primary_key=True),
+                       Column("field_value", String))
+
+mapper(MetaData, metadata_table)

eos/db/gamedata/metaGroup.py

@@ -23,7 +23,7 @@ from sqlalchemy.orm import relation, mapper, synonym
 
 from eos.db import gamedata_meta
 from eos.db.gamedata.item import items_table
-from eos.types import MetaGroup, Item, MetaType
+from eos.gamedata import Item, MetaGroup, MetaType
 
 metagroups_table = Table("invmetagroups", gamedata_meta,
                          Column("metaGroupID", Integer, primary_key=True),
@@ -35,13 +35,17 @@ metatypes_table = Table("invmetatypes", gamedata_meta,
                         Column("metaGroupID", Integer, ForeignKey("invmetagroups.metaGroupID")))
 
 mapper(MetaGroup, metagroups_table,
-       properties={"ID": synonym("metaGroupID"),
-                   "name": synonym("metaGroupName")})
+       properties={
+           "ID"  : synonym("metaGroupID"),
+           "name": synonym("metaGroupName")
+        })
 
 mapper(MetaType, metatypes_table,
-       properties={"ID": synonym("metaGroupID"),
-                   "parent": relation(Item, primaryjoin=metatypes_table.c.parentTypeID == items_table.c.typeID),
-                   "items": relation(Item, primaryjoin=metatypes_table.c.typeID == items_table.c.typeID),
-                   "info": relation(MetaGroup, lazy=False)})
+       properties={
+           "ID"    : synonym("metaGroupID"),
+           "parent": relation(Item, primaryjoin=metatypes_table.c.parentTypeID == items_table.c.typeID),
+           "items" : relation(Item, primaryjoin=metatypes_table.c.typeID == items_table.c.typeID),
+           "info"  : relation(MetaGroup, lazy=False)
+        })
 
 MetaType.name = association_proxy("info", "name")

eos/db/gamedata/queries.py

@@ -17,21 +17,21 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-from sqlalchemy.orm import join, exc
+from sqlalchemy.orm import join, exc, aliased
 from sqlalchemy.sql import and_, or_, select
 
 import eos.config
 from eos.db import gamedata_session
 from eos.db.gamedata.metaGroup import metatypes_table, items_table
+from eos.db.gamedata.group import groups_table
 from eos.db.util import processEager, processWhere
-from eos.types import Item, Category, Group, MarketGroup, AttributeInfo, MetaData, MetaGroup
+from eos.gamedata import AlphaClone, Attribute, Category, Group, Item, MarketGroup, MetaGroup, AttributeInfo, MetaData
 
+cache = {}
 configVal = getattr(eos.config, "gamedataCache", None)
 if configVal is True:
     def cachedQuery(amount, *keywords):
         def deco(function):
-            cache = {}
-
             def checkAndReturn(*args, **kwargs):
                 useCache = kwargs.pop("useCache", True)
                 cacheKey = []
@@ -97,6 +97,53 @@ def getItem(lookfor, eager=None):
     return item
 
 
+@cachedQuery(1, "lookfor")
+def getItems(lookfor, eager=None):
+    """
+    Gets a list of items. Does a bit of cache hackery to get working properly -- cache
+    is usually based on function calls with the parameters, needed to extract data directly.
+    Works well enough. Not currently used, but it's here for possible future inclusion
+    """
+
+    toGet = []
+    results = []
+
+    for id in lookfor:
+        if (id, None) in cache:
+            results.append(cache.get((id, None)))
+        else:
+            toGet.append(id)
+
+    if len(toGet) > 0:
+        # Get items that aren't currently cached, and store them in the cache
+        items = gamedata_session.query(Item).filter(Item.ID.in_(toGet)).all()
+        for item in items:
+            cache[(item.ID, None)] = item
+        results += items
+
+    # sort the results based on the original indexing
+    results.sort(key=lambda x: lookfor.index(x.ID))
+    return results
+
+
+@cachedQuery(1, "lookfor")
+def getAlphaClone(lookfor, eager=None):
+    if isinstance(lookfor, int):
+        if eager is None:
+            item = gamedata_session.query(AlphaClone).get(lookfor)
+        else:
+            item = gamedata_session.query(AlphaClone).options(*processEager(eager)).filter(AlphaClone.ID == lookfor).first()
+    else:
+        raise TypeError("Need integer as argument")
+    return item
+
+
+def getAlphaCloneList(eager=None):
+    eager = processEager(eager)
+    clones = gamedata_session.query(AlphaClone).options(*eager).all()
+    return clones
+
+
 groupNameMap = {}
 
 
@@ -133,7 +180,7 @@ def getCategory(lookfor, eager=None):
             category = gamedata_session.query(Category).get(lookfor)
         else:
             category = gamedata_session.query(Category).options(*processEager(eager)).filter(
-                Category.ID == lookfor).first()
+                    Category.ID == lookfor).first()
     elif isinstance(lookfor, basestring):
         if lookfor in categoryNameMap:
             id = categoryNameMap[lookfor]
@@ -141,11 +188,11 @@ def getCategory(lookfor, eager=None):
                 category = gamedata_session.query(Category).get(id)
             else:
                 category = gamedata_session.query(Category).options(*processEager(eager)).filter(
-                    Category.ID == id).first()
+                        Category.ID == id).first()
         else:
             # Category names are unique, so we can use first() instead of one()
             category = gamedata_session.query(Category).options(*processEager(eager)).filter(
-                Category.name == lookfor).first()
+                    Category.name == lookfor).first()
             categoryNameMap[lookfor] = category.ID
     else:
         raise TypeError("Need integer or string as argument")
@@ -162,7 +209,7 @@ def getMetaGroup(lookfor, eager=None):
             metaGroup = gamedata_session.query(MetaGroup).get(lookfor)
         else:
             metaGroup = gamedata_session.query(MetaGroup).options(*processEager(eager)).filter(
-                MetaGroup.ID == lookfor).first()
+                    MetaGroup.ID == lookfor).first()
     elif isinstance(lookfor, basestring):
         if lookfor in metaGroupNameMap:
             id = metaGroupNameMap[lookfor]
@@ -170,11 +217,11 @@ def getMetaGroup(lookfor, eager=None):
                 metaGroup = gamedata_session.query(MetaGroup).get(id)
             else:
                 metaGroup = gamedata_session.query(MetaGroup).options(*processEager(eager)).filter(
-                    MetaGroup.ID == id).first()
+                        MetaGroup.ID == id).first()
         else:
             # MetaGroup names are unique, so we can use first() instead of one()
             metaGroup = gamedata_session.query(MetaGroup).options(*processEager(eager)).filter(
-                MetaGroup.name == lookfor).first()
+                    MetaGroup.name == lookfor).first()
             metaGroupNameMap[lookfor] = metaGroup.ID
     else:
         raise TypeError("Need integer or string as argument")
@@ -188,7 +235,7 @@ def getMarketGroup(lookfor, eager=None):
             marketGroup = gamedata_session.query(MarketGroup).get(lookfor)
         else:
             marketGroup = gamedata_session.query(MarketGroup).options(*processEager(eager)).filter(
-                MarketGroup.ID == lookfor).first()
+                    MarketGroup.ID == lookfor).first()
     else:
         raise TypeError("Need integer as argument")
     return marketGroup
@@ -205,7 +252,7 @@ def getItemsByCategory(filter, where=None, eager=None):
 
     filter = processWhere(filter, where)
     return gamedata_session.query(Item).options(*processEager(eager)).join(Item.group, Group.category).filter(
-        filter).all()
+            filter).all()
 
 
 @cachedQuery(3, "where", "nameLike", "join")
@@ -230,8 +277,24 @@ def searchItems(nameLike, where=None, join=None, eager=None):
     return items
 
 
+@cachedQuery(3, "where", "nameLike", "join")
+def searchSkills(nameLike, where=None, eager=None):
+    if not isinstance(nameLike, basestring):
+        raise TypeError("Need string as argument")
+
+    items = gamedata_session.query(Item).options(*processEager(eager)).join(Item.group, Group.category)
+    for token in nameLike.split(' '):
+        token_safe = u"%{0}%".format(sqlizeString(token))
+        if where is not None:
+            items = items.filter(and_(Item.name.like(token_safe, escape="\\"), Category.ID == 16, where))
+        else:
+            items = items.filter(and_(Item.name.like(token_safe, escape="\\"), Category.ID == 16))
+    items = items.limit(100).all()
+    return items
+
+
 @cachedQuery(2, "where", "itemids")
-def getVariations(itemids, where=None, eager=None):
+def getVariations(itemids, groupIDs=None, where=None, eager=None):
     for itemid in itemids:
         if not isinstance(itemid, int):
             raise TypeError("All passed item IDs must be integers")
@@ -243,7 +306,17 @@ def getVariations(itemids, where=None, eager=None):
     filter = processWhere(itemfilter, where)
     joinon = items_table.c.typeID == metatypes_table.c.typeID
     vars = gamedata_session.query(Item).options(*processEager(eager)).join((metatypes_table, joinon)).filter(
-        filter).all()
+            filter).all()
+
+    if vars:
+        return vars
+    elif groupIDs:
+        itemfilter = or_(*(groups_table.c.groupID == groupID for groupID in groupIDs))
+        filter = processWhere(itemfilter, where)
+        joinon = items_table.c.groupID == groups_table.c.groupID
+        vars = gamedata_session.query(Item).options(*processEager(eager)).join((groups_table, joinon)).filter(
+                filter).all()
+
     return vars
 
 
@@ -280,9 +353,31 @@ def directAttributeRequest(itemIDs, attrIDs):
         if not isinstance(itemID, int):
             raise TypeError("All itemIDs must be integer")
 
-    q = select((eos.types.Item.typeID, eos.types.Attribute.attributeID, eos.types.Attribute.value),
-               and_(eos.types.Attribute.attributeID.in_(attrIDs), eos.types.Item.typeID.in_(itemIDs)),
-               from_obj=[join(eos.types.Attribute, eos.types.Item)])
+    q = select((Item.typeID, Attribute.attributeID, Attribute.value),
+               and_(Attribute.attributeID.in_(attrIDs), Item.typeID.in_(itemIDs)),
+               from_obj=[join(Attribute, Item)])
 
     result = gamedata_session.execute(q).fetchall()
     return result
+
+
+def getRequiredFor(itemID, attrMapping):
+    Attribute1 = aliased(Attribute)
+    Attribute2 = aliased(Attribute)
+
+    skillToLevelClauses = []
+
+    for attrSkill, attrLevel in attrMapping.iteritems():
+        skillToLevelClauses.append(and_(Attribute1.attributeID == attrSkill, Attribute2.attributeID == attrLevel))
+
+    queryOr = or_(*skillToLevelClauses)
+
+    q = select((Attribute2.typeID, Attribute2.value),
+               and_(Attribute1.value == itemID, queryOr),
+               from_obj=[
+                   join(Attribute1, Attribute2, Attribute1.typeID == Attribute2.typeID)
+               ])
+
+    result = gamedata_session.execute(q).fetchall()
+
+    return result

eos/db/gamedata/traits.py

@@ -2,7 +2,7 @@ from sqlalchemy import Column, Table, Integer, String, ForeignKey
 from sqlalchemy.orm import mapper
 
 from eos.db import gamedata_meta
-from eos.types import Traits
+from eos.gamedata import Traits
 
 traits_table = Table("invtraits", gamedata_meta,
                      Column("typeID", Integer, ForeignKey("invtypes.typeID"), primary_key=True),

eos/db/gamedata/unit.py

@@ -21,7 +21,7 @@ from sqlalchemy import Column, Table, Integer, String
 from sqlalchemy.orm import mapper, synonym
 
 from eos.db import gamedata_meta
-from eos.types import Unit
+from eos.gamedata import Unit
 
 groups_table = Table("dgmunits", gamedata_meta,
                      Column("unitID", Integer, primary_key=True),
@@ -29,5 +29,7 @@ groups_table = Table("dgmunits", gamedata_meta,
                      Column("displayName", String))
 
 mapper(Unit, groups_table,
-       properties={"ID": synonym("unitID"),
-                   "name": synonym("unitName")})
+       properties={
+           "ID"  : synonym("unitID"),
+           "name": synonym("unitName")
+        })

eos/db/migration.py

@@ -1,11 +1,11 @@
-import logging
+from logbook import Logger
 import shutil
 import time
 
 import config
 import migrations
 
-logger = logging.getLogger(__name__)
+pyfalog = Logger(__name__)
 
 
 def getVersion(db):
@@ -37,7 +37,7 @@ def update(saveddata_engine):
         for version in xrange(dbVersion, appVersion):
             func = migrations.updates[version + 1]
             if func:
-                logger.info("Applying database update: %d", version + 1)
+                pyfalog.info("Applying database update: {0}", version + 1)
                 func(saveddata_engine)
 
         # when all is said and done, set version to current

eos/db/migrations/upgrade1.py

@@ -14,50 +14,50 @@ Migration 1
 import sqlalchemy
 
 CONVERSIONS = {
-    6135: [  # Scoped Cargo Scanner
+    6135 : [  # Scoped Cargo Scanner
         6133,  # Interior Type-E Cargo Identifier
     ],
-    6527: [  # Compact Ship Scanner
+    6527 : [  # Compact Ship Scanner
         6525,  # Ta3 Perfunctory Vessel Probe
         6529,  # Speculative Ship Identifier I
         6531,  # Practical Type-E Ship Probe
     ],
-    6569: [  # Scoped Survey Scanner
+    6569 : [  # Scoped Survey Scanner
         6567,  # ML-3 Amphilotite Mining Probe
         6571,  # Rock-Scanning Sensor Array I
         6573,  # 'Dactyl' Type-E Asteroid Analyzer
     ],
-    509: [  # 'Basic' Capacitor Flux Coil
+    509  : [  # 'Basic' Capacitor Flux Coil
         8163,  # Partial Power Plant Manager: Capacitor Flux
         8165,  # Alpha Reactor Control: Capacitor Flux
         8167,  # Type-E Power Core Modification: Capacitor Flux
         8169,  # Marked Generator Refitting: Capacitor Flux
     ],
-    8135: [  # Restrained Capacitor Flux Coil
+    8135 : [  # Restrained Capacitor Flux Coil
         8131,  # Local Power Plant Manager: Capacitor Flux I
     ],
-    8133: [  # Compact Capacitor Flux Coil
+    8133 : [  # Compact Capacitor Flux Coil
         8137,  # Mark I Generator Refitting: Capacitor Flux
     ],
-    3469: [  # Basic Co-Processor
+    3469 : [  # Basic Co-Processor
         8744,  # Nanoelectrical Co-Processor
         8743,  # Nanomechanical CPU Enhancer
         8746,  # Quantum Co-Processor
         8745,  # Photonic CPU Enhancer
         15425,  # Naiyon's Modified Co-Processor (never existed but convert
-                # anyway as some fits may include it)
+        # anyway as some fits may include it)
     ],
-    8748: [  # Upgraded Co-Processor
+    8748 : [  # Upgraded Co-Processor
         8747,  # Nanomechanical CPU Enhancer I
         8750,  # Quantum Co-Processor I
         8749,  # Photonic CPU Enhancer I
     ],
-    1351: [  # Basic Reactor Control Unit
+    1351 : [  # Basic Reactor Control Unit
         8251,  # Partial Power Plant Manager: Reaction Control
         8253,  # Alpha Reactor Control: Reaction Control
         8257,  # Marked Generator Refitting: Reaction Control
     ],
-    8263: [  # Compact Reactor Control Unit
+    8263 : [  # Compact Reactor Control Unit
         8259,  # Local Power Plant Manager: Reaction Control I
         8265,  # Mark I Generator Refitting: Reaction Control
         8261,  # Beta Reactor Control: Reaction Control I
@@ -69,19 +69,20 @@ CONVERSIONS = {
     31936: [  # Navy Micro Auxiliary Power Core
         16543,  # Micro 'Vigor' Core Augmentation
     ],
-    8089: [  # Compact Light Missile Launcher
-       8093,  # Prototype 'Arbalest' Light Missile Launcher
+    8089 : [  # Compact Light Missile Launcher
+        8093,  # Prototype 'Arbalest' Light Missile Launcher
     ],
-    8091: [  # Ample Light Missile Launcher
+    8091 : [  # Ample Light Missile Launcher
         7993,  # Experimental TE-2100 Light Missile Launcher
     ],
     # Surface Cargo Scanner I was removed from game, however no mention of
     # replacement module in patch notes. Morphing it to meta 0 module to be safe
-    442: [  # Cargo Scanner I
+    442  : [  # Cargo Scanner I
         6129,  # Surface Cargo Scanner I
     ]
 }
 
+
 def upgrade(saveddata_engine):
     # Update fits schema to include target resists attribute
     try:
@@ -92,6 +93,7 @@ def upgrade(saveddata_engine):
     # Convert modules
     for replacement_item, list in CONVERSIONS.iteritems():
         for retired_item in list:
-            saveddata_engine.execute('UPDATE "modules" SET "itemID" = ? WHERE "itemID" = ?', (replacement_item, retired_item))
-            saveddata_engine.execute('UPDATE "cargo" SET "itemID" = ? WHERE "itemID" = ?', (replacement_item, retired_item))
-
+            saveddata_engine.execute('UPDATE "modules" SET "itemID" = ? WHERE "itemID" = ?',
+                                     (replacement_item, retired_item))
+            saveddata_engine.execute('UPDATE "cargo" SET "itemID" = ? WHERE "itemID" = ?',
+                                     (replacement_item, retired_item))

eos/db/migrations/upgrade10.py

@@ -6,6 +6,7 @@ Migration 10
 
 import sqlalchemy
 
+
 def upgrade(saveddata_engine):
     # Update projectedFits schema to include active attribute
     try:

eos/db/migrations/upgrade11.py

@@ -7,7 +7,6 @@ Migration 11
     modules with their new replacements
 """
 
-
 CONVERSIONS = {
     16467: (  # Medium Gremlin Compact Energy Neutralizer
         16471,  # Medium Unstable Power Fluctuator I
@@ -15,7 +14,7 @@ CONVERSIONS = {
     22947: (  # 'Beatnik' Small Remote Armor Repairer
         23414,  # 'Brotherhood' Small Remote Armor Repairer
     ),
-    8295: (  # Type-D Restrained Shield Flux Coil
+    8295 : (  # Type-D Restrained Shield Flux Coil
         8293,  # Beta Reactor Control: Shield Flux I
     ),
     16499: (  # Heavy Knave Scoped Energy Nosferatu
@@ -30,13 +29,13 @@ CONVERSIONS = {
     16447: (  # Medium Solace Scoped Remote Armor Repairer
         16445,  # Medium 'Arup' Remote Armor Repairer
     ),
-    508: (  # 'Basic' Shield Flux Coil
+    508  : (  # 'Basic' Shield Flux Coil
         8325,  # Alpha Reactor Shield Flux
         8329,  # Marked Generator Refitting: Shield Flux
         8323,  # Partial Power Plant Manager: Shield Flux
         8327,  # Type-E Power Core Modification: Shield Flux
     ),
-    1419: (  # 'Basic' Shield Power Relay
+    1419 : (  # 'Basic' Shield Power Relay
         8341,  # Alpha Reactor Shield Power Relay
         8345,  # Marked Generator Refitting: Shield Power Relay
         8339,  # Partial Power Plant Manager: Shield Power Relay
@@ -48,57 +47,57 @@ CONVERSIONS = {
     16505: (  # Medium Ghoul Compact Energy Nosferatu
         16511,  # Medium Diminishing Power System Drain I
     ),
-    8297: (  # Mark I Compact Shield Flux Coil
+    8297 : (  # Mark I Compact Shield Flux Coil
         8291,  # Local Power Plant Manager: Reaction Shield Flux I
     ),
     16455: (  # Large Solace Scoped Remote Armor Repairer
         16453,  # Large 'Arup' Remote Armor Repairer
     ),
-    6485: (  # M51 Benefactor Compact Shield Recharger
+    6485 : (  # M51 Benefactor Compact Shield Recharger
         6491,  # Passive Barrier Compensator I
         6489,  # 'Benefactor' Ward Reconstructor
         6487,  # Supplemental Screen Generator I
     ),
-    5137: (  # Small Knave Scoped Energy Nosferatu
+    5137 : (  # Small Knave Scoped Energy Nosferatu
         5135,  # E5 Prototype Energy Vampire
     ),
-    8579: (  # Medium Murky Compact Remote Shield Booster
+    8579 : (  # Medium Murky Compact Remote Shield Booster
         8581,  # Medium 'Atonement' Remote Shield Booster
     ),
-    8531: (  # Small Murky Compact Remote Shield Booster
+    8531 : (  # Small Murky Compact Remote Shield Booster
         8533,  # Small 'Atonement' Remote Shield Booster
     ),
     16497: (  # Heavy Ghoul Compact Energy Nosferatu
         16503,  # Heavy Diminishing Power System Drain I
     ),
-    4477: (  # Small Gremlin Compact Energy Neutralizer
+    4477 : (  # Small Gremlin Compact Energy Neutralizer
         4475,  # Small Unstable Power Fluctuator I
     ),
-    8337: (  # Mark I Compact Shield Power Relay
+    8337 : (  # Mark I Compact Shield Power Relay
         8331,  # Local Power Plant Manager: Reaction Shield Power Relay I
     ),
     23416: (  # 'Peace' Large Remote Armor Repairer
         22951,  # 'Pacifier' Large Remote Armor Repairer
     ),
-    5141: (  # Small Ghoul Compact Energy Nosferatu
+    5141 : (  # Small Ghoul Compact Energy Nosferatu
         5139,  # Small Diminishing Power System Drain I
     ),
-    4471: (  # Small Infectious Scoped Energy Neutralizer
+    4471 : (  # Small Infectious Scoped Energy Neutralizer
         4473,  # Small Rudimentary Energy Destabilizer I
     ),
     16469: (  # Medium Infectious Scoped Energy Neutralizer
         16465,  # Medium Rudimentary Energy Destabilizer I
     ),
-    8335: (  # Type-D Restrained Shield Power Relay
+    8335 : (  # Type-D Restrained Shield Power Relay
         8333,  # Beta Reactor Control: Shield Power Relay I
     ),
-    405: (  # 'Micro' Remote Shield Booster
+    405  : (  # 'Micro' Remote Shield Booster
         8631,  # Micro Asymmetric Remote Shield Booster
         8627,  # Micro Murky Remote Shield Booster
         8629,  # Micro 'Atonement' Remote Shield Booster
         8633,  # Micro S95a Remote Shield Booster
     ),
-    8635: (  # Large Murky Compact Remote Shield Booster
+    8635 : (  # Large Murky Compact Remote Shield Booster
         8637,  # Large 'Atonement' Remote Shield Booster
     ),
     16507: (  # Medium Knave Scoped Energy Nosferatu
@@ -106,11 +105,12 @@ CONVERSIONS = {
     ),
 }
 
-def upgrade(saveddata_engine):
 
+def upgrade(saveddata_engine):
     # Convert modules
     for replacement_item, list in CONVERSIONS.iteritems():
         for retired_item in list:
-            saveddata_engine.execute('UPDATE "modules" SET "itemID" = ? WHERE "itemID" = ?', (replacement_item, retired_item))
-            saveddata_engine.execute('UPDATE "cargo" SET "itemID" = ? WHERE "itemID" = ?', (replacement_item, retired_item))
-
+            saveddata_engine.execute('UPDATE "modules" SET "itemID" = ? WHERE "itemID" = ?',
+                                     (replacement_item, retired_item))
+            saveddata_engine.execute('UPDATE "cargo" SET "itemID" = ? WHERE "itemID" = ?',
+                                     (replacement_item, retired_item))

eos/db/migrations/upgrade12.py

@@ -7,33 +7,32 @@ Migration 12
     modules with their new replacements
 """
 
-
 CONVERSIONS = {
     16457: (  # Crosslink Compact Ballistic Control System
         16459,  # Muon Coil Bolt Array I
         16461,  # Multiphasic Bolt Array I
         16463,  # 'Pandemonium' Ballistic Enhancement
     ),
-    5281: (  # Coadjunct Scoped Remote Sensor Booster
+    5281 : (  # Coadjunct Scoped Remote Sensor Booster
         7218,  # Piercing ECCM Emitter I
     ),
-    5365: (  # Cetus Scoped Burst Jammer
+    5365 : (  # Cetus Scoped Burst Jammer
         5359,  # 1Z-3 Subversive ECM Eruption
     ),
-    1973: (  # Sensor Booster I
+    1973 : (  # Sensor Booster I
         1947,  # ECCM - Radar I
         2002,  # ECCM - Ladar I
         2003,  # ECCM - Magnetometric I
         2004,  # ECCM - Gravimetric I
         2005,  # ECCM - Omni I
     ),
-    1951: (  # 'Basic' Tracking Enhancer
+    1951 : (  # 'Basic' Tracking Enhancer
         6322,  # Beta-Nought Tracking Mode
         6323,  # Azimuth Descalloping Tracking Enhancer
         6324,  # F-AQ Delay-Line Scan Tracking Subroutines
         6321,  # Beam Parallax Tracking Program
     ),
-    521: (  # 'Basic' Damage Control
+    521  : (  # 'Basic' Damage Control
         5829,  # GLFF Containment Field
         5831,  # Interior Force Field Array
         5835,  # F84 Local Damage System
@@ -43,13 +42,13 @@ CONVERSIONS = {
         22939,  # 'Boss' Remote Sensor Booster
         22941,  # 'Entrepreneur' Remote Sensor Booster
     ),
-    5443: (  # Faint Epsilon Scoped Warp Scrambler
+    5443 : (  # Faint Epsilon Scoped Warp Scrambler
         5441,  # Fleeting Progressive Warp Scrambler I
     ),
-    1963: (  # Remote Sensor Booster I
+    1963 : (  # Remote Sensor Booster I
         1959,  # ECCM Projector I
     ),
-    6325: (  # Fourier Compact Tracking Enhancer
+    6325 : (  # Fourier Compact Tracking Enhancer
         6326,  # Sigma-Nought Tracking Mode I
         6327,  # Auto-Gain Control Tracking Enhancer I
         6328,  # F-aQ Phase Code Tracking Subroutines
@@ -69,19 +68,19 @@ CONVERSIONS = {
     22919: (  # 'Monopoly' Magnetic Field Stabilizer
         22917,  # 'Capitalist' Magnetic Field Stabilizer I
     ),
-    5839: (  # IFFA Compact Damage Control
+    5839 : (  # IFFA Compact Damage Control
         5841,  # Emergency Damage Control I
         5843,  # F85 Peripheral Damage System I
         5837,  # Pseudoelectron Containment Field I
     ),
-    522: (  # 'Micro' Cap Battery
+    522  : (  # 'Micro' Cap Battery
         4747,  # Micro Ld-Acid Capacitor Battery I
         4751,  # Micro Ohm Capacitor Reserve I
         4745,  # Micro F-4a Ld-Sulfate Capacitor Charge Unit
         4749,  # Micro Peroxide Capacitor Power Cell
         3480,  # Micro Capacitor Battery II
     ),
-    518: (  # 'Basic' Gyrostabilizer
+    518  : (  # 'Basic' Gyrostabilizer
         5915,  # Lateral Gyrostabilizer
         5919,  # F-M2 Weapon Inertial Suspensor
         5913,  # Hydraulic Stabilization Actuator
@@ -90,19 +89,19 @@ CONVERSIONS = {
     19931: (  # Compulsive Scoped Multispectral ECM
         19933,  # 'Hypnos' Multispectral ECM I
     ),
-    5403: (  # Faint Scoped Warp Disruptor
+    5403 : (  # Faint Scoped Warp Disruptor
         5401,  # Fleeting Warp Disruptor I
     ),
     23902: (  # 'Trebuchet' Heat Sink I
         23900,  # 'Mangonel' Heat Sink I
     ),
-    1893: (  # 'Basic' Heat Sink
+    1893 : (  # 'Basic' Heat Sink
         5845,  # Heat Exhaust System
         5856,  # C3S Convection Thermal Radiator
         5855,  # 'Boreas' Coolant System
         5854,  # Stamped Heat Sink
     ),
-    6160: (  # F-90 Compact Sensor Booster
+    6160 : (  # F-90 Compact Sensor Booster
         20214,  # Extra Radar ECCM Scanning Array I
         20220,  # Extra Ladar ECCM Scanning Array I
         20226,  # Extra Gravimetric ECCM Scanning Array I
@@ -124,40 +123,40 @@ CONVERSIONS = {
     19952: (  # Umbra Scoped Radar ECM
         9520,  # 'Penumbra' White Noise ECM
     ),
-    1952: (  # Sensor Booster II
+    1952 : (  # Sensor Booster II
         2258,  # ECCM - Omni II
         2259,  # ECCM - Gravimetric II
         2260,  # ECCM - Ladar II
         2261,  # ECCM - Magnetometric II
         2262,  # ECCM - Radar II
     ),
-    5282: (  # Linked Enduring Sensor Booster
+    5282 : (  # Linked Enduring Sensor Booster
         7219,  # Scattering ECCM Projector I
     ),
-    1986: (  # Signal Amplifier I
+    1986 : (  # Signal Amplifier I
         2579,  # Gravimetric Backup Array I
         2583,  # Ladar Backup Array I
         2587,  # Magnetometric Backup Array I
         2591,  # Multi Sensor Backup Array I
         4013,  # RADAR Backup Array I
     ),
-    4871: (  # Large Compact Pb-Acid Cap Battery
+    4871 : (  # Large Compact Pb-Acid Cap Battery
         4875,  # Large Ohm Capacitor Reserve I
         4869,  # Large F-4a Ld-Sulfate Capacitor Charge Unit
         4873,  # Large Peroxide Capacitor Power Cell
     ),
-    1964: (  # Remote Sensor Booster II
+    1964 : (  # Remote Sensor Booster II
         1960,  # ECCM Projector II
     ),
-    5933: (  # Counterbalanced Compact Gyrostabilizer
+    5933 : (  # Counterbalanced Compact Gyrostabilizer
         5931,  # Cross-Lateral Gyrostabilizer I
         5935,  # F-M3 Munition Inertial Suspensor
         5929,  # Pneumatic Stabilization Actuator I
     ),
-    4025: (  # X5 Enduring Stasis Webifier
+    4025 : (  # X5 Enduring Stasis Webifier
         4029,  # 'Langour' Drive Disruptor I
     ),
-    4027: (  # Fleeting Compact Stasis Webifier
+    4027 : (  # Fleeting Compact Stasis Webifier
         4031,  # Patterned Stasis Web I
     ),
     22937: (  # 'Enterprise' Remote Tracking Computer
@@ -166,7 +165,7 @@ CONVERSIONS = {
     22929: (  # 'Marketeer' Tracking Computer
         22927,  # 'Economist' Tracking Computer I
     ),
-    1987: (  # Signal Amplifier II
+    1987 : (  # Signal Amplifier II
         2580,  # Gravimetric Backup Array II
         2584,  # Ladar Backup Array II
         2588,  # Magnetometric Backup Array II
@@ -176,13 +175,13 @@ CONVERSIONS = {
     19939: (  # Enfeebling Scoped Ladar ECM
         9522,  # Faint Phase Inversion ECM I
     ),
-    5340: (  # P-S Compact Remote Tracking Computer
+    5340 : (  # P-S Compact Remote Tracking Computer
         5341,  # 'Prayer' Remote Tracking Computer
     ),
     19814: (  # Phased Scoped Target Painter
         19808,  # Partial Weapon Navigation
     ),
-    1949: (  # 'Basic' Signal Amplifier
+    1949 : (  # 'Basic' Signal Amplifier
         1946,  # Basic RADAR Backup Array
         1982,  # Basic Ladar Backup Array
         1983,  # Basic Gravimetric Backup Array
@@ -223,10 +222,10 @@ CONVERSIONS = {
     23416: (  # 'Peace' Large Remote Armor Repairer
         None,  # 'Pacifier' Large Remote Armor Repairer
     ),
-    6176: (  # F-12 Enduring Tracking Computer
+    6176 : (  # F-12 Enduring Tracking Computer
         6174,  # Monopulse Tracking Mechanism I
     ),
-    6159: (  # Alumel-Wired Enduring Sensor Booster
+    6159 : (  # Alumel-Wired Enduring Sensor Booster
         7917,  # Alumel Radar ECCM Sensor Array I
         7918,  # Alumel Ladar ECCM Sensor Array I
         7922,  # Alumel Gravimetric ECCM Sensor Array I
@@ -248,7 +247,7 @@ CONVERSIONS = {
         7914,  # Prototype ECCM Magnetometric Sensor Cluster
         6158,  # Prototype Sensor Booster
     ),
-    5849: (  # Extruded Compact Heat Sink
+    5849 : (  # Extruded Compact Heat Sink
         5846,  # Thermal Exhaust System I
         5858,  # C4S Coiled Circuit Thermal Radiator
         5857,  # 'Skadi' Coolant System I
@@ -264,15 +263,15 @@ CONVERSIONS = {
     22945: (  # 'Executive' Remote Sensor Dampener
         22943,  # 'Broker' Remote Sensor Dampener I
     ),
-    6173: (  # Optical Compact Tracking Computer
+    6173 : (  # Optical Compact Tracking Computer
         6175,  # 'Orion' Tracking CPU I
     ),
-    5279: (  # F-23 Compact Remote Sensor Booster
+    5279 : (  # F-23 Compact Remote Sensor Booster
         7217,  # Spot Pulsing ECCM I
         7220,  # Phased Muon ECCM Caster I
         5280,  # Connected Remote Sensor Booster
     ),
-    4787: (  # Small Compact Pb-Acid Cap Battery
+    4787 : (  # Small Compact Pb-Acid Cap Battery
         4791,  # Small Ohm Capacitor Reserve I
         4785,  # Small F-4a Ld-Sulfate Capacitor Charge Unit
         4789,  # Small Peroxide Capacitor Power Cell
@@ -280,7 +279,7 @@ CONVERSIONS = {
     19946: (  # BZ-5 Scoped Gravimetric ECM
         9519,  # FZ-3 Subversive Spatial Destabilizer ECM
     ),
-    6073: (  # Medium Compact Pb-Acid Cap Battery
+    6073 : (  # Medium Compact Pb-Acid Cap Battery
         6097,  # Medium Ohm Capacitor Reserve I
         6111,  # Medium F-4a Ld-Sulfate Capacitor Charge Unit
         6083,  # Medium Peroxide Capacitor Power Cell
@@ -288,7 +287,7 @@ CONVERSIONS = {
     21484: (  # 'Full Duplex' Ballistic Control System
         21482,  # Ballistic 'Purge' Targeting System I
     ),
-    6296: (  # F-89 Compact Signal Amplifier
+    6296 : (  # F-89 Compact Signal Amplifier
         6218,  # Protected Gravimetric Backup Cluster I
         6222,  # Protected Ladar Backup Cluster I
         6226,  # Protected Magnetometric Backup Cluster I
@@ -325,16 +324,17 @@ CONVERSIONS = {
         6293,  # Wavelength Signal Enhancer I
         6295,  # Type-D Attenuation Signal Augmentation
     ),
-    5302: (  # Phased Muon Scoped Sensor Dampener
+    5302 : (  # Phased Muon Scoped Sensor Dampener
         5300,  # Indirect Scanning Dampening Unit I
     ),
 }
 
-def upgrade(saveddata_engine):
 
+def upgrade(saveddata_engine):
     # Convert modules
     for replacement_item, list in CONVERSIONS.iteritems():
         for retired_item in list:
-            saveddata_engine.execute('UPDATE "modules" SET "itemID" = ? WHERE "itemID" = ?', (replacement_item, retired_item))
-            saveddata_engine.execute('UPDATE "cargo" SET "itemID" = ? WHERE "itemID" = ?', (replacement_item, retired_item))
-
+            saveddata_engine.execute('UPDATE "modules" SET "itemID" = ? WHERE "itemID" = ?',
+                                     (replacement_item, retired_item))
+            saveddata_engine.execute('UPDATE "cargo" SET "itemID" = ? WHERE "itemID" = ?',
+                                     (replacement_item, retired_item))

eos/db/migrations/upgrade13.py

@@ -6,10 +6,11 @@ Migration 13
 
 import sqlalchemy
 
+
 def upgrade(saveddata_engine):
     # Update fits schema to include implant location attribute
     try:
         saveddata_engine.execute("SELECT implantLocation FROM fits LIMIT 1")
     except sqlalchemy.exc.DatabaseError:
         saveddata_engine.execute("ALTER TABLE fits ADD COLUMN implantLocation INTEGER;")
-        saveddata_engine.execute("UPDATE fits SET implantLocation = 0")
+        saveddata_engine.execute("UPDATE fits SET implantLocation = 0")

eos/db/migrations/upgrade14.py

@@ -6,8 +6,10 @@ Migration 14
 
 import sqlalchemy
 
+
 def upgrade(saveddata_engine):
-    if saveddata_engine.execute("SELECT name FROM sqlite_master WHERE type='table' AND name='fighters'").scalar() == 'fighters':
+    if saveddata_engine.execute(
+            "SELECT name FROM sqlite_master WHERE type='table' AND name='fighters'").scalar() == 'fighters':
         # Fighters table exists
         try:
             saveddata_engine.execute("SELECT active FROM fighters LIMIT 1")
@@ -16,4 +18,4 @@ def upgrade(saveddata_engine):
             # (they will be recreated)
 
             saveddata_engine.execute("DROP TABLE fighters")
-            saveddata_engine.execute("DROP TABLE fightersAbilities")
+            saveddata_engine.execute("DROP TABLE fightersAbilities")

eos/db/migrations/upgrade15.py

@@ -4,10 +4,8 @@ Migration 15
 - Delete projected modules on citadels
 """
 
-import sqlalchemy
 
 def upgrade(saveddata_engine):
-
     sql = """
     DELETE FROM modules WHERE ID IN
     (

eos/db/migrations/upgrade16.py

@@ -6,6 +6,7 @@ Migration 16
 
 import sqlalchemy
 
+
 def upgrade(saveddata_engine):
     # Update fits schema to include notes attribute
     try:

eos/db/migrations/upgrade17.py

@@ -4,8 +4,6 @@ Migration 17
 - Moves all fleet boosters to the new schema
 """
 
-import sqlalchemy
-
 
 def upgrade(saveddata_engine):
     from eos.db import saveddata_session
@@ -18,22 +16,27 @@ def upgrade(saveddata_engine):
           JOIN wings w on w.ID = s.wingID
           JOIN gangs g on g.ID = w.gangID
           """
+    try:
+        results = saveddata_session.execute(sql)
 
-    results = saveddata_session.execute(sql)
+        inserts = []
 
-    inserts = []
+        for row in results:
+            boosted = row["boostedFit"]
+            types = ("squad", "wing", "gang")
+            for x in types:
+                value = row["{}Boost".format(x)]
+                if value is None:
+                    continue
 
-    for row in results:
-        boosted = row["boostedFit"]
-        types = ("squad", "wing", "gang")
-        for x in types:
-            value = row["{}Boost".format(x)]
-            if value is None:
-                continue
-
-            inserts.append({"boosterID": value, "boostedID": boosted, "active": 1})
-            try:
-                saveddata_session.execute(commandFits_table.insert(), {"boosterID": value, "boostedID": boosted, "active": 1})
-            except Exception, e:
-                pass
-    saveddata_session.commit()
+                inserts.append({"boosterID": value, "boostedID": boosted, "active": 1})
+                try:
+                    saveddata_session.execute(commandFits_table.insert(),
+                                              {"boosterID": value, "boostedID": boosted, "active": 1})
+                except Exception:
+                    pass
+        saveddata_session.commit()
+    except:
+        # Shouldn't fail unless you have updated database without the old fleet schema and manually modify the database version
+        # If it does, simply fail. Fleet data migration isn't critically important here
+        pass

eos/db/migrations/upgrade18.py

@@ -4,27 +4,26 @@ Migration 8
 - Converts modules from old Warfare Links to Command Modules
 """
 
-
 CONVERSIONS = {
     42526: (  # Armor Command Burst I
-        20069, # Armored Warfare Link - Damage Control I
-        20409, # Armored Warfare Link - Passive Defense I
-        22227, # Armored Warfare Link - Rapid Repair I
+        20069,  # Armored Warfare Link - Damage Control I
+        20409,  # Armored Warfare Link - Passive Defense I
+        22227,  # Armored Warfare Link - Rapid Repair I
     ),
     43552: (  # Armor Command Burst II
-        4264, # Armored Warfare Link - Damage Control II
-        4266, # Armored Warfare Link - Passive Defense II
-        4266, # Armored Warfare Link - Rapid Repair II
+        4264,  # Armored Warfare Link - Damage Control II
+        4266,  # Armored Warfare Link - Passive Defense II
+        4266,  # Armored Warfare Link - Rapid Repair II
     ),
     42527: (  # Information Command Burst I
-        11052, # Information Warfare Link - Sensor Integrity I
-        20405, # Information Warfare Link - Recon Operation I
-        20406, # Information Warfare Link - Electronic Superiority I
+        11052,  # Information Warfare Link - Sensor Integrity I
+        20405,  # Information Warfare Link - Recon Operation I
+        20406,  # Information Warfare Link - Electronic Superiority I
     ),
     43554: (  # Information Command Burst II
-        4268, # Information Warfare Link - Electronic Superiority II
-        4270, # Information Warfare Link - Recon Operation II
-        4272, # Information Warfare Link - Sensor Integrity II
+        4268,  # Information Warfare Link - Electronic Superiority II
+        4270,  # Information Warfare Link - Recon Operation II
+        4272,  # Information Warfare Link - Sensor Integrity II
     ),
     42529: (  # Shield Command Burst I
         20124,  # Siege Warfare Link - Active Shielding I
@@ -34,17 +33,17 @@ CONVERSIONS = {
     43555: (  # Shield Command Burst II
         4280,  # Siege Warfare Link - Active Shielding II
         4282,  # Siege Warfare Link - Shield Efficiency II
-        4284   # Siege Warfare Link - Shield Harmonizing II
+        4284  # Siege Warfare Link - Shield Harmonizing II
     ),
     42530: (  # Skirmish Command Burst I
-        11017, # Skirmish Warfare Link - Interdiction Maneuvers I
-        20070, # Skirmish Warfare Link - Evasive Maneuvers I
-        20408, # Skirmish Warfare Link - Rapid Deployment I
+        11017,  # Skirmish Warfare Link - Interdiction Maneuvers I
+        20070,  # Skirmish Warfare Link - Evasive Maneuvers I
+        20408,  # Skirmish Warfare Link - Rapid Deployment I
     ),
     43556: (  # Skirmish Command Burst II
         4286,  # Skirmish Warfare Link - Evasive Maneuvers II
         4288,  # Skirmish Warfare Link - Interdiction Maneuvers II
-        4290   # Skirmish Warfare Link - Rapid Deployment II
+        4290  # Skirmish Warfare Link - Rapid Deployment II
     ),
     42528: (  # Mining Foreman Burst I
         22553,  # Mining Foreman Link - Harvester Capacitor Efficiency I
@@ -54,15 +53,16 @@ CONVERSIONS = {
     43551: (  # Mining Foreman Burst II
         4274,  # Mining Foreman Link - Harvester Capacitor Efficiency II
         4276,  # Mining Foreman Link - Laser Optimization II
-        4278   # Mining Foreman Link - Mining Laser Field Enhancement II
+        4278  # Mining Foreman Link - Mining Laser Field Enhancement II
     ),
 }
 
-def upgrade(saveddata_engine):
 
+def upgrade(saveddata_engine):
     # Convert modules
     for replacement_item, list in CONVERSIONS.iteritems():
         for retired_item in list:
-            saveddata_engine.execute('UPDATE "modules" SET "itemID" = ? WHERE "itemID" = ?', (replacement_item, retired_item))
-            saveddata_engine.execute('UPDATE "cargo" SET "itemID" = ? WHERE "itemID" = ?', (replacement_item, retired_item))
-
+            saveddata_engine.execute('UPDATE "modules" SET "itemID" = ? WHERE "itemID" = ?',
+                                     (replacement_item, retired_item))
+            saveddata_engine.execute('UPDATE "cargo" SET "itemID" = ? WHERE "itemID" = ?',
+                                     (replacement_item, retired_item))

eos/db/migrations/upgrade19.py

@@ -0,0 +1,18 @@
+"""
+Migration 19
+
+- Deletes broken references to fits from the commandFits table (see GH issue #844)
+"""
+
+
+def upgrade(saveddata_engine):
+    from eos.db import saveddata_session
+
+    sql = """
+        DELETE FROM commandFits
+        WHERE boosterID NOT IN (select ID from fits)
+        OR boostedID NOT IN (select ID from fits)
+        """
+
+    saveddata_session.execute(sql)
+    saveddata_session.commit()

eos/db/migrations/upgrade2.py

@@ -6,6 +6,7 @@ Migration 2
 
 import sqlalchemy
 
+
 def upgrade(saveddata_engine):
     # Update characters schema to include default chars
     try:

eos/db/migrations/upgrade20.py

@@ -0,0 +1,15 @@
+"""
+Migration 20
+
+- Adds support for alpha clones to the characters table
+"""
+
+import sqlalchemy
+
+
+def upgrade(saveddata_engine):
+    # Update characters schema to include alphaCloneID
+    try:
+        saveddata_engine.execute("SELECT alphaCloneID FROM characters LIMIT 1")
+    except sqlalchemy.exc.DatabaseError:
+        saveddata_engine.execute("ALTER TABLE characters ADD COLUMN alphaCloneID INTEGER;")

eos/db/migrations/upgrade21.py

@@ -0,0 +1,10 @@
+"""
+Migration 21
+
+- Fixes discrepancy in drone table where we may have an amount active that is not equal to the amount in the stack
+  (we don't support activating only 2/5 drones). See GH issue #728
+"""
+
+
+def upgrade(saveddata_engine):
+    saveddata_engine.execute("UPDATE drones SET amountActive = amount where amountActive > 0 AND amountActive <> amount;")

eos/db/migrations/upgrade22.py

@@ -0,0 +1,45 @@
+"""
+Migration 22
+
+- Adds the created and modified fields to most tables
+"""
+import sqlalchemy
+
+
+def upgrade(saveddata_engine):
+
+    # 1 = created only
+    # 2 = created and modified
+    tables = {
+        "boosters": 2,
+        "cargo": 2,
+        "characters": 2,
+        "crest": 1,
+        "damagePatterns": 2,
+        "drones": 2,
+        "fighters": 2,
+        "fits": 2,
+        "projectedFits": 2,
+        "commandFits": 2,
+        "implants": 2,
+        "implantSets": 2,
+        "modules": 2,
+        "overrides": 2,
+        "characterSkills": 2,
+        "targetResists": 2
+    }
+
+    for table in tables.keys():
+
+        # midnight brain, there's probably a much more simple way to do this, but fuck it
+        if tables[table] > 0:
+            try:
+                saveddata_engine.execute("SELECT created FROM {0} LIMIT 1;".format(table))
+            except sqlalchemy.exc.DatabaseError:
+                saveddata_engine.execute("ALTER TABLE {} ADD COLUMN created DATETIME;".format(table))
+
+        if tables[table] > 1:
+            try:
+                saveddata_engine.execute("SELECT modified FROM {0} LIMIT 1;".format(table))
+            except sqlalchemy.exc.DatabaseError:
+                saveddata_engine.execute("ALTER TABLE {} ADD COLUMN modified DATETIME;".format(table))

eos/db/migrations/upgrade23.py

@@ -0,0 +1,13 @@
+"""
+Migration 23
+
+- Adds a sec status field to the character table
+"""
+import sqlalchemy
+
+
+def upgrade(saveddata_engine):
+    try:
+        saveddata_engine.execute("SELECT secStatus FROM characters LIMIT 1")
+    except sqlalchemy.exc.DatabaseError:
+        saveddata_engine.execute("ALTER TABLE characters ADD COLUMN secStatus FLOAT;")

eos/db/migrations/upgrade24.py

@@ -0,0 +1,14 @@
+"""
+Migration 24
+
+- Adds a boolean value to fit to signify if fit should ignore restrictions
+"""
+import sqlalchemy
+
+
+def upgrade(saveddata_engine):
+    try:
+        saveddata_engine.execute("SELECT ignoreRestrictions FROM fits LIMIT 1")
+    except sqlalchemy.exc.DatabaseError:
+        saveddata_engine.execute("ALTER TABLE fits ADD COLUMN ignoreRestrictions BOOLEAN")
+        saveddata_engine.execute("UPDATE fits SET ignoreRestrictions = 0")

eos/db/migrations/upgrade26.py

@@ -0,0 +1,9 @@
+"""
+Migration 26
+
+- Deletes invalid command fit relationships caused by a bug (see #1244)
+"""
+
+
+def upgrade(saveddata_engine):
+    saveddata_engine.execute("DELETE FROM commandFits WHERE boosterID NOT IN (SELECT ID FROM fits) OR boostedID NOT IN (SELECT ID FROM fits)")

eos/db/migrations/upgrade3.py

@@ -6,6 +6,7 @@ Migration 3
 
 import sqlalchemy
 
+
 def upgrade(saveddata_engine):
     try:
         saveddata_engine.execute("SELECT modeID FROM fits LIMIT 1")

eos/db/migrations/upgrade4.py

@@ -10,66 +10,65 @@ Migration 4
     and output of itemDiff.py
 """
 
-
 CONVERSIONS = {
-    506: (  # 'Basic' Capacitor Power Relay
+    506  : (  # 'Basic' Capacitor Power Relay
         8205,  # Alpha Reactor Control: Capacitor Power Relay
         8209,  # Marked Generator Refitting: Capacitor Power Relay
         8203,  # Partial Power Plant Manager: Capacity Power Relay
         8207,  # Type-E Power Core Modification: Capacitor Power Relay
     ),
-    8177: (  # Mark I Compact Capacitor Power Relay
+    8177 : (  # Mark I Compact Capacitor Power Relay
         8173,  # Beta Reactor Control: Capacitor Power Relay I
     ),
-    8175: (  # Type-D Restrained Capacitor Power Relay
+    8175 : (  # Type-D Restrained Capacitor Power Relay
         8171,  # Local Power Plant Manager: Capacity Power Relay I
     ),
 
-    421: (  # 'Basic' Capacitor Recharger
+    421  : (  # 'Basic' Capacitor Recharger
         4425,  # AGM Capacitor Charge Array,
         4421,  # F-a10 Buffer Capacitor Regenerator
         4423,  # Industrial Capacitor Recharger
         4427,  # Secondary Parallel Link-Capacitor
     ),
-    4435: (  # Eutectic Compact Cap Recharger
+    4435 : (  # Eutectic Compact Cap Recharger
         4433,  # Barton Reactor Capacitor Recharger I
         4431,  # F-b10 Nominal Capacitor Regenerator
         4437,  # Fixed Parallel Link-Capacitor I
     ),
 
-    1315: (  # 'Basic' Expanded Cargohold
+    1315 : (  # 'Basic' Expanded Cargohold
         5483,  # Alpha Hull Mod Expanded Cargo
         5479,  # Marked Modified SS Expanded Cargo
         5481,  # Partial Hull Conversion Expanded Cargo
         5485,  # Type-E Altered SS Expanded Cargo
     ),
-    5493: (  # Type-D Restrained Expanded Cargo
+    5493 : (  # Type-D Restrained Expanded Cargo
         5491,  # Beta Hull Mod Expanded Cargo
         5489,  # Local Hull Conversion Expanded Cargo I
         5487,  # Mark I Modified SS Expanded Cargo
     ),
 
-    1401: (  # 'Basic' Inertial Stabilizers
+    1401 : (  # 'Basic' Inertial Stabilizers
         5523,  # Alpha Hull Mod Inertial Stabilizers
         5521,  # Partial Hull Conversion Inertial Stabilizers
         5525,  # Type-E Altered SS Inertial Stabilizers
     ),
-    5533: (  # Type-D Restrained Inertial Stabilizers
+    5533 : (  # Type-D Restrained Inertial Stabilizers
         5531,  # Beta Hull Mod Inertial Stabilizers
         5529,  # Local Hull Conversion Inertial Stabilizers I
         5527,  # Mark I Modified SS Inertial Stabilizers
         5519,  # Marked Modified SS Inertial Stabilizers
     ),
 
-    5239: (  # EP-S Gaussian Scoped Mining Laser
+    5239 : (  # EP-S Gaussian Scoped Mining Laser
         5241,  # Dual Diode Mining Laser I
     ),
-    5233: (  # Single Diode Basic Mining Laser
+    5233 : (  # Single Diode Basic Mining Laser
         5231,  # EP-R Argon Ion Basic Excavation Pulse
         5237,  # Rubin Basic Particle Bore Stream
         5235,  # Xenon Basic Drilling Beam
     ),
-    5245: (  # Particle Bore Compact Mining Laser
+    5245 : (  # Particle Bore Compact Mining Laser
         5243,  # XeCl Drilling Beam I
     ),
 
@@ -80,62 +79,63 @@ CONVERSIONS = {
         22609,  # Erin Mining Laser Upgrade
     ),
 
-    1242: (  # 'Basic' Nanofiber Internal Structure
+    1242 : (  # 'Basic' Nanofiber Internal Structure
         5591,  # Alpha Hull Mod Nanofiber Structure
         5595,  # Marked Modified SS Nanofiber Structure
         5559,  # Partial Hull Conversion Nanofiber Structure
         5593,  # Type-E Altered SS Nanofiber Structure
     ),
-    5599: (  # Type-D Restrained Nanofiber Structure
+    5599 : (  # Type-D Restrained Nanofiber Structure
         5597,  # Beta Hull Mod Nanofiber Structure
         5561,  # Local Hull Conversion Nanofiber Structure I
         5601,  # Mark I Modified SS Nanofiber Structure
     ),
 
-    1192: (  # 'Basic' Overdrive Injector System
+    1192 : (  # 'Basic' Overdrive Injector System
         5613,  # Alpha Hull Mod Overdrive Injector
         5617,  # Marked Modified SS Overdrive Injector
         5611,  # Partial Hull Conversion Overdrive Injector
         5615,  # Type-E Altered SS Overdrive Injector
     ),
-    5631: (  # Type-D Restrained Overdrive Injector
+    5631 : (  # Type-D Restrained Overdrive Injector
         5629,  # Beta Hull Mod Overdrive Injector
         5627,  # Local Hull Conversion Overdrive Injector I
         5633,  # Mark I Modified SS Overdrive Injector
     ),
 
-    1537: (  # 'Basic' Power Diagnostic System
+    1537 : (  # 'Basic' Power Diagnostic System
         8213,  # Alpha Reactor Control: Diagnostic System
         8217,  # Marked Generator Refitting: Diagnostic System
         8211,  # Partial Power Plant Manager: Diagnostic System
         8215,  # Type-E Power Core Modification: Diagnostic System
         8255,  # Type-E Power Core Modification: Reaction Control
     ),
-    8225: (  # Mark I Compact Power Diagnostic System
+    8225 : (  # Mark I Compact Power Diagnostic System
         8221,  # Beta Reactor Control: Diagnostic System I
         8219,  # Local Power Plant Manager: Diagnostic System I
         8223,  # Type-D Power Core Modification: Diagnostic System
     ),
 
-    1240: (  # 'Basic' Reinforced Bulkheads
+    1240 : (  # 'Basic' Reinforced Bulkheads
         5677,  # Alpha Hull Mod Reinforced Bulkheads
         5681,  # Marked Modified SS Reinforced Bulkheads
         5675,  # Partial Hull Conversion Reinforced Bulkheads
         5679,  # Type-E Altered SS Reinforced Bulkheads
     ),
-    5649: (  # Mark I Compact Reinforced Bulkheads
+    5649 : (  # Mark I Compact Reinforced Bulkheads
         5645,  # Beta Hull Mod Reinforced Bulkheads
     ),
-    5647: (  # Type-D Restrained Reinforced Bulkheads
+    5647 : (  # Type-D Restrained Reinforced Bulkheads
         5643,  # Local Hull Conversion Reinforced Bulkheads I
     ),
 }
 
-def upgrade(saveddata_engine):
 
+def upgrade(saveddata_engine):
     # Convert modules
     for replacement_item, list in CONVERSIONS.iteritems():
         for retired_item in list:
-            saveddata_engine.execute('UPDATE "modules" SET "itemID" = ? WHERE "itemID" = ?', (replacement_item, retired_item))
-            saveddata_engine.execute('UPDATE "cargo" SET "itemID" = ? WHERE "itemID" = ?', (replacement_item, retired_item))
-
+            saveddata_engine.execute('UPDATE "modules" SET "itemID" = ? WHERE "itemID" = ?',
+                                     (replacement_item, retired_item))
+            saveddata_engine.execute('UPDATE "cargo" SET "itemID" = ? WHERE "itemID" = ?',
+                                     (replacement_item, retired_item))

eos/db/migrations/upgrade5.py

@@ -4,5 +4,6 @@ Migration 5
 Simply deletes damage profiles with a blank name. See GH issue #256
 """
 
+
 def upgrade(saveddata_engine):
     saveddata_engine.execute('DELETE FROM damagePatterns WHERE name LIKE ?', ("",))

eos/db/migrations/upgrade6.py

@@ -4,6 +4,8 @@ Migration 6
 Overwrites damage profile 0 to reset bad uniform values (bad values set with bug)
 """
 
+
 def upgrade(saveddata_engine):
     saveddata_engine.execute('DELETE FROM damagePatterns WHERE name LIKE ? OR ID LIKE ?', ("Uniform", "1"))
-    saveddata_engine.execute('INSERT INTO damagePatterns VALUES (?, ?, ?, ?, ?, ?, ?)', (1, "Uniform", 25, 25, 25, 25, None))
+    saveddata_engine.execute('INSERT INTO damagePatterns (ID, name, emAmount, thermalAmount, kineticAmount, explosiveAmount, ownerID) VALUES (?, ?, ?, ?, ?, ?, ?)',
+                             (1, "Uniform", 25, 25, 25, 25, None))

eos/db/migrations/upgrade7.py

@@ -8,17 +8,16 @@ Migration 7
     Pyfa.
 """
 
-
 CONVERSIONS = {
     640: (  # Scorpion
         4005,  # Scorpion Ishukone Watch
     )
 }
 
-def upgrade(saveddata_engine):
 
+def upgrade(saveddata_engine):
     # Convert ships
     for replacement_item, list in CONVERSIONS.iteritems():
         for retired_item in list:
-            saveddata_engine.execute('UPDATE "fits" SET "shipID" = ? WHERE "shipID" = ?', (replacement_item, retired_item))
-
+            saveddata_engine.execute('UPDATE "fits" SET "shipID" = ? WHERE "shipID" = ?',
+                                     (replacement_item, retired_item))

eos/db/migrations/upgrade8.py

@@ -7,18 +7,17 @@ Migration 8
     modules with their new replacements
 """
 
-
 CONVERSIONS = {
-    8529: (  # Large F-S9 Regolith Compact Shield Extender
+    8529 : (  # Large F-S9 Regolith Compact Shield Extender
         8409,  # Large Subordinate Screen Stabilizer I
     ),
-    8419: (  # Large Azeotropic Restrained Shield Extender
+    8419 : (  # Large Azeotropic Restrained Shield Extender
         8489,  # Large Supplemental Barrier Emitter I
     ),
-    8517: (  # Medium F-S9 Regolith Compact Shield Extender
+    8517 : (  # Medium F-S9 Regolith Compact Shield Extender
         8397,  # Medium Subordinate Screen Stabilizer I
     ),
-    8433: (  # Medium Azeotropic Restrained Shield Extender
+    8433 : (  # Medium Azeotropic Restrained Shield Extender
         8477,  # Medium Supplemental Barrier Emitter I
     ),
     20627: (  # Small 'Trapper' Shield Extender
@@ -29,10 +28,10 @@ CONVERSIONS = {
         8387,  # Micro Subordinate Screen Stabilizer I
         8465,  # Micro Supplemental Barrier Emitter I
     ),
-    8521: (  # Small F-S9 Regolith Compact Shield Extender
+    8521 : (  # Small F-S9 Regolith Compact Shield Extender
         8401,  # Small Subordinate Screen Stabilizer I
     ),
-    8427: (  # Small Azeotropic Restrained Shield Extender
+    8427 : (  # Small Azeotropic Restrained Shield Extender
         8481,  # Small Supplemental Barrier Emitter I
     ),
     11343: (  # 100mm Crystalline Carbonide Restrained Plates
@@ -71,15 +70,16 @@ CONVERSIONS = {
         11321,  # 800mm Reinforced Nanofiber Plates I
     ),
     11317: (  # 800mm Rolled Tungsten Compact Plates
-        11315,  #  800mm Reinforced Titanium Plates I
+        11315,  # 800mm Reinforced Titanium Plates I
     ),
 }
 
-def upgrade(saveddata_engine):
 
+def upgrade(saveddata_engine):
     # Convert modules
     for replacement_item, list in CONVERSIONS.iteritems():
         for retired_item in list:
-            saveddata_engine.execute('UPDATE "modules" SET "itemID" = ? WHERE "itemID" = ?', (replacement_item, retired_item))
-            saveddata_engine.execute('UPDATE "cargo" SET "itemID" = ? WHERE "itemID" = ?', (replacement_item, retired_item))
-
+            saveddata_engine.execute('UPDATE "modules" SET "itemID" = ? WHERE "itemID" = ?',
+                                     (replacement_item, retired_item))
+            saveddata_engine.execute('UPDATE "cargo" SET "itemID" = ? WHERE "itemID" = ?',
+                                     (replacement_item, retired_item))

eos/db/migrations/upgrade9.py

@@ -16,8 +16,10 @@ CREATE TABLE boostersTemp (
 )
 """
 
+
 def upgrade(saveddata_engine):
     saveddata_engine.execute(tmpTable)
-    saveddata_engine.execute("INSERT INTO boostersTemp (ID, itemID, fitID, active) SELECT ID, itemID, fitID, active FROM boosters")
+    saveddata_engine.execute(
+            "INSERT INTO boostersTemp (ID, itemID, fitID, active) SELECT ID, itemID, fitID, active FROM boosters")
     saveddata_engine.execute("DROP TABLE boosters")
     saveddata_engine.execute("ALTER TABLE boostersTemp RENAME TO boosters")

eos/db/saveddata/__init__.py

@@ -8,7 +8,6 @@ __all__ = [
     "booster",
     "drone",
     "implant",
-    "fleet",
     "damagePattern",
     "miscData",
     "targetResists",

eos/db/saveddata/booster.py

@@ -17,33 +17,39 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-from sqlalchemy import Table, Column, ForeignKey, Integer, Boolean
-from sqlalchemy.ext.associationproxy import association_proxy
+from sqlalchemy import Table, Column, ForeignKey, Integer, Boolean, DateTime
 from sqlalchemy.orm import mapper, relation
+import datetime
 
 from eos.db import saveddata_meta
-from eos.types import Booster
+from eos.saveddata.booster import Booster
+from eos.saveddata.boosterSideEffect import BoosterSideEffect
 
 boosters_table = Table("boosters", saveddata_meta,
                        Column("ID", Integer, primary_key=True),
                        Column("itemID", Integer),
                        Column("fitID", Integer, ForeignKey("fits.ID"), nullable=False),
                        Column("active", Boolean),
+                       Column("created", DateTime, nullable=True, default=datetime.datetime.now),
+                       Column("modified", DateTime, nullable=True, onupdate=datetime.datetime.now),
                        )
 
-# Legacy booster side effect code, should disable but a mapper relies on it.
-activeSideEffects_table = Table("boostersActiveSideEffects", saveddata_meta,
-                                Column("boosterID", ForeignKey("boosters.ID"), primary_key=True),
-                                Column("effectID", Integer, primary_key=True))
+
+booster_side_effect_table = Table("boosterSideEffects", saveddata_meta,
+                                  Column("boosterID", Integer, ForeignKey("boosters.ID"), primary_key=True, index=True),
+                                  Column("effectID", Integer, nullable=False, primary_key=True),
+                                  Column("active", Boolean, default=False)
+                                  )
 
 
-class ActiveSideEffectsDummy(object):
-    def __init__(self, effectID):
-        self.effectID = effectID
-
-
-mapper(ActiveSideEffectsDummy, activeSideEffects_table)
 mapper(Booster, boosters_table,
-       properties={"_Booster__activeSideEffectDummies": relation(ActiveSideEffectsDummy)})
+       properties={
+        "_Booster__sideEffects": relation(
+            BoosterSideEffect,
+            backref="booster",
+            cascade='all, delete, delete-orphan'),
+       }
+       )
 
-Booster._Booster__activeSideEffectIDs = association_proxy("_Booster__activeSideEffectDummies", "effectID")
+
+mapper(BoosterSideEffect, booster_side_effect_table)

eos/db/saveddata/cargo.py

@@ -17,16 +17,25 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-from sqlalchemy import Table, Column, Integer, ForeignKey
-from sqlalchemy.orm import mapper
+from sqlalchemy import Table, Column, Integer, ForeignKey, DateTime
+from sqlalchemy.orm import mapper, relation
+import datetime
 
 from eos.db import saveddata_meta
-from eos.types import Cargo
+from eos.saveddata.cargo import Cargo
+from eos.saveddata.fit import Fit
 
 cargo_table = Table("cargo", saveddata_meta,
                     Column("ID", Integer, primary_key=True),
                     Column("fitID", Integer, ForeignKey("fits.ID"), nullable=False, index=True),
                     Column("itemID", Integer, nullable=False),
-                    Column("amount", Integer, nullable=False))
+                    Column("amount", Integer, nullable=False),
+                    Column("created", DateTime, nullable=True, default=datetime.datetime.now),
+                    Column("modified", DateTime, nullable=True, onupdate=datetime.datetime.now),
+                    )
 
-mapper(Cargo, cargo_table)
+mapper(Cargo, cargo_table,
+   properties={
+       "owner": relation(Fit)
+   }
+)

eos/db/saveddata/character.py

@@ -17,13 +17,16 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-from sqlalchemy import Table, Column, Integer, ForeignKey, String
+from sqlalchemy import Table, Column, Integer, ForeignKey, String, DateTime, Float
 from sqlalchemy.orm import relation, mapper
+import datetime
 
 from eos.db import saveddata_meta
 from eos.db.saveddata.implant import charImplants_table
 from eos.effectHandlerHelpers import HandledImplantBoosterList
-from eos.types import Character, User, Skill, Implant
+from eos.saveddata.implant import Implant
+from eos.saveddata.user import User
+from eos.saveddata.character import Character, Skill
 
 characters_table = Table("characters", saveddata_meta,
                          Column("ID", Integer, primary_key=True),
@@ -33,26 +36,32 @@ characters_table = Table("characters", saveddata_meta,
                          Column("defaultChar", Integer),
                          Column("chars", String, nullable=True),
                          Column("defaultLevel", Integer, nullable=True),
-                         Column("ownerID", ForeignKey("users.ID"), nullable=True))
+                         Column("alphaCloneID", Integer, nullable=True),
+                         Column("ownerID", ForeignKey("users.ID"), nullable=True),
+                         Column("secStatus", Float, nullable=True, default=0.0),
+                         Column("created", DateTime, nullable=True, default=datetime.datetime.now),
+                         Column("modified", DateTime, nullable=True, onupdate=datetime.datetime.now))
 
 mapper(Character, characters_table,
        properties={
-           "savedName": characters_table.c.name,
-           "_Character__owner": relation(
-               User,
-               backref="characters"),
-           "_Character__skills": relation(
-               Skill,
-               backref="character",
-               cascade="all,delete-orphan"),
-           "_Character__implants": relation(
-               Implant,
-               collection_class=HandledImplantBoosterList,
-               cascade='all,delete-orphan',
-               backref='character',
-               single_parent=True,
-               primaryjoin=charImplants_table.c.charID == characters_table.c.ID,
-               secondaryjoin=charImplants_table.c.implantID == Implant.ID,
-               secondary=charImplants_table),
+           "_Character__alphaCloneID": characters_table.c.alphaCloneID,
+           "savedName"               : characters_table.c.name,
+           "_Character__secStatus": characters_table.c.secStatus,
+           "_Character__owner"       : relation(
+                   User,
+                   backref="characters"),
+           "_Character__skills"      : relation(
+                   Skill,
+                   backref="character",
+                   cascade="all,delete-orphan"),
+           "_Character__implants"    : relation(
+                   Implant,
+                   collection_class=HandledImplantBoosterList,
+                   cascade='all,delete-orphan',
+                   backref='character',
+                   single_parent=True,
+                   primaryjoin=charImplants_table.c.charID == characters_table.c.ID,
+                   secondaryjoin=charImplants_table.c.implantID == Implant.ID,
+                   secondary=charImplants_table),
        }
        )

eos/db/saveddata/crest.py

@@ -17,15 +17,18 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-from sqlalchemy import Table, Column, Integer, String
+from sqlalchemy import Table, Column, Integer, String, DateTime
 from sqlalchemy.orm import mapper
+import datetime
 
 from eos.db import saveddata_meta
-from eos.types import CrestChar
+from eos.saveddata.crestchar import CrestChar
 
 crest_table = Table("crest", saveddata_meta,
                     Column("ID", Integer, primary_key=True),
                     Column("name", String, nullable=False, unique=True),
-                    Column("refresh_token", String, nullable=False))
+                    Column("refresh_token", String, nullable=False),
+                    # These records aren't updated. Instead, they are dropped and created, hence we don't have a modified field
+                    Column("created", DateTime, nullable=True, default=datetime.datetime.now))
 
 mapper(CrestChar, crest_table)

eos/db/saveddata/damagePattern.py

@@ -17,11 +17,12 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-from sqlalchemy import Table, Column, Integer, ForeignKey, String
+from sqlalchemy import Table, Column, Integer, ForeignKey, String, DateTime
 from sqlalchemy.orm import mapper
+import datetime
 
 from eos.db import saveddata_meta
-from eos.types import DamagePattern
+from eos.saveddata.damagePattern import DamagePattern
 
 damagePatterns_table = Table("damagePatterns", saveddata_meta,
                              Column("ID", Integer, primary_key=True),
@@ -30,6 +31,9 @@ damagePatterns_table = Table("damagePatterns", saveddata_meta,
                              Column("thermalAmount", Integer),
                              Column("kineticAmount", Integer),
                              Column("explosiveAmount", Integer),
-                             Column("ownerID", ForeignKey("users.ID"), nullable=True))
+                             Column("ownerID", ForeignKey("users.ID"), nullable=True),
+                             Column("created", DateTime, nullable=True, default=datetime.datetime.now),
+                             Column("modified", DateTime, nullable=True, onupdate=datetime.datetime.now)
+                             )
 
 mapper(DamagePattern, damagePatterns_table)

eos/db/saveddata/databaseRepair.py

@@ -0,0 +1,239 @@
+# ===============================================================================
+# Copyright (C) 2010 Diego Duclos
+#
+# This file is part of pyfa.
+#
+# pyfa is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# pyfa is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with pyfa.  If not, see <http://www.gnu.org/licenses/>.
+# ===============================================================================
+
+from sqlalchemy.exc import DatabaseError
+from logbook import Logger
+
+pyfalog = Logger(__name__)
+
+
+class DatabaseCleanup(object):
+    def __init__(self):
+        pass
+
+    @staticmethod
+    def ExecuteSQLQuery(saveddata_engine, query):
+        try:
+            results = saveddata_engine.execute(query)
+            return results
+        except DatabaseError:
+            pyfalog.error("Failed to connect to database or error executing query:\n{0}", query)
+            return None
+
+    @staticmethod
+    def OrphanedCharacterSkills(saveddata_engine):
+        # Find orphaned character skills.
+        # This solves an issue where the character doesn't exist, but skills for that character do.
+        # See issue #917
+        pyfalog.debug("Running database cleanup for character skills.")
+        query = "SELECT COUNT(*) AS num FROM characterSkills WHERE characterID NOT IN (SELECT ID from characters)"
+        results = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, query)
+
+        if results is None:
+            return
+
+        row = results.first()
+
+        if row and row['num']:
+            query = "DELETE FROM characterSkills WHERE characterID NOT IN (SELECT ID from characters)"
+            delete = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, query)
+            pyfalog.error("Database corruption found. Cleaning up {0} records.", delete.rowcount)
+
+    @staticmethod
+    def OrphanedFitDamagePatterns(saveddata_engine):
+        # Find orphaned damage patterns.
+        # This solves an issue where the damage pattern doesn't exist, but fits reference the pattern.
+        # See issue #777
+        pyfalog.debug("Running database cleanup for orphaned damage patterns attached to fits.")
+        query = "SELECT COUNT(*) AS num FROM fits WHERE damagePatternID NOT IN (SELECT ID FROM damagePatterns) OR damagePatternID IS NULL"
+        results = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, query)
+
+        if results is None:
+            return
+
+        row = results.first()
+
+        if row and row['num']:
+            # Get Uniform damage pattern ID
+            uniform_query = "SELECT ID FROM damagePatterns WHERE name = 'Uniform'"
+            uniform_results = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, uniform_query)
+
+            if uniform_results is None:
+                return
+
+            rows = uniform_results.fetchall()
+
+            if len(rows) == 0:
+                pyfalog.error("Missing uniform damage pattern.")
+            elif len(rows) > 1:
+                pyfalog.error("More than one uniform damage pattern found.")
+            else:
+                uniform_damage_pattern_id = rows[0]['ID']
+                update_query = "UPDATE 'fits' SET 'damagePatternID' = {} " \
+                               "WHERE damagePatternID NOT IN (SELECT ID FROM damagePatterns) OR damagePatternID IS NULL".format(uniform_damage_pattern_id)
+                update_results = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, update_query)
+                pyfalog.error("Database corruption found. Cleaning up {0} records.", update_results.rowcount)
+
+    @staticmethod
+    def OrphanedFitCharacterIDs(saveddata_engine):
+        # Find orphaned character IDs. This solves an issue where the character doesn't exist, but fits reference the pattern.
+        pyfalog.debug("Running database cleanup for orphaned characters attached to fits.")
+        query = "SELECT COUNT(*) AS num FROM fits WHERE characterID NOT IN (SELECT ID FROM characters) OR characterID IS NULL"
+        results = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, query)
+
+        if results is None:
+            return
+
+        row = results.first()
+
+        if row and row['num']:
+            # Get All 5 character ID
+            all5_query = "SELECT ID FROM characters WHERE name = 'All 5'"
+            all5_results = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, all5_query)
+
+            if all5_results is None:
+                return
+
+            rows = all5_results.fetchall()
+
+            if len(rows) == 0:
+                pyfalog.error("Missing 'All 5' character.")
+            elif len(rows) > 1:
+                pyfalog.error("More than one 'All 5' character found.")
+            else:
+                all5_id = rows[0]['ID']
+                update_query = "UPDATE 'fits' SET 'characterID' = " + str(all5_id) + \
+                               " WHERE characterID not in (select ID from characters) OR characterID IS NULL"
+                update_results = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, update_query)
+                pyfalog.error("Database corruption found. Cleaning up {0} records.", update_results.rowcount)
+
+    @staticmethod
+    def NullDamagePatternNames(saveddata_engine):
+        # Find damage patterns that are missing the name.
+        # This solves an issue where the damage pattern ends up with a name that is null.
+        # See issue #949
+        pyfalog.debug("Running database cleanup for missing damage pattern names.")
+        query = "SELECT COUNT(*) AS num FROM damagePatterns WHERE name IS NULL OR name = ''"
+        results = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, query)
+
+        if results is None:
+            return
+
+        row = results.first()
+
+        if row and row['num']:
+            query = "DELETE FROM damagePatterns WHERE name IS NULL OR name = ''"
+            delete = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, query)
+            pyfalog.error("Database corruption found. Cleaning up {0} records.", delete.rowcount)
+
+    @staticmethod
+    def NullTargetResistNames(saveddata_engine):
+        # Find target resists that are missing the name.
+        # This solves an issue where the target resist ends up with a name that is null.
+        # See issue #949
+        pyfalog.debug("Running database cleanup for missing target resist names.")
+        query = "SELECT COUNT(*) AS num FROM targetResists WHERE name IS NULL OR name = ''"
+        results = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, query)
+
+        if results is None:
+            return
+
+        row = results.first()
+
+        if row and row['num']:
+            query = "DELETE FROM targetResists WHERE name IS NULL OR name = ''"
+            delete = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, query)
+            pyfalog.error("Database corruption found. Cleaning up {0} records.", delete.rowcount)
+
+    @staticmethod
+    def OrphanedFitIDItemID(saveddata_engine):
+        # Orphaned items that are missing the fit ID or item ID.
+        # See issue #954
+        for table in ['drones', 'cargo', 'fighters']:
+            pyfalog.debug("Running database cleanup for orphaned {0} items.", table)
+            query = "SELECT COUNT(*) AS num FROM {} WHERE itemID IS NULL OR itemID = '' or itemID = '0' or fitID IS NULL OR fitID = '' or fitID = '0'".format(
+                    table)
+            results = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, query)
+
+            if results is None:
+                return
+
+            row = results.first()
+
+            if row and row['num']:
+                query = "DELETE FROM {} WHERE itemID IS NULL OR itemID = '' or itemID = '0' or fitID IS NULL OR fitID = '' or fitID = '0'".format(
+                        table)
+                delete = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, query)
+                pyfalog.error("Database corruption found. Cleaning up {0} records.", delete.rowcount)
+
+        for table in ['modules']:
+            pyfalog.debug("Running database cleanup for orphaned {0} items.", table)
+            query = "SELECT COUNT(*) AS num FROM {} WHERE itemID = '0' or fitID IS NULL OR fitID = '' or fitID = '0'".format(
+                    table)
+            results = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, query)
+
+            if results is None:
+                return
+
+            row = results.first()
+
+            if row and row['num']:
+                query = "DELETE FROM {} WHERE itemID = '0' or fitID IS NULL OR fitID = '' or fitID = '0'".format(table)
+                delete = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, query)
+                pyfalog.error("Database corruption found. Cleaning up {0} records.", delete.rowcount)
+
+    @staticmethod
+    def NullDamageTargetPatternValues(saveddata_engine):
+        # Find patterns that have null values
+        # See issue #954
+        for profileType in ['damagePatterns', 'targetResists']:
+            for damageType in ['em', 'thermal', 'kinetic', 'explosive']:
+                pyfalog.debug("Running database cleanup for null {0} values. ({1})", profileType, damageType)
+                query = "SELECT COUNT(*) AS num FROM {0} WHERE {1}Amount IS NULL OR {1}Amount = ''".format(profileType,
+                                                                                                           damageType)
+                results = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, query)
+
+                if results is None:
+                    return
+
+                row = results.first()
+
+                if row and row['num']:
+                    query = "UPDATE '{0}' SET '{1}Amount' = '0' WHERE {1}Amount IS NULL OR {1}Amount = ''".format(profileType,
+                                                                                                                  damageType)
+                    delete = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, query)
+                    pyfalog.error("Database corruption found. Cleaning up {0} records.", delete.rowcount)
+
+    @staticmethod
+    def DuplicateSelectedAmmoName(saveddata_engine):
+        # Orphaned items that are missing the fit ID or item ID.
+        # See issue #954
+        pyfalog.debug("Running database cleanup for duplicated selected ammo profiles.")
+        query = "SELECT COUNT(*) AS num FROM damagePatterns WHERE name = 'Selected Ammo'"
+        results = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, query)
+
+        if results is None:
+            return
+
+        row = results.first()
+
+        if row and row['num'] > 1:
+            query = "DELETE FROM damagePatterns WHERE name = 'Selected Ammo'"
+            delete = DatabaseCleanup.ExecuteSQLQuery(saveddata_engine, query)
+            pyfalog.error("Database corruption found. Cleaning up {0} records.", delete.rowcount)

eos/db/saveddata/drone.py

@@ -17,11 +17,13 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-from sqlalchemy import Table, Column, Integer, ForeignKey, Boolean
-from sqlalchemy.orm import mapper
+from sqlalchemy import Table, Column, Integer, ForeignKey, Boolean, DateTime
+from sqlalchemy.orm import mapper, relation
+import datetime
 
 from eos.db import saveddata_meta
-from eos.types import Drone
+from eos.saveddata.drone import Drone
+from eos.saveddata.fit import Fit
 
 drones_table = Table("drones", saveddata_meta,
                      Column("groupID", Integer, primary_key=True),
@@ -29,6 +31,13 @@ drones_table = Table("drones", saveddata_meta,
                      Column("itemID", Integer, nullable=False),
                      Column("amount", Integer, nullable=False),
                      Column("amountActive", Integer, nullable=False),
-                     Column("projected", Boolean, default=False))
+                     Column("projected", Boolean, default=False),
+                     Column("created", DateTime, nullable=True, default=datetime.datetime.now),
+                     Column("modified", DateTime, nullable=True, onupdate=datetime.datetime.now)
+                     )
 
-mapper(Drone, drones_table)
+mapper(Drone, drones_table,
+   properties={
+       "owner": relation(Fit)
+   }
+)

eos/db/saveddata/fighter.py

@@ -17,12 +17,14 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-from sqlalchemy import Table, Column, Integer, ForeignKey, Boolean
-from sqlalchemy.orm import *
+from sqlalchemy import Table, Column, Integer, ForeignKey, Boolean, DateTime
+from sqlalchemy.orm import mapper, relation
+import datetime
 
 from eos.db import saveddata_meta
-from eos.types import Fighter, Fit
-from eos.types import FighterAbility
+from eos.saveddata.fighterAbility import FighterAbility
+from eos.saveddata.fighter import Fighter
+from eos.saveddata.fit import Fit
 
 fighters_table = Table("fighters", saveddata_meta,
                        Column("groupID", Integer, primary_key=True),
@@ -30,7 +32,10 @@ fighters_table = Table("fighters", saveddata_meta,
                        Column("itemID", Integer, nullable=False),
                        Column("active", Boolean, nullable=True),
                        Column("amount", Integer, nullable=False),
-                       Column("projected", Boolean, default=False))
+                       Column("projected", Boolean, default=False),
+                       Column("created", DateTime, nullable=True, default=datetime.datetime.now),
+                       Column("modified", DateTime, nullable=True, onupdate=datetime.datetime.now)
+                       )
 
 fighter_abilities_table = Table("fightersAbilities", saveddata_meta,
                                 Column("groupID", Integer, ForeignKey("fighters.groupID"), primary_key=True,
@@ -40,11 +45,11 @@ fighter_abilities_table = Table("fightersAbilities", saveddata_meta,
 
 mapper(Fighter, fighters_table,
        properties={
-           "owner": relation(Fit),
+           "owner"              : relation(Fit),
            "_Fighter__abilities": relation(
-               FighterAbility,
-               backref="fighter",
-               cascade='all, delete, delete-orphan'),
+                   FighterAbility,
+                   backref="fighter",
+                   cascade='all, delete, delete-orphan'),
        })
 
 mapper(FighterAbility, fighter_abilities_table)

eos/db/saveddata/fit.py

@@ -17,21 +17,33 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-from sqlalchemy import *
 from sqlalchemy.ext.associationproxy import association_proxy
-from sqlalchemy.orm import *
 from sqlalchemy.orm.collections import attribute_mapped_collection
 from sqlalchemy.sql import and_
+from sqlalchemy.orm import relation, reconstructor, mapper, relationship
+from sqlalchemy import ForeignKey, Column, Integer, String, Table, Boolean, DateTime
+import datetime
 
 from eos.db import saveddata_meta
+from eos.db import saveddata_session
 from eos.db.saveddata.cargo import cargo_table
 from eos.db.saveddata.drone import drones_table
 from eos.db.saveddata.fighter import fighters_table
 from eos.db.saveddata.implant import fitImplants_table
 from eos.db.saveddata.module import modules_table
-from eos.effectHandlerHelpers import *
-from eos.types import Fit, Module, User, Booster, Drone, Fighter, Cargo, Implant, Character, DamagePattern, \
-    TargetResists, ImplantLocation
+from eos.effectHandlerHelpers import HandledModuleList, HandledImplantBoosterList, HandledProjectedModList, \
+    HandledDroneCargoList, HandledProjectedDroneList
+from eos.saveddata.implant import Implant
+from eos.saveddata.character import Character
+from eos.saveddata.user import User
+from eos.saveddata.fighter import Fighter
+from eos.saveddata.fit import Fit as es_Fit, ImplantLocation
+from eos.saveddata.drone import Drone
+from eos.saveddata.booster import Booster
+from eos.saveddata.module import Module
+from eos.saveddata.cargo import Cargo
+from eos.saveddata.damagePattern import DamagePattern
+from eos.saveddata.targetResists import TargetResists
 
 fits_table = Table("fits", saveddata_meta,
                    Column("ID", Integer, primary_key=True),
@@ -45,7 +57,10 @@ fits_table = Table("fits", saveddata_meta,
                    Column("targetResistsID", ForeignKey("targetResists.ID"), nullable=True),
                    Column("modeID", Integer, nullable=True),
                    Column("implantLocation", Integer, nullable=False, default=ImplantLocation.FIT),
-                   Column("notes", String, nullable = True),
+                   Column("notes", String, nullable=True),
+                   Column("ignoreRestrictions", Boolean, default=0),
+                   Column("created", DateTime, nullable=True, default=datetime.datetime.now),
+                   Column("modified", DateTime, nullable=True, default=datetime.datetime.now, onupdate=datetime.datetime.now)
                    )
 
 projectedFits_table = Table("projectedFits", saveddata_meta,
@@ -53,14 +68,19 @@ projectedFits_table = Table("projectedFits", saveddata_meta,
                             Column("victimID", ForeignKey("fits.ID"), primary_key=True),
                             Column("amount", Integer, nullable=False, default=1),
                             Column("active", Boolean, nullable=False, default=1),
+                            Column("created", DateTime, nullable=True, default=datetime.datetime.now),
+                            Column("modified", DateTime, nullable=True, onupdate=datetime.datetime.now)
                             )
 
 commandFits_table = Table("commandFits", saveddata_meta,
                           Column("boosterID", ForeignKey("fits.ID"), primary_key=True),
                           Column("boostedID", ForeignKey("fits.ID"), primary_key=True),
-                          Column("active", Boolean, nullable=False, default=1)
+                          Column("active", Boolean, nullable=False, default=1),
+                          Column("created", DateTime, nullable=True, default=datetime.datetime.now),
+                          Column("modified", DateTime, nullable=True, onupdate=datetime.datetime.now)
                           )
 
+
 class ProjectedFit(object):
     def __init__(self, sourceID, source_fit, amount=1, active=True):
         self.sourceID = sourceID
@@ -72,9 +92,9 @@ class ProjectedFit(object):
     def init(self):
         if self.source_fit.isInvalid:
             # Very rare for this to happen, but be prepared for it
-            eos.db.saveddata_session.delete(self.source_fit)
-            eos.db.saveddata_session.flush()
-            eos.db.saveddata_session.refresh(self.victim_fit)
+            saveddata_session.delete(self.source_fit)
+            saveddata_session.flush()
+            saveddata_session.refresh(self.victim_fit)
 
     # We have a series of setters and getters here just in case someone
     # downgrades and screws up the table with NULL values
@@ -88,9 +108,10 @@ class ProjectedFit(object):
 
     def __repr__(self):
         return "ProjectedFit(sourceID={}, victimID={}, amount={}, active={}) at {}".format(
-            self.sourceID, self.victimID, self.amount, self.active, hex(id(self))
+                self.sourceID, self.victimID, self.amount, self.active, hex(id(self))
         )
 
+
 class CommandFit(object):
     def __init__(self, boosterID, booster_fit, active=True):
         self.boosterID = boosterID
@@ -101,119 +122,131 @@ class CommandFit(object):
     def init(self):
         if self.booster_fit.isInvalid:
             # Very rare for this to happen, but be prepared for it
-            eos.db.saveddata_session.delete(self.booster_fit)
-            eos.db.saveddata_session.flush()
-            eos.db.saveddata_session.refresh(self.boosted_fit)
+            saveddata_session.delete(self.booster_fit)
+            saveddata_session.flush()
+            saveddata_session.refresh(self.boosted_fit)
 
     def __repr__(self):
         return "CommandFit(boosterID={}, boostedID={}, active={}) at {}".format(
-            self.boosterID, self.boostedID, self.active, hex(id(self))
+                self.boosterID, self.boostedID, self.active, hex(id(self))
         )
 
-Fit._Fit__projectedFits = association_proxy(
-    "victimOf",  # look at the victimOf association...
-    "source_fit",  # .. and return the source fits
-    creator=lambda sourceID, source_fit: ProjectedFit(sourceID, source_fit)
+
+es_Fit._Fit__projectedFits = association_proxy(
+        "victimOf",  # look at the victimOf association...
+        "source_fit",  # .. and return the source fits
+        creator=lambda sourceID, source_fit: ProjectedFit(sourceID, source_fit)
 )
 
-Fit._Fit__commandFits = association_proxy(
-    "boostedOf",  # look at the boostedOf association...
-    "booster_fit",  # .. and return the booster fit
-    creator=lambda boosterID, booster_fit: CommandFit(boosterID, booster_fit)
+es_Fit._Fit__commandFits = association_proxy(
+        "boostedOf",  # look at the boostedOf association...
+        "booster_fit",  # .. and return the booster fit
+        creator=lambda boosterID, booster_fit: CommandFit(boosterID, booster_fit)
 )
-mapper(Fit, fits_table,
-   properties={
-       "_Fit__modules": relation(
-           Module,
-           collection_class=HandledModuleList,
-           primaryjoin=and_(modules_table.c.fitID == fits_table.c.ID, modules_table.c.projected == False),
-           order_by=modules_table.c.position,
-           cascade='all, delete, delete-orphan'),
-       "_Fit__projectedModules": relation(
-           Module,
-           collection_class=HandledProjectedModList,
-           cascade='all, delete, delete-orphan',
-           single_parent=True,
-           primaryjoin=and_(modules_table.c.fitID == fits_table.c.ID, modules_table.c.projected == True)),
-       "owner": relation(
-           User,
-           backref="fits"),
-       "itemID": fits_table.c.shipID,
-       "shipID": fits_table.c.shipID,
-       "_Fit__boosters": relation(
-           Booster,
-           collection_class=HandledImplantBoosterList,
-           cascade='all, delete, delete-orphan',
-           single_parent=True),
-       "_Fit__drones": relation(
-           Drone,
-           collection_class=HandledDroneCargoList,
-           cascade='all, delete, delete-orphan',
-           single_parent=True,
-           primaryjoin=and_(drones_table.c.fitID == fits_table.c.ID, drones_table.c.projected == False)),
-       "_Fit__fighters": relation(
-           Fighter,
-           collection_class=HandledDroneCargoList,
-           cascade='all, delete, delete-orphan',
-           single_parent=True,
-           primaryjoin=and_(fighters_table.c.fitID == fits_table.c.ID, fighters_table.c.projected == False)),
-       "_Fit__cargo": relation(
-           Cargo,
-           collection_class=HandledDroneCargoList,
-           cascade='all, delete, delete-orphan',
-           single_parent=True,
-           primaryjoin=and_(cargo_table.c.fitID == fits_table.c.ID)),
-       "_Fit__projectedDrones": relation(
-           Drone,
-           collection_class=HandledProjectedDroneList,
-           cascade='all, delete, delete-orphan',
-           single_parent=True,
-           primaryjoin=and_(drones_table.c.fitID == fits_table.c.ID, drones_table.c.projected == True)),
-       "_Fit__projectedFighters": relation(
-           Fighter,
-           collection_class=HandledProjectedDroneList,
-           cascade='all, delete, delete-orphan',
-           single_parent=True,
-           primaryjoin=and_(fighters_table.c.fitID == fits_table.c.ID, fighters_table.c.projected == True)),
-       "_Fit__implants": relation(
-           Implant,
-           collection_class=HandledImplantBoosterList,
-           cascade='all, delete, delete-orphan',
-           backref='fit',
-           single_parent=True,
-           primaryjoin=fitImplants_table.c.fitID == fits_table.c.ID,
-           secondaryjoin=fitImplants_table.c.implantID == Implant.ID,
-           secondary=fitImplants_table),
-       "_Fit__character": relation(
-           Character,
-           backref="fits"),
-       "_Fit__damagePattern": relation(DamagePattern),
-       "_Fit__targetResists": relation(TargetResists),
-       "projectedOnto": relationship(
-           ProjectedFit,
-           primaryjoin=projectedFits_table.c.sourceID == fits_table.c.ID,
-           backref='source_fit',
-           collection_class=attribute_mapped_collection('victimID'),
-           cascade='all, delete, delete-orphan'),
-       "victimOf": relationship(
-           ProjectedFit,
-           primaryjoin=fits_table.c.ID == projectedFits_table.c.victimID,
-           backref='victim_fit',
-           collection_class=attribute_mapped_collection('sourceID'),
-           cascade='all, delete, delete-orphan'),
-       "boostedOnto": relationship(
-           CommandFit,
-           primaryjoin=commandFits_table.c.boosterID == fits_table.c.ID,
-           backref='booster_fit',
-           collection_class=attribute_mapped_collection('boostedID'),
-           cascade='all, delete, delete-orphan'),
-       "boostedOf": relationship(
-           CommandFit,
-           primaryjoin=fits_table.c.ID == commandFits_table.c.boostedID,
-           backref='boosted_fit',
-           collection_class=attribute_mapped_collection('boosterID'),
-           cascade='all, delete, delete-orphan'),
-   }
+
+
+# These relationships are broken out so that we can easily access it in the events stuff
+# We sometimes don't want particular relationships to cause a fit modified update (eg: projecting
+# a fit onto another would 'modify' both fits unless the following relationship is ignored)
+projectedFitSourceRel = relationship(
+   ProjectedFit,
+   primaryjoin=projectedFits_table.c.sourceID == fits_table.c.ID,
+   backref='source_fit',
+   collection_class=attribute_mapped_collection('victimID'),
+   cascade='all, delete, delete-orphan')
+
+
+boostedOntoRel = relationship(
+   CommandFit,
+   primaryjoin=commandFits_table.c.boosterID == fits_table.c.ID,
+   backref='booster_fit',
+   collection_class=attribute_mapped_collection('boostedID'),
+   cascade='all, delete, delete-orphan')
+
+mapper(es_Fit, fits_table,
+       properties={
+           "_Fit__modules": relation(
+                   Module,
+                   collection_class=HandledModuleList,
+                   primaryjoin=and_(modules_table.c.fitID == fits_table.c.ID, modules_table.c.projected == False),  # noqa
+                   order_by=modules_table.c.position,
+                   cascade='all, delete, delete-orphan'),
+           "_Fit__projectedModules": relation(
+                   Module,
+                   collection_class=HandledProjectedModList,
+                   cascade='all, delete, delete-orphan',
+                   single_parent=True,
+                   primaryjoin=and_(modules_table.c.fitID == fits_table.c.ID, modules_table.c.projected == True)),  # noqa
+           "owner": relation(
+                   User,
+                   backref="fits"),
+           "itemID": fits_table.c.shipID,
+           "shipID": fits_table.c.shipID,
+           "_Fit__boosters": relation(
+                   Booster,
+                   collection_class=HandledImplantBoosterList,
+                   cascade='all, delete, delete-orphan',
+                   backref='owner',
+                   single_parent=True),
+           "_Fit__drones": relation(
+                   Drone,
+                   collection_class=HandledDroneCargoList,
+                   cascade='all, delete, delete-orphan',
+                   single_parent=True,
+                   primaryjoin=and_(drones_table.c.fitID == fits_table.c.ID, drones_table.c.projected == False)),  # noqa
+           "_Fit__fighters": relation(
+                   Fighter,
+                   collection_class=HandledDroneCargoList,
+                   cascade='all, delete, delete-orphan',
+                   single_parent=True,
+                   primaryjoin=and_(fighters_table.c.fitID == fits_table.c.ID, fighters_table.c.projected == False)),  # noqa
+           "_Fit__cargo": relation(
+                   Cargo,
+                   collection_class=HandledDroneCargoList,
+                   cascade='all, delete, delete-orphan',
+                   single_parent=True,
+                   primaryjoin=and_(cargo_table.c.fitID == fits_table.c.ID)),
+           "_Fit__projectedDrones": relation(
+                   Drone,
+                   collection_class=HandledProjectedDroneList,
+                   cascade='all, delete, delete-orphan',
+                   single_parent=True,
+                   primaryjoin=and_(drones_table.c.fitID == fits_table.c.ID, drones_table.c.projected == True)),  # noqa
+           "_Fit__projectedFighters": relation(
+                   Fighter,
+                   collection_class=HandledProjectedDroneList,
+                   cascade='all, delete, delete-orphan',
+                   single_parent=True,
+                   primaryjoin=and_(fighters_table.c.fitID == fits_table.c.ID, fighters_table.c.projected == True)),  # noqa
+           "_Fit__implants": relation(
+                   Implant,
+                   collection_class=HandledImplantBoosterList,
+                   cascade='all, delete, delete-orphan',
+                   backref='owner',
+                   single_parent=True,
+                   primaryjoin=fitImplants_table.c.fitID == fits_table.c.ID,
+                   secondaryjoin=fitImplants_table.c.implantID == Implant.ID,
+                   secondary=fitImplants_table),
+           "_Fit__character": relation(
+                   Character,
+                   backref="fits"),
+           "_Fit__damagePattern": relation(DamagePattern),
+           "_Fit__targetResists": relation(TargetResists),
+           "projectedOnto": projectedFitSourceRel,
+           "victimOf": relationship(
+                   ProjectedFit,
+                   primaryjoin=fits_table.c.ID == projectedFits_table.c.victimID,
+                   backref='victim_fit',
+                   collection_class=attribute_mapped_collection('sourceID'),
+                   cascade='all, delete, delete-orphan'),
+           "boostedOnto": boostedOntoRel,
+           "boostedOf": relationship(
+                   CommandFit,
+                   primaryjoin=fits_table.c.ID == commandFits_table.c.boostedID,
+                   backref='boosted_fit',
+                   collection_class=attribute_mapped_collection('boosterID'),
+                   cascade='all, delete, delete-orphan'),
+       }
 )
 
 mapper(ProjectedFit, projectedFits_table,
@@ -222,4 +255,4 @@ mapper(ProjectedFit, projectedFits_table,
    }
 )
 
-mapper(CommandFit, commandFits_table)
+mapper(CommandFit, commandFits_table)

eos/db/saveddata/fleet.py

@@ -1,65 +0,0 @@
-# ===============================================================================
-# Copyright (C) 2010 Diego Duclos
-#
-# This file is part of eos.
-#
-# eos is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Lesser General Public License as published by
-# the Free Software Foundation, either version 2 of the License, or
-# (at your option) any later version.
-#
-# eos is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU Lesser General Public License for more details.
-#
-# You should have received a copy of the GNU Lesser General Public License
-# along with eos.  If not, see <http://www.gnu.org/licenses/>.
-# ===============================================================================
-
-from sqlalchemy import Table, Column, Integer, ForeignKey, String
-from sqlalchemy.orm import mapper, relation
-
-from eos.db import saveddata_meta
-from eos.db.saveddata.fit import fits_table
-from eos.types import Fleet, Wing, Squad, Fit
-
-gangs_table = Table("gangs", saveddata_meta,
-                    Column("ID", Integer, primary_key=True),
-                    Column("leaderID", ForeignKey("fits.ID")),
-                    Column("boosterID", ForeignKey("fits.ID")),
-                    Column("name", String))
-
-wings_table = Table("wings", saveddata_meta,
-                    Column("ID", Integer, primary_key=True),
-                    Column("gangID", ForeignKey("gangs.ID")),
-                    Column("boosterID", ForeignKey("fits.ID")),
-                    Column("leaderID", ForeignKey("fits.ID")))
-
-squads_table = Table("squads", saveddata_meta,
-                     Column("ID", Integer, primary_key=True),
-                     Column("wingID", ForeignKey("wings.ID")),
-                     Column("leaderID", ForeignKey("fits.ID")),
-                     Column("boosterID", ForeignKey("fits.ID")))
-
-squadmembers_table = Table("squadmembers", saveddata_meta,
-                           Column("squadID", ForeignKey("squads.ID"), primary_key=True),
-                           Column("memberID", ForeignKey("fits.ID"), primary_key=True))
-
-mapper(Fleet, gangs_table,
-       properties={"wings": relation(Wing, backref="gang"),
-                   "leader": relation(Fit, primaryjoin=gangs_table.c.leaderID == fits_table.c.ID),
-                   "booster": relation(Fit, primaryjoin=gangs_table.c.boosterID == fits_table.c.ID)})
-
-mapper(Wing, wings_table,
-       properties={"squads": relation(Squad, backref="wing"),
-                   "leader": relation(Fit, primaryjoin=wings_table.c.leaderID == fits_table.c.ID),
-                   "booster": relation(Fit, primaryjoin=wings_table.c.boosterID == fits_table.c.ID)})
-
-mapper(Squad, squads_table,
-       properties={"leader": relation(Fit, primaryjoin=squads_table.c.leaderID == fits_table.c.ID),
-                   "booster": relation(Fit, primaryjoin=squads_table.c.boosterID == fits_table.c.ID),
-                   "members": relation(Fit,
-                                       primaryjoin=squads_table.c.ID == squadmembers_table.c.squadID,
-                                       secondaryjoin=squadmembers_table.c.memberID == fits_table.c.ID,
-                                       secondary=squadmembers_table)})

eos/db/saveddata/implant.py

@@ -17,16 +17,20 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-from sqlalchemy import Table, Column, Integer, ForeignKey, Boolean
+from sqlalchemy import Table, Column, Integer, ForeignKey, Boolean, DateTime
 from sqlalchemy.orm import mapper
+import datetime
 
 from eos.db import saveddata_meta
-from eos.types import Implant
+from eos.saveddata.implant import Implant
 
 implants_table = Table("implants", saveddata_meta,
                        Column("ID", Integer, primary_key=True),
                        Column("itemID", Integer),
-                       Column("active", Boolean))
+                       Column("active", Boolean),
+                       Column("created", DateTime, nullable=True, default=datetime.datetime.now),
+                       Column("modified", DateTime, nullable=True, onupdate=datetime.datetime.now)
+                       )
 
 fitImplants_table = Table("fitImplants", saveddata_meta,
                           Column("fitID", ForeignKey("fits.ID"), index=True),

eos/db/saveddata/implantSet.py

@@ -17,29 +17,33 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-from sqlalchemy import Table, Column, Integer, String
+from sqlalchemy import Table, Column, Integer, String, DateTime
 from sqlalchemy.orm import relation, mapper
+import datetime
 
 from eos.db import saveddata_meta
 from eos.db.saveddata.implant import implantsSetMap_table
 from eos.effectHandlerHelpers import HandledImplantBoosterList
-from eos.types import Implant, ImplantSet
+from eos.saveddata.implant import Implant
+from eos.saveddata.implantSet import ImplantSet
 
 implant_set_table = Table("implantSets", saveddata_meta,
                           Column("ID", Integer, primary_key=True),
                           Column("name", String, nullable=False),
+                          Column("created", DateTime, nullable=True, default=datetime.datetime.now),
+                          Column("modified", DateTime, nullable=True, onupdate=datetime.datetime.now)
                           )
 
 mapper(ImplantSet, implant_set_table,
        properties={
            "_ImplantSet__implants": relation(
-               Implant,
-               collection_class=HandledImplantBoosterList,
-               cascade='all, delete, delete-orphan',
-               backref='set',
-               single_parent=True,
-               primaryjoin=implantsSetMap_table.c.setID == implant_set_table.c.ID,
-               secondaryjoin=implantsSetMap_table.c.implantID == Implant.ID,
-               secondary=implantsSetMap_table),
+                   Implant,
+                   collection_class=HandledImplantBoosterList,
+                   cascade='all, delete, delete-orphan',
+                   backref='set',
+                   single_parent=True,
+                   primaryjoin=implantsSetMap_table.c.setID == implant_set_table.c.ID,
+                   secondaryjoin=implantsSetMap_table.c.implantID == Implant.ID,
+                   secondary=implantsSetMap_table),
        }
        )

eos/db/saveddata/loadDefaultDatabaseValues.py

@@ -18,14 +18,15 @@
 # ===============================================================================
 
 import eos.db
-import eos.types
+from eos.saveddata.damagePattern import DamagePattern as es_DamagePattern
+from eos.saveddata.targetResists import TargetResists as es_TargetResists
 
 
 class ImportError(Exception):
     pass
 
 
-class DefaultDatabaseValues():
+class DefaultDatabaseValues(object):
     def __init__(self):
         pass
 
@@ -118,7 +119,7 @@ class DefaultDatabaseValues():
             name, em, therm, kin, exp = damageProfileRow
             damageProfile = eos.db.getDamagePattern(name)
             if damageProfile is None:
-                damageProfile = eos.types.DamagePattern(em, therm, kin, exp)
+                damageProfile = es_DamagePattern(em, therm, kin, exp)
                 damageProfile.name = name
                 eos.db.save(damageProfile)
 
@@ -180,7 +181,7 @@ class DefaultDatabaseValues():
             name, em, therm, kin, exp = targetResistProfileRow
             resistsProfile = eos.db.eos.db.getTargetResists(name)
             if resistsProfile is None:
-                resistsProfile = eos.types.TargetResists(em, therm, kin, exp)
+                resistsProfile = es_TargetResists(em, therm, kin, exp)
                 resistsProfile.name = name
                 eos.db.save(resistsProfile)
 
@@ -192,6 +193,6 @@ class DefaultDatabaseValues():
             name, em, therm, kin, exp = damageProfileRow
             damageProfile = eos.db.getDamagePattern(name)
             if damageProfile is None:
-                damageProfile = eos.types.DamagePattern(em, therm, kin, exp)
+                damageProfile = es_DamagePattern(em, therm, kin, exp)
                 damageProfile.name = name
                 eos.db.save(damageProfile)

eos/db/saveddata/miscData.py

@@ -21,7 +21,7 @@ from sqlalchemy import Column, Table, String
 from sqlalchemy.orm import mapper
 
 from eos.db import saveddata_meta
-from eos.types import MiscData
+from eos.saveddata.miscData import MiscData
 
 miscdata_table = Table("miscdata", saveddata_meta,
                        Column("fieldName", String, primary_key=True),

eos/db/saveddata/module.py

@@ -17,11 +17,13 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-from sqlalchemy import Table, Column, Integer, ForeignKey, CheckConstraint, Boolean
+from sqlalchemy import Table, Column, Integer, ForeignKey, CheckConstraint, Boolean, DateTime
 from sqlalchemy.orm import relation, mapper
+import datetime
 
 from eos.db import saveddata_meta
-from eos.types import Module, Fit
+from eos.saveddata.module import Module
+from eos.saveddata.fit import Fit
 
 modules_table = Table("modules", saveddata_meta,
                       Column("ID", Integer, primary_key=True),
@@ -32,6 +34,8 @@ modules_table = Table("modules", saveddata_meta,
                       Column("state", Integer, CheckConstraint("state >= -1"), CheckConstraint("state <= 2")),
                       Column("projected", Boolean, default=False, nullable=False),
                       Column("position", Integer),
+                      Column("created", DateTime, nullable=True, default=datetime.datetime.now),
+                      Column("modified", DateTime, nullable=True, onupdate=datetime.datetime.now),
                       CheckConstraint('("dummySlot" = NULL OR "itemID" = NULL) AND "dummySlot" != "itemID"'))
 
 mapper(Module, modules_table,

eos/db/saveddata/override.py

@@ -17,15 +17,19 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-from sqlalchemy import Table, Column, Integer, Float
+from sqlalchemy import Table, Column, Integer, Float, DateTime
 from sqlalchemy.orm import mapper
+import datetime
 
 from eos.db import saveddata_meta
-from eos.types import Override
+from eos.saveddata.override import Override
 
 overrides_table = Table("overrides", saveddata_meta,
                         Column("itemID", Integer, primary_key=True, index=True),
                         Column("attrID", Integer, primary_key=True, index=True),
-                        Column("value", Float, nullable=False))
+                        Column("value", Float, nullable=False),
+                        Column("created", DateTime, nullable=True, default=datetime.datetime.now),
+                        Column("modified", DateTime, nullable=True, onupdate=datetime.datetime.now)
+                        )
 
 mapper(Override, overrides_table)

eos/db/saveddata/price.py

@@ -21,12 +21,14 @@ from sqlalchemy import Table, Column, Float, Integer
 from sqlalchemy.orm import mapper
 
 from eos.db import saveddata_meta
-from eos.types import Price
+from eos.saveddata.price import Price
 
 prices_table = Table("prices", saveddata_meta,
                      Column("typeID", Integer, primary_key=True),
-                     Column("price", Float),
+                     Column("price", Float, default=0.0),
                      Column("time", Integer, nullable=False),
                      Column("failed", Integer))
 
-mapper(Price, prices_table)
+mapper(Price, prices_table, properties={
+    "_Price__price": prices_table.c.price,
+})

eos/db/saveddata/queries.py

@@ -17,13 +17,25 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
+import sys
+
 from sqlalchemy.sql import and_
+from sqlalchemy import desc, select
 
 from eos.db import saveddata_session, sd_lock
 from eos.db.saveddata.fit import projectedFits_table
-from eos.db.saveddata.fleet import squadmembers_table
 from eos.db.util import processEager, processWhere
-from eos.types import *
+from eos.saveddata.price import Price
+from eos.saveddata.user import User
+from eos.saveddata.crestchar import CrestChar
+from eos.saveddata.damagePattern import DamagePattern
+from eos.saveddata.targetResists import TargetResists
+from eos.saveddata.character import Character
+from eos.saveddata.implantSet import ImplantSet
+from eos.saveddata.fit import Fit
+from eos.saveddata.module import Module
+from eos.saveddata.miscData import MiscData
+from eos.saveddata.override import Override
 
 import eos.config
 
@@ -34,7 +46,6 @@ if configVal is True:
     itemCache = {}
     queryCache = {}
 
-
     def cachedQuery(type, amount, *keywords):
         itemCache[type] = localItemCache = weakref.WeakValueDictionary()
         queryCache[type] = typeQueryCache = {}
@@ -61,6 +72,7 @@ if configVal is True:
             def checkAndReturn(*args, **kwargs):
                 useCache = kwargs.pop("useCache", True)
                 cacheKey = []
+                items = None
                 cacheKey.extend(args)
                 for keyword in keywords:
                     cacheKey.append(kwargs.get(keyword))
@@ -93,7 +105,6 @@ if configVal is True:
 
         return deco
 
-
     def removeCachedEntry(type, ID):
         if type not in queryCache:
             return
@@ -123,7 +134,6 @@ else:
 
         return deco
 
-
     def removeCachedEntry(*args, **kwargs):
         return
 
@@ -169,7 +179,7 @@ def getCharacter(lookfor, eager=None):
         eager = processEager(eager)
         with sd_lock:
             character = saveddata_session.query(Character).options(*eager).filter(
-                Character.savedName == lookfor).first()
+                    Character.savedName == lookfor).first()
     else:
         raise TypeError("Need integer or string as argument")
     return character
@@ -213,51 +223,6 @@ def getFit(lookfor, eager=None):
     return fit
 
 
-@cachedQuery(Fleet, 1, "fleetID")
-def getFleet(fleetID, eager=None):
-    if isinstance(fleetID, int):
-        if eager is None:
-            with sd_lock:
-                fleet = saveddata_session.query(Fleet).get(fleetID)
-        else:
-            eager = processEager(eager)
-            with sd_lock:
-                fleet = saveddata_session.query(Fleet).options(*eager).filter(Fleet.ID == fleetID).first()
-    else:
-        raise TypeError("Need integer as argument")
-    return fleet
-
-
-@cachedQuery(Wing, 1, "wingID")
-def getWing(wingID, eager=None):
-    if isinstance(wingID, int):
-        if eager is None:
-            with sd_lock:
-                wing = saveddata_session.query(Wing).get(wingID)
-        else:
-            eager = processEager(eager)
-            with sd_lock:
-                wing = saveddata_session.query(Wing).options(*eager).filter(Wing.ID == wingID).first()
-    else:
-        raise TypeError("Need integer as argument")
-    return wing
-
-
-@cachedQuery(Squad, 1, "squadID")
-def getSquad(squadID, eager=None):
-    if isinstance(squadID, int):
-        if eager is None:
-            with sd_lock:
-                squad = saveddata_session.query(Squad).get(squadID)
-        else:
-            eager = processEager(eager)
-            with sd_lock:
-                squad = saveddata_session.query(Squad).options(*eager).filter(Fleet.ID == squadID).first()
-    else:
-        raise TypeError("Need integer as argument")
-    return squad
-
-
 def getFitsWithShip(shipID, ownerID=None, where=None, eager=None):
     """
     Get all the fits using a certain ship.
@@ -280,22 +245,34 @@ def getFitsWithShip(shipID, ownerID=None, where=None, eager=None):
     return fits
 
 
-def getBoosterFits(ownerID=None, where=None, eager=None):
-    """
-    Get all the fits that are flagged as a boosting ship
-    If no user is passed, do this for all users.
-    """
-
-    if ownerID is not None and not isinstance(ownerID, int):
-        raise TypeError("OwnerID must be integer")
-    filter = Fit.booster == 1
-    if ownerID is not None:
-        filter = and_(filter, Fit.ownerID == ownerID)
-
-    filter = processWhere(filter, where)
+def getRecentFits(ownerID=None, where=None, eager=None):
     eager = processEager(eager)
     with sd_lock:
-        fits = removeInvalid(saveddata_session.query(Fit).options(*eager).filter(filter).all())
+        q = select((
+            Fit.ID,
+            Fit.shipID,
+            Fit.name,
+            Fit.modified,
+            Fit.created,
+            Fit.timestamp,
+            Fit.notes
+        )).order_by(desc(Fit.modified), desc(Fit.timestamp)).limit(50)
+        fits = eos.db.saveddata_session.execute(q).fetchall()
+
+    return fits
+
+
+def getFitsWithModules(typeIDs, eager=None):
+    """
+    Get all the fits that have typeIDs fitted to them
+    """
+
+    if not hasattr(typeIDs, "__iter__"):
+        typeIDs = (typeIDs,)
+
+    eager = processEager(eager)
+    with sd_lock:
+        fits = removeInvalid(saveddata_session.query(Fit).join(Module).options(*eager).filter(Module.itemID.in_(typeIDs)).all())
 
     return fits
 
@@ -306,24 +283,31 @@ def countAllFits():
     return count
 
 
-def countFitsWithShip(shipID, ownerID=None, where=None, eager=None):
+def countFitsWithShip(lookfor, ownerID=None, where=None, eager=None):
     """
     Get all the fits using a certain ship.
     If no user is passed, do this for all users.
     """
-    if isinstance(shipID, int):
-        if ownerID is not None and not isinstance(ownerID, int):
-            raise TypeError("OwnerID must be integer")
-        filter = Fit.shipID == shipID
-        if ownerID is not None:
-            filter = and_(filter, Fit.ownerID == ownerID)
+    if ownerID is not None and not isinstance(ownerID, int):
+        raise TypeError("OwnerID must be integer")
 
-        filter = processWhere(filter, where)
-        eager = processEager(eager)
-        with sd_lock:
-            count = saveddata_session.query(Fit).options(*eager).filter(filter).count()
+    if isinstance(lookfor, int):
+        filter = Fit.shipID == lookfor
+    elif isinstance(lookfor, list):
+        if len(lookfor) == 0:
+            return 0
+        filter = Fit.shipID.in_(lookfor)
     else:
-        raise TypeError("ShipID must be integer")
+        raise TypeError("You must supply either an integer or ShipID must be integer")
+
+    if ownerID is not None:
+        filter = and_(filter, Fit.ownerID == ownerID)
+
+    filter = processWhere(filter, where)
+    eager = processEager(eager)
+    with sd_lock:
+        count = saveddata_session.query(Fit).options(*eager).filter(filter).count()
+
     return count
 
 
@@ -335,13 +319,6 @@ def getFitList(eager=None):
     return fits
 
 
-def getFleetList(eager=None):
-    eager = processEager(eager)
-    with sd_lock:
-        fleets = saveddata_session.query(Fleet).options(*eager).all()
-    return fleets
-
-
 @cachedQuery(Price, 1, "typeID")
 def getPrice(typeID):
     if isinstance(typeID, int):
@@ -375,6 +352,13 @@ def getDamagePatternList(eager=None):
     return patterns
 
 
+def clearDamagePatterns():
+    with sd_lock:
+        deleted_rows = saveddata_session.query(DamagePattern).filter(DamagePattern.name != 'Uniform').delete()
+    commit()
+    return deleted_rows
+
+
 def getTargetResistsList(eager=None):
     eager = processEager(eager)
     with sd_lock:
@@ -382,6 +366,13 @@ def getTargetResistsList(eager=None):
     return patterns
 
 
+def clearTargetResists():
+    with sd_lock:
+        deleted_rows = saveddata_session.query(TargetResists).delete()
+    commit()
+    return deleted_rows
+
+
 def getImplantSetList(eager=None):
     eager = processEager(eager)
     with sd_lock:
@@ -399,12 +390,12 @@ def getDamagePattern(lookfor, eager=None):
             eager = processEager(eager)
             with sd_lock:
                 pattern = saveddata_session.query(DamagePattern).options(*eager).filter(
-                    DamagePattern.ID == lookfor).first()
+                        DamagePattern.ID == lookfor).first()
     elif isinstance(lookfor, basestring):
         eager = processEager(eager)
         with sd_lock:
             pattern = saveddata_session.query(DamagePattern).options(*eager).filter(
-                DamagePattern.name == lookfor).first()
+                    DamagePattern.name == lookfor).first()
     else:
         raise TypeError("Need integer or string as argument")
     return pattern
@@ -420,12 +411,12 @@ def getTargetResists(lookfor, eager=None):
             eager = processEager(eager)
             with sd_lock:
                 pattern = saveddata_session.query(TargetResists).options(*eager).filter(
-                    TargetResists.ID == lookfor).first()
+                        TargetResists.ID == lookfor).first()
     elif isinstance(lookfor, basestring):
         eager = processEager(eager)
         with sd_lock:
             pattern = saveddata_session.query(TargetResists).options(*eager).filter(
-                TargetResists.name == lookfor).first()
+                    TargetResists.name == lookfor).first()
     else:
         raise TypeError("Need integer or string as argument")
     return pattern
@@ -441,7 +432,7 @@ def getImplantSet(lookfor, eager=None):
             eager = processEager(eager)
             with sd_lock:
                 pattern = saveddata_session.query(ImplantSet).options(*eager).filter(
-                    TargetResists.ID == lookfor).first()
+                        TargetResists.ID == lookfor).first()
     elif isinstance(lookfor, basestring):
         eager = processEager(eager)
         with sd_lock:
@@ -466,17 +457,6 @@ def searchFits(nameLike, where=None, eager=None):
     return fits
 
 
-def getSquadsIDsWithFitID(fitID):
-    if isinstance(fitID, int):
-        with sd_lock:
-            squads = saveddata_session.query(squadmembers_table.c.squadID).filter(
-                squadmembers_table.c.memberID == fitID).all()
-            squads = tuple(entry[0] for entry in squads)
-            return squads
-    else:
-        raise TypeError("Need integer as argument")
-
-
 def getProjectedFits(fitID):
     if isinstance(fitID, int):
         with sd_lock:
@@ -561,5 +541,10 @@ def remove(stuff):
 
 def commit():
     with sd_lock:
-        saveddata_session.commit()
-        saveddata_session.flush()
+        try:
+            saveddata_session.commit()
+            saveddata_session.flush()
+        except Exception:
+            saveddata_session.rollback()
+            exc_info = sys.exc_info()
+            raise exc_info[0], exc_info[1], exc_info[2]

eos/db/saveddata/skill.py

@@ -17,15 +17,20 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-from sqlalchemy import Table, Column, Integer, ForeignKey
+from sqlalchemy import Table, Column, Integer, ForeignKey, DateTime
 from sqlalchemy.orm import mapper
+import datetime
 
 from eos.db import saveddata_meta
-from eos.types import Skill
+from eos.saveddata.character import Skill
+
 
 skills_table = Table("characterSkills", saveddata_meta,
                      Column("characterID", ForeignKey("characters.ID"), primary_key=True, index=True),
                      Column("itemID", Integer, primary_key=True),
-                     Column("_Skill__level", Integer, nullable=True))
+                     Column("_Skill__level", Integer, nullable=True),
+                     Column("created", DateTime, nullable=True, default=datetime.datetime.now),
+                     Column("modified", DateTime, nullable=True, onupdate=datetime.datetime.now)
+                     )
 
 mapper(Skill, skills_table)

eos/db/saveddata/targetResists.py

@@ -17,11 +17,12 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-from sqlalchemy import Table, Column, Integer, Float, ForeignKey, String
+from sqlalchemy import Table, Column, Integer, Float, ForeignKey, String, DateTime
 from sqlalchemy.orm import mapper
+import datetime
 
 from eos.db import saveddata_meta
-from eos.types import TargetResists
+from eos.saveddata.targetResists import TargetResists
 
 targetResists_table = Table("targetResists", saveddata_meta,
                             Column("ID", Integer, primary_key=True),
@@ -30,6 +31,9 @@ targetResists_table = Table("targetResists", saveddata_meta,
                             Column("thermalAmount", Float),
                             Column("kineticAmount", Float),
                             Column("explosiveAmount", Float),
-                            Column("ownerID", ForeignKey("users.ID"), nullable=True))
+                            Column("ownerID", ForeignKey("users.ID"), nullable=True),
+                            Column("created", DateTime, nullable=True, default=datetime.datetime.now),
+                            Column("modified", DateTime, nullable=True, onupdate=datetime.datetime.now)
+                            )
 
 mapper(TargetResists, targetResists_table)

eos/db/saveddata/user.py

@@ -21,7 +21,7 @@ from sqlalchemy import Table, Column, Integer, String, Boolean
 from sqlalchemy.orm import mapper
 
 from eos.db import saveddata_meta
-from eos.types import User
+from eos.saveddata.user import User
 
 users_table = Table("users", saveddata_meta,
                     Column("ID", Integer, primary_key=True),

eos/db/util.py

@@ -20,16 +20,18 @@
 from sqlalchemy.orm import eagerload
 from sqlalchemy.sql import and_
 
-replace = {"attributes": "_Item__attributes",
-           "modules": "_Fit__modules",
-           "projectedModules": "_Fit__projectedModules",
-           "boosters": "_Fit__boosters",
-           "drones": "_Fit__drones",
-           "projectedDrones": "_Fit__projectedDrones",
-           "implants": "_Fit__implants",
-           "character": "_Fit__character",
-           "damagePattern": "_Fit__damagePattern",
-           "projectedFits": "_Fit__projectedFits"}
+replace = {
+    "attributes"      : "_Item__attributes",
+    "modules"         : "_Fit__modules",
+    "projectedModules": "_Fit__projectedModules",
+    "boosters"        : "_Fit__boosters",
+    "drones"          : "_Fit__drones",
+    "projectedDrones" : "_Fit__projectedDrones",
+    "implants"        : "_Fit__implants",
+    "character"       : "_Fit__character",
+    "damagePattern"   : "_Fit__damagePattern",
+    "projectedFits"   : "_Fit__projectedFits"
+}
 
 
 def processEager(eager):

eos/effectHandlerHelpers.py

@@ -17,13 +17,9 @@
 # along with eos.  If not, see <http://www.gnu.org/licenses/>.
 # ===============================================================================
 
-# from sqlalchemy.orm.attributes import flag_modified
-import logging
+from logbook import Logger
 
-import eos.db
-import eos.types
-
-logger = logging.getLogger(__name__)
+pyfalog = Logger(__name__)
 
 
 class HandledList(list):
@@ -140,10 +136,6 @@ class HandledModuleList(HandledList):
             self.remove(mod)
             return
 
-        # fix for #529, where a module may be in incorrect state after CCP changes mechanics of module
-        if not mod.isValidState(mod.state):
-            mod.state = eos.types.State.ONLINE
-
     def insert(self, index, mod):
         mod.position = index
         i = index
@@ -163,7 +155,7 @@ class HandledModuleList(HandledList):
     def toDummy(self, index):
         mod = self[index]
         if not mod.isEmpty:
-            dummy = eos.types.Module.buildEmpty(mod.slot)
+            dummy = mod.buildEmpty(mod.slot)
             dummy.position = index
             self[index] = dummy
 
@@ -172,10 +164,11 @@ class HandledModuleList(HandledList):
         self[index] = mod
 
     def freeSlot(self, slot):
-        for i in range(len(self) - 1, -1, -1):
+        for i in range(len(self)):
             mod = self[i]
             if mod.getModifiedItemAttr("subSystemSlot") == slot:
-                del self[i]
+                self.toDummy(i)
+                break
 
 
 class HandledDroneCargoList(HandledList):
@@ -205,7 +198,7 @@ class HandledImplantBoosterList(HandledList):
         # if needed, remove booster that was occupying slot
         oldObj = next((m for m in self if m.slot == thing.slot), None)
         if oldObj:
-            logging.info("Slot %d occupied with %s, replacing with %s", thing.slot, oldObj.item.name, thing.item.name)
+            pyfalog.info("Slot {0} occupied with {1}, replacing with {2}", thing.slot, oldObj.item.name, thing.item.name)
             oldObj.itemID = 0  # hack to remove from DB. See GH issue #324
             self.remove(oldObj)
 
@@ -229,7 +222,7 @@ class HandledProjectedModList(HandledList):
             oldEffect = next((m for m in self if m.item.group.name == "Effect Beacon"), None)
 
             if oldEffect:
-                logging.info("System effect occupied with %s, replacing with %s", oldEffect.item.name, proj.item.name)
+                pyfalog.info("System effect occupied with {0}, replacing with {1}", oldEffect.item.name, proj.item.name)
                 self.remove(oldEffect)
 
         HandledList.append(self, proj)

eos/effects/adaptivearmorhardener.py

@@ -2,17 +2,124 @@
 #
 # Used by:
 # Module: Reactive Armor Hardener
+from logbook import Logger
+import eos.config
+
+pyfalog = Logger(__name__)
+
+runTime = "late"
 type = "active"
+
+
 def handler(fit, module, context):
-    for type in ("kinetic", "thermal", "explosive", "em"):
-        attr = "armor%sDamageResonance" % type.capitalize()
+    damagePattern = fit.damagePattern
 
-        #Adjust RAH to match the current damage pattern
-        damagePattern = fit.damagePattern
-        if damagePattern:
-            attrDamagePattern = "%sAmount" % type
-            damagePatternModifier = getattr(damagePattern,attrDamagePattern)/float(sum((damagePattern.emAmount,damagePattern.thermalAmount,damagePattern.kineticAmount,damagePattern.explosiveAmount)))
-            modifiedResistModifier = (1-(((1-module.getModifiedItemAttr(attr))*4)*(damagePatternModifier)))
-            module.forceItemAttr(attr, modifiedResistModifier)
+    static_adaptive_behavior = eos.config.settings['useStaticAdaptiveArmorHardener']
 
-        fit.ship.multiplyItemAttr(attr, module.getModifiedItemAttr(attr), stackingPenalties=True, penaltyGroup="preMul")
+    if (damagePattern.emAmount == damagePattern.thermalAmount == damagePattern.kineticAmount == damagePattern.explosiveAmount) and static_adaptive_behavior:
+        pyfalog.debug("Setting adaptivearmorhardener resists to uniform profile.")
+        return
+
+    # Skip if there is no damage pattern. Example: projected ships or fleet boosters
+    if damagePattern:
+
+        # Populate a tuple with the damage profile modified by current armor resists.
+        baseDamageTaken = (
+            damagePattern.emAmount * fit.ship.getModifiedItemAttr('armorEmDamageResonance'),
+            damagePattern.thermalAmount * fit.ship.getModifiedItemAttr('armorThermalDamageResonance'),
+            damagePattern.kineticAmount * fit.ship.getModifiedItemAttr('armorKineticDamageResonance'),
+            damagePattern.explosiveAmount * fit.ship.getModifiedItemAttr('armorExplosiveDamageResonance'),
+        )
+        # pyfalog.debug("Damage Adjusted for Armor Resists: %f/%f/%f/%f", baseDamageTaken[0], baseDamageTaken[1], baseDamageTaken[2], baseDamageTaken[3])
+
+        resistanceShiftAmount = module.getModifiedItemAttr(
+            'resistanceShiftAmount') / 100  # The attribute is in percent and we want a fraction
+        RAHResistance = [
+            module.getModifiedItemAttr('armorEmDamageResonance'),
+            module.getModifiedItemAttr('armorThermalDamageResonance'),
+            module.getModifiedItemAttr('armorKineticDamageResonance'),
+            module.getModifiedItemAttr('armorExplosiveDamageResonance'),
+        ]
+
+        # Simulate RAH cycles until the RAH either stops changing or enters a loop.
+        # The number of iterations is limited to prevent an infinite loop if something goes wrong.
+        cycleList = []
+        loopStart = -20
+        for num in range(50):
+            # pyfalog.debug("Starting cycle %d.", num)
+            # The strange order is to emulate the ingame sorting when different types have taken the same amount of damage.
+            # This doesn't take into account stacking penalties. In a few cases fitting a Damage Control causes an inaccurate result.
+            damagePattern_tuples = [
+                (0, baseDamageTaken[0] * RAHResistance[0], RAHResistance[0]),
+                (3, baseDamageTaken[3] * RAHResistance[3], RAHResistance[3]),
+                (2, baseDamageTaken[2] * RAHResistance[2], RAHResistance[2]),
+                (1, baseDamageTaken[1] * RAHResistance[1], RAHResistance[1]),
+            ]
+
+            # Sort the tuple to drop the highest damage value to the bottom
+            sortedDamagePattern_tuples = sorted(damagePattern_tuples, key=lambda damagePattern: damagePattern[1])
+
+            if sortedDamagePattern_tuples[2][1] == 0:
+                # One damage type: the top damage type takes from the other three
+                # Since the resistances not taking damage will end up going to the type taking damage we just do the whole thing at once.
+                change0 = 1 - sortedDamagePattern_tuples[0][2]
+                change1 = 1 - sortedDamagePattern_tuples[1][2]
+                change2 = 1 - sortedDamagePattern_tuples[2][2]
+                change3 = -(change0 + change1 + change2)
+            elif sortedDamagePattern_tuples[1][1] == 0:
+                # Two damage types: the top two damage types take from the other two
+                # Since the resistances not taking damage will end up going equally to the types taking damage we just do the whole thing at once.
+                change0 = 1 - sortedDamagePattern_tuples[0][2]
+                change1 = 1 - sortedDamagePattern_tuples[1][2]
+                change2 = -(change0 + change1) / 2
+                change3 = -(change0 + change1) / 2
+            else:
+                # Three or four damage types: the top two damage types take from the other two
+                change0 = min(resistanceShiftAmount, 1 - sortedDamagePattern_tuples[0][2])
+                change1 = min(resistanceShiftAmount, 1 - sortedDamagePattern_tuples[1][2])
+                change2 = -(change0 + change1) / 2
+                change3 = -(change0 + change1) / 2
+
+            RAHResistance[sortedDamagePattern_tuples[0][0]] = sortedDamagePattern_tuples[0][2] + change0
+            RAHResistance[sortedDamagePattern_tuples[1][0]] = sortedDamagePattern_tuples[1][2] + change1
+            RAHResistance[sortedDamagePattern_tuples[2][0]] = sortedDamagePattern_tuples[2][2] + change2
+            RAHResistance[sortedDamagePattern_tuples[3][0]] = sortedDamagePattern_tuples[3][2] + change3
+            # pyfalog.debug("Resistances shifted to %f/%f/%f/%f", RAHResistance[0], RAHResistance[1], RAHResistance[2], RAHResistance[3])
+
+            # See if the current RAH profile has been encountered before, indicating a loop.
+            for i, val in enumerate(cycleList):
+                tolerance = 1e-06
+                if abs(RAHResistance[0] - val[0]) <= tolerance and \
+                            abs(RAHResistance[1] - val[1]) <= tolerance and \
+                            abs(RAHResistance[2] - val[2]) <= tolerance and \
+                            abs(RAHResistance[3] - val[3]) <= tolerance:
+                    loopStart = i
+                    # pyfalog.debug("Loop found: %d-%d", loopStart, num)
+                    break
+            if loopStart >= 0:
+                break
+
+            cycleList.append(list(RAHResistance))
+
+        if loopStart < 0:
+            pyfalog.error("Reactive Armor Hardener failed to find equilibrium. Damage profile after armor: {0}/{1}/{2}/{3}",
+                         baseDamageTaken[0], baseDamageTaken[1], baseDamageTaken[2], baseDamageTaken[3])
+
+        # Average the profiles in the RAH loop, or the last 20 if it didn't find a loop.
+        loopCycles = cycleList[loopStart:]
+        numCycles = len(loopCycles)
+        average = [0, 0, 0, 0]
+        for cycle in loopCycles:
+            for i in range(4):
+                average[i] += cycle[i]
+
+        for i in range(4):
+            average[i] = round(average[i] / numCycles, 3)
+
+        # Set the new resistances
+        # pyfalog.debug("Setting new resist profile: %f/%f/%f/%f", average[0], average[1], average[2],average[3])
+        for i, attr in enumerate((
+                'armorEmDamageResonance', 'armorThermalDamageResonance', 'armorKineticDamageResonance',
+                'armorExplosiveDamageResonance')):
+            module.increaseItemAttr(attr, average[i] - module.getModifiedItemAttr(attr))
+            fit.ship.multiplyItemAttr(attr, average[i], stackingPenalties=True, penaltyGroup="preMul")

eos/effects/advanceddroneinterfacingmaxgroupdcuskilllevel.py

@@ -1,10 +0,0 @@
-# advancedDroneInterfacingMaxGroupDCUSkillLevel
-#
-# Used by:
-# Skill: Advanced Drone Interfacing
-type = "passive"
-
-
-def handler(fit, skill, context):
-    fit.modules.filteredItemIncrease(lambda mod: mod.item.group.name == "Fighter Support Unit",
-                                     "maxGroupActive", skill.level)

eos/effects/agilitybonus.py

@@ -0,0 +1,9 @@
+# agilityBonus
+#
+# Used by:
+# Subsystems named like: Propulsion Interdiction Nullifier (4 of 4)
+type = "passive"
+
+
+def handler(fit, src, context):
+    fit.ship.increaseItemAttr("agility", src.getModifiedItemAttr("agilityBonusAdd"))

eos/effects/ammoinfluencecapneed.py

@@ -1,9 +1,7 @@
 # ammoInfluenceCapNeed
 #
 # Used by:
-# Items from category: Charge (465 of 899)
-# Charges from group: Frequency Crystal (185 of 185)
-# Charges from group: Hybrid Charge (209 of 209)
+# Items from category: Charge (478 of 924)
 type = "passive"
 
 

eos/effects/ammoinfluencerange.py

@@ -1,7 +1,7 @@
 # ammoInfluenceRange
 #
 # Used by:
-# Items from category: Charge (571 of 899)
+# Items from category: Charge (572 of 924)
 type = "passive"
 
 

eos/effects/ammospeedmultiplier.py

@@ -1,9 +1,8 @@
 # ammoSpeedMultiplier
 #
 # Used by:
-# Charges from group: Festival Charges (8 of 8)
+# Charges from group: Festival Charges (22 of 22)
 # Charges from group: Interdiction Probe (2 of 2)
-# Charges from group: Survey Probe (3 of 3)
 type = "passive"
 
 

eos/effects/ammotrackingmultiplier.py

@@ -7,7 +7,7 @@
 # Charges from group: Advanced Blaster Charge (8 of 8)
 # Charges from group: Advanced Pulse Laser Crystal (8 of 8)
 # Charges from group: Advanced Railgun Charge (8 of 8)
-# Charges from group: Projectile Ammo (129 of 129)
+# Charges from group: Projectile Ammo (128 of 128)
 type = "passive"
 
 

eos/effects/angelsetbonus.py

@@ -8,7 +8,7 @@ type = "passive"
 
 def handler(fit, implant, context):
     fit.appliedImplants.filteredItemMultiply(
-        lambda
-            implant: "signatureRadiusBonus" in implant.itemModifiedAttributes and "implantSetAngel" in implant.itemModifiedAttributes,
+        lambda implant: "signatureRadiusBonus" in implant.itemModifiedAttributes and
+                        "implantSetAngel" in implant.itemModifiedAttributes,
         "signatureRadiusBonus",
         implant.getModifiedItemAttr("implantSetAngel"))

eos/effects/armoredcommanddurationbonus.py

@@ -3,6 +3,9 @@
 # Used by:
 # Skill: Armored Command
 type = "passive"
+
+
 def handler(fit, src, context):
     lvl = src.level
-    fit.modules.filteredItemBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "buffDuration", src.getModifiedItemAttr("durationBonus") * lvl)
+    fit.modules.filteredItemBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "buffDuration",
+                                  src.getModifiedItemAttr("durationBonus") * lvl)

eos/effects/armoredcommandmindlink.py

@@ -5,9 +5,16 @@
 # Implant: Federation Navy Command Mindlink
 # Implant: Imperial Navy Command Mindlink
 type = "passive"
+
+
 def handler(fit, src, context):
-    fit.modules.filteredChargeBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "warfareBuff2Multiplier", src.getModifiedItemAttr("mindlinkBonus"))
-    fit.modules.filteredChargeBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "warfareBuff1Multiplier", src.getModifiedItemAttr("mindlinkBonus"))
-    fit.modules.filteredChargeBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "warfareBuff4Multiplier", src.getModifiedItemAttr("mindlinkBonus"))
-    fit.modules.filteredChargeBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "warfareBuff3Multiplier", src.getModifiedItemAttr("mindlinkBonus"))
-    fit.modules.filteredItemBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "buffDuration", src.getModifiedItemAttr("mindlinkBonus"))
+    fit.modules.filteredChargeBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "warfareBuff2Multiplier",
+                                    src.getModifiedItemAttr("mindlinkBonus"))
+    fit.modules.filteredChargeBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "warfareBuff1Multiplier",
+                                    src.getModifiedItemAttr("mindlinkBonus"))
+    fit.modules.filteredChargeBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "warfareBuff4Multiplier",
+                                    src.getModifiedItemAttr("mindlinkBonus"))
+    fit.modules.filteredChargeBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "warfareBuff3Multiplier",
+                                    src.getModifiedItemAttr("mindlinkBonus"))
+    fit.modules.filteredItemBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "buffDuration",
+                                  src.getModifiedItemAttr("mindlinkBonus"))

eos/effects/armoredcommandstrengthbonus.py

@@ -3,9 +3,15 @@
 # Used by:
 # Skill: Armored Command Specialist
 type = "passive"
+
+
 def handler(fit, src, context):
     lvl = src.level
-    fit.modules.filteredChargeBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "warfareBuff1Multiplier", src.getModifiedItemAttr("commandStrengthBonus") * lvl)
-    fit.modules.filteredChargeBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "warfareBuff2Multiplier", src.getModifiedItemAttr("commandStrengthBonus") * lvl)
-    fit.modules.filteredChargeBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "warfareBuff4Multiplier", src.getModifiedItemAttr("commandStrengthBonus") * lvl)
-    fit.modules.filteredChargeBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "warfareBuff3Multiplier", src.getModifiedItemAttr("commandStrengthBonus") * lvl)
+    fit.modules.filteredChargeBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "warfareBuff1Multiplier",
+                                    src.getModifiedItemAttr("commandStrengthBonus") * lvl)
+    fit.modules.filteredChargeBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "warfareBuff2Multiplier",
+                                    src.getModifiedItemAttr("commandStrengthBonus") * lvl)
+    fit.modules.filteredChargeBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "warfareBuff4Multiplier",
+                                    src.getModifiedItemAttr("commandStrengthBonus") * lvl)
+    fit.modules.filteredChargeBoost(lambda mod: mod.item.requiresSkill("Armored Command"), "warfareBuff3Multiplier",
+                                    src.getModifiedItemAttr("commandStrengthBonus") * lvl)

eos/effects/armoredsquadroncommand.py

@@ -1,11 +0,0 @@
-# armoredSquadronCommand
-#
-# Used by:
-# Skill: Armored Command Specialist
-runTime = "early"
-type = "passive"
-
-
-def handler(fit, skill, context):
-    fit.modules.filteredItemBoost(lambda mod: mod.item.requiresSkill("Armored Command Specialist"),
-                                  "commandBonus", skill.getModifiedItemAttr("squadronCommandBonus") * skill.level)

eos/effects/armoredwarfaremindlink.py

@@ -1,12 +0,0 @@
-# armoredWarfareMindlink
-#
-# Used by:
-# Implant: Armored Command Mindlink
-# Implant: Federation Navy Warfare Mindlink
-# Implant: Imperial Navy Warfare Mindlink
-type = "passive"
-
-
-def handler(fit, implant, context):
-    fit.modules.filteredItemBoost(lambda mod: mod.item.requiresSkill("Armored Command Specialist"),
-                                  "commandBonus", implant.getModifiedItemAttr("mindlinkBonus"))

eos/effects/armorhpbonusaddpassive.py

@@ -1,9 +1,9 @@
 # armorHPBonusAddPassive
 #
 # Used by:
-# Subsystems from group: Defensive Systems (16 of 16)
+# Subsystems from group: Defensive Systems (9 of 12)
 type = "passive"
 
 
 def handler(fit, module, context):
-    fit.ship.increaseItemAttr("armorHP", module.getModifiedItemAttr("armorHPBonusAdd"))
+    fit.ship.increaseItemAttr("armorHP", module.getModifiedItemAttr("armorHPBonusAdd") or 0)